efortuna@google.com
26c5c48fe2
Revert 20127
...
TBR
BUG=
Review URL: https://codereview.chromium.org//12474007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20133 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-16 00:14:27 +00:00
blois@google.com
1fa1a541df
Adding tests for Element & Node lists insert method.
...
BUG=
Review URL: https://codereview.chromium.org//12407005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20129 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:58:06 +00:00
efortuna@google.com
3e1f5ce451
Expanded map options to named parameters.
...
BUG=
Review URL: https://codereview.chromium.org//12531013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20127 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:46:13 +00:00
efortuna@google.com
b2594b0111
Fix up static analysis errors introduced by Futures CL.
...
BUG=
Review URL: https://codereview.chromium.org//12653008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20120 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:06:10 +00:00
blois@google.com
aca4a1d77b
Fixing dart2js size regression introduced by Node.model.
...
BUG=
Review URL: https://codereview.chromium.org//12829007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20111 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 21:24:36 +00:00
amouravski@google.com
ad74dd0131
Added the CanvasImageSource interface, which all types that a canvas can draw
...
with drawImage implements.
Review URL: https://codereview.chromium.org//12775010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20108 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 20:54:50 +00:00
blois@google.com
26b77f96ab
Adding a model property to Node which is inherited through the tree.
...
This only works for trees which are in the document, but when a tree is added to the document everything should just 'start working'.
This should work on all browsers (tested on Chrome, FF and IE9).
Not sure about performance impact on large trees and lots of bindings (balance between optimizing for lots of bindings or lots of elements, few bindings), but it should not impact anything if models are not used.
BUG=
Review URL: https://codereview.chromium.org//12754013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20104 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 20:22:24 +00:00
lrn@google.com
844cd39fad
Change getRange to sublist. Make getRange deprecated.
...
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.
Review URL: https://codereview.chromium.org//12817003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
floitsch@google.com
a1029cb537
Fix after bad merge.
...
Review URL: https://codereview.chromium.org//12432017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20041 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 18:05:19 +00:00
floitsch@google.com
76d507cb6f
Add List.insert.
...
BUG= http://dartbug.com/5375
Review URL: https://codereview.chromium.org//12383073
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20037 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 17:38:14 +00:00
floitsch@google.com
65718c56df
Rename XMatching to XWhere.
...
For example firstMatching -> firstWhere.
BUG= http://dartbug.com/8664
BUG= http://dartbug.com/8337
Review URL: https://codereview.chromium.org//12537009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19880 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 17:34:49 +00:00
blois@google.com
7119f07f96
Fixing Node.nodes.first.
...
Was throwing an incorrect exception because the JS type was being annotated as non-null.
BUG=9070
Review URL: https://codereview.chromium.org//12513010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19834 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 00:59:02 +00:00
blois@google.com
3dc9e79521
Consolidating platform code into dart:html_common
...
Basically a number of our platform checks are only accessible from dart:html and not other libs. Moved Device class over to html_common and added more platform logic which was distributed elsewhere.
Also fixing up Device to cache the platform checks.
BUG=
Review URL: https://codereview.chromium.org//12541020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19833 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 00:49:27 +00:00
blois@google.com
30764d4a5b
Was benchmarking the differences between document.query and using the native DOM methods when available, and document.query is significantly worse in almost all scenarios.
...
Our current document.query can be optimized about 2x by caching the RegExps being used, but this is still not enough to get close to what they should be.
We special-cased a couple of queries to optimize those, but it appears that the browsers are optimizing those now as well and our optimizations are getting in the way, overall.
From my tests so far, this CL brings a speed improvement to document.query for all scenarios except for the name test:
document.queryAll('[name="test"]') which takes a fairly significant performance hit (runs close to 1/2 speed with this CL). This is mitigated by exposing getElementsByName which if used brings a 2x performance gain over queryAll.
BUG=
Review URL: https://codereview.chromium.org//12715003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19831 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-12 00:39:38 +00:00
blois@google.com
118fa93da7
BUG=
...
Review URL: https://codereview.chromium.org//12596004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19804 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-11 16:40:01 +00:00
amouravski@google.com
3f83719bdc
Fix build break.
...
Review URL: https://codereview.chromium.org//12733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19750 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 23:51:29 +00:00
amouravski@google.com
792ca95fa5
Revert "Revert "Update context2d.arc to take optional anticlockwise parameter""
...
Fixed checked mode test failures.
Review URL: https://codereview.chromium.org//12719002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19747 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 23:33:37 +00:00
blois@google.com
df12fc3a5f
Converting Element.client*, offset* and Screen.avail* over to Rects
...
Converting more APIs over to exposing as Rects.
BUG=
Review URL: https://codereview.chromium.org//12605003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19702 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 18:12:16 +00:00
lrn@google.com
bead146749
Renamed StreamSink to EventSink. Renamed signalError to addError.
...
Review URL: https://codereview.chromium.org//12610006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19683 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:31:19 +00:00
blois@google.com
dad0804d7b
Making Indexed DB's cursor stream not auto-advance if no subscribers
...
BUG=8552
Review URL: https://codereview.chromium.org//12644004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19667 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 01:37:02 +00:00
blois@google.com
2fcae75253
Exposing Point & Rect types
...
This exposes ClientRects as Rects and exposes UIEvent.clientX/Y properties as Points.
This also deprecates the UIEvent.clientX/Y properties.
BUG=
Review URL: https://codereview.chromium.org//12493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19659 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 22:17:04 +00:00
blois@google.com
40e5bd7d28
Adding Node.insertAllBefore
...
Also addressing some late feedback from Node.nodes.addAll.
BUG=8882
Review URL: https://codereview.chromium.org//12374060
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19593 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 00:43:53 +00:00
efortuna@google.com
58b10f811e
Reapply Futureification.
...
BUG=
Review URL: https://codereview.chromium.org//12543014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19590 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-07 00:13:57 +00:00
blois@google.com
a94084913c
Fixing a number of dart:html analyzer issues
...
A couple of real bugs, rotten code and deprecated APIs.
BUG=
Review URL: https://codereview.chromium.org//12510003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19588 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 22:46:34 +00:00
efortuna@google.com
60a5ed7215
"Reverting 19586"
...
BUG=
Review URL: https://codereview.chromium.org//12463028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19587 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 22:43:47 +00:00
efortuna@google.com
18f08c3a4c
Future-ify All the methods!
...
(with a few exceptions we've planned).
Also added some tests to test these apis.
BUG=
Review URL: https://codereview.chromium.org//12380046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19586 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 22:32:54 +00:00
floitsch@google.com
d91bca2813
Add List.asMap().
...
Review URL: https://codereview.chromium.org//12391046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19399 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 16:57:52 +00:00
lrn@google.com
f4300b84a2
Make List.from and Iterable.toList default to not growable.
...
Review URL: https://codereview.chromium.org//12401002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19391 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-04 14:55:40 +00:00
blois@google.com
f310d35ea4
Speeding up Node.nodes.addAll
...
During profiling of the Dart API app I noticed quite a non-trivial amount of time and garbage in nodes.addAll. This case can be optimized for the case where we know that both lists are node lists.
BUG=
Review URL: https://codereview.chromium.org//12382022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19268 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 00:03:35 +00:00
blois@google.com
d4d1228ce9
Cleaning up the TableElement API
...
Basically just converting to more proper types for a number of the APIs.
BUG=
Review URL: https://codereview.chromium.org//12320102
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19175 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 21:47:09 +00:00
antonm@google.com
a118f08856
Chrome roll 181864->184590.
...
TBR=ager@google.com ,podivivlov@chromium.org
Review URL: https://codereview.chromium.org//12315128
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19129 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 12:53:40 +00:00
lrn@google.com
08c3df394d
Fix bug in html library.
...
Review URL: https://codereview.chromium.org//12319141
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19114 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 09:00:46 +00:00
lrn@google.com
6b4f4b1bab
Change new List(n) to return fixed length list.
...
Deprecate List.fixedLength, add List.filled.
Make Iterable.toList and List.from take "growable" argument,
defaulting to false.
Review URL: https://codereview.chromium.org//12328104
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:45:04 +00:00
blois@google.com
8c0eeaa152
Removing an unnecessary throw for JS interop.
...
Was hitting this debugging some code using JS interop, seems like a simple cleanup.
BUG=
Review URL: https://codereview.chromium.org//12326132
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19090 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 22:26:21 +00:00
blois@google.com
d9b1c12f4c
Fixing CssStyleDeclaration to not throw exceptions for unsupported values.
...
Only occurs on IE9, but unsupported values should fail silently.
BUG=8588
Review URL: https://codereview.chromium.org//12295039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19024 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 00:48:23 +00:00
blois@google.com
0d2c7ea397
Fixing Indexed DB supported check.
...
The test was incorrectly passing on platforms which do not support IndexedDB.
BUG=
Review URL: https://codereview.chromium.org//12320101
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18998 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 20:59:12 +00:00
blois@google.com
bc4f90bd09
Dartifying remainder of Index DB APIs.
...
BUG=
Review URL: https://codereview.chromium.org//12313015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18992 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 18:59:34 +00:00
blois@google.com
5b0fea791f
Removing DateTimeInputElement.
...
This has been removed from Chrome and it sounds like it's being removed from the spec.
Chromium bug- https://code.google.com/p/chromium/issues/detail?id=175080
BUG=8709
Review URL: https://codereview.chromium.org//12310068
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18910 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 19:29:20 +00:00
blois@google.com
0f8df99a73
Fixing WheelEvent.deltaMode polyfill after IDL update.
...
BUG=8713
Review URL: https://codereview.chromium.org//12335036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18904 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:32:19 +00:00
ager@google.com
8594f56bbf
Update WebKit idl files after chrome roll
...
R=antonm@google.com ,blois@google.com
BUG=
Review URL: https://codereview.chromium.org//12316066
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18889 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 13:15:56 +00:00
ager@google.com
51527e2115
WheelEvent template changes for chrome rool.
...
R=antonm@google.com
BUG=
Review URL: https://codereview.chromium.org//12321076
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18881 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 11:52:14 +00:00
blois@google.com
8595b8bed2
Using an ordered set for Element.classes.
...
BUG=6946
Review URL: https://codereview.chromium.org//12282045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18727 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 21:37:32 +00:00
blois@google.com
d8265d81a5
Fixing Geolocation on Firefox
...
For position, Firefox is returning an object which doesn't map nicely, so added a wrapper for that.
Also cleaned up the APIs to make them more dart-friendly.
BUG=7547
Review URL: https://codereview.chromium.org//12274002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18723 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 21:18:36 +00:00
floitsch@google.com
ecce8a6293
Remove deprecated Strings class.
...
Review URL: https://codereview.chromium.org//12295014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18686 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 13:57:03 +00:00
lrn@google.com
03f5a66836
Recommit changing List.skip/take/revert returns Iterable and remove mappedBy.
...
This reverts r18591.
Review URL: https://codereview.chromium.org//12295009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-18 10:35:51 +00:00
rnystrom@google.com
0e0473d33a
Unbreak pub:
...
Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."
This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.
Revert "Remove deprecated mappedBy."
This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.
BUG=dartbug.com/8560
Review URL: https://codereview.chromium.org//12286004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18591 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 18:38:42 +00:00
floitsch@google.com
0672317bec
Remove deprecated mappedBy.
...
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576
Review URL: https://codereview.chromium.org//12212213
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:57:18 +00:00
floitsch@google.com
ad839e6957
Revert "Remove deprecated mappedBy."
...
This reverts commit 18575.
Review URL: https://codereview.chromium.org//12207205
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:23:22 +00:00
floitsch@google.com
b37100770b
Remove deprecated mappedBy.
...
Review URL: https://codereview.chromium.org//12212213
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:18:17 +00:00
lrn@google.com
349cd9eae0
Add unmodifiable list view.
...
Avoid using list.take(list.length), which no longer gives a list.
Review URL: https://codereview.chromium.org//12259045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18572 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 12:42:27 +00:00