Commit Graph

746 Commits

Author SHA1 Message Date
blois@google.com 58a92ac603 Fixing a number of Dart2JS compiler warnings.
BUG=11039
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16336022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23569 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 21:11:14 +00:00
blois@google.com 5bbd582932 Fixing some of the tests disabled from the chrome IDL roll.
Basically some native constructors were added which are not yet cross-platform, so skipping them for now.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//16335012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23564 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 20:10:48 +00:00
antonm@google.com 442b84095e Always return true for ShadowRoot.supported.
R=blois@google.com
BUG=10960

Review URL: https://codereview.chromium.org//15679018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23525 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 08:21:37 +00:00
vsm@google.com b85b97cbe6 Fixes for Blink roll to r151189
TBR=antonm

Review URL: https://codereview.chromium.org//16308002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23511 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 18:34:36 +00:00
lrn@google.com faa7227cec Make new StreamController be async by default.
Change all instances, except some tests, to be sync still.
Rename Multiplex to Broadcast everywhere.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//16125005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23453 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 06:07:39 +00:00
blois@google.com 9a9db6b3eb Fixing broken tests because of mismatch of suppressed warnings.
Removing additional warnings and fixing the core issues.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16050007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23433 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 18:26:32 +00:00
blois@google.com ca01606620 Fixing dart2js compilation warning.
Was seeing the warnings:
build/ReleaseIA32/dart-sdk/lib/html/dart2js/html_dart2js.dart:15831:21: Warning: no property named _this in class Iterable
      if (identical(newNodes._this, this)) {
                    ^^^^^^^^^^^^^^
build/ReleaseIA32/dart-sdk/lib/html/dart2js/html_dart2js.dart:15838:27: Warning: no operator [] in class Iterable
        this.insertBefore(newNodes[0], refChild);

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15660010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23428 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 17:47:07 +00:00
blois@google.com 881e456c21 Cleaning up some DOM APIs which were marked as deprecated because they were moved or renamed.
There were basically two issues:
- localName and namespaceUri moved from Node down to Element.
- The transitionEnd event was polyfilled based on the deprecated webkitTransitionEnd event, so it was switched to the standard transtionEnd.

The Attr change was needed because the node map was using localName on Attr (inherited from Node), when it should have been using name. Attr is not actually exposed anywhere, so made it private.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//15814008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23423 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 16:31:09 +00:00
efortuna@google.com 533a66bdac Reapply removeWhere and retainWhere for elements in dart:html
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//15810006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23371 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 23:40:52 +00:00
efortuna@google.com 54bafa2ebf "Reverting 23366"
BUG=

Review URL: https://codereview.chromium.org//15950008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23369 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 22:25:05 +00:00
efortuna@google.com 942392b7e6 Correctly implemented removeWhere and retainWhere for elements in dart:html.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//16171012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23366 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 21:22:22 +00:00
blois@google.com 0942acf5d2 Fixing IndexedDB's deleteDatabase to have the correct future result.
BUG=10648
R=efortuna@google.com

Review URL: https://codereview.chromium.org//16022012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23305 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 19:38:44 +00:00
efortuna@google.com 87182ddeac Make RTC work on Firefox (mostly).
BUG=
R=blois@google.com, sra@google.com

Review URL: https://codereview.chromium.org//16023011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23298 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:55:05 +00:00
floitsch@google.com 5d058bb0eb Adding isNotEmpty property to collection and string.
BUG= http://dartbug.com/3074
R=floitsch@google.com

Review URL: https://codereview.chromium.org//15263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23294 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:30:37 +00:00
blois@google.com ee483c9b6a Cleanup of various DOM dart2js and dart_analyzer warnings
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//15431003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22976 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-22 01:23:28 +00:00
blois@google.com 4284aa2264 Getting html_dart2js and html_dartium a bit more in sync.
I used the analyzer and made a quick API diff app to compare the two libraries, most of these are just minor nits, but good to get them in sync.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14630016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22963 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 21:52:07 +00:00
vsm@google.com 8379279dc0 Retry "Changes for webkit roll 148757-149482"
TBR=antonm

Review URL: https://codereview.chromium.org//14948011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22801 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 16:39:09 +00:00
vsm@google.com 45fc399cf7 Revert "Changes for webkit roll 148757-149482"
TBR=antonm

Review URL: https://codereview.chromium.org//14636013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22769 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 06:06:49 +00:00
vsm@google.com da46c65d3b Changes for webkit roll 148757-149482
Review URL: https://codereview.chromium.org//14954007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22765 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 05:37:13 +00:00
jmesserly@google.com ee7bbf71f6 fix warnings caused by xtag
fixes http://dartbug.com/10651

R=blois@google.com

Review URL: https://codereview.chromium.org//14979006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22692 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-14 18:07:30 +00:00
jmesserly@google.com 02ffdc01ad expose MDV addBindings
this is used to implement Web UI style bindings in the shadowroot template for declarative custom elements.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//14812016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22660 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-14 03:22:00 +00:00
jmesserly@google.com 215e6e66ad Move top-level internal methods of the MDV system into a class.
In dart:html we don't have the luxury of sublibraries, so we resort to the static-methods pattern to emulate a namespace.

If there was a more appropriate class I put it there, but some methods are shared by multiple other classes.

Note, this uses another CL (https://codereview.chromium.org/14795005) as its baseline.

R=blois@google.com

Review URL: https://codereview.chromium.org//14634011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22654 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 22:57:45 +00:00
jmesserly@google.com 6a17da6b4a Add support for custom elements to MDV
1. Custom elements should be able to override Node.bind
2. Custom elements should be able to intercept attributes set by the binding system

R=blois@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//14795005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22650 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 20:27:30 +00:00
blois@google.com 31db2b16d2 Fixing overrideMimeType on IE10.
I thought the test was failing for a different reason earlier, but it's that overrideMimeType is not supported on IE.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14989011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22607 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 23:47:37 +00:00
blois@google.com 4fd4ab5b36 Syncing CssStyleDeclaration.setPropertyValue's signature between dart2js and dartium
Because of IDL changes, the generated signature changed but the dart2js code had a polyfill which did not change.

The last parameter really should be optional, but this is dependent on https://code.google.com/p/dart/issues/detail?id=9156.

BUG=10583
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14646035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22606 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 23:22:16 +00:00
jmesserly@google.com 870bad8d86 MDV v3 changes: add getInstanceModel for custom syntax
They also simplified TemplateIterator

I added getInstanceFragment, in anticipation of "MDV v4" :)

R=blois@google.com

Review URL: https://codereview.chromium.org//14793017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22591 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 18:59:40 +00:00
blois@google.com 078208e1cf Adding ability to specify request headers and mime type for Future-based XHRs.
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14752025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22588 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 17:36:42 +00:00
jmesserly@google.com 9005b278e7 Implement Model-Driven-Views spec for Dart
This has code ported from a few different sources:
* a port of https://github.com/toolkitchen/mdv polyfill
* a port of the observable layer:  https://github.com/dart-lang/web-ui/tree/master/lib/observe
* a port of list change summary: https://github.com/rafaelw/ChangeSummary/blob/master/change_summary.js

The observePath/PathObserver code is written from scratch, but inspired by change_summary. I tried to keep it simpler; it does not support dirty checking. There's no good way to do that until we get dart:mirrors.

R=floitsch@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22561

Review URL: https://codereview.chromium.org//14732003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22570 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-09 21:39:03 +00:00
jmesserly@google.com 1cef1fbc55 "Reverting 22561"
need to investigate test failures

Review URL: https://codereview.chromium.org//14908005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22562 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-09 20:43:30 +00:00
jmesserly@google.com bf4f12c62b Implement Model-Driven-Views spec for Dart
This has code ported from a few different sources:
* a port of https://github.com/toolkitchen/mdv polyfill
* a port of the observable layer:  https://github.com/dart-lang/web-ui/tree/master/lib/observe
* a port of list change summary: https://github.com/rafaelw/ChangeSummary/blob/master/change_summary.js

The observePath/PathObserver code is written from scratch, but inspired by change_summary. I tried to keep it simpler; it does not support dirty checking. There's no good way to do that until we get dart:mirrors.

R=floitsch@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//14732003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22561 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-09 20:29:14 +00:00
blois@google.com c10ca84eb4 Making HiddenInputElement implement InputElementBase.
BUG=10520
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//14667009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22520 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-08 18:24:57 +00:00
blois@google.com 0c48687c86 Updating DOM code to use list mixins
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//14036014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22512 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-08 15:45:30 +00:00
blois@google.com a3feae2cc8 Fixing Location.origin to work on non-WebKit browsers.
BUG=10162
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14646032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22486 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-08 00:08:23 +00:00
blois@google.com 93dedc90ab Adding tests for experimental Safe DOM creation technique.
This is just the underlying DOM creation code which should be able to parse HTML with no script execution. I'd like to get this in so we can make sure it works across all supported platforms. This does not do any sanitization or validation.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//14839006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22473 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-07 18:32:47 +00:00
efortuna@google.com 6f7ef4126d Reapply "Aggregate CSS manipulation functions in html lib." (r22400)
BUG=

Review URL: https://codereview.chromium.org//14931008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22424 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-06 16:27:16 +00:00
floitsch@google.com fc31fb12b4 More fixes.
Review URL: https://codereview.chromium.org//14992002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22423 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-06 16:26:29 +00:00
efortuna@google.com 33b4567f83 "Reverting 22400"
BUG=

Review URL: https://codereview.chromium.org//14965003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22401 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-06 00:12:34 +00:00
efortuna@google.com 5e07799aba Aggregate CSS manipulation functions in html lib.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//14941002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22400 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-06 00:04:15 +00:00
amouravski@google.com 98f022a003 First try at removing ? from HTML.
R=blois@google.com

Review URL: https://codereview.chromium.org//14400004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22163 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 02:29:32 +00:00
blois@google.com 3ca6bd2dc6 Properly exposing NodeIterator and TreeWalker
Also removing references to EntityReference which is an outdated XML type.

Note that there's a bit of an oddity here around NodeFilter, which is both a class with all of the filter flags, and a function signature for a callback.

For now, I've scrubbed references to NodeFilter (the callback), but if desired I can add a new filter callback. This will most likely require a bit of Dartium work as well, so a separate CL I think.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//13685021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22160 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 01:36:04 +00:00
jmesserly@google.com 6f85889ab7 fix a bug in the Event constructor
R=blois@google.com

Review URL: https://codereview.chromium.org//14387011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22130 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-29 17:18:55 +00:00
blois@google.com 59c2920a7f This is a resubmit of:
https://codereview.chromium.org/13852008/

There were some type issues in Dartium checked mode on collections which caused problems. Basically just tweaked the generic arguments on some collections.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//13963020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22087 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-26 21:10:49 +00:00
sra@google.com 9e657bd652 Fix indexdb regression under optimization
TBR=blois@google.com

Review URL: https://codereview.chromium.org//14237005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21900 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 19:46:33 +00:00
lrn@google.com 554a845e4f Make List.remove return boolean.
Remove Queue implementations' remove methods, which are not in the
interface.
Added more tests for list operations.
Fixed bugs and omissions found by tests.

http://dartbug.com/10042
http://dartbug.com/10112

Review URL: https://codereview.chromium.org//14425003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21867 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 11:13:17 +00:00
sra@google.com 600bcf9339 Make RadioNodeList be NodeList
BUG=

Review URL: https://codereview.chromium.org//14159020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21858 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 00:18:39 +00:00
sra@google.com 15e8e0d70a Revert "Revert "Allow multiple tags in native clause.""
WebKit with a 'K', not 'k'

Review URL: https://codereview.chromium.org//13973017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21853 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 22:57:06 +00:00
blois@google.com 463e990434 Revert "With the collections deriving from ListBase, we no longer need to implement a number of boiler-plate methods."
This reverts commit http://code.google.com/p/dart/source/detail?r=21848.

BUG=

Review URL: https://codereview.chromium.org//13934019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21852 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 22:54:33 +00:00
blois@google.com 3dc436c463 With the collections deriving from ListBase, we no longer need to implement a number of boiler-plate methods.
There are some gotchas with Element and Node lists as they may mutate the list being passed in if it's a nodelist as well, so I'm keeping those unimplemented.

In some cases this may fall back to less efficient operations (such as the WrappedList which no longer forwards every method), but I tried to keep all of the primary cases fast and I believe that these methods would fall back to generic implementations anyways in all cases where we use the classes.

BUG=

Review URL: https://codereview.chromium.org//13852008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21848 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 22:29:05 +00:00
sra@google.com 4d02ad5c16 Revert "Allow multiple tags in native clause."
BUG=

Review URL: https://codereview.chromium.org//14358016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21846 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 22:07:13 +00:00
sra@google.com fb5b910c07 Allow multiple tags in native clause.
This simplifies, but does not allow us to get rid of, the typeNameOf
functions.

The '*' is no longer necessary, so
  native "*DOMWindow"
becomes
  native  "Window,DOMWindow".

Review URL: https://codereview.chromium.org//14051007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21843 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 21:41:35 +00:00