whesse@google.com
82c29cbb7a
Avoid regenerating unchanged bindings files for Dartium.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//69343006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30192 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 12:44:24 +00:00
whesse@google.com
e7afc18bb9
Print more information when Dartium IDL bindings processing fails during build.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//63173005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30053 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 16:00:25 +00:00
blois@google.com
768e147559
Fixing comment constructor not functioning on IE
...
BUG=13943
R=efortuna@google.com
Review URL: https://codereview.chromium.org//56603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29777 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 22:45:11 +00:00
blois@google.com
cb0fa66a9b
Fixing BeforeUnloadEvent.returnValue
...
This is an update of https://codereview.chromium.org/54913005/ which was failing on the Dartium bots.
Original is patch #1 , fix is #2 (re-ordering the parts in html_dartium).
Issue with the original appears to be that parts have some order-dependency in the VM when executing with --error_on_bad_type, which is used in snapshotting.
Opened bug https://code.google.com/p/dart/issues/detail?id=14721
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//55903004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29766 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:53:45 +00:00
blois@google.com
7046fc201e
Revert "Fixing the BeforeUnloadEvent"
...
Causing problems with build on Dartium:
class _CustomEventStreamImpl<T extends Event> extends Stream<T>
^
'file:///mnt/data/b/build/slave/dartium-lucid32-full-be/build/src/dart/tools/dom/src/EventStreamProvider.dart': Error: line 334 pos 41: type '_CustomEventStreamImpl<KeyEvent>' has an out of bound type argument
class _CustomKeyEventStreamImpl extends _CustomEventStreamImpl<KeyEvent>
TBR
BUG=
Review URL: https://codereview.chromium.org//54923006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29754 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 16:37:33 +00:00
blois@google.com
a948d4384a
Fixing the BeforeUnloadEvent
...
Basically the last Blink upgrade introduced the BeforeUnloadEvent which conflicted with our previous polyfill. Our definition was removed, but the suppression remained for Event.returnValue.
The suppression is still needed since that's the incorrect type and on the wrong class, so I modified our metadata lookup to allow it to only target exact class matches (and not super classes).
BUG=
R=efortuna@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//54913005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29752 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 16:17:38 +00:00
kasperl@google.com
1bbe4d5452
Make sure that classes in dart:html do not implement both List and List<E>.
...
R=johnniwinther@google.com , blois@google.com
BUG=
Review URL: https://codereview.chromium.org//50263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29417 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 08:37:10 +00:00
jacobr@google.com
fa8b243f62
Add JsArray
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//41163005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29393 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 20:46:36 +00:00
amouravski@google.com
79b447a313
Renamed XmlHttpRequestEventTarget to remove Xml for consistency.
...
R=blois@google.com
Review URL: https://codereview.chromium.org//49013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29385 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 19:54:00 +00:00
efortuna@google.com
45701cfb4b
Second round of deprecation removal.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//41843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29275 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:39:09 +00:00
sra@google.com
f41f6f6722
ImageData.data is a Uint8ClampedList
...
Review URL: https://codereview.chromium.org//41583005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29228 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 00:46:48 +00:00
efortuna@google.com
971dbf30ab
Supress list mixins for deprecated/removed class.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//42543006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29226 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 00:23:06 +00:00
amouravski@google.com
c1eb44e3d0
Fix for getContextAttributes which wraps bare dictionary into a Dart type.
...
R=sra@google.com
Review URL: https://codereview.chromium.org//35863006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29221 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:32:46 +00:00
efortuna@google.com
9b40aca70c
Remove the low hanging deprecation fruit.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//41753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29219 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:13:51 +00:00
efortuna@google.com
7effd23744
Add DOMRect for Firefox Rectangle behavior.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//41463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29210 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 21:28:58 +00:00
efortuna@google.com
7e685302b9
Add back unseparated out version of method overloads in dart:html.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//34733007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29135 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:07:45 +00:00
vsm@google.com
db97191375
Dartium fixes for latest Blink rolls.
...
TBR=blois@google.com
Review URL: https://codereview.chromium.org//37203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29085 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 15:00:32 +00:00
jmesserly@google.com
360ea42322
Rename mdv -> template_binding, remove experiemntal apis from dart:html
...
essentially, we trade off reduce dart:html API surface area for more annoying usage of these APIs. Since Polymer hides most of this, I suspect it won't be too annoying in practice.
Sample usage:
nodeBind(node).bind(...)
templateBind(node).model = ...;
R=sigmund@google.com
Review URL: https://codereview.chromium.org//34453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29057 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 02:11:49 +00:00
blois@google.com
15e086338d
Revert "Revert "Removing some deprecated members""
...
Take-two of https://code.google.com/p/dart/source/detail?r=29022
The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//35013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:44:10 +00:00
efortuna@google.com
a4a2e26bde
Reapply lineDash with polyfill.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//35623004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29050 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:15:36 +00:00
blois@google.com
3aef09e008
Revert "Removing some deprecated members"
...
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.
TBR
BUG=
Review URL: https://codereview.chromium.org//32523007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:20:32 +00:00
blois@google.com
e2c4716609
Removing some deprecated members
...
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//30353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:42:01 +00:00
efortuna@google.com
8b4e5e92ba
"Reverting 29013"
...
TBR
BUG=
Review URL: https://codereview.chromium.org//35723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29017 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:25:40 +00:00
jacobr@google.com
c274135947
Revert "Revert breaking CL"
...
This reverts commit 582a7848d7ad11fe981257598124431e36a9c982.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//35513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29014 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:15:03 +00:00
efortuna@google.com
f4e40d6d9a
Make getLineDash return [] instead of null if it has not yet been set.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//27983005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29013 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 17:40:58 +00:00
vsm@google.com
e92900f914
Revert breaking CL
...
Revert "Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages."
TBR=jacobr@google.com
BUG=
Review URL: https://codereview.chromium.org//32643009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28981 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 04:30:23 +00:00
jacobr@google.com
c74e0cec97
Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//33993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28976 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 00:46:02 +00:00
amouravski@google.com
0177ed7ae4
CanvasRenderingContext2D.fillText now works correctly with null maxWidth.
...
BUG=13369
R=efortuna@google.com
Review URL: https://codereview.chromium.org//29273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28963 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 22:09:07 +00:00
jacobr@google.com
5ee178076a
A few API changes:
...
Remove Callback in favor of directly using closures or JsFunction.withThis().
Move jsify() to a named constructor on JsObject.
- Throw on types other than Map and Iterable.
- Handle cycles
Add JsObject.fromDartObject() which force a transferrable native to be proxied.
Still to do: Reach a conclusion on Serializable
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//27514003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28902 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-19 04:36:10 +00:00
blois@google.com
e7aef33a2c
Fixing custom element type extensions in Dartium to have correct native type ID
...
This is in support of the recent change to write the native type ID to the Dart wrappers
Dart changes for https://codereview.chromium.org/27769002/
BUG=14190
R=vsm@google.com
Review URL: https://codereview.chromium.org//29033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28899 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 23:43:45 +00:00
efortuna@google.com
4f06435c24
Make AudioContext work in iOS 7.
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//29583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28877 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 20:37:09 +00:00
asiva@google.com
ab61301521
Generate a class table of all the IDL classes in the database. This table is used
...
to access the C++ class hierachy information to do a proper subtype of check.
The new subtype of check improves the following benchmarks
Dromaeo-drt dom-modify appendChild runs-per-second from 889.0 to 1575.0
Dromaeo-drt dom-modify insertBefore runs-per-second from 592.4075924075925 to 1298.0
The generated class table is as follows:
enum {
_HistoryCrossFrameClassId = 0,
_LocationCrossFrameClassId,
_DOMWindowCrossFrameClassId,
_DateTimeClassId,
// New types that are not auto-generated should be added here.
ANGLEInstancedArraysClassId,
AbstractWorkerClassId,
....
....
};
typedef struct {
const char* class_name;
int library_id;
int base_class_id;
bool is_node;
bool is_active;
bool is_event;
} _Classinfo;
typedef _Classinfo _DartWebkitClassInfo[NumWebkitClassIds];
_DartWebkitClassInfo DartWebkitClassInfo = {
{ "_HistoryCrossFrame", DartHtmlLibraryId, -1, false, false, false },
{ "_LocationCrossFrame", DartHtmlLibraryId, -1, false, false, false },
{ "_DOMWindowCrossFrame", DartHtmlLibraryId, -1, false, false, true },
{ "DateTime", DartCoreLibraryId, -1, false, false, false },
// New types that are not auto-generated should be added here.
{ "AngleInstancedArrays", DartWebGlLibraryId, -1, false, false, false, },
{ "AbstractWorker", DartHtmlLibraryId, -1, false, false, false, },
.....
.....
};
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//27358002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28821 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:27:30 +00:00
blois@google.com
89802cee42
Updating CustomElement lifecycle scope logic
...
More closely following what V8 is doing in:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.pm&l=1725
Primary issue was that this was being emitted in too many places (getters and attributes which didn't need it).
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//25675008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28818 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:13:14 +00:00
blois@google.com
e3b35dabb6
Renaming Node.document back to Node.ownerDocument
...
With custom elements, the document instance variable creates an odd conflict with the document global.
BUG=14099
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//27602002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28810 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:55:38 +00:00
blois@google.com
0c4f4dce36
Fixing dart2js size regression from CustomElement.detail
...
The annotation for CustomEvent.detail was being dropped.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//26115003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28807 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:36:58 +00:00
blois@google.com
333054ee75
Supporting non-SSVs in CustomEvent.detail
...
BUG=12641
R=vsm@google.com
Review URL: https://codereview.chromium.org//27308006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28758 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 23:09:33 +00:00
blois@google.com
19655e4e6b
Revert "Revert "Removing setImmediate and hiding WindowTimers interface""
...
Issue was that requestAnimationFrame got removed from Dartium during a merge conflict :(
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//27441002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28700 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:50:49 +00:00
efortuna@google.com
951dca71cb
Deprecate query and queryAll, also add back querySelector and querySelectorAll.
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//27223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28699 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:44:47 +00:00
blois@google.com
8e255ada0f
Revert "Removing setImmediate and hiding WindowTimers interface"
...
This reverts commit 28690.
TBR
BUG=
Review URL: https://codereview.chromium.org//27440002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28696 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:16:59 +00:00
blois@google.com
303710040b
Removing setImmediate and hiding WindowTimers interface
...
These timing APIs are all redundant with dart:async and those versions should be used instead.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//26534005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28690 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 23:52:09 +00:00
blois@google.com
9baacafa7a
Making all callbacks use zones (take 2)
...
Changes: fixed parameter ordering for RTCPeerConnection.getStats and fixed error for StorageInfo.
Revert "Revert "Making all callbacks use zones""
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//27240004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28674 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 19:07:22 +00:00
sra@google.com
c66099f078
Tighter native type annotations for some elements returning Lists
...
We need to be more careful with type annotations on native elements now that some classes implement List<dynamic>.
R=blois@google.com
Review URL: https://codereview.chromium.org//26971005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28626 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 01:45:17 +00:00
efortuna@google.com
035e04fb2d
Making all base class DOM types throw as well (to prevent a default constructor for DOM types that are not constructable).
...
BUG=https://code.google.com/p/dart/issues/detail?id=11620
R=blois@google.com
Review URL: https://codereview.chromium.org//27033009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28615 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 21:58:46 +00:00
blois@google.com
e1d441b22f
Revert "Making all callbacks use zones"
...
This reverts commit 28607, running into analyzer issues.
TBR
BUG=
Review URL: https://codereview.chromium.org//27232003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28609 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 20:23:11 +00:00
blois@google.com
84a3415e82
Making all callbacks use zones
...
This was primarily converting APIs to use Futures, all appear to be new ones since we did the last pass.
MutationObserver and Window.requestAnimationFrame had to be fixed manually.
BUG=
R=efortuna@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//27082002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28607 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 19:49:17 +00:00
blois@google.com
f51dad91fd
Untyping List types
...
Making all DOM lists implement List rather than List<T>. This is primarily for NodeList which is used in cases where it's just a list of Elements and allows us to assign it to List<Element> without type checks.
BUG=
R=sra@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//27227002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28597 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:36:59 +00:00
efortuna@google.com
95c3be5481
Made index_db Cursor.next behavior consistent between JS and vm.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//26703006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28431 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 23:45:59 +00:00
asiva@google.com
33b96c8696
Pass in domData as a parameter to unwrapDartWrapper.
...
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//26051003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28353 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 03:25:48 +00:00
efortuna@google.com
eaa854b258
Move Rectangle and Point into dart:math.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//25808002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:47:39 +00:00
asiva@google.com
19a260904e
Generate a library ID instead of a library name, so that the ID can be used
...
to get the library handles from the cache (avoids having to lookup everytime)
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//25626002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28226 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 16:21:17 +00:00