8963a49505
Event delegation
...
Fix for https://code.google.com/p/dart/issues/detail?id=6270
BUG=
R=blois@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//21607003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25969 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 17:37:32 +00:00
cd7a678e83
Use DartExceptionState
...
R=blois@google.com
Review URL: https://codereview.chromium.org//22605010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25953 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 22:56:57 +00:00
f58ea07d46
EventTargets should be EventTargets
...
systemnative.py keys off the ext_attr. Recent IDL changes removed the EventTarget attribute however.
Types marked with isEventTarget are handled specially during GC.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//22507005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25947 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 21:18:13 +00:00
68b7394e53
Treat EventTarget as a secondary superclass
...
This matches the C++. It's brittle, but it's not clear how to get
this out of idl right now.
R=blois@google.com
Review URL: https://codereview.chromium.org//22594012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25906 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 22:15:10 +00:00
2b37129071
Fixing polyfill for Element.createShadowRoot.
...
Chrome roll changed it from webkitCreateShadowRoot to createShadowRoot, polyfills need to be updated. This change should probably be reverted once everyone adapts to the new API.
TBR
BUG=
Review URL: https://codereview.chromium.org//22513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25851 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 01:32:58 +00:00
0094164ae8
Regenerating DOM types from IDL roll.
...
TBR=vsm
BUG=
Review URL: https://codereview.chromium.org//22352004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25849 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 00:57:08 +00:00
abb3ca866b
Do not generate calls to Dart_EnterScope/Dart_ExitScope around native
...
callbacks as an ApiLocalScope is auto created by the VM when making
external native calls.
R=vsm@google.com
Review URL: https://codereview.chromium.org//22392006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25846 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 23:57:50 +00:00
c5dd3d3ba7
MERGE: 152953-155080
...
TBR=jacobr@google.com ,blois@google.com
Review URL: https://codereview.chromium.org//22357003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25832 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 21:17:56 +00:00
7376bf6cf2
Alter the native code generator to directly use
...
Dart_SetBooleanReturnValue
Dart_SetIntReturnValue
Dart_SetDoubleReturnValue
instead of
Dart_Handle retval = toDart(...); // Calls Dart_Boolean, Dart_NewInteger,
// Dart_Double.
Dart_SetReturnValue(args, retval);
R=vsm@google.com
Review URL: https://codereview.chromium.org//21156011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25698 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 00:58:22 +00:00
1311f1d755
Fixing WebGLLoseContext on Firefox.
...
BUG=11874
R=efortuna@google.com
Review URL: https://codereview.chromium.org//21287002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25697 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 00:35:25 +00:00
651836e67b
Fixing some SVG collections not working on Dartium.
...
Issue was that we were generating code calling native methods which were not present for these SVG collections.
BUG=11204
R=vsm@google.com
Review URL: https://codereview.chromium.org//21085008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25682 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 20:18:42 +00:00
59a514b316
Moving AngleInstancedArrays from dart:html to dart:web_gl.
...
It's a new type which for some reason was added to Canvas rather than with the rest of the WebGL stuff.
BUG=11357
R=efortuna@google.com
Review URL: https://codereview.chromium.org//21297002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25649 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 22:26:34 +00:00
c75ffac982
Added shim for scrollX and scrollY for IE 9.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//20385002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25529 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 18:09:13 +00:00
9f8be9f84a
Fix Dartium test break
...
I had to revert this line - it's breaking a test on Dartium.
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//20174003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25460 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 01:50:42 +00:00
a439ba51c0
Fix dartium build breakage
...
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//20214002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25458 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 00:47:17 +00:00
28541ed31f
Regenerate dart:html from new Blink IDL files
...
This includes some script updates. See:
https://codereview.chromium.org/19605006
for the IDL roll.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//19789017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25456 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 00:08:44 +00:00
992776552a
Fixes for Blink roll.
...
TBR=jacobr@google.com ,asiva@google.com
Review URL: https://codereview.chromium.org//19820007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25395 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 04:46:29 +00:00
1fdd1a34b2
Utility methods used for dartium debugger integration.
...
In addition, added back two DOM methods required by the chrome dev tools that had been removed from dart:html
I'm not thrilled about adding back className but the devtools use className in 495 places so figuring out which places are actually talking about classNames of inspected objects and which ones are just internal uses of className inside the devtools would be a pain.
As the browser has a String "class" attribute I do think it is natural to provide at least a read only className in addition to classes.
This changes goes along with the larger CL
https://codereview.chromium.org/18169002/
which I will be sending out for general review in a little bit.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18125007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25032 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 22:57:04 +00:00
4fe143407c
Update dart:chrome APIs and include chrome.fileSystem
...
chrome.fileSystem is needed to do integration testing.
BUG=None
R=blois@google.com
Review URL: https://codereview.chromium.org//19090002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24988 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 01:09:52 +00:00
2a070f0c72
Add point to Window class and Window polyfills of screen.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18920008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24987 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-13 00:40:26 +00:00
a9ea9a28ad
Convert decodeAudioData to return a Future.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//19018006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24893 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-10 22:58:33 +00:00
f50bfde69f
Fixing CustomEvent.detail leaks.
...
Basically CustomEvent.detail does no conversion of objects and will pass JS objects through unmodified.
This fix restricts CustomEvent.detail for Dart down to serialized script values, but JS allows anything (which can lead to memory leaks).
With this fix, CustomEvent.detail is essentially handled similar to MessageEvent.data.
BUG=https://code.google.com/p/dart/issues/detail?id=6220
R=vsm@google.com
Review URL: https://codereview.chromium.org//18811006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24884 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-10 20:12:25 +00:00
71d6d11712
Update idlsync.py to work with chrome generator.
...
BUG=None
R=vsm@google.com
Review URL: https://codereview.chromium.org//18855009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24871 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-10 00:29:19 +00:00
875d28e015
Fixing mapping of attribute maps on FireFox.
...
Not sure when/why this broke (most likely FF change), but one of the MDV tests started failing because of it:
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-ff-win7-1-2/builds/5798/steps/dart2js%20tests/logs/stdio
Closest thing I can find in reference to this type refers to it going away in WebKit:
http://trac.webkit.org/changeset/42107
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//18302005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24870 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-10 00:25:30 +00:00
cc9f39dfba
Add back appendBlob and send variants in WebSocket.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//18850007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24854 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 17:26:51 +00:00
ad95ee86e2
Make multiple attempts to write binding files to disc
...
Our dartium-win builders are currently flaky on the compile step. Sometimes
we're not able to write the generated dart bindings to disc (we get an IOError:
Permission denied).
This change makes sure we do multiple attempts for writing out the generated
files before we give up. Hopefully we can eliminate this hack as soon as we
found the root cause.
TBR=efortuna@google.com
Review URL: https://codereview.chromium.org//18676003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24772 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-04 11:55:19 +00:00
842b1f41c3
Make type parameter in toDataUrl have an optional default value as per the spec.
...
BUG=
R=amouravski@google.com
Review URL: https://codereview.chromium.org//18500010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24753 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 21:19:16 +00:00
5937290e27
Enabling logger information for multiemitter.py and add more debug information
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//18326018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24725 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 13:59:13 +00:00
f81052f2c8
Reapply expanding overloaded functions into separate functions.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//18577002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24709 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 22:32:44 +00:00
d06e9eb36e
Catch IOError instead of OSError
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//18541003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24692 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 15:29:08 +00:00
a63d13556c
Adding debug information to multiemitter.py
...
Our win-dartium builders are flaky. Very often the compilation fails because
dartdomgenerator.py gets an "IOError: [Errno 13] Permission denied" error.
This is an attempt to get more insight into which other processes have
the file open at the same time.
R=antonm@google.com
Review URL: https://codereview.chromium.org//18534002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24688 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 14:39:07 +00:00
6f88eecf44
Removed overloads for WebGLRenderingContext.texImage2D and texSubImage2D.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//17738007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24670 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-02 00:01:15 +00:00
3629744086
"Reverting 24655"
...
BUG=
Review URL: https://codereview.chromium.org//18277003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24656 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 21:09:19 +00:00
fc0df10d8b
Expand overloaded methods and optional parameters in the html library.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//16494002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24655 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 20:49:07 +00:00
894a503bfd
Fixed a typo that broke tests.
...
Review URL: https://codereview.chromium.org//18379002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24644 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 19:05:46 +00:00
c0a39d0412
Make html metadata follow the spec.
...
Per https://code.google.com/p/dart/issues/detail?id=11568
R=scheglov@google.com
Review URL: https://codereview.chromium.org//18182010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24638 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-01 18:34:30 +00:00
9dd81d94a7
Fixing up DOM constructors.
...
This is a continuation of https://codereview.chromium.org/17063007/
Basically I changed it so factory constructors are only added if the class derives from a native type. Otherwise the native type now extends Interceptor.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//18054021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24619 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-29 00:14:23 +00:00
f191d0d4de
Fixing DateTime values in serialized script values.
...
This allows Dart's DateTime objects to be passed as serialized script values. Especially useful for DB values.
BUG=11449
R=sra@google.com
Review URL: https://codereview.chromium.org//17574008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24608 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 20:55:23 +00:00
0c17281a29
Fixing type error for WebGL's getShaderParameter.
...
Was preventing the return of bools in dart2js.
BUG=11487
R=efortuna@google.com
Review URL: https://codereview.chromium.org//18089016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24599 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 17:54:42 +00:00
4d9098cb0e
Move some native type dispatch tags from runtime into class definitions.
...
R=blois@google.com
Review URL: https://codereview.chromium.org//17893009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24488 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 20:40:02 +00:00
edf30f6b20
Exposing Node.firstChild and Node.lastChild.
...
These are the most efficient way access children and are very commonly used.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//17909002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24476 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 16:53:50 +00:00
7fd6e0a3dc
Restore adoptNode and importNode to dart:html
...
http://dom.spec.whatwg.org/#dom-document-importnode
These seem more relevant in a <template>/ShadowRoot world. In particular I wanted to port an MDV test that uses adoptNode.
R=blois@google.com
Review URL: https://codereview.chromium.org//17681003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24423 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 18:02:26 +00:00
c0f342adcd
Fixing up previous CL to fix Dartium issues.
...
patch from issue 17453003
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17550014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24354 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 17:49:25 +00:00
04f294a73d
Remove =List in JS, use JSExtendableArray instead.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//17301008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24319 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 10:09:14 +00:00
9a55dad88e
This is causing a build error on Dartium (conversion from unsigned long to GLenum).
...
TBR
BUG=
Review URL: https://codereview.chromium.org//17141011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24298 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 18:18:17 +00:00
7b4bd8fef5
Fixing an issue where EXTDrawBuffers.drawBuffersEXT was not getting generated.
...
Core issue is that sequences of typedefs aren't getting resolved properly, so it was treated as an unknown type.
Did a workaround, opened bug 11395 to track the core IDL parser issue.
BUG=11029
R=vsm@google.com
Review URL: https://codereview.chromium.org//17453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24296 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 17:34:21 +00:00
6b44f65407
Revert "Making all DOM types abstract and removing superfluous Dartium constructors."
...
This reverts commit http://code.google.com/p/dart/source/detail?r=24241 .
Compiler error, not sure of best fix.
BUG=
Review URL: https://codereview.chromium.org//17508002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24245 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 19:37:47 +00:00
c3547d4e9b
Making all DOM types abstract and removing superfluous Dartium constructors.
...
Adding factory constructors to all classes to suppress missing generative constructor warnings.
Adding a throw to Dartium's base DOM class to prevent construction of native objects.
This also includes the changes necessary to make all DOM types abstract, but I'm running into a dart2js issue which is preventing that.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//17063007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24241 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 17:31:36 +00:00
28560f4a06
Adding WebGL context events to Canvas.
...
BUG=9482
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16997002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24006 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 20:12:01 +00:00
b206fa4a34
We always had this class in the hierarchy for Dartium but had hidden it for Dart2js, this caused problems because the actual runtime hierarchy was different than the Dart expressed one.
...
BUG=9907
R=sra@google.com
Review URL: https://codereview.chromium.org//16770003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23999 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 17:17:54 +00:00
efortuna@google.com