dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

21307 Commits

Author SHA1 Message Date
Mayank Patke 1702b986c8 Move the JavaScript constant system into constants/constant_system.dart 
in preparation to merge it with the base constant system and flatten the
constant system hierarchy.

Change-Id: I6ef27b210515140d4516336fea015f74c8a0cd6a
Reviewed-on: https://dart-review.googlesource.com/c/93840
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-22 21:34:47 +00:00
Mayank Patke 5af8de8954 Remove the Dart constant system and move all required classes into the 
JavaScript constant system.

Change-Id: I2a31ea743270459284c42b615b0dffd1c7aa2584
Reviewed-on: https://dart-review.googlesource.com/c/93746
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-22 21:34:47 +00:00
Dan Rubel 58cea93953 Update BodyBuilder to use handleLiteralSetOrMap 
This is the second of several CLs updating the parser and its listeners
to conform to the unified collection spec:
https://github.com/dart-lang/language/pull/200

Change-Id: I5c277d05a3726a3f5a40823cf878f025167340e6
Reviewed-on: https://dart-review.googlesource.com/c/93741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-22 17:31:24 +00:00
Johnni Winther 8e2fcf7782 Advanced tracking of field initialization 
Change-Id: I8c8edb517bc3a3805ac0d72388f4e5c7fc34247f
Reviewed-on: https://dart-review.googlesource.com/c/93680
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-22 16:08:16 +00:00
Johnni Winther 60e4f194b0 Recognize and inline effectively constant fields 
Change-Id: I243ee80ebc45d9cdab2f7c944cf5eceb26185b2c
Reviewed-on: https://dart-review.googlesource.com/c/93436
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-22 14:06:05 +00:00
Stephen Adams b60a55510b [dart2js] Disable assignment chaining optimization 
Disable while we look into variable allocator assertion.

Change-Id: Ib1e7c2eb869020ae8ecfa123801009adb6a742c7
Reviewed-on: https://dart-review.googlesource.com/c/93925
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-02-22 00:10:23 +00:00
Ryan Macnak d253642f25 [standalone] Fix isolate messages for processes that a creating an AppJIT snapshot. 
The standalone embedder was sorting classes in the main isolate, but not child isolates, causing the CIDs to diverge.

Also fix a few isolate tests.

Bug: https://github.com/dart-lang/sdk/issues/33128
Bug: https://github.com/dart-lang/sdk/issues/36000
Change-Id: Ic21acb02eb623ae177ed242aa21b0e243775e369
Reviewed-on: https://dart-review.googlesource.com/c/93923
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-21 22:39:39 +00:00
Jenny Messerly 627e96c9c1 [dartdevc] simplify microtask scheduling using JS Promise 
All of DDC's supported platforms have Promises, so we can use them
instead of MutationObservers (web) and timers (node.js).

See issue #20055 (same issue, but for dart2js).

Change-Id: Id635a4a9fa104a2ab19dd20824d209f682f831f9
Reviewed-on: https://dart-review.googlesource.com/c/91765
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2019-02-21 20:13:19 +00:00
Liam Appelbe ee32f8c87e [VM] Rehash sets after they are read from a snapshot. 
Fixes: https://github.com/dart-lang/sdk/issues/35626
Bug: https://github.com/dart-lang/sdk/issues/35626
Change-Id: I4d5b3799072faf8abb16e9eac15b834dbecce07b
Reviewed-on: https://dart-review.googlesource.com/c/93843
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-02-21 19:39:09 +00:00
Sigmund Cherem e3b8065625 Add support for --dump-info=binary 
We continue to accept `--dump-info`, but now also accept `--dump-info=binary` so
we can use the new cheaper encoding.

Change-Id: I971cb9a3634ae1a333cfee14b2927c0e25000a01
Reviewed-on: https://dart-review.googlesource.com/c/93823
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-02-21 17:54:39 +00:00
Ryan Macnak 3068192450 [vm] Remove deferred canonicalization from isolate message serialization. 
This fixes sending more commonly used types at the expense of less common recursive types.

Bug: https://github.com/dart-lang/sdk/issues/35778
Change-Id: I55f1105d1a8a48b6c4c241c2ce4d2f36863d7b5a
Reviewed-on: https://dart-review.googlesource.com/c/93372
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-20 20:11:05 +00:00
Stephen Adams 0e453c637b [dart2js] Chain static assignments 
Extend the logic for chaining field assignments to static variables.

Change-Id: Ia87d8ff3400d6f04257a546c7a1bb74775a3019e
Reviewed-on: https://dart-review.googlesource.com/c/93620
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-20 20:07:55 +00:00
Johnni Winther 7edb7dddd8 Merge allocator analysis with collection of elided fields 
- and rename to field analysis.

This prepares for recognizing effectively constant fields.

Change-Id: I1caa2e1a4f6d90fcd2562ec17d3093bff3a9b0d8
Reviewed-on: https://dart-review.googlesource.com/c/93427
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-20 16:03:24 +00:00
Aske Simon Christensen 6f8415245d [fasta] Transform set literals in initializers and default values. 
The set literal desugaring was missing set literals in constructor
initializers and parameter default values. Furthermore, it assumed
that a constructor that contained a set literal had a body.

Fixes https://github.com/dart-lang/sdk/issues/35989

Change-Id: I42c77b96bbe751ee6f7c7ba7921e9b9df24c16e9
Reviewed-on: https://dart-review.googlesource.com/c/93660
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-02-20 15:38:54 +00:00
Johnni Winther 596e0aa645 Include FieldInitializer in allocator analysis 
Change-Id: Id3ce8113816193408f704045c130e65fe65e6244
Reviewed-on: https://dart-review.googlesource.com/c/93424
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-20 10:53:01 +00:00
Samir Jindel c635896e1b [vm] Fix langauge_2_kernel.status after 93301 
Change-Id: I79f57caea89356e7505a07ebd911c8732fccd816
Reviewed-on: https://dart-review.googlesource.com/c/93542
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-02-20 10:24:10 +00:00
Bob Nystrom 6cf71022a8 Add a test for type promotion in "if" collection elements. 
Change-Id: Ibdb5002fc7646b80978ea447fedd97606476630d
Reviewed-on: https://dart-review.googlesource.com/c/93301
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-02-20 02:03:01 +00:00
Daco Harkes a85ae4e919 [vm/ffi] fix sizeOf on subtypes of Pointer 
Change-Id: I9f1f0c6fc618039e0c50d0a70460e1d66d568bca
Reviewed-on: https://dart-review.googlesource.com/c/93502
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-02-19 12:57:04 +00:00
Stephen Adams db71576ef3 [dart2js] Generator bodies can be on super mixin applications 
Bug: 35965
Change-Id: Ib611ba596d5778b6da2131e4712bfa669cf5e2b3
Reviewed-on: https://dart-review.googlesource.com/c/93465
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-02-18 16:57:23 +00:00
Johnni Winther 8e5f644d0a Use constant evaluation in allocator analysis 
Change-Id: I93543c7f295d4b325a34ced632c2d0a7555391e6
Reviewed-on: https://dart-review.googlesource.com/c/92421
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-18 13:18:31 +00:00
Johnni Winther bfa6041801 Add allocator analysis test for the J model 
Change-Id: I42fc8bfa4ea35c9025f6f48faa73a7cc16aab3b8
Reviewed-on: https://dart-review.googlesource.com/c/92287
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-18 13:18:31 +00:00
Daco Harkes 620743fb6b [vm/ffi] void functions 
Change-Id: I1544e0985d934dfa354143764dee61feb08b2592
Reviewed-on: https://dart-review.googlesource.com/c/93422
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-02-18 13:15:21 +00:00
Johnni Winther 885f1cbe31 Fix constant folding of type literal equality 
Closes #35853

Change-Id: I1c6caa1c8e074e8fd80c47699d6b0837bec166e0
Reviewed-on: https://dart-review.googlesource.com/c/92422
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-02-18 10:34:20 +00:00
Jenny Messerly 15e7457519 [dartdevc] change browser tests to wait longer for async completion 
Also fixes 2 html tests whose failure was caught by this change.

Change-Id: I707cba922bc7e7728ba0b026ad056b547fcd1432
Reviewed-on: https://dart-review.googlesource.com/c/92392
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-02-16 01:15:01 +00:00
Stephen Adams 1ac61b0c35 [dart2js] Basic chaining of field assignments 
t4 = t3.tooltip;
      t2._tooltipText = t4;
      this.currenttooltip = t4;
--->
      this.currenttooltip = t2._tooltipText = t3.tooltip;


        future = new P._Future(0, $.Zone__current, [P.bool]);
        this._stateData = future;
        return future;
--->
        return this._stateData = new P._Future(0, $.Zone__current, [P.bool]);

Change-Id: I8a1c4dae85b8a10f8b2c099668033f0c1ea9b6c4
Reviewed-on: https://dart-review.googlesource.com/c/93342
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-15 22:45:46 +00:00
Mayank Patke 99a5057bca Add set tracing. 
Change-Id: I889c5ac8d6207c9a25721d939b0f01b4e945a940
Reviewed-on: https://dart-review.googlesource.com/c/92149
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-15 20:44:46 +00:00
Mayank Patke e53cd30112 Add SetTypeMask. 
Change-Id: I9f202506c364cc1387efa8cea4cca6038f350470
Reviewed-on: https://dart-review.googlesource.com/c/92146
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-15 20:44:46 +00:00
Daco Harkes 185c0f3e89 [gardening] status file entry for entrypoints_verification_test 
Issue: https://github.com/dart-lang/sdk/issues/35957
Change-Id: Ic2cfbe25718f1511bb1ae33b785ea9bdff910274
Reviewed-on: https://dart-review.googlesource.com/c/93405
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-02-15 09:16:50 +00:00
Ryan Macnak 0e62060be4 [test] Mark standalone_2/io/arguments_test as failing due to a bug in the test harness. 
Change-Id: Id1e445f61b4421d1a43e31bcb4e2a455129c5e40
Reviewed-on: https://dart-review.googlesource.com/c/93380
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-15 01:36:51 +00:00
Samir Jindel 3b2144fa93 [vm] Respect entry-point annotation on constructors during obfuscation. 
Change-Id: Ia61d582fb6dd647b8fcab051b57ff08682076d9d
Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-precomp-obfuscate-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/93225
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-14 20:18:19 +00:00
Liam Appelbe 223eaa6fbb Report noSuchMethod forwarders as synthetic in the mirror api 
Fixes http://dartbug.com/34982

Bug: http://dartbug.com/34982
Change-Id: I0302586c5f0e58dd66e238bd32088ebe1c150c0e
Reviewed-on: https://dart-review.googlesource.com/c/93124
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-02-14 18:42:19 +00:00
Samir Jindel ae7bf9e999 [vm] Support closurization of methods through @pragma entry-points. 
Fixes dartbug.com/35720.

Also enable native extensions in AOT.
Increases Flutter Gallery snapshot size by 0.19%.

Change-Id: I1b24c3b9a49a13fd48452e9a89595516a7f01780
Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/92283
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-14 17:47:28 +00:00
Samir Jindel a5d396cd25 [vm/extensions] Fix native extensions in hot-reload and running from snapshot. 
This is a re-land of "[vm/extensions] Fix Loader::ReloadNativeExtensions(...)."

The native extension test was failing in hot-reload: this has been fixed.

Change-Id: Ic18da8cfbc6a3dba8aac09d654dce616487a67d7
Reviewed-on: https://dart-review.googlesource.com/c/92800
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-02-14 17:47:28 +00:00
Martin Kustermann 4daabe69c3 [vm/gardening] Mark convert/base64_test/01 as flaky 
Issue https://github.com/dart-lang/sdk/issues/35948

Change-Id: Ib0358706e96ceda5d49d7a3496354eb903d8a40d
Reviewed-on: https://dart-review.googlesource.com/c/93223
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-02-14 16:42:48 +00:00
Daco Harkes 3abc7d34d7 [vm/ffi] Remove platform specific logic from DynamicLibrary.open 
Change-Id: Id69e17563c4d64f6ead5e143077a7364520f65a0
Reviewed-on: https://dart-review.googlesource.com/c/93173
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-02-14 16:08:28 +00:00
Sergey G. Grekhov 70e300fea0 [co19] DEPS updated 
Change-Id: I487933deef8968e2c82904a895ea948831fcd9ff
Reviewed-on: https://dart-review.googlesource.com/c/92700
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-02-14 09:02:50 +00:00
Nicholas Shahan 80798fad97 [tests] Add missing parenthesis on <list|map|set>Equals() calls 
Change-Id: I2d4fc114ad01ba075c644285d7e87b89570f626b
Reviewed-on: https://dart-review.googlesource.com/c/92661
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-02-13 23:51:37 +00:00
Daco Harkes 4510fa08ca [vm / library] reduce dart:ffi test recursion depth 
Change-Id: Iaa5ff60388398fcf5cf89b5e91e931f76f8f6572
Reviewed-on: https://dart-review.googlesource.com/c/93085
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-02-13 16:59:56 +00:00
Daco Harkes 76f531e742 [vm / library] dart:ffi status file entry for flaky dartkb crash 
Issue: https://github.com/dart-lang/sdk/issues/35935
Change-Id: I938bb508f5d320fc21500c6478a2f32bb4e6a673
Reviewed-on: https://dart-review.googlesource.com/c/93084
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-02-13 16:35:36 +00:00
Daco Harkes 0651c8c4fd [vm / library] dart:ffi status file entry for reload crash 
issue: https://github.com/dart-lang/sdk/issues/35933
Change-Id: I8d0d5f50ce65747aa8cfe7b36888d87173ea7b4b
Reviewed-on: https://dart-review.googlesource.com/c/93028
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-13 13:59:57 +00:00
Daco Harkes 4fa1e3a3ca [vm / library] dart:ffi status file entry for appjitk crashes 
Issue: https://github.com/dart-lang/sdk/issues/35934
Change-Id: I64475d76b1ad8687f1b48278b9e0e4adca2e4f7c
Reviewed-on: https://dart-review.googlesource.com/c/93030
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-13 13:58:11 +00:00
Daco Harkes 7d46d4b5cb [vm / library] Foreign function interface prototype 
Prototype for `dart:ffi` on Linux/MacOS x64 in JIT mode.
`dart:ffi` is experimental and its API is likely to change in the future.
Progress and design decisions are tracked in https://github.com/dart-lang/sdk/projects/13


issue: https://github.com/dart-lang/sdk/issues/34452
Change-Id: Ifa4566388e42c8757f154741d11e303465ef305d
Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try, vm-kernel-mac-debug-x64-try, vm-kernel-asan-linux-release-x64
Reviewed-on: https://dart-review.googlesource.com/c/80124
Reviewed-by: Samir Jindel <sjindel@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2019-02-13 12:42:47 +00:00
Lasse R.H. Nielsen 671865cd1a Fix JSON parser. 
JSON parser was not rewritten when integers became fixed-size, so
some large integers could overflow silently and give the wrong
result, as could some doubles where the pre-decimal point digits
overflowed an `int`. Also added overflow protection for exponent.

Change-Id: I02941272c36fba4b9226e324936aebd4a5c5aa3b
Reviewed-on: https://dart-review.googlesource.com/c/91521
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-02-13 11:06:35 +00:00
Peter von der Ahé 857d834e64 Remove obsolete expectMoreSpecific parameter 
Change-Id: I6d5ff79ba0eec022812da14201fb30ae2625d355
Reviewed-on: https://dart-review.googlesource.com/c/92126
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-13 10:51:55 +00:00
Konstantin Shcheglov f841096701 Fix for crash if MixinDeclaration has a const constructor. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/124304191
Change-Id: I78f07338c3ac4c254986fb2b19a00bb5fd4201b7
Reviewed-on: https://dart-review.googlesource.com/c/92860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 22:16:12 +00:00
Sigmund Cherem 6588eaf794 Fix calls to generator-bodies to correctly model elided parameters 
Bug: https://github.com/dart-lang/sdk/issues/35924
Change-Id: If4e2597c1e92f12675f537a1cfba4cb14f9551d8
Reviewed-on: https://dart-review.googlesource.com/c/92862
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-02-12 21:58:31 +00:00
Sigmund Cherem c507acfae4 Fix Js-interop factory calls which broke when eliding optional parameters. 
The issue derives from the fact that `parameterStructure` has only the preserved parameters,
however the SSA was emitting values for all arguments.

I fixed this by emitting all parameters. I also noticed that the parameter order should
probably be the native-ordering here as well (it doesn't matter for the factory, but it may
matter for other static native calls, if any)

Bug: https://github.com/dart-lang/sdk/issues/35916
Change-Id: I2e93c7f8e3baf5c9285107d23786bb3bf4f3a511
Reviewed-on: https://dart-review.googlesource.com/c/92626
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-12 18:53:43 +00:00
Nicholas Shahan d93ef933d5 [tests] Add 'spread-collections' flag 
Some of the new control flow collections tests are using the spread operator.

Change-Id: Id050025342692a5e3d88471840c4f0ca5cdab5da
Reviewed-on: https://dart-review.googlesource.com/c/92480
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-02-11 19:52:19 +00:00
Aart Bik 32603d5626 [vm/compiler] improve equality constant folding 
Rationale:
Static calls were formerly unexplored in our constant
folding. This is a first step towards making the
constant folder aware of semantics of recognized methods.

https://github.com/dart-lang/sdk/issues/35882

Change-Id: Id6e366f4d25f08a618931fc3c8a8c065f6358feb
Reviewed-on: https://dart-review.googlesource.com/c/92410
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-02-09 01:09:39 +00:00
Kevin Millikin be79eb4517 Ship experiment 'set-literals' 
Change-Id: Ief182017752b87ef099ac5140ff781cbb14d76a9
Reviewed-on: https://dart-review.googlesource.com/c/92125
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-02-08 16:17:55 +00:00