2d3b1055d3
[vm/ffi] remove RuntimeError/Fail expectation from status files
...
Change-Id: Iaff947c213ac6cff666202fca16b3775bcc10413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95782
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Samir Jindel <sjindel@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2019-03-07 13:16:06 +00:00
b71f6afd2c
[vm/ffi] enable function stress test on macos
...
Change-Id: I92f676ac6c9733123b7cccf4dc24cb723a2b0594
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95655
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Samir Jindel <sjindel@google.com >
2019-03-07 08:20:08 +00:00
975cc65c17
[vm, interpreter] Implement interpreter stubs for IA32.
...
Change-Id: I7bb7e51cb46868abcc10c7dcc7cbf1db1ccdc35c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95264
Reviewed-by: Régis Crelier <regis@google.com >
2019-03-06 21:09:30 +00:00
7a98559781
[vm/ffi] make Pointer.toString() uniform on all operating systems
...
Change-Id: I805c8b3c56a18a253c5005945cab47d5a6aa26cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95648
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Samir Jindel <sjindel@google.com >
Auto-Submit: Daco Harkes <dacoharkes@google.com >
2019-03-06 16:48:09 +00:00
a85e481d3d
[vm/gardening] Fix status file for entrypoints_verification_test.
...
Fixes https://github.com/dart-lang/sdk/issues/35957
Change-Id: I215538cfa8dcda733bf29aaa3fa2a73817663bb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95646
Commit-Queue: Samir Jindel <sjindel@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Auto-Submit: Samir Jindel <sjindel@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2019-03-06 13:56:36 +00:00
ea6e83004b
Use @pragma instead of package:meta/dart2js in tests
...
Change-Id: I16c0ed6f391a417d8faa55e68cde902d91e3db32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95220
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2019-03-06 08:32:05 +00:00
57f16820cd
Add tests for "await" inside spread, if, and for.
...
These don't try to comprehensively cover every interaction of async
and the new syntax, but they should test that an implementation handles
an await appearing in all the various places in the new syntax where an
expression is permitted.
Change-Id: I4852815002fcad6697f3bad4103693b1d4288d06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94121
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2019-03-06 00:10:04 +00:00
ed8357cf83
Re-land "[vm/ffi] Stress tests for FFI functions.""
...
We will only run the tests on supported configurations. Issues are open
to expand coverage.
This reverts commit 1d3a0d5129https://dart-review.googlesource.com/c/sdk/+/95023
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2019-03-05 14:17:08 +00:00
204651f3ab
Replace package:expect annotations with @pragma
...
Change-Id: Ib43d0d71a3ee8b0f0e6d676e6a3e448a107b7ca5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95180
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2019-03-05 11:00:17 +00:00
99093c0610
[fasta] Required but not inferred constant context.
...
Add a new kind of constant context in the body builder for expressions
that must be constant but where constness is not inferred.
This context is used for parameter default values and initializing
expressions for non-final fields in classes containing at least one
const constructor.
Fixes https://github.com/dart-lang/sdk/issues/34191
Change-Id: I200ca88586b19335b185dad0839dfad4eef1f75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93520
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2019-03-05 09:23:57 +00:00
822ebdd1e0
[fasta] Wrap non-const variable accesses inside const expressions.
...
Change-Id: I8761031da2419a47a947a02721d4ffd86ac7c531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93504
Reviewed-by: Peter von der Ahé <ahe@google.com >
2019-03-05 09:23:57 +00:00
013cf68624
Replace js_helper annotations with @pragma
...
@ForceInline is still used by dart:html, will be removed in a later CL.
Change-Id: I480325fe91cc6baefb17ead49f839442e023d441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95160
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2019-03-05 08:56:18 +00:00
5a8bdc7f34
[dartdevc] fix #36052 , missing key in map should result in null
...
Change-Id: Ic32fb8689fd2163e162b80ad4682e9b10ba4eaee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94920
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Auto-Submit: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2019-03-05 01:15:30 +00:00
b88e6dd910
Fix the type argument on the deep flattening spread test.
...
Change-Id: Icba0904c88a18901c0a2d423a8ce7ab7af8413fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94941
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2019-03-04 19:20:53 +00:00
2c087433db
[co19] DEPS and status files updated
...
Change-Id: I75e42be513c65799bcb9332a5c4614c00461ec85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94283
Reviewed-by: William Hesse <whesse@google.com >
2019-03-04 15:35:31 +00:00
95cfa6c583
Support native class and js-interop annotations through ir constants
...
Change-Id: I8e9deb1392dc98d958f13611a984e422b028265c
Reviewed-on: https://dart-review.googlesource.com/c/95032
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-03-04 08:40:15 +00:00
c2a48ee065
[VM] Fix bigint left shift that could cause heap corruption when intrinsified.
...
The size of the result digit array was not computed correctly.
When 64-bit intrinsics are used, one extra digit pair must be allocated.
Change-Id: Id3ca3a16ef24b598e44bf25221d400b9be71248a
Reviewed-on: https://dart-review.googlesource.com/c/94683
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2019-03-01 18:59:10 +00:00
9201b906ee
Convert ir.Constant to ConstantValue
...
Needed for passing the --enable-experiments=constant-update-2018 option to start working on ir.Constant nodes.
Change-Id: I4f3d8fa6a59ddbda1635fe2da64591bcffcb0f12
Reviewed-on: https://dart-review.googlesource.com/c/95030
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-03-01 18:46:00 +00:00
2c8f70cde3
[cfe] Add type inference for spreads in set literals
...
Change-Id: I60250ec4ba7dba2381d84328095d38cf47b4ea8b
Reviewed-on: https://dart-review.googlesource.com/c/94548
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2019-03-01 15:17:13 +00:00
ba4cfb8613
Initial computation of initializer complexity through the scope visitor.
...
Change-Id: I2951624a0ad901c7c518b6e5d2f147dceae870cc
Reviewed-on: https://dart-review.googlesource.com/c/94382
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-03-01 08:37:12 +00:00
1d3a0d5129
Revert "[vm/ffi] Stress tests for FFI functions."
...
This reverts commit b186a270e43dcc0c69a19d609426b2223f407af5https://github.com/dart-lang/sdk/issues/36033
Issue: https://github.com/dart-lang/sdk/issues/36034
Change-Id: Ifa338fb96b490e8137a8aa6a4a62f4a6f9e6ea83
Reviewed-on: https://dart-review.googlesource.com/c/94963
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Aart Bik <ajcbik@google.com >
Auto-Submit: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Aart Bik <ajcbik@google.com >
2019-03-01 01:37:09 +00:00
223f407af5
[gardening] Skip ffi/negative_function_test on asan bot
...
This newly added test causes crash dump archiving to fail on
vm-kernel-asan-linux-release-x64 bot. This causes bot to fail
although the test failure was approved.
The test was added in b186a270e4https://github.com/dart-lang/sdk/issues/36033
Issue: https://github.com/dart-lang/sdk/issues/36034
Change-Id: I9ac201124db239d9c4bcce176c54e66cfdf1b54e
Reviewed-on: https://dart-review.googlesource.com/c/94961
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Auto-Submit: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2019-02-28 23:44:49 +00:00
48ee388791
Fix a typo in a shared test
...
Change-Id: I096e459ffeae70f944d03715081c3b9f653b01a6
Reviewed-on: https://dart-review.googlesource.com/c/94843
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2019-02-28 21:25:49 +00:00
a10b0d8763
[vm/compiler] LICM and CSE improvements
...
Several improvements
(1) makes implicit control dependence of a null check
explicit by means of data dependence (already
done for bounds checks); also see the doc in
runtime/docs/compiler/data_dep_for_control_dep.md
(2) improves CSE properties of various IL nodes
(3) allows LICM on invariant code that may-throw
as long as the visible behavior is preserved
https://github.com/dart-lang/sdk/issues/35323
https://github.com/dart-lang/sdk/issues/34684
Change-Id: Icb4520a649da38eddc3d7c85af21427d3c64d22e
Reviewed-on: https://dart-review.googlesource.com/c/93822
Commit-Queue: Aart Bik <ajcbik@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-02-28 19:29:06 +00:00
9d609426b2
[vm] Update status file for standalone_2/ffi/function_stress_test
...
Change-Id: I15eba297fb13a57ea4a9cd70364916ceba20ee3a
Reviewed-on: https://dart-review.googlesource.com/c/94755
Reviewed-by: Samir Jindel <sjindel@google.com >
2019-02-28 17:42:53 +00:00
b186a270e4
[vm/ffi] Stress tests for FFI functions.
...
Change-Id: I75251b92688b70b4d14eda7b1fddef0fe94c60fe
Reviewed-on: https://dart-review.googlesource.com/c/94384
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Auto-Submit: Samir Jindel <sjindel@google.com >
2019-02-28 16:40:36 +00:00
9a4c49f301
Update field analysis tests to prepare for eager initializer improvements
...
Change-Id: Ie9611ed269a42be4d7c406739cf935d569d8606a
Reviewed-on: https://dart-review.googlesource.com/c/94297
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-02-28 10:32:06 +00:00
1720704594
Recognize effectively constant static fields
...
Change-Id: Ic8f7a014a6af2f9d8854e0731fe0d2df11b554da
Reviewed-on: https://dart-review.googlesource.com/c/94281
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-02-28 09:12:26 +00:00
5f095b7039
[Fasta] Add support for spread in map literals
...
Spreads are compiled as if they were spread elements in list or set
literals. When one occurs in a map literal it is translated to a new
spread map entry.
Change-Id: Ic618b1e85e595b4c2cd65e184b9d2c49e9c34b79
Reviewed-on: https://dart-review.googlesource.com/c/94547
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-02-28 06:05:00 +00:00
36c14db2d3
Only refine non-null in SSA
...
Code-size difference on a large app is very small (0.007% worse), but
this cuts the time spent in type-propagation by more than half
(23s -> 10s on my machine).
I saw a 0.4% code-size regression in pop-pop-win, but that is
recovered once we are smarter about generating simple is-checks
when the "raw" type can be used because the type arguments
match the bounds (see separate CL).
Change-Id: I45c0fb1afabdca3d045aec576c131ed764dc31ce
Reviewed-on: https://dart-review.googlesource.com/c/94120
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2019-02-27 21:48:00 +00:00
d7a7de31bf
Update dartkb test expectations
...
Change-Id: I8137e49fc7982a65c857c206763ffecacd141cac
Reviewed-on: https://dart-review.googlesource.com/c/94545
Reviewed-by: Jens Johansen <jensj@google.com >
2019-02-27 14:26:02 +00:00
a9ef31ba43
[Fasta] Add Kernel syntax for spread elements
...
Add spread elements to the Kernel syntax. They are currently replaced
by an invalid expression during type inference.
Change-Id: Icdb489e2c9993c6517983cfafdefc801ebb378ab
Reviewed-on: https://dart-review.googlesource.com/c/94501
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-02-27 11:48:12 +00:00
b79e2a8882
Fix equivalence/show_helper
...
Change-Id: I95952b42bbaa882cedc4c3ab20182381d8424173
Reviewed-on: https://dart-review.googlesource.com/c/94224
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-02-27 10:48:22 +00:00
edcaa05375
Support @pragma('dart2js:noElision') on non-internal methods
...
Change-Id: Ifae3f76107086f6ad47de2f9eda7b7aec589fc89
Reviewed-on: https://dart-review.googlesource.com/c/94284
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-02-27 09:46:52 +00:00
dc8a56bc0e
Rename set literal tests to end in _test
...
Change-Id: Ifc33abb2279554373bdfb9c1c54f468d7fd683c2
Reviewed-on: https://dart-review.googlesource.com/c/94480
Commit-Queue: Alexander Thomas <athom@google.com >
Auto-Submit: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2019-02-27 08:14:12 +00:00
3d3f6f9d4b
Remove immediateUnderSetLiteral.
...
Change-Id: I5abb8bb6dafa2a7ee88ce4bf559bae20ac0998fd
Reviewed-on: https://dart-review.googlesource.com/c/92401
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-02-26 18:38:00 +00:00
fa0ba2220e
[vm/compiler] Fix bug in Cid range computation
...
Rationale:
Make sure open range is closed when skipping
special cids. This bug was probably undetected
for a while, since only kByteBufferCid is adjacent
to kNullCid.
https://github.com/flutter/flutter/issues/28260
Change-Id: Ic22c83aeb26c3130132dc901004a0ad818246dbc
Reviewed-on: https://dart-review.googlesource.com/c/93926
Commit-Queue: Aart Bik <ajcbik@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2019-02-25 22:31:24 +00:00
e7d263b05f
[fasta] Transform set literals in annotations.
...
Change-Id: I23e60cb85e1df728fc3be3b38be43e31a1795d1d
Reviewed-on: https://dart-review.googlesource.com/c/93941
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2019-02-25 10:30:14 +00:00
646c1f679a
[tests] Minor fixes in control flow collections for tests
...
Change-Id: I61bbe247b8474a6eeb2d63f9acbd99218f2d04e6
Reviewed-on: https://dart-review.googlesource.com/c/94140
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2019-02-23 01:37:41 +00:00
5192cd1008
Narrowing improvements in dart2js global inference.
...
* no longer narrow by selector use, only narrow by type and non-null
* check for narrow nesting
* add non-null in a couple known places
One large apps, I compared the type-masks in dump-info and all differences were improvements with non-null. We weren't doing any narrowing based on the possible targets of a selector.
Change-Id: I270f360f70fbe3171d09ccd71d10517be9140194
Reviewed-on: https://dart-review.googlesource.com/c/90340
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2019-02-23 00:10:11 +00:00
8fface97f0
Reland "Eliminate singleton/static access to the constant system and expose its functionality at the top level."
...
This is a reland of 027b76ecbfhttps://dart-review.googlesource.com/c/93842
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
Change-Id: Ib04a9d48c8dca51020258313256e0fb0df330d9b
Reviewed-on: https://dart-review.googlesource.com/c/94107
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-02-23 00:06:31 +00:00
e40b0e04c9
Reland "Merge the JavaScript constant system into the base constant system and flatten the inheritance hierarchy."
...
This is a reland of cf51eb2fbahttps://dart-review.googlesource.com/c/93880
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
Change-Id: I83960035a7b0989397f9646f2f834ec468aa4908
Reviewed-on: https://dart-review.googlesource.com/c/94106
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-02-23 00:06:31 +00:00
6bdd38ae84
Reland "Move the JavaScript constant system into constants/constant_system.dart in preparation to merge it with the base constant system and flatten the constant system hierarchy."
...
This is a reland of 1702b986c8https://dart-review.googlesource.com/c/93840
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
Change-Id: I20ef9755886a6b54135aa7169c9d7de08e8cbe93
Reviewed-on: https://dart-review.googlesource.com/c/94105
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-02-23 00:06:31 +00:00
960b08a969
Reland "Remove the Dart constant system and move all required classes into the JavaScript constant system."
...
This is a reland of 5af8de8954https://dart-review.googlesource.com/c/93746
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
Change-Id: I8c8399e94dd80c1f543a54454efc9cf59ef6ac7b
Reviewed-on: https://dart-review.googlesource.com/c/94104
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-02-23 00:06:31 +00:00
e1992e0178
Revert "Remove the Dart constant system and move all required classes into the"
...
This reverts commit 5af8de8954https://dart-review.googlesource.com/c/93746
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
TBR=johnniwinther@google.com ,sigmund@google.com ,fishythefish@google.com
Change-Id: Ic28807774502d11a53572095616510a642cf75b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94081
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2019-02-22 21:54:57 +00:00
05d9c60a22
Revert "Move the JavaScript constant system into constants/constant_system.dart"
...
This reverts commit 1702b986c8https://dart-review.googlesource.com/c/93840
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
TBR=johnniwinther@google.com ,sigmund@google.com ,fishythefish@google.com
Change-Id: If1b6291508c9792a6135a2ad5333b4bb3b800f69
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94103
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2019-02-22 21:50:57 +00:00
388f8e7731
Revert "Merge the JavaScript constant system into the base constant system and"
...
This reverts commit cf51eb2fbahttps://dart-review.googlesource.com/c/93880
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
TBR=johnniwinther@google.com ,sigmund@google.com ,fishythefish@google.com
Change-Id: I2d403834ac3ac41371e041d21eec3d83d152343a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94102
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2019-02-22 21:46:52 +00:00
2c3dfa9e71
Revert "Eliminate singleton/static access to the constant system and expose its"
...
This reverts commit 027b76ecbfhttps://dart-review.googlesource.com/c/93842
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
TBR=johnniwinther@google.com ,sigmund@google.com ,fishythefish@google.com
Change-Id: I65310b2579c6746620ed6129e670206ed9bf5e91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94101
Reviewed-by: Mayank Patke <fishythefish@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2019-02-22 21:42:52 +00:00
027b76ecbf
Eliminate singleton/static access to the constant system and expose its
...
functionality at the top level.
Use sites have been updated to import the library with a prefix.
Change-Id: I0f5e4e47bec089d2d0dc2fcd50caccfd98947cf5
Reviewed-on: https://dart-review.googlesource.com/c/93842
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-02-22 21:34:47 +00:00
cf51eb2fba
Merge the JavaScript constant system into the base constant system and
...
flatten the inheritance hierarchy.
dart2js only needs one constant system at most.
Change-Id: I72e446652ea44298677e986b06e63152e381353b
Reviewed-on: https://dart-review.googlesource.com/c/93880
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-02-22 21:34:47 +00:00
Daco Harkes