9206b6cabb
Delete tests/kernel
...
regression_flutter51828_test moved to front_end expectation tests
Closes #42926
Change-Id: If177b844d9cf3542e3ec9c845ccd32f9b0a7a111
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163582
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-09-21 08:33:26 +00:00
735bcbe10d
Allow reading null current with unsound null safety
...
Fixes #42950
It was previously allowed, though non-sensible, to read `.current`
before advancing the iterator for a `RegExp.allMatches` iterable and get
`null`. Using `as` allows backward compatibility in unsound null safety
mode, while `!` is breaking since it introduces a null check in either
mode.
The new behavior is also the behavior of the migrated code for DDC since
https://dart-review.googlesource.com/c/sdk/+/151121
Change-Id: I9f3654298a3d480ec2f297a40a4145ff6ca9f011
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157880
Auto-Submit: Nate Bosch <nbosch@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Nate Bosch <nbosch@google.com >
2020-09-18 17:43:57 +00:00
d5bbfcd874
Update static errors for variance_in_inference_error_test.
...
These changes look substantive to me, which isn't expected.
Change-Id: Ie4e4fd9d702923b3c3c2fdd56160a523801a6c9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162944
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-09-18 11:57:05 +00:00
569bbc3ee5
[dart2js] Clean up tests/dart2js/async_stacktrace_test.
...
Change-Id: I9dd1ca1d0ee9294548114266cef9dff822c8b24b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163303
Commit-Queue: Mayank Patke <fishythefish@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-09-18 11:53:05 +00:00
122f07c7bb
Fix mistakes in variance_downwards_inference_test.
...
Fix #43422 .
Change-Id: Ic315148284e45a26cfe88ac6177c16c671a318eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162961
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-09-17 00:15:19 +00:00
cc8fd04924
[wasm] Add WasmMemory class.
...
Also, port the old wasm memory tests, and fix some NNBD issues.
Bug: https://github.com/dart-lang/sdk/issues/37882
Change-Id: I131ba5836bb0a3dd946cf9b0fa3f2e186b6b132e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162801
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2020-09-16 19:24:28 +00:00
1d34f60b66
[ddc] Fix missing covariant checks from mixins
...
Collect all forwarding stubs from anonymous mixin classes and insert
them in the target class if no override exists.
Change-Id: Id62f20b644ce7bbabe114d0d1648664392748a2d
Fixes: https://github.com/dart-lang/sdk/issues/43027
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161760
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-09-16 18:56:58 +00:00
623a9bda67
Fix async test to match inference changes from #43162 .
...
Closes #43440 .
Change-Id: If25e49400d63698b974ab935f483804e36e22f98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163040
Auto-Submit: Leaf Petersen <leafp@google.com >
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-09-16 14:39:28 +00:00
e119ccad2a
[cfe] Infer Object from constraints similar to T? = dynamic
...
Closes #43163 .
Bug: https://github.com/dart-lang/sdk/issues/43163
Change-Id: I55f51eee097a320dcc38cf54a41c9f6684b5dd59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162505
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-09-16 11:36:28 +00:00
8d8df2c9f6
Revert "Issue 43162. Change matching dynamic/void vs. 'T?'."
...
This reverts commit 7b0aeb2ac8https://github.com/dart-lang/sdk/issues/43162
> Change-Id: I8ae2166e4bc593b42ddd39c35e7d02a706d7b94d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162621
> Reviewed-by: Leaf Petersen <leafp@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=leafp@google.com ,scheglov@google.com ,brianwilkerson@google.com ,srawlins@google.com
Change-Id: I288f8ccf82c17565c40e02245998590ebd7c98bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/43162
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162747
Reviewed-by: David Morgan <davidmorgan@google.com >
Commit-Queue: David Morgan <davidmorgan@google.com >
2020-09-16 07:36:05 +00:00
7b0aeb2ac8
Issue 43162. Change matching dynamic/void vs. 'T?'.
...
Bug: https://github.com/dart-lang/sdk/issues/43162
Change-Id: I8ae2166e4bc593b42ddd39c35e7d02a706d7b94d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162621
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-16 02:31:02 +00:00
56be9a7425
[wasm] Port about half of the old dart:wasm tests to package:wasm
...
The rest of the tests rely of features I haven't implemented yet. I'll
port them as I implement them.
Bug: https://github.com/dart-lang/sdk/issues/37882
Change-Id: I3465f10055db8d82148004ea975c0ed3b2928178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162780
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
2020-09-15 20:48:31 +00:00
4948c31b7a
[test_runner] Support detection of CFE warnings
...
+ some test expectation fixes
Change-Id: Ibf0259914960ea25978f2b8e29aa89336e209f2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162321
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-09-15 07:57:31 +00:00
2f1ad1e929
Fix lib/mirrors/library_uri_package_test.
...
It was importing the args package which has not yet been migrated to
null safety in the SDK repo. It uses that package mostly arbitrarily
so I switched it to use expect instead.
Change-Id: I1550a830a157c376219ebb64c97f3a329af6e75b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162802
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-09-15 00:53:48 +00:00
cdd1260ef0
[tests] Move regression test to run on all backends
...
This same error recently surfaced on a flutter web target.
Change-Id: If4c093cde85887105e93ab46469b1c3b2ea55d03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162243
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-09-14 21:13:37 +00:00
9ea431c158
Simplifying and recategorizing cyclic imports test
...
This bug doesn't depend on exports and instead of the constructed class hierarchy.
See: https://dart-review.googlesource.com/c/sdk/+/162383/comment/9196db98_412d446d/
Change-Id: Ib107d3fa3ab7782bee5db59754583b20976832a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162785
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2020-09-14 20:20:49 +00:00
343148f60a
More test cases for never_runtime_check.
...
These test cases cover the following scenarios:
- `is` and `is!` tests that do not appear inside an "if" statement.
- `== null` and `!= null` tests that do not appear inside an "if"
statement.
- `??=` assignment where the "write" type is nullable but the "read"
type is non-nullable (to make sure the implementation is using the
read type to decide whether to insert the null check).
- `??=` assignment where the LHS is a super call to the index operator.
- `??=` assignment where the LHS is accessed through an extension
(either explicitly or implicitly).
- `??=` assignment where the LHS is a null-aware indexed operator.
- Null-aware access to a getter.
- Null-aware access via a cascade.
- Null-aware access to a method/getter on Object (e.g. `toString()`).
- Null-aware access to a method/getter supplied by an extension that
extends a nullable type (either explicitly or implicitly).
Change-Id: I46aeb6ffc35fc776f48bcd838ff8e4acf7b39f05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162629
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-09-14 19:53:37 +00:00
27235bf480
[VM/runtime] Fix finalization of recursive types.
...
Super type's type arguments that are still unfinalized after instantiation during finalization are not necessarily `TypeRef`, but can be (recursive) `Type`.
Add regression test.
This fixes flutter issue https://github.com/flutter/flutter/issues/65278
Change-Id: I07f842d798d24ebff9d1462d7e47278e901c0128
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162583
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2020-09-14 18:52:43 +00:00
53895b2270
[dartdevc] Fixing issue related to dual exports of multiple entrypoints in a cyclic import loop.
...
See: https://github.com/flutter/flutter/issues/64011
Change-Id: I8a11e9d3f19428a516cf7a60ee45c3bacf26545d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162383
Commit-Queue: Mark Zhou <markzipan@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-09-14 18:49:00 +00:00
781094f2ce
[vm/bytecode] Add parameter flags to FunctionDeclaration.
...
We create the parameter names array when loading the
FunctionDeclaration, but the required parameter flags are only set later
when we load the Code declaration. If there's an intermediate use of the
Function object that copies the required parameter flags, like creating
an ImplicitClosureFunction when loading a tearoff stored in the object
pool, there will be no set flags at that point.
Add a copy of the parameter flags to the FunctionDeclaration so the
required flags can be set at the same time as the parameter name and
type to avoid this scenario.
To avoid adding unneeded flags to the kernel bytecode, we only serialize
the parameter flags needed for each declaration, so FunctionDeclaration
and ClosureDeclaration only contain the required flag, and Code contains
all flags _but_ the required flag.
There are no trybots for strong mode + bytecode, but manually checked
by running the following on the main branch (cherry-picking the
test_matrix.json changes) and this branch:
python tools/test.py \
-n dartkb-mixed-strong-linux-release-x64,dartkb-interpret-strong-linux-release-x64 \
tests/language/nnbd/required_named_parameters/missing_required_argument_dynamic_test.dart
Cq-Include-Trybots: luci.dart.try:vm-dartkb-linux-release-simarm64-try,vm-dartkb-linux-release-x64-try
Change-Id: Ic75b831d5ceed08154e2c61b8f64461705558653
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162501
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Tess Strickland <sstrickl@google.com >
2020-09-14 15:28:20 +00:00
e6ffc0b285
[parser] Issue different warnings for missing identifier based on whether the token is used or not.
...
E.g. "var = 42;" now has a different error message than "var default = 42;".
Fixes #22553
Change-Id: I58affe988569d8e79190b63f7267b471a1b0ebc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162182
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-14 08:55:18 +00:00
6e30428829
[dart2js] Add tests for https://dart-review.googlesource.com/c/sdk/+/162420 .
...
Change-Id: Ifc4f060a72dc273d130ba33d5f61cd4c7e014fdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162580
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2020-09-11 22:53:35 +00:00
af110a7aa4
Change resolution of assignment to PropertyAccess.
...
Change-Id: Ie9de1166eb0dfd179d539f1b10c54084caf643d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162248
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-11 15:50:20 +00:00
8d68480746
[dart2js] Fix global type analysis
...
https://github.com/dart-lang/sdk/issues/43366
Fixed: 43366
Change-Id: Iac8247c31fa268186c8f2e3f52e0be1cac062598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162247
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-09-11 04:07:41 +00:00
ae0fbde71c
[dart:io] Enable insecure connection ban for HttpClient.
...
We are reverting socket level checks at https://dart-review.googlesource.com/c/sdk/+/161581 .
Instead, we are moving the checks to upper protocols
such as http and grpc.
Change-Id: Ice1a6bf818810f59937c19b48f5a68bb512c018d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161801
Commit-Queue: Mehmet Fidanboylu <mehmetf@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2020-09-10 17:42:29 +00:00
3d77741666
[vm/compiler] Unify name checking in dynamic closure call dispatchers.
...
Instead of possibly looping over the closure function parameter names
array multiple times, just do it once. Check each entry against the
provided argument names. If none match, check the required bit (if in
null-safe mode). Also keep a count of matched names to check that all
provided names matched after the iteration.
Now that optional name checking is part of the fragment built by
BuildClosureCallArgumentsValidCheck, that method builds checks for
exactly the same things as its namesake in Function.
Also refactor the variables used by the checker into read/write ones
that need to be allocated in the parsed function and read-only ones
that can just be temporaries since no Phi nodes are needed.
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-release-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-release-simarm_x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try
Bug: https://github.com/dart-lang/sdk/issues/40813
Change-Id: I3cb421dd538629d7f5499f3bbf0653d34b850dce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160725
Commit-Queue: Tess Strickland <sstrickl@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2020-09-10 07:12:14 +00:00
0e93845ba1
Make update_static_error_tests work on Windows (again)
...
+ update some test expectations
Change-Id: I63ca86309ea3352a88686f5e3f416311ee7bc03c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162185
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-09-10 06:21:13 +00:00
0c90775fd6
[CFE] Better error messages for class initialization errors
...
Change-Id: Ic7c489b0bfffd05cdd71dc254db042956fd25c3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161944
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-09-09 11:37:47 +00:00
17cf1b780c
[co19] Some LanguageFeatures and Utils tests enabled
...
Change-Id: I54a134e20e394510e808737421d081cea1ea0d50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161702
Reviewed-by: Alexander Thomas <athom@google.com >
2020-09-09 06:44:41 +00:00
f8fbefd951
Revert "Enable long path on Windows"
...
This reverts commit 08662f0575https://dart-ci.appspot.com/log/pkg-win-release/unittest-asserts-release-win/12878/pkg/dartdev/test/commands/test_test
Original change's description:
> Enable long path on Windows
>
> File APIs on Windows can now handle files and directories identified by
> long paths (greater than 260 characters). For directory, the limit is
> 248.
>
> Some restrictions from Windows:
> 1. The size limit for long path is 32,767 characters.
> 2. Each component separated by backslashes should not be more than 255
> characters.
>
> Reference: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#maximum-path-length-limitation .
>
> Note that `Directory.current` does not work with long path.
>
> Bug: https://github.com/dart-lang/sdk/issues/42416
> Change-Id: Ia1b4608d393fb36f1d843858c6f076f3c825dc83
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152736
> Reviewed-by: Alexander Aprelev <aam@google.com >
> Commit-Queue: Zichang Guo <zichangguo@google.com >
TBR=aam@google.com ,zra@google.com ,zichangguo@google.com
Change-Id: If6701c887e616cd62f20faac43f601cfb53ed349
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/42416
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162104
Reviewed-by: Zichang Guo <zichangguo@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2020-09-08 22:34:50 +00:00
08662f0575
Enable long path on Windows
...
File APIs on Windows can now handle files and directories identified by
long paths (greater than 260 characters). For directory, the limit is
248.
Some restrictions from Windows:
1. The size limit for long path is 32,767 characters.
2. Each component separated by backslashes should not be more than 255
characters.
Reference: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#maximum-path-length-limitation .
Note that `Directory.current` does not work with long path.
Bug: https://github.com/dart-lang/sdk/issues/42416
Change-Id: Ia1b4608d393fb36f1d843858c6f076f3c825dc83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152736
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2020-09-08 20:12:05 +00:00
4237fda6a5
Check for IN_MODIFY in file_system_watcher_linux.cc
...
This allows to detect changes to a file due to `write` or `truncate`
syscalls.
Change-Id: I095d842367a56121cd87c2176dde0a4feb5e3d7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161177
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
Auto-Submit: Michal Terepeta <michalt@google.com >
2020-09-08 17:57:45 +00:00
42c4c3c1bd
[cfe] Add Jenkins SMI hashcode combiner
...
Change-Id: I542369fc2d8443bb0094fdedc11596fdc2f20e2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159084
Commit-Queue: Javier López-Contreras <jlcontreras@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-09-07 12:36:13 +00:00
909a05cf8a
[dart:io] Remove obsolete http embedder config.
...
This is no longer being used.
Change-Id: I316a28193698cc2ceb62e6d89c87adf0d05f7be7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161800
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Mehmet Fidanboylu <mehmetf@google.com >
2020-09-04 16:50:10 +00:00
5c4bf35a2b
[dart:io] Remove socket level checks for domain policy.
...
This partially reverts https://dart-review.googlesource.com/c/sdk/+/154180 .
The main mechanism for setting domain policy is still useful as we will
use this to avoid insecure connections for higher level protocols (such
as HTTP and gRPC).
We already knew Android does not enforce network policy at socket level
but it turns out iOS does not as well:
> ATS doesn’t apply to calls your app makes to lower-level networking
> interfaces like the Network framework or CFNetwork. In these cases,
> you take responsibility for ensuring the security of the connection.
This also resolves the need to fix
https://github.com/dart-lang/sdk/issues/43223 as we are no longer
enforcing the policy at socket level.
Change-Id: I3913da8ea39dac2c5a70fdabe442775b18cfd0c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161581
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Mehmet Fidanboylu <mehmetf@google.com >
2020-09-04 15:01:40 +00:00
90652bc314
[VM] Fixes nested sync* w. diff. types.
...
Makes the synthetic sync* iterator dynamic to allow the internal,
synthetic sync* code to handle nested iterators of differing types.
Bug: https://github.com/dart-lang/sdk/issues/42234
Change-Id: I309885b27555142cd7f8ab13a5637b35545f1d44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160071
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2020-09-03 11:48:44 +00:00
a0f67bc9ed
[co19] Set literals tests enabled
...
Change-Id: I3bbc3558770143b4b97eb08c014dcf250bb2cf70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161162
Reviewed-by: Alexander Thomas <athom@google.com >
2020-09-03 07:38:01 +00:00
0c5f2a3532
[vm/file] Ensure that appropriate type is reported for links to files vs directories
...
Bug: https://github.com/dart-lang/sdk/issues/30410
Change-Id: I96c9ca8a5aff4a4337022047ea0b844335efdfcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161260
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Zichang Guo <zichangguo@google.com >
2020-09-03 01:17:52 +00:00
a51197194f
Fix test for abstract field, not impelemnetd by the mixin application.
...
Change-Id: I1d12a70a82a859d57516948672ed6a931904ae7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161626
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-03 01:15:23 +00:00
a7fbb3ffe3
Add regression test for issue #43281
...
Change-Id: Iae1c81f60ccc36708601d73d426f4fbc6f119084
Issue: https://github.com/dart-lang/sdk/issues/43281
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161627
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-09-03 00:38:52 +00:00
c3dd499a28
Skip the slow http_big_header_test for bytecode mode
...
Bug: https://github.com/dart-lang/sdk/issues/43291
Change-Id: Ia0e4a2325285e4573e4bf86ee8b74019813430bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161606
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-09-02 20:57:42 +00:00
a3322ad622
[dart:io] Use empty path on Windows leads to error
...
Bug: https://github.com/dart-lang/sdk/issues/42938
Change-Id: Id988420fd14caf6ac985aa4de0b974f344809e51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157942
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-09-02 20:49:37 +00:00
01024dfa5a
Issue 43200. Report ASSIGNMENT_TO_FINAL when 'final late' has an initializer.
...
Bug: https://github.com/dart-lang/sdk/issues/43200
Change-Id: Ib79b4e8246f8f67661212c3d107de961d72132b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161471
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-02 15:38:22 +00:00
7130dd4d3d
[cfe] Report error on non-void setter return type
...
This CL also adds fileUri/charOffset to all TypeBuilder's and renames
Void/FutureOr/Never/Dynamic/BuiltInTypeBuilder to *TypeDeclarationBuilder
so match their relation to TypeBuilder/TypeDeclarationBuilder.
Closes #42962
Change-Id: Iee5102134574d24f748103282a37bb9a85a0ac2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161165
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2020-09-02 12:43:12 +00:00
a7cb764aa4
[tests/ffi] Reinstate deleted test
...
Test was added in https://dart-review.googlesource.com/c/sdk/+/132843 ,
duplicated in https://dart-review.googlesource.com/c/sdk/+/132604 ,
and then got deleted in the non-NNBD folder, but that does not show up
in https://github.com/dart-lang/sdk/commits/master/tests/ffi_2 .
Change-Id: Id3dbe2c065d3b74144f1007d35c8d4c8d962f528
Cq-Include-Trybots:dart/try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161487
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-09-02 12:12:52 +00:00
d27556656f
Fix Directory.list from aborting on Linux
...
Directory.list will throw fatal error if a symbolic link points to an
unexpected file type with follow_link being set. This cl will make
list() issuing the link itself regardless of whether follow_link is set.
Closes: https://github.com/dart-lang/sdk/issues/43176
Change-Id: I16f0e9a0ec68c9d48e60f1fbe58820ebe4b066eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160705
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-09-01 22:44:01 +00:00
a6db069971
[dart:io] Loosen the HTTP header size limit
...
The `HttpClient` and `HttpServer` clasess now have a 1 MiB limit for the
total size of the HTTP headers when parsing a request or response,
instead of the former 8 KiB limit for each header name and value. This
limit cannot be configured at this time.
Bug: https://github.com/flutter/flutter/issues/56580
Change-Id: I5f094df32a93ec3e6645a0d69d8cf8263082775a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150500
Commit-Queue: Zichang Guo <zichangguo@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
2020-09-01 22:34:21 +00:00
d9b874c4b5
Resolve AssignmentExpression with SimpleIdentifier directly.
...
Change-Id: I81cc3d6b1cf31d840727300c0a22e8acfa5bf17c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-01 22:15:41 +00:00
c1bb9a520c
[vm] Don't write LibraryPrefix::importer_ in AOT snapshots.
...
This field won't be used at runtime and is not accounted for during tree-shaking.
Bug: https://github.com/dart-lang/sdk/issues/41974
Bug: https://github.com/dart-lang/sdk/issues/43245
Change-Id: Ie5a669608e896aa8cee74a3a4249ba99ec6f980a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161220
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-09-01 16:49:49 +00:00
b59cf7f006
[co19] LibTest/typed_data tests enabled
...
Change-Id: Id8f34fd8026d50f5678c0976c08a1f59c8b4f18e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160284
Reviewed-by: William Hesse <whesse@google.com >
2020-08-31 19:38:08 +00:00
Johnni Winther