4a45573956
Change the default for the len argument to writeFrom on OutputStream
...
Fixed a bug in the writing code as a result.
Also added copyByffer argument to one of the write methods on the OutputStream interface.
R=ager@google.com
BUG=dart:292
TEST=EchoServerStreamTest.dart
Review URL: http://codereview.chromium.org//8493002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1293 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-08 09:42:20 +00:00
01990eb7dc
Fix TestRunnerTest to actually fail if one of the test tests has unexpected output.
...
R=whesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8501004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1287 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-08 07:40:47 +00:00
9f08c80a39
Fix the TestRunnerTest.
...
Use the correct path to the process_test. Decrease the timeout so
the test doesn't wait for 10 seconds.
R=whesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8502008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1286 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-08 07:25:25 +00:00
75915f99d8
Mark these tests as skip
...
TBR=ager
Review URL: http://codereview.chromium.org//8493014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1265 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-07 17:48:52 +00:00
68e7ec0db7
Skip TestRunnerTest on win32 platform, file issue 363 about flaky Process class.
...
BUG=363
TEST=standalone/TestRunnerTest
Review URL: http://codereview.chromium.org//8477028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1262 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-07 15:08:36 +00:00
ec697c8481
Implementation of Platform class that exposes information about the machine and the OS.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8492007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1260 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-07 15:04:42 +00:00
77e1072eeb
Change the handling of the close event in the StringInputStream
...
When the underlying InputStream issues a close event keep track of
when the final string data have been read from the
StringInputStream. When all string data have been read schedule a
callback of the close event.
R=whesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8477026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1253 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-07 13:51:37 +00:00
3d9daebb1b
Fix standalone/TestRunnerTest timeout and file-not-found errors.
...
BUG=
TEST=standalone/TestRunnerTest
Review URL: http://codereview.chromium.org//8494006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1252 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-07 13:28:06 +00:00
8a7ae17d76
Handling of wrong types of arguments in the File API.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8491014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1251 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-07 13:23:28 +00:00
f7582845ef
Dart test script dart rewrite - find the correct executable file for "process_test".
...
BUG=
TEST=standalone/TestRunnerTest
Review URL: http://codereview.chromium.org//8493004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1247 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-07 12:37:10 +00:00
a417e377dc
Add test_runner.dart to Dart version of test scripts. Include TestRunnerTest unit test.
...
BUG=
TEST=standalone/TestRunnerTest
Review URL: http://codereview.chromium.org//8440066
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1245 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-07 12:11:07 +00:00
516d71ab0b
Change the handling of closing sockets
...
Sockets now supports being half-closed for either reading or writing. When a socket is closed it is by default closed for both read and write and the underlying file descriptor is destroyed. However the socket close can be asked to only half-close the socket to send end of stream to the other end and still have the ability to receive more data.
The close event on a socket is only emitted when the socket is closed by the other end. Both half-close and full-close by the other end is reported as a close event. If a socket is already half closed the close event will automatically destroy the socket.
The streams on the sockets also takes advantage of this. A socket input stream will report a close event when the other end closed. A socket output stream will half-close the socket when close is called making it possible to still receive data on the input stream. When both streams have been closed the socket is destroyed.
For sockets operating on pipes they are initially created as half-closed for either reading or writing depending on which type of pipe a socket object is based on. A pipe for writing will start half-closed for reading so if it is only half-closed for writing the socket will still be destroyed. Same with a pipe for reading that will start half-closed for writing and when a close event is received half-closing the other direction will destroy the socket. Socket objects based on pipes are only exposed through streams.
Extended the socket close test to test a number of different scenarios.
Also refactor the socket data C++ object to encapsulate more socket information and operations.
Now the Linux and Mac OS versions are 100% the same as it turned out that using POLLRDHUP on Linux was not required any more.
R=ager@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8437090
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1196 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-04 12:34:43 +00:00
3a51b5ae88
Change test to not use DartOptions.
...
Review URL: http://codereview.chromium.org//8467003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1189 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-04 11:05:47 +00:00
9feefc61ba
- Disable OptionsTest in for component Dartium.
...
Review URL: http://codereview.chromium.org//8450022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1182 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-04 00:54:44 +00:00
a690fbc1ba
- Add a test for basic passing of arguments from the command line.
...
Review URL: http://codereview.chromium.org//8412007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1171 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-03 21:55:23 +00:00
026a56f666
Implement fullPath method on File objects.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8439067
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1134 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-03 08:28:16 +00:00
f74ecd22fd
Implemented File create API.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8437056
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1095 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 15:57:54 +00:00
ba34b6eb98
Fix process test and implementation after change to setter for registering event handler.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8440035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1084 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 12:50:59 +00:00
362d04f9af
Consistently use setters to set event handlers in native APIs.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8386029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1083 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 12:12:43 +00:00
9eda6e634b
Disable standalone/StatusFileParserTest on dartium, improve handling of missing files.
...
BUG=
TEST=standalone/StatusFileParserTest
Review URL: http://codereview.chromium.org//8440033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1082 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 12:12:09 +00:00
f9a5add2da
Add status_file_parser.dart library, and tests for it, to the Dart rewrite of the test suite runner.
...
BUG=
TEST=standalone/StatusFileParserTest
Review URL: http://codereview.chromium.org//8335008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1076 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 10:17:35 +00:00
0a275e0644
Fix file test.
...
Always use the input file to determine the full path to use
for the file tests. The output file does not exist before
the tests are run.
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8372056
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1074 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 08:05:05 +00:00
d95f5721e4
Completely skip FileTest while I investigate. It seems to be failing on fresh checkouts.
...
R=bak@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8438031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1073 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 07:24:54 +00:00
1b3cab3a4c
Update status file.
...
Review URL: http://codereview.chromium.org//8438006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1031 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 17:33:17 +00:00
5b5c36e253
Implement async file API on top of isolates.
...
This is not going to be efficient but will give us the right
semantics of the operations. We should be using native async
operations for this.
Fixed a bug in VM implementation of List.setRange.
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8431028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1012 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 14:07:30 +00:00
18e5ef8da5
New OutputStream interface
...
R=ager@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8413034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@997 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 10:10:37 +00:00
33ec29bf11
Add a new variable environment for testing, to replace the misusage of 'arch'.
...
Review URL: http://codereview.chromium.org//8408002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@993 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 09:12:55 +00:00
f9cb997183
Verify that user classes do not extend any of Bool, Double, ObjectArray,
...
ImmutableArray, GrowableObjectArray, IntegerImplementation, Smi, Mint,
BigInt, OneByteString, TwoByteString, FourByteString.
Review URL: http://codereview.chromium.org//8429013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@963 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-31 18:45:16 +00:00
83539ca419
Add type checks to directory listing.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8417023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@940 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-31 09:37:07 +00:00
4609b5a7ea
Standalone status file was updated too early.
...
Review URL: http://codereview.chromium.org//8417041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@924 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 22:32:37 +00:00
78353be760
Verify that user classes/interfaces do not extend/implement any of bool, num,
...
int, double, String, Function, or Dynamic.
Review URL: http://codereview.chromium.org//8416052
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@922 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 22:24:18 +00:00
38b7f4fdfb
Re-enable standalone/StatusExpressionTest on dartium.
...
BUG=
TEST=standalone/StatusExpressionTest
Review URL: http://codereview.chromium.org//8343058
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@888 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 12:05:47 +00:00
41b8b4a875
Fix type error in tools/testing/dart/status_expression.dart.
...
BUG=
TEST=standalone/StatusExpressionTest
Review URL: http://codereview.chromium.org//8400058
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@887 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 11:47:36 +00:00
205ddb3ad1
Start adding files for Dart version of test script test.py.
...
BUG=
TEST=
Review URL: http://codereview.chromium.org//8394043
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@885 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 11:09:48 +00:00
d864b5e1f6
First round of changes to the file interface.
...
Have both async and sync version for the file operations. The
thinking is that once you have used an async operation you will
not be allowed to use a sync one. Only sync versions currently
implemented.
Instead of having one input and one output stream associated with a
file we create new streams whenever needed. These get their own
underlying file descriptor so they do not interfere. This means
that FileStreams have to be explicitly closed.
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8399033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@819 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-27 13:33:18 +00:00
78f7c8bd45
Fix typo
...
TBR=whesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8399031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@805 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-27 08:31:44 +00:00
9265136864
Add support for test expectations based on the --checked flag.
...
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8341056
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@751 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 14:24:38 +00:00
a16c4ee066
Update test expectations
...
TBR=ager@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8341055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@749 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 13:37:34 +00:00
00a00bcdb4
This contains a new InputStream and StringInputStream interfaces.
...
The readUntil is only supported through readLine on the StringInputStream.
The StringInputStream implementation in string_stream.dart could live outside the VM as it is plain Dart code.
BUG=
TEST=
Review URL: http://codereview.chromium.org//8318009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@747 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 13:17:28 +00:00
8f6c84704d
Disable test that has failing type checks on purpose.
...
Should be skipped only for checked tests. I'll look into that tomorrow.
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8383039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@694 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-25 13:23:30 +00:00
86284155b9
Improve error handling in the process library.
...
Verify that the arguments have the types expected by the
implementation. Require a List instance containing builtin
Strings as the arguments. Require a builtin String path.
R=sgjesse@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8383037
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@690 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-25 12:16:04 +00:00
17f9c619db
Rename getters in process object
...
stdinStream -> stdin
stdoutStream -> stdout
stderrStream -> stderr
R=rchandia@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8359033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@602 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-21 15:22:35 +00:00
fa8bd0833d
Fixed TimerCancel1Test.
...
Review URL: http://codereview.chromium.org//8366038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@599 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-21 13:15:49 +00:00
e7b8e8d0ee
Add more tests for classes which may not be subclassed.
...
Review URL: http://codereview.chromium.org//8355001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@577 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-20 06:55:45 +00:00
8c680b64ba
Disabled failing tests.
...
Review URL: http://codereview.chromium.org//8357002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@552 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-19 14:26:14 +00:00
9da32a390f
Moved Timer tests to the right directory.
...
Review URL: http://codereview.chromium.org//8353004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@549 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-19 12:04:27 +00:00
dc895f3138
Rename class AssertError to AssertionError in the VM (fix issue 119).
...
Move VM specific tests to the correct tests directory.
Enable asserts in the VM when type checks are enabled.
Review URL: http://codereview.chromium.org//8294005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@460 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 22:02:50 +00:00
953d2599c1
Add exists, create and delete to directory implementation on Linux and Mac.
...
All of the directory implementations on Linux and Mac are identical
and uncontroversial. Join the implementations in directory_posix for
now. I will split it into the two files again if it becomes necessary.
BUG=
TEST=
Review URL: http://codereview.chromium.org//8277033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@432 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 12:42:44 +00:00
fc1b7603b3
Add short read/write testing of Socket and Process tests
...
The changes to standalone tests from http://codereview.chromium.org/8226016/ somehow got lost when the tests where moved from runtime/tests/dart to tests/standalone.
Also fix and issue where just specifying "VMOptions=" did not run the test without any arguments.
R=ngeoffray@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8273035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@426 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 09:31:12 +00:00
bf1c910eed
Re-enable test EchoServerStreamReadUntilTest on Windows
...
R=ager@google.com
BUG=b/5414270
TEST=
Review URL: http://codereview.chromium.org//8275027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@423 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 08:33:02 +00:00
sgjesse@google.com