Commit Graph

2501 Commits

Author SHA1 Message Date
vsm@google.com 45b5d7b750 Mark broken test
TBR=cshapiro

Review URL: https://chromiumcodereview.appspot.com//9379042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4172 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-13 02:29:13 +00:00
srdjan@google.com c95d58ef9f Intrinsify InternalByteArray's get_length and [].
Disallow intrinsification of non-corelib methods. Recognize private classes for intrinsification.
Review URL: https://chromiumcodereview.appspot.com//9383004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4171 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-12 07:10:09 +00:00
ager@google.com 25a81afab6 Fix type warning.
R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9384001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4128 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-10 11:10:15 +00:00
ager@google.com ac5c191683 Another attempt at fixing the Socket tests.
The tests did not wait for the server isolate to finish before
exiting the main isolate.

The tests did not correctly count the number of bytes received on
the server-side. We have to count bytes per connection.

There were issues with close handlers being confused for timeouts.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9382001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4127 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-10 11:00:15 +00:00
ager@google.com aaed22d42e Revert "Fix potential flakiness of SocketStreamCloseTest."
R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9368058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4120 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-10 07:06:18 +00:00
ager@google.com 4b2bfef991 Fix potential flakiness of SocketStreamCloseTest.
Not reading out all 5 bytes before moving on.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9361034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4119 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-10 06:57:37 +00:00
ager@google.com 6ea7cb4708 Fix SocketStreamCloseTest flakiness because of not waiting for all close events.
There might be issues with not reading all in the data handler as
well. I will deal with that separately.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9358026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4036 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-08 14:31:18 +00:00
whesse@google.com 9f27aa3a69 Remove unused support files for old version of tools/test.py.
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9360017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4033 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-08 14:11:42 +00:00
ricow@google.com 7c524e3e3c Change file opening operation to set position at the end of the file when FileMode.APPEND is used.
Additionally, allow File.openOutputStream to take a FileMode enum (only FileMode.WRITE and FileMode.APPEND is allowed).
Review URL: https://chromiumcodereview.appspot.com//9346015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3984 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-07 09:34:12 +00:00
ager@google.com 5b598c889f Fix flakiness of SocketCloseTest by waiting for all close events.
The assumption that all close events are delivered before the server
shutdown message is received is false.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9325062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3933 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-06 11:27:03 +00:00
ager@google.com 4078d7e4fd Fix at least one source of flakiness in SocketCloseTest.
We did not make sure to read all the bytes written to
a socket before moving on.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9307082

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3899 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-03 13:40:11 +00:00
ager@google.com 641cf84f6a Implement recursive directory deletion.
Additionally, make sure that the handler can be registered after
the operation in file and directory implementation:

  dir.delete();
  dir.deleteHandler = () => print('hest');

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9316066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3892 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-03 12:37:30 +00:00
whesse@google.com 0f1aa1b50d Fix error in standalone/StatusFileParserTest.
BUG=
TEST=standalone/StatusFileParserTest

Review URL: https://chromiumcodereview.appspot.com//9323029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3887 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-03 10:18:41 +00:00
ajohnsen@google.com 143de9eb80 Use ByteArray's native for Socket and File.
Review URL: https://chromiumcodereview.appspot.com//9235067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3812 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-01 21:48:27 +00:00
ager@google.com 3c8c228fd1 Fix status file parser test.
We should look into why this failure did not turn the buildbot
red. I'll file a bug report on that.

R=whesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9309031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3785 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-01 12:54:46 +00:00
srdjan@google.com df94bc5fa5 Use inlined double temporary object for unary operation, add tests. Fix disassembler crash.
Review URL: https://chromiumcodereview.appspot.com//9297026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3666 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-27 21:04:12 +00:00
ager@google.com 4605b5ea33 Minor changes to the dart:io library files.
- Split some of the streams into an interface and an implementation file.
- Add documentation comments where missing.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9289042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3616 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-26 10:03:19 +00:00
ager@google.com 4efd1f98fa Split dart:builtin into dart:builtin and dart:io.
- dart:builtin is implicitly imported.
- dart:io has to be explicitly imported.

I will update the macos and windows stable test binaries when we
are happy with the solution.

R=iposva@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9254026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3537 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-24 07:36:59 +00:00
whesse@google.com b02ed08af1 Add script attribute to Options class, providing the name of the running script.
BUG=dart:409
TEST=standalone/OptionsTest

Review URL: https://chromiumcodereview.appspot.com//9159013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3485 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-23 12:15:26 +00:00
sgjesse@google.com c1d041500f Use hash map for event handler file descriptor map
Instead of using an array indexed using the file descriptor for
looking up data associated with a socket (SocketData objects) this is
now stored in a hash map using the file descriptor as key.

Added hash map implementation like the one used in the V8 project.

R=ager@google.com, whesse@google.com

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9186035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3483 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-23 09:10:51 +00:00
whesse@google.com 2367d814d1 Fix error in tests/standalone/FileTest.dart, where files were not closed.
Review URL: https://chromiumcodereview.appspot.com//9249018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3402 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-18 17:35:31 +00:00
whesse@google.com 28429d406c Fix standalone tests that didn't delete the temporary directories they created.
BUG=
TEST=tools/test.py standalone; ls /tmp/temp_dir*

Review URL: https://chromiumcodereview.appspot.com//9251012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3396 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-18 15:37:13 +00:00
regis@google.com 2d1f63af47 Port a couple more stubs to x64.
Fix integer implementation issues.
Enable all tests on x64.
Review URL: http://codereview.chromium.org//9114054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3307 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-13 20:07:54 +00:00
ajohnsen@google.com 1af7a35c4b Removed a debug print line.
Review URL: http://codereview.chromium.org//9113007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2988 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-05 10:13:39 +00:00
ajohnsen@google.com c2b45bf04e Add optional workingDirectory argument to Process.start.
Review URL: http://codereview.chromium.org//9108008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2987 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-05 09:54:54 +00:00
ager@google.com d5696e2026 Change the behavior of open on files to not truncate by default
when opening for writing.

We have an explicit truncate method in the API and truncating
the file is a bit hostile to users who want to modify or append
to an existing file. :-)

R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//9034005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2941 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-04 12:23:01 +00:00
iposva@google.com e52e33466e - Add regression test for issue 1023.
Review URL: http://codereview.chromium.org//9091001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2932 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-04 01:28:25 +00:00
sgjesse@google.com 18aba0fd29 Handle reading byte past the end of file
When reading a byte past the end of file an error is now triggered.

R=ager@google.com

BUG=dart:1017

TEST=

Review URL: http://codereview.chromium.org//9072003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2906 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-03 11:16:56 +00:00
sgjesse@google.com 959977140b Refactor the file input stream
Inherit FileInputStream from _BaseDataInputStream.

R=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//9067004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2904 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-03 10:17:17 +00:00
sgjesse@google.com b6c38c1763 Update status file
Skip test SocketStreamCloseTest on dartium

TBR=antonm@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8952026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2896 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-02 13:16:36 +00:00
sgjesse@google.com 8055ffeb77 Add close to input stream and cleanup socket and streams
* All input streams now have a close method for just cutting
  the stream
* Removed interfaces FileInputStream and FileOutputStream
* Added exceptions to socket to avoid mixing stream and non-stream
  use of the same socket
* Added special handling of the socket connect handler callback

R=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//9029001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2893 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-02 13:00:59 +00:00
ager@google.com 27508f3eb1 Change the process API to be completely asynchronous.
Some of the implementation is still not asynchronous but the API is
now prepared for it.

This is a breaking change for the dart test scripts. Once the
change has its final form I will add new stable builds of the
VM to the changelist for running tests.

R=sgjesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//9024008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2753 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-22 13:43:43 +00:00
sgjesse@google.com 7014704266 Fix list output stream
The write and writeFrom where missing their boolean return value.

R=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//9021008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2687 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-21 08:33:02 +00:00
sgjesse@google.com bf0798ec22 Update tests/standalone status file
Skip ListOutputStreamTest on chromium

TBR=antonm@google.com

Fix broken build

TBR=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//9007014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2644 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 16:44:27 +00:00
sgjesse@google.com c7b4a1fc58 Fix broken build
TBR=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//9005010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2643 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 16:35:50 +00:00
sgjesse@google.com 3ebb36c77f Implement list based output stream and add pipe to list based input streams
R=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8989019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2641 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 16:03:29 +00:00
antonm@google.com 4a802cfaa8 Supper another test for Dartium.
Review URL: http://codereview.chromium.org//8956026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2627 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 11:30:26 +00:00
sgjesse@google.com bcd4584f59 Add input streams based on supplying data from lists
Two new streams are added ListInputStream and
DynamicListInputStream. ListInputStream takes all the data in the
stream in the constructor whereas DynamicListInputStream can get data
added dynamically using the write method and have end of stream
indicated using the method markEndOfStream.

In a separate change I expect to have the current FileInputStream be
based on the _BaseDataInputStream as it currently used the same logic
with the sync file API.

R=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8953030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2621 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 10:07:02 +00:00
ager@google.com 46ba817562 Add asynchronous versions of the methods on Directory.
For now, use an isolate to make the operations async from the
point of view of the main Dart thread.

Clean up the directory tests a bit by removing code that didn't do anything and by removing file testing that is already covered by the file tests.

R=sgjesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8965036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2617 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 09:28:28 +00:00
ager@google.com 1aaa58f803 Make the repeating argument to timers optional.
R=sgjesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8992007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2577 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-19 12:34:12 +00:00
antonm@google.com 8f259487bd Suppress StreamPipeTest on Dartium.
Review URL: http://codereview.chromium.org//8995005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2575 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-19 12:28:23 +00:00
sgjesse@google.com 0a3bf1c3eb Add pipe to input stream
Using the pipe method the data from an input stream can be piped
directly to an output stream.

R=whesse@google.com, ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8933029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2564 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-19 09:14:19 +00:00
srdjan@google.com bdb48aefb4 Use deopt on some instructions that have not collected type feedback when optimizing compierl kicks in. Optimize SAR.
Review URL: http://codereview.chromium.org//8972002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2487 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-15 22:39:21 +00:00
sgjesse@google.com 9f92d783ef Change temp dir generation on Windows to use UUIDs instead of random numbers
This avoids having to generate random numbers for all platforms as
only Windows was using them. Also when the andom number generator is
deterministic the Windows implementation using random numbers could
end up running out of temporary files.

R=whesse@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8879058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2417 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-14 07:25:09 +00:00
sgjesse@google.com eed3c9bc2c Use Expect.throws for directory test
R=whesse@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8937004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2387 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-13 14:51:21 +00:00
sgjesse@google.com 55bfcb9f92 Fix broken test
The Expect.throws did not work as expected.

TBR=whesse@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8879056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2386 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-13 14:37:53 +00:00
sgjesse@google.com f2bda92a66 Add support for getting OS error information for creating temporary directories
R=whesse@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8934004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2385 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-13 14:22:50 +00:00
sgjesse@google.com 8f1b82458f Improve the event handling for string input stream
1. The string input stream now calls the data or line handler if there
   is still data available after returning from the data or line
   handler. These callbacks are scheduled on the event loop.

2. The reading of data is now throtteld so that calls to read or
   readLine will not eagerly try to read from the wrapped input
   stream. After each call to read the data handler is installed if
   no more buffered data is available. Also when the data handler
   is called the data handler on the wrapped input stream is
   un-installed if no more data is required for the current data or
   line handler.

One side effect of this change is that just reading from an input
stream obtained from a file is no longer possible. One will have to
set up a data handler callback of some kind before any calls to read
will return data. We can of cause change this to allow synchronous
usage of an input stream obtained from a file (maybe with an optional
argument to openInputStream).

Fixed a related throtteling issue with the chunked input stream.

R=ager@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8885032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2310 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-09 14:08:47 +00:00
ager@google.com 64ca753193 Split File into File and RandomAccessFile.
Update all users of the API.

R=sgjesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8883017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2272 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-08 19:37:17 +00:00
ager@google.com efc76278db Support --special-command test option. As a special case support --valgrind option.
R=whesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8835010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2174 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-07 13:23:57 +00:00