Implements SecurityContext.setTrustedCertificates in terms of the new
function. This requires setTrustedCertificates to return a Future,
and removing the `directory` named argument as it is not possible to
implement with BoringSSL without blocking IO.
R=whesse@google.com
Review URL: https://codereview.chromium.org/1665433002 .
JS integer overflow limit when read in microseconds. These tests will
fail because initializing the Stopwatch object now throws the
JavascriptIntegerOveflowError during load.
- Disable these tests.
BUG=
Review URL: https://codereview.chromium.org/1646413005 .
This is the first step toward removing blocking IO calls from
the implementation of the SecurityContext API.
Using a buffer rather than a file name API will probably be needed
for implementing SecurityContext and SecureSocket with platform
specific built-in APIs on iOS/Mac/Windows rather than BoringSSL.
related #8227R=whesse@google.com
Review URL: https://codereview.chromium.org/1616073004 .
Resolve issue with server applying context takeover when not enabled.
After resolving negotiation and optimizing client/server takeover usage
an bug became apparent where no context takeover was being applied but
not advertised by the server.
This patch resolves that issue and adds tests to validate in the future.
Ensure encoders/decoders are properly 'discarded' when client_no_context_takeover
and server_no_context_takeover flags are detected.
Resolve issues with client not sending appropriate header request values based
on the configured passed by CompressionOptions.
Add tests for client header values
BUG=25317
Patch by Matthew Butler <butler.matthew@gmail.com>
R=sgjesse@google.com
Review URL: https://codereview.chromium.org/1584653008 .
Some cases, an HttpHeader Value may contain all parameters and
no values. This changes ensures that such a header is parsed, that
it is handled correctly.
This was noticed when parsing the following header for websockets:
Sec-WebSocket-Extensions: permessage-deflate; client_no_context_takeover; client_max_window_bits; server_no_context_takeover
It was parsing with the value permessage-deflate (correct) with parameters:
{'client_no_context_takeover;' : 'client_max_window_bits',
'server_no_context_takeover' : null }
With this patch it now properly shows the parameters as:
{'client_no_context_takeover' : null,
'client_max_window_bits' : null,
'server_no_context_takeover' : null }
I've also included a test for this as well.
BUG=
Patch by Matthew Butler <butler.matthew@gmail.com>.
Review URL: https://codereview.chromium.org/1564913002 .
BSD systems don't place bash in /bin and a lot of the dart tools
hardcode a #!/bin/bash shebang that fails the 'all' target build
(not able to execute dart2js since the interpreter is not found).
Solve the issue by using #!/usr/bin/env as the shebang. For scripts
that need to pass arguments to bash modify the script to use the set
command as the first executed line of shell.
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org/1552313002 .
- Make --gen/run-precompiled-snapshot take a directory to use for the snapshot pieces.
- Throw on Platform.executeable to prevent tests from becoming fork-bombs.
- Update status files so 'dart_precompiled' is generally expected to behave the same as 'vm'.
Currently multitests will fail unless run with --jobs=1 because the test harness assigns them the same temporary directory.
Running this also requires a great deal of space. My out directory is 380G.
BUG=http://dartbug.com/24975R=fschneider@google.com, srdjan@google.com
Review URL: https://codereview.chromium.org/1507943002 .
We have restored blocking isolate spawning under a flag.
--------
Revert "Update test status files. Issue #24990."
This reverts commit 05bf1d6bb6.
Revert "Skip isolate spawning tests on Dartium."
This reverts commit c6c6f121ed.
BUG=
Review URL: https://codereview.chromium.org/1472783004 .
This removes most of the compiler-related code from dart_precompiled:
x64 stripped binary size 13M -> 9.1M
ARM stripped binary size 12M -> 8.3M
The precompiled build defines the DART_PRECOMPILED macro. This
stubs out the public interface to the compiler/parser with empty
function bodies.
Use gcc options -ffunction-sections and --gc-sections to make the linker remove
unused functions/symbols.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/1459443002 .
I undid the patch John McCutchan did to disable compression and compiled and verify that Chrome does not experience any issues with websocket compression negotiation and that compression is enabled.
Also tested with observatory on Firefox and Edge (IE) and both work with current configuration.
BUG=#24864
subject: Ensure proper response to chrome client_max_window_bits
R=sgjesse@google.com
Review URL: https://codereview.chromium.org/1437623002 .
John McCutchan