Previously, Socket::ListInterfaces failed to set the os_error out
parameter causing a crash in the caller. This change sets an error here.
I've also added NetworkInterface.listSupported, which returns false on
Android, and true everywhere else. ifaddrs.h continues not to exist in
the NDK, so in order to support NetworkInterface.list, we'd have to
reimplement it, or find a suitable reimplementation somewhere.
related #26329R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/1916223003 .
There were differences between linux gcc, android gcc,
MacOS clang, and 32 vs. 64-bit w.r.t the __builtin
functions for detecting arithmetic overflow. I couldn't get
them all working at the same time. Instead, I removed them,
and changed to always use the inline assembly. This works
in all the configurations above.
This change also adds a simdbc64 target for building simdbc
for 64-bit, and sets up the android targets. simdbc targets
arm, and simdbc64 targets arm64. You can build them with:
$ ./tools/build.py -m release -a simdbc{64} --os=android runtime
R=iposva@google.com
Review URL: https://codereview.chromium.org/1904153003 .
The resolved executable path is returned to the static in Platform as
a scope allocated string. This change strdups it when it is cached in
a static for return on subsequent calls. Previously, the memory would
be deallocated on exit from the scope.
fixes#26031R=asiva@google.com
Review URL: https://codereview.chromium.org/1813943004 .
The test standalone/full_coverage_test.dart was marked in
standalone.status as a possible timeout, because I received buildbot
failure email that it had timed out.
The CL https://codereview.chromium.org/1779173003 that I had landed
only added 3 new test files and changed the status files for them, so
it is my interpretation that the timeouts are unrelated to my changes.
Review URL: https://codereview.chromium.org/1784383002 .
which have multiple VMOption specifications in them run in parallel with the
same snapshot filename and they clobber each other resulting in random crashes
- Delete the temporary snapshot generation directory after the test run
- Modify map_literal_oom_test.dart to run with 10mb heap limit instead of 7MB
as the VM service isolate in the dart_no_snapshot run gets an OOM.
R=johnmccutchan@google.com, rmacnak@google.com
Review URL: https://codereview.chromium.org/1731023003 .
Any PKCS12 container, not just those containing a private key, can be
protected by a password. This change adds an optional named `password`
parameter to other SecurityContext calls, and plumbs it through to
the calls reading PKCS12 data.
R=whesse@google.com
Review URL: https://codereview.chromium.org/1699163002 .
Runtime system does not expect to see TypeRef as a destination type for a
type check: type references should only appear in the type arguments of
recursive types.
Reorganize canonicalization code to make it more readable and assertions to
catch this issue earlier.
BUG=http://dartbug.com/25782R=fschneider@google.com
Review URL: https://codereview.chromium.org/1701963002 .
While reading PEM data, if we encounter PEM_R_NO_START_LINE, and some
data has been read successfully, we assume that we have reached the
end of the data.
If we encounter PEM_R_NO_START_LINE, and no data has been read
successfully, we assume that the data is not PEM, and we try instead
to read it as PKCS12.
Otherwise, we assume it is malformed PEM, and propagate an error.
R=whesse@google.com
Review URL: https://codereview.chromium.org/1689873003 .
Looking forward to using platform specific APIs, this container type is
more common on MacOS and Windows, and is the only container type
supported by the native iOS API.
R=whesse@google.com
Review URL: https://codereview.chromium.org/1687533002 .
Zachary Anderson