Fixed some errors in other_declarations_location_test, removed checks
for TypeError when passing invalid arguments to a method in
private_symbol_test.
Bug:
Change-Id: I82030f1189a7a370d15bef4fd284d92b0b2de5bb
Reviewed-on: https://dart-review.googlesource.com/3791
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Also share (almost identicial) code between
error_at_exit_spawn_test.dart
error_at_exit_spawnuri_test.dart
in
error_at_exit_spawning_shared.dart
Converted 3 tests away from package:unittest to use package:async_helper/package:expect.
Change-Id: I1b9bf7c895eb21f3c5be9246e69b784296610ce3
Reviewed-on: https://dart-review.googlesource.com/5261
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
This CL silences several tests for '$compiler = dartkp' configuration
in order to make vm-kernel-precomp-* buildbots greener.
These tests are already silenced for '$compiler = precompiler' or
'$compiler = dartk' configurations.
Change-Id: Ia3208853655868ae4cf39775d40db15218c1a1df
Reviewed-on: https://dart-review.googlesource.com/5286
Reviewed-by: Alexander Aprelev <aam@google.com>
Mirrors are not supported in precompiler/AOT, so all lib_2/mirrors/*
tests should be skipped for '$compiler = dartkp' configuration, like
they are skipped for '$compiler = precompiler' configuration in
lib_2_precompiled.status.
Change-Id: I65322c700375168b105d5e659de284216bc49f11
Reviewed-on: https://dart-review.googlesource.com/5281
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
lazy_static_test needed a field changed from var -> dynamic. Otherwise,
simple block.
Bug:
Change-Id: I5d685b5802da906d22f524466eb6794b75c0da62
Reviewed-on: https://dart-review.googlesource.com/3784
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Updated invoke_call_through* tests to make them strong mode clean, which
mostly involved changing var -> dynamic in some places.
Bug:
Change-Id: I3ac946bdfadd09d6459c7f104068be4cb0c49c1d
Reviewed-on: https://dart-review.googlesource.com/3781
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This is a reland of 77a7ca98a2
Original change's description:
> Migrate test batch 226 to Dart 2.0
>
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
>
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Change-Id: I083c07c08333909aaf5bce763601445ff9f0413f
Reviewed-on: https://dart-review.googlesource.com/3920
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
This reverts commit 77a7ca98a2.
Reason for revert: Migrated a test file that's still being used by the unmigrated tests.
Original change's description:
> Migrate test batch 226 to Dart 2.0
>
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
>
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
TBR=jakobr@google.com,lrn@google.com
Change-Id: If4d0b44f81cfadf290bf72b23765fa85a6580937
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/3900
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
Specifically skipped formatting these files, since there are tests that depend
on non-standard source formatting.
Bug:
Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
Reviewed-on: https://dart-review.googlesource.com/3440
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Fairly simple block, with only minor changes made to lib_2/mirrors tests
needed for strong mode compliance.
BUG=
Review-Url: https://codereview.chromium.org/2997283003 .
This block felt trickier than others, mostly due to random errors that I
wasn't able to find a cause for. Tests that I'm uncertain about are:
-first_regression_test
-future_timeout_test
-future_or_bad_type_test/implements
These all have status entries to prevent failures, but I think these
tests need another set of eyes.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2999943002 .
Jakob Roland Andersen