dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

230 Commits

Author SHA1 Message Date
Régis Crelier a38ac7cf12 Resubmit "Set --strong in runtime arguments also when specified in the precompiled configuration" 
Update dartkp status files, since --strong is now properly passed to the runtime.

Change-Id: I36dcc04a70f46730b24b5aaa2f118ed9baf42cbd
Reviewed-on: https://dart-review.googlesource.com/26561
Reviewed-by: Régis Crelier <regis@google.com>
 2017-12-06 17:25:23 +00:00
Vijay Menon 416b55437a Limit renaming on external members 
Fixes #31489

Change-Id: Iece82eaf0bcd83dfc6f2335214b084b0d9e06de0
Reviewed-on: https://dart-review.googlesource.com/25180
Reviewed-by: Jacob Richman <jacobr@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-12-05 16:17:12 +00:00
Paul Berry e8091b27b1 Implement "unknown getter/setter/method" compile time errors in the front end. 
Fixes #21938 (Front end does not warn on function calls on Object).

A small number of tests begin failing with this change--these tests
have been marked with issue #31533 for later triage.

Change-Id: I3a956410a6780772fe90098d8604fb10718504df
Reviewed-on: https://dart-review.googlesource.com/26045
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-12-05 00:14:54 +00:00
Lasse Reichstein Holst Nielsen 757d806b36 Add type parameter to Isolate.spawn. 
This is a strong mode migration that was missed in the earlier rounds.
It allows use of functions that have a more restricted argument type than Object in strong mode
while still ensuring that the argument has a correct type.

Change-Id: Ib00e3f4b4a679c003a992d674c36ef672729b22e
Reviewed-on: https://dart-review.googlesource.com/24540
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-12-04 07:11:44 +00:00
Régis Crelier 08b2294713 [kernel] In strong mode, change covariant parameter types to Object in the 
implicit closure of a method compiled by kernel (fixes #31305).

Change-Id: Iabeee2e382bf07ff78645054e453e0bd1afd02ab
Reviewed-on: https://dart-review.googlesource.com/24362
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2017-12-01 18:00:16 +00:00
Samir Jindel 50887f3ffa [kernel] Generic tearoffs in VM's Kernel FE. 
Bug: #31482
Change-Id: Ice2f19983ac42aba22f6b4cdebf34dbae3cdf1ca
Reviewed-on: https://dart-review.googlesource.com/24960
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-11-30 14:56:29 +00:00
Morten Krogh-Jespersen 39907272f6 Remove comments from status files. 
This will allow for having automatic tools to alphabetize sections and entries.

Bug:
Change-Id: Ia7b7a100ca33197c4f3b1c50c11f24873dfbc09b
Reviewed-on: https://dart-review.googlesource.com/23675
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 07:56:20 +00:00
Paul Berry 9693e47d89 Insert implicit downcasts for the expressions in a return or yield statement. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: Id570bf354583a3780087ffc820eefc3619573af4
Reviewed-on: https://dart-review.googlesource.com/22842
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 15:33:07 +00:00
Paul Berry 2d00ba15b3 Insert implicit downcast checks for the expressions in a list literal. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I1a4a2eed0f7b8ebb5cab0a993d7cf26e925b9425
Reviewed-on: https://dart-review.googlesource.com/22802
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 00:03:56 +00:00
Paul Berry 8cdd9d323c Insert implicit downcast checks for invocation arguments. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I1fa7490f6143bd6ceca80f831e0196b16c497966
Reviewed-on: https://dart-review.googlesource.com/20907
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 00:17:37 +00:00
Paul Berry f043446962 Insert implicit downcast checks for the RHS of variable declarations. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I5be5fb6f47430d390d53d9f195b6a75ca566f8b9
Reviewed-on: https://dart-review.googlesource.com/21701
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-18 15:35:45 +00:00
Sigmund Cherem 134dd443e5 Renormalize corelib_2 dartk/dartkp sections. 
Normalize the dartk sections in corelib_2.status so that our tools can process
them. Also add some documentation for others.

TBR=paulberry@google.com

Change-Id: I6f67dd0b505a22e4438a30bc7407e4d19ac75912
Reviewed-on: https://dart-review.googlesource.com/21791
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-11-18 04:17:25 +00:00
Régis Crelier f91f67a5be [VM] Emit type checks for incoming function arguments in strong mode. 
Change-Id: Icd64913f0fc6ba54a0b8517bf05ae4babfae3bdc
Reviewed-on: https://dart-review.googlesource.com/19287
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-11-18 00:31:35 +00:00
Alexander Markov a211134136 [Tests] Update _2 tests for Dart 2.0 fixed-size integers 
Also, --limit-ints-to-64-bits is enabled when running tests in _2 test
suites.

This is the re-landing of 92ebd8aefa with
fixes:

* Revert changes in pkg/dev_compiler/test/browser/language_tests.js
  and tests/language/language_dart2js.status as they describe
  'language' test suite, not 'language_2'

* Correct tests/standalone_2/io/fuzz_support.dart as file_fuzz test was
  timing out on Windows and failing on android/arm.

Closes https://github.com/dart-lang/sdk/issues/31396

Change-Id: If9ca77fca300ddc605f17a7be39d1707e9724e25
Reviewed-on: https://dart-review.googlesource.com/21700
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2017-11-17 20:28:06 +00:00
Sigmund Cherem af814e27db Normalize lib_2 status files. 
All entries affecting dartk* are in lib_2_kernel.status

Change-Id: I10fda8747a514aabffcf6ecffd62db3b32df59a8
Reviewed-on: https://dart-review.googlesource.com/21561
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-17 01:14:38 +00:00
Alexander Markov 22218e9b9e Revert "[Tests] Update _2 tests for Dart 2.0 fixed-size integers" 
This reverts commit 92ebd8aefa.

Reason: various failures on buildbots.
Change-Id: I03e877e240fdb010d1288baebc124a3e364d1025
Reviewed-on: https://dart-review.googlesource.com/21565
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2017-11-17 00:52:17 +00:00
Alexander Markov 92ebd8aefa [Tests] Update _2 tests for Dart 2.0 fixed-size integers 
Also, --limit-ints-to-64-bits is enabled when running tests in _2 test
suites.

Change-Id: I0b75e5e6e7af78adb29401d77ff55e735781ab73
Reviewed-on: https://dart-review.googlesource.com/20960
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-16 22:40:11 +00:00
Alexander Markov 0a4b151dc4 [Test tool] Pass --strong to dart_bootstrap, disable experimental opts 
In '-c dartkp --strong' mode test tool should pass --strong option to
dart_bootstrap. Otherwise it uses non-strong vm_platform.dill instead
of vm_platform_strong.dill.

Also, experimental strong-mode based optimizations are disabled for now.

Closes https://github.com/dart-lang/sdk/issues/31348
Closes https://github.com/dart-lang/sdk/issues/31335

Change-Id: I2188b9165ae4daa0510e4e566393810b8165291e
Reviewed-on: https://dart-review.googlesource.com/20304
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2017-11-11 01:46:01 +00:00
Vyacheslav Egorov 2b88fa0132 [gardening] Update dartkp-debug status files. 
R=kustermann@google.com

Bug:
Change-Id: Ifc35f8a9b2ccf2fa095a4da510111b04c1ea883e
Reviewed-on: https://dart-review.googlesource.com/20061
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-10 13:35:13 +00:00
Vyacheslav Egorov fd78da5059 [gardening] Update dartkp status files. 
Bug:
Change-Id: I51746bfa10bc10acc90c176ef98cf6da081a42d9
Reviewed-on: https://dart-review.googlesource.com/19568
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-09 16:26:01 +00:00
Jens Johansen 66bf1a5fbd [kernel, VM] ReportError on unsupported tag instead of crashing 
Closes #31296.

Bug:
Change-Id: I1bcdd60d25fde7d99e71ce0e42efcd78916a3409
Reviewed-on: https://dart-review.googlesource.com/19186
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-09 13:25:07 +00:00
Lasse R.H. Nielsen adcb6a7399 Make main invocation not fail strong-mode type checking. 
Bug: http://dartbug.com/31270
Change-Id: Id6ad2a429d5dc44b437a0fdd8fb4889d3dccf194
Reviewed-on: https://dart-review.googlesource.com/18480
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-03 16:06:00 +00:00
Sigmund Cherem a8d13565cd Add support for deferred loading in fasta 
Change-Id: I2a5489b618210935b4b21c583aba9738a5e3f645
Reviewed-on: https://dart-review.googlesource.com/13441
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-10-26 23:22:48 +00:00
Sigmund Cherem 5d2613d632 Status updates for vm-kernel in strong mode 
Change-Id: I93a4429822f374741b0211e755ed9d5b1b43fe23
Reviewed-on: https://dart-review.googlesource.com/16623
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-10-25 20:25:49 +00:00
Sigmund Cherem e2e3934b62 Add status entries for dartk and dartkp in strong mode 
This is an initial step and some entries say "Pass", which indicates
that the test was marked earlier in some other (more general) section and that
we should split that section.

Change-Id: I0417d55dcdec352f730c298bb155d112eb341711
Reviewed-on: https://dart-review.googlesource.com/16322
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-10-24 21:49:19 +00:00
Samir Jindel 6b64aa8943 [kernel] Always disable reified generic functions in the Kernel FE. 
Currently, we have some tests that run with reified generic functions ON and
some with it OFF. However, this causes inconsistencies when running the Kernel
FE from snapshot in the VM, since the VM requires that the flag be consistent
with the snapshot. Our solution is to turn the reified generic functions flag
into a per-isolate flag, which is always disabled in the Kernel FE's isolate.

Bug:
Change-Id: Ia91e9f0ff5fc059edf4bdbd79ef14abb288b4a49
Reviewed-on: https://dart-review.googlesource.com/16020
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-24 15:21:28 +00:00
Janice Collins ad3efd8717 Migrate leftovers in lib/async to Dart 2.0. 
Bug:
Change-Id: I57ceb6a807fd63691028f2c5542f4446f748dda2
Reviewed-on: https://dart-review.googlesource.com/14882
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-20 16:41:18 +00:00
Konstantin Shcheglov 3fedd483f3 Parse metadata for import/export directives and resynthesize in Analyzer. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30284
Change-Id: I57af6f4d58b6de39f13b9656af25f0be6949cf79
Reviewed-on: https://dart-review.googlesource.com/14363
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-19 16:35:17 +00:00
Régis Crelier 0d976d1014 Update kernel status file for lib_2 now that --reify-generic-functions is passed. 
Change-Id: I8a5af7e4ebcbdd82506799929a90d4a61d86c8b7
Reviewed-on: https://dart-review.googlesource.com/15003
Reviewed-by: Régis Crelier <regis@google.com>
 2017-10-18 22:35:42 +00:00
Konstantin Shcheglov 1e6c488ef5 Parse annotations for library directives. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30284
Change-Id: I9354e114eb2d603543a964030482af7ac9198760
Reviewed-on: https://dart-review.googlesource.com/12802
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-16 17:35:06 +00:00
Alexander Markov dd2d586a30 [Test status] exclude html/* tests from dartkp configuration 
Change-Id: I3684b3fc87f91465076c6ca70804a47c6053d9a6
Reviewed-on: https://dart-review.googlesource.com/13840
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-10-13 17:53:23 +00:00
Terry Lucas 213830e122 Migrated Block 188 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I3a450b04becaef007cc81fda1dbca1fda58b3d19
Reviewed-on: https://dart-review.googlesource.com/12361
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-11 14:42:22 +00:00
Terry Lucas 8611852b81 Migrated Block 199 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic52e7afb489b15b2f2e45f5ad9191cf5e441c047
Reviewed-on: https://dart-review.googlesource.com/11342
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-10 13:53:24 +00:00
Ben Konyi 24ee7dab3c Migrated test block 35 to Dart 2.0. 
No changes made to tests.

Bug:
Change-Id: I98d755d0c8005fd9cf0770966927b57a5fcc25de
Reviewed-on: https://dart-review.googlesource.com/11620
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-06 23:56:03 +00:00
Ben Konyi e2f92be5ae Migrated test block 34 to Dart 2.0. 
Bug:
Change-Id: Ib2e0effabc354b5864f59b0de6611381d7dfd0df
Reviewed-on: https://dart-review.googlesource.com/11250
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-06 22:52:56 +00:00
Ben Konyi 7ea539a4c5 Migrated test block 190 to Dart 2.0. 
Migrated multiple tests from unittest->test, fixed small strong mode
issue in cross_frame_test.

Bug:
Change-Id: I1c504ab4ac45e487ff3d3d156416e579978adc20
Reviewed-on: https://dart-review.googlesource.com/4820
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-05 22:00:26 +00:00
Ben Konyi d932b15c0d Migrated test block 33 to Dart 2.0. 
Bug:
Change-Id: Ifb1626e45868c1bfc626edd83c7d9db5680764ed
Reviewed-on: https://dart-review.googlesource.com/11246
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-05 21:04:03 +00:00
Ben Konyi 992d060da6 Migrated test block 31 to Dart 2.0. 
Minor changes for strong-mode.

Bug:
Change-Id: Ia9387a4d7976156bb592515bb848f7be45699478
Reviewed-on: https://dart-review.googlesource.com/11021
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-05 19:34:33 +00:00
Jens Johansen 89644d89d2 [kernel] Add check to constant evaluator; pass script on error more often. 
Change-Id: I655121953c7be2e6c3173a3c186339d31a9be7bc
Reviewed-on: https://dart-review.googlesource.com/11500
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-05 13:47:20 +00:00
Jens Johansen 5fff3689d6 [kernel] Report error instead of crashing in constant evaluator. 
Change-Id: I2c116cdc6add54194d0641631b3603313603c89e
Reviewed-on: https://dart-review.googlesource.com/11442
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-05 12:13:03 +00:00
Jakob Roland Andersen f7a794201e Update status files. 
Removed html/ entries for kernel, since there's a html/* at the top.

Sorted newly added entries in lib_2_dartdevc.status, and added issue
number for webgl_extensions_test.

Bug:
Change-Id: I5bee92e992cd420e9d4b2c0629e2b75b6b22715e
Reviewed-on: https://dart-review.googlesource.com/11441
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 10:06:42 +00:00
Jakob Roland Andersen 42e28ca782 Migrated test batch 213 to Dart 2.0. 
Bug:
Change-Id: I31f519c18ab62cc0aef969f60116ed518bcb77e3
Reviewed-on: https://dart-review.googlesource.com/11061
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-05 07:56:30 +00:00
Terry Lucas bbbb548e0a Migrated Block 195 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic5622d23d3159016625cfc17785f140ba9df409e
Reviewed-on: https://dart-review.googlesource.com/8739
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 06:08:10 +00:00
Terry Lucas 7f137ca921 Migrated Block 194 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I4e77f837a26d37e2d8f650c941f72454e6536b8d
Reviewed-on: https://dart-review.googlesource.com/8737
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 04:19:10 +00:00
Ben Konyi b4d5cbda31 Migrated test block 191 to Dart 2.0. 
WIP.

Fixed status file migration issues for html and isolate directories.

Bug:
Change-Id: Id84c7ee89a7eb283d3202f3018d008cede0fda56
Reviewed-on: https://dart-review.googlesource.com/4920
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-03 21:54:44 +00:00
Jakob Roland Andersen 7f34184508 Migrated test batch 210 to Dart 2.0. 
Bug:
Change-Id: I8552149b85676cba497d78a9f6e3861257b746bc
Reviewed-on: https://dart-review.googlesource.com/10361
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-03 14:39:09 +00:00
Jakob Roland Andersen d2cd2a4720 Migrated test batch 209 to Dart 2.0. 
Bug:
Change-Id: If23630da318547e3beaf417a5ad97b30f6ffcbd3
Reviewed-on: https://dart-review.googlesource.com/10340
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-03 13:02:49 +00:00
Jakob Roland Andersen 56c8922c7c Migrated test batch 208 to Dart 2.0. 
Bug:
Change-Id: I97b3ca0d43bf68a60cdc2959844888c82c6af9eb
Reviewed-on: https://dart-review.googlesource.com/10260
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-03 10:23:49 +00:00
Jens Johansen 2e75b6cce9 [kernel] Fix closure in for loop 
In kernel the loop level wasn't set correctly for for loops, resulting
in the loop variable not always being fresh.

Examples:

```
  // Capture the loop variable, ensure we capture the right value.
  for (int i = 0; i < 10; i++) { if (i == 7) f = () => "i = $i"; }

  print(f());
  // There is only one instance of k. The captured variable continues to change.
  int k;
  for (k = 0; k < 10; k++) { if (k == 7) f = () => "k = $k"; }
  print(f());
```

resulted in
i = 10
k = 10

(i.e. it's wrong)

whereas

```
  // Capture the loop variable, ensure we capture the right value.
  for (int i = 0; i < 10; i++) { if (i == 7) { f = () => "i = $i"; } }
  print(f());
  {
    // There is only one instance of k. The captured variable continues to change.
    int k;
    for (k = 0; k < 10; k++) { if (k == 7) { f = () => "k = $k"; } }
    print(f());
  }
```

resultet in

i = 7
k = 10

(i.e. it's correct).

Now both examples produce the correct result.

Change-Id: I1fb4c888c6a0eaa690f62226e093508992b33ed4
Reviewed-on: https://dart-review.googlesource.com/9961
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-03 07:56:13 +00:00
Jakob Roland Andersen c930fc0781 Migrated test batch 206 to Dart 2.0. 
Bug:
Change-Id: I231aa434de41c55a290ab3e399c97b7dbbbb028d
Reviewed-on: https://dart-review.googlesource.com/9940
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-02 13:26:07 +00:00