Commit Graph

480 Commits

Author SHA1 Message Date
zarah@google.com 32814d4233 Substitute types in instances of generic classes.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//39783003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29235 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 07:52:21 +00:00
rmacnak@google.com ccfaa29881 Make type variables belong to the original declaration in VM.
BUG=http://dartbug.com/14240
R=gbracha@google.com, zarah@google.com

Review URL: https://codereview.chromium.org//35543007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29106 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 18:28:46 +00:00
rmacnak@google.com cfa80041e9 VM: Always return immutable collections from the mirrors.
Fix assert in partial demangling. Fix inappropriate compilation when handling parameters.

BUG=http://dartbug.com/14027
R=ahe@google.com, asiva@google.com

Review URL: https://codereview.chromium.org//34533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29030 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 19:53:14 +00:00
rmacnak@google.com a3cd93fa15 Cover an example of equality and hashCode for each type of mirror.
BUG=http://dartbug.com/6680
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//34133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29015 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:16:39 +00:00
zarah@google.com 00585d9dac Fix class_mirror_type_variable_test.
Review URL: https://codereview.chromium.org//34723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28993 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 10:39:37 +00:00
zarah@google.com 6da04e04e2 Support reflection on recursive upper bounds of type variables.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//27064004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28991 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 10:20:16 +00:00
rmacnak@google.com bd284f7262 Generic typedefs and their referents.
BUG=http://dartbug.com/12282
R=regis@google.com

Review URL: https://codereview.chromium.org//27728004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28972 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 00:00:08 +00:00
rmacnak@google.com a5fd049d73 Hide MirroredCompilationErrror behind a flag until post-1.0. Remove VM reference to MirroredUncaughtExceptionError.
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//28053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28946 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:12:49 +00:00
rmacnak@google.com addba00bd7 Fix VM crash when ClosureMirror.findInContext operates on a fake function.
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//29413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28937 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 17:10:21 +00:00
rmacnak@google.com d5931765f3 Add test for type variable ownership.
R=gbracha@google.com, zarah@google.com

Review URL: https://codereview.chromium.org//29823003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28936 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 16:56:13 +00:00
sra@google.com 49a3c1a6ea Revert "Revert "Resolve metadata on library tags""
BUG=

Review URL: https://codereview.chromium.org//30013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28887 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 22:09:58 +00:00
sra@google.com a8f349dbaf Revert "Resolve metadata on library tags"
BUG=

Review URL: https://codereview.chromium.org//30003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28883 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 21:55:32 +00:00
sra@google.com 64f8f67333 Resolve metadata on library tags
Preemptively resolving metadata on library tags ensures they are resolved when queried from back end.

Review URL: https://codereview.chromium.org//29263006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28882 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 21:48:40 +00:00
rmacnak@google.com 0d23dbc1e2 Make TypedefMirror a direct descendant of TypeMirror.
BUG=http://dartbug.com/11616
R=ahe@google.com, asiva@google.com

Review URL: https://codereview.chromium.org//24005002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28862 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 16:59:55 +00:00
johnniwinther@google.com 09116b857b Force resolution on metadata of static members
R=kasperl@google.com

Review URL: https://codereview.chromium.org//26800008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28847 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 09:15:47 +00:00
rmacnak@google.com c64d749f49 Remove conflict between type parameter and method/field from typevariable_mirror_metadata_test. Remove irregularity in metadata lookup naming that dealt with allow their co-existence.
BUG=http://dartbug.com/13327
BUG=http://dartbug.com/14016

Review URL: https://codereview.chromium.org//27525007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28815 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:49:27 +00:00
zarah@google.com 440e6729be Reapply "Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type of Iterable.".""
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//27689002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28797 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 11:16:14 +00:00
rmacnak@google.com 58c1759454 Generic instantiations of mixins and interfaces. Equality of type parameters.
BUG=http://dartbug.com/14113
BUG=http://dartbug.com/14114
R=regis@google.com

Review URL: https://codereview.chromium.org//27610002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28768 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 00:16:34 +00:00
rmacnak@google.com de9bfaa347 Update mirror tests to new mixin application syntax.
R=ahe@google.com

Review URL: https://codereview.chromium.org//27369003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28742 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 18:22:12 +00:00
zarah@google.com 5ad0b1da0a Revert "Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type of Iterable."."
This reverts commit r28726.

Review URL: https://codereview.chromium.org//27529003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28730 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 16:13:14 +00:00
zarah@google.com 9ed673286a Reapply "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type of Iterable.".
This reverts r28717.

R=ahe@google.com

Review URL: https://codereview.chromium.org//26900005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28726 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 15:15:09 +00:00
zarah@google.com ea215826f9 Revert "Add TypeVariable object on runtime to support reflection on type variables." and "Fix type of Iterable.".
This reverts commit r28708 and r28713.

Review URL: https://codereview.chromium.org//26166003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28717 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 09:47:13 +00:00
lrn@google.com 8b1d5720f7 Change "typedef" to "class" in core library and related tests.
R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//27300003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28712 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 09:02:46 +00:00
zarah@google.com a741237b80 Add TypeVariable object on runtime to support reflection on type variables.
R=ahe@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//26472002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28708 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 08:17:16 +00:00
rmacnak@google.com 15bc17777f Add mirror tests for generic interfaces. Add base-language test for malbounded interfaces.
B=http://dartbug.com/14118
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//27378002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28703 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 01:06:56 +00:00
rmacnak@google.com e8d030b338 Do not hide membership of implementation classes in dart:core.
BUG=http://dartbuc.com/12141
R=ahe@google.com, asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//27226003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28695 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:15:10 +00:00
rmacnak@google.com 06e159f087 Add mirror tests for f-bounded mixin applications and generic mixins (not to be confused with mixin applications).
R=ahe@google.com, gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//26768005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28664 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 17:22:48 +00:00
rmacnak@google.com 259c83c8d5 Add test for ClassMirror.mixin. Rename the mixin application test.
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//27275002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28660 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 16:55:46 +00:00
rmacnak@google.com 9662a9ab58 Give dart2js partial coverage from the initializing formals test. (Mostly their types.)
BUG=http://dartbug.com/11281
R=ahe@google.com

Review URL: https://codereview.chromium.org//27225003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28656 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 16:40:31 +00:00
rmacnak@google.com d278f9f3c4 New mirror tests: basic types found in dart:core and member collections are immutable.
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//27069003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28591 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 17:07:32 +00:00
rmacnak@google.com 564fbb68dd Add proper API for creating private symbols wrt a library.
BUG=http://dartbug.com/13355
BUG=http://dartbug.com/12358
R=ahe@google.com, asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//24631003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28551 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 20:56:14 +00:00
rmacnak@google.com 8a0d62f5f9 Substitution for type variables in mirrors on instantiated generics.
BUG=http://dartbug.com/12282
BUG=http://dartbug.com/13808
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//26344006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28495 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 01:51:11 +00:00
rmacnak@google.com 90772b13b8 Mirror tests for type bounds.
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//26772002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28435 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 00:34:17 +00:00
rmacnak@google.com 6ed9f2c17f Implement constructor kinds in the VM mirrors.
BUG=http://dartbug.com/13798
R=asiva@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//26436004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28416 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:40:11 +00:00
rmacnak@google.com 41f0d0e0f1 Correctly report the type of initializing formals declared without an explicit type to be the type of the corresponding field.
BUG=http://dartbug.com/11281
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//26346002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28349 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 01:08:59 +00:00
rmacnak@google.com 27d8969f33 Add test coverage for InstanceMirror.type in the face of a reflectee that overrides runtimeType.
R=gbracha@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//25996006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28311 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 16:38:43 +00:00
rmacnak@google.com 4691c007bf More mirror tests: initializing formals and substituted types in instantiated generics.
BUG=
R=gbracha@google.com

Review URL: https://codereview.chromium.org//25945002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:41:51 +00:00
rmacnak@google.com b444bb86a9 Add missing test coverage for constructor kinds, generic function typedefs, generic mixin applications, delegate, type arguments are type variables.
BUG=
R=gbracha@google.com

Review URL: https://codereview.chromium.org//25609003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28270 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:32:21 +00:00
rmacnak@google.com 3cbf9141ae Make reflectClass in dart2js behave appropriately when passed bad arguments.
BUG=http://dartbug.com/13145
R=zarah@google.com

Review URL: https://codereview.chromium.org//24984003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28269 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:25:08 +00:00
rmacnak@google.com cd5ca9a0ec Rework redirection_type_shuffling_test to not require status override for analyzer.
R=brianwilkerson@google.com, regis@google.com

Review URL: https://codereview.chromium.org//25600002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28116 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:48:46 +00:00
rmacnak@google.com ab2d2fc25b Make ClassMirror.newInstance deal with reordered etc type arguments for redirecting factories.
BUG=http://dartbug.com/11781
BUG=http://dartbug.com/13365
R=regis@google.com

Review URL: https://codereview.chromium.org//25097005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28106 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 18:23:24 +00:00
mlippautz@google.com 19763aae4d Implementation for ClosureMirror.findInContext.
Fixes issue 5897.

BUG=https://code.google.com/p/dart/issues/detail?id=5897
R=asiva@google.com, gbracha@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//23633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27982 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-27 01:28:12 +00:00
regis@google.com 42972d1e37 Fix test failure expectations and update status files.
R=hausner@google.com

Review URL: https://codereview.chromium.org//24789003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27976 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 22:19:02 +00:00
ahe@google.com 94b894acb1 Implement InstanceMirror.invoke of methods with optional arguments.
BUG=http://dartbug.com/6490
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//24745003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27947 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 12:45:17 +00:00
ahe@google.com c24b1b7e78 Implement named arguments in InstanceMirror.invoke.
BUG=http://dartbug.com/12863
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//24493006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27936 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 09:08:03 +00:00
rmacnak@google.com 753af9b01b Implement closurization of regular methods in ObjectMirror.getField in the VM.
BUG=http://dartbug.com/13001
BUG=http://dartbug.com/13002
R=asiva@google.com

Review URL: https://codereview.chromium.org//23441073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27916 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 21:42:13 +00:00
rmacnak@google.com 306d474235 Use symbol literals in the mirror tests. (Except for void, the empty string and setters.)
R=mlippautz@google.com

Review URL: https://codereview.chromium.org//24239010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27773 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 16:17:13 +00:00
zarah@google.com 7d93dd8b28 Support typeVariables in ClassMirror.
R=ahe@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//24197003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27753 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 11:17:55 +00:00
zarah@google.com e36ac8f125 Mark generics_test.dart as failing when run with the analyzer.
Review URL: https://codereview.chromium.org//23465031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27665 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 15:52:40 +00:00
zarah@google.com 317bb49282 Support typeArguments, isOriginalDeclaration, and get originalDeclaration in ClassMirror.
R=ahe@google.com

Review URL: https://codereview.chromium.org//23707046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27662 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 14:54:52 +00:00