Commit Graph

480 Commits

Author SHA1 Message Date
rmacnak@google.com 57dd1321d1 Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
Regenerate snapshot test due to change in the size of Namespace. Relate the types source mirror libraries dependencies to the runtime library dependencies.

BUG=http://dartbug.com/10360

Review URL: https://codereview.chromium.org//189843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 19:00:20 +00:00
rmacnak@google.com 62ad4b82ce Revert "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
Review URL: https://codereview.chromium.org//189293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33402 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:45:29 +00:00
rmacnak@google.com 2d0e54a94d Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors.
BUG=http://dartbug.com/10360
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//154733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33397 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:02:29 +00:00
rmacnak@google.com 42e8c08b3c Match existing expectation that delegate returns unwrapped values.
TBR

Review URL: https://codereview.chromium.org//181063025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33306 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 21:56:57 +00:00
rmacnak@google.com d515f61a35 Work around bug where closures are missing #call to support delegation of #call to closures.
BUG=http://dartbug.com/16995
R=iposva@google.com

Review URL: https://codereview.chromium.org//183923018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33303 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 21:10:04 +00:00
rmacnak@google.com d3a92a0f3d Hoist hasReflectedType and reflectedType from ClassMirror to TypeMirror.
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//183853022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33291 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 19:01:26 +00:00
rmacnak@google.com c4f989c768 Add TypeVariableMirror.isStatic to the API.
BUG=http://dartbug.com/16819
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//182603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33283 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 18:13:22 +00:00
rmacnak@google.com 7c4a84d130 Remove LibraryMirror.topLevelMembers.
R=gbracha@google.com

Review URL: https://codereview.chromium.org//164823006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33256 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 01:35:07 +00:00
lrn@google.com 7d4d533114 Add validation of private symbols to the dart2js mirrors.
The mirrors.getSymbol function works for non-private symbols, and
validates private symbols (but still fail to create a Symbol object).

R=ahe@google.com

Review URL: https://codereview.chromium.org//177483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33212 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 12:58:54 +00:00
sigurdm@google.com 3af598f554 Make deferred loading and meta-data play better.
BUG= http://dartbug.com/17110
R=floitsch@google.com

Review URL: https://codereview.chromium.org//180843012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33208 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 11:47:16 +00:00
karlklose@google.com 51047b6c1b Implement Mirror.isSubclassOf.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//172353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33151 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 09:38:52 +00:00
rmacnak@google.com b49aa48f07 Fix VM crash when parsing what looks like a closure call during metadata evaluation.
BUG=http://dartbug.com/17141
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//180313003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33141 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-27 23:24:05 +00:00
floitsch@google.com 5316f7bdfe Assign invalid name to globalized closures.
BUG= http://dartbug.com/16244
R=karlklose@google.com

Review URL: https://codereview.chromium.org//179803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33061 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-26 13:46:50 +00:00
karlklose@google.com 32ee534a3f Emit named parameter information in declaration order.
R=floitsch@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32880

Review URL: https://codereview.chromium.org//163773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33017 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 13:17:54 +00:00
karlklose@google.com 19a522a25b Revert "Emit named parameter information in declaration order."
This reverts commit 32880.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//179583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33008 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 09:35:30 +00:00
lrn@google.com 8ae4728a4f Update documentation on Symbol. Make validation match.
Changed documentation of the Symbol constructor to correctly state
which inputs are accepted.
Changed validation to match.
Disallow keywords as identifiers.
No longer accepts "x.y=" symbols which are not the name of anything
in the source.

BUG= http://dartbug.com/13716
R=ahe@google.com

Review URL: https://codereview.chromium.org//140643006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32952 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 08:11:16 +00:00
karlklose@google.com c2f4610b3b Emit named parameter information in declaration order.
R=floitsch@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//163773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32880 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 09:31:09 +00:00
floitsch@google.com 22ab27256e Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32650

Reverted: https://code.google.com/p/dart/source/detail?r=32652

Committed: https://code.google.com/p/dart/source/detail?r=32654

Reverted: https://code.google.com/p/dart/source/detail?r=32665

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32692 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 12:08:18 +00:00
floitsch@google.com 4b184d887a Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField."
Revert "Update status file."

This reverts commit r32654 and r32661.

Review URL: https://codereview.chromium.org//163853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32665 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 18:36:46 +00:00
floitsch@google.com 69b2710ae4 Update status file.
Review URL: https://codereview.chromium.org//164143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32661 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 17:41:50 +00:00
floitsch@google.com dfaf149d7e Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32650
Reverted: https://code.google.com/p/dart/source/detail?r=32652

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32654 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 15:10:12 +00:00
floitsch@google.com 9cbc78cd36 Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField."
This reverts commit r32650.

Review URL: https://codereview.chromium.org//163513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32652 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 13:46:37 +00:00
floitsch@google.com 6e0b2d61c4 Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32650 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 12:39:28 +00:00
rmacnak@google.com 0c821b2457 Fix getField/setField optimization for private members.
BUG=http://dartbug.com/16773
R=hausner@google.com

Review URL: https://codereview.chromium.org//160843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32634 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 23:44:34 +00:00
karlklose@google.com 2ea953bd76 Implement reflection on annotations of parameters.
R=floitsch@google.com
BUG= http://dartbug.com/15820

Review URL: https://codereview.chromium.org//160343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32600 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 14:28:33 +00:00
rmacnak@google.com 1c7fecac7e Add TypeMirror.isSubtypeOf, TypeMirror.isAssignableTo, ClassMirror.isSubclassOf to the API, the VM runtime mirrors and the source mirrors.
BUG=http://dartbug.com/12439
BUG=http://dartbug.com/13856
R=gbracha@google.com, johnniwinther@google.com, regis@google.com

Review URL: https://codereview.chromium.org//126823004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32577 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 20:41:32 +00:00
johnniwinther@google.com 093f23bb12 Fix dartium build.
BUG=

Review URL: https://codereview.chromium.org//157453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32417 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 11:11:48 +00:00
johnniwinther@google.com 6fd76b92dc Add mirrors_reader_test which tests that everything reachable from a [MirrorSystem] can be accessed.
BUG=
R=floitsch@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//153553007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32415 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 09:26:15 +00:00
johnniwinther@google.com 3f016c29bc Fix ParameterMirror.hasDefaultValue/defaultValue in source mirrors.
BUG=http://dartbug.com/16535
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32356

Review URL: https://codereview.chromium.org//150693005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32409 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 08:03:38 +00:00
johnniwinther@google.com 9b55806eb4 Test source mirrors with lib/mirrors test.
BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org//108753003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32280 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 13:37:10 +00:00
rmacnak@google.com 509556a094 Fix handling of CRLF line endings in Script::GetSnippet.
BUG=http://dartbug.com/16098
R=hausner@google.com

Review URL: https://codereview.chromium.org//132773006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32254 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 18:11:57 +00:00
rmacnak@google.com 2da8c830a3 Fix non-specific type parameter in member maps.
BUG=http://dartbug.com/14972
R=regis@google.com

Review URL: https://codereview.chromium.org//140313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32225 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 23:52:15 +00:00
floitsch@google.com 61e503c7cb Fix warnings in tests.
Review URL: https://codereview.chromium.org//141563010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32160 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 15:25:49 +00:00
floitsch@google.com 40f277dab6 Fix JS-backend when MirrorsUsed target a static field, but there is no mirrors usage.
r31964 (https://codereview.chromium.org/141753002) ensures that type-declarations are resolved, but that wasn't the case for static fields that weren't referenced except through "MirrorsUsed". Dart2Js didn't resolve or compile the static, but then tried to emit its getters/setters (which ended up calling the "_resolveTypeDeclaration" in members.dart).

With this patch we always enqueue static variables that are referenced by MirrorsUsed. If the user doesn't use mirrors it will increase the code-size (slightly) but that should be a rare case.

R=johnniwinther@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//142193005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32159 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 15:04:25 +00:00
rmacnak@google.com 2808e02ca0 VM: Fix crash when a type error is encountered while evaluating metadata in checked mode.
BUG=http://dartbug.com/16321
R=hausner@google.com

Review URL: https://codereview.chromium.org//148263007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32042 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-27 23:50:45 +00:00
ahe@google.com 46387633af Handle dynamic as type argument.
BUG=http://dartbug.com/15573
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//113193006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31977 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-22 18:02:29 +00:00
rmacnak@google.com 2b77f8b1d4 dart2js: Implement instanceMembers and staticMembers.
BUG=http://dartbug.com/14633

Review URL: https://codereview.chromium.org//137123005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31808 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 22:31:20 +00:00
rmacnak@google.com 39f69b6045 Revert "dart2js: Implement instanceMembers and staticMembers."
Review URL: https://codereview.chromium.org//137533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31763 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 22:40:36 +00:00
rmacnak@google.com 3886174aa1 dart2js: Implement instanceMembers and staticMembers.
BUG=http://dartbug.com/14633
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//94093011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31757 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 21:09:49 +00:00
rmacnak@google.com 615715ccaa Extend the immutable collections test to the new API. Make *Members return immutable collections. Add missing metadata property for SyntheticSetterParameter.
R=asiva@google.com

Review URL: https://codereview.chromium.org//132133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31675 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 20:38:32 +00:00
ahe@google.com 4789392a5b Use growable lists.
BUG=http://dartbug.com/15599
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//113283008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31659 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 14:29:58 +00:00
rmacnak@google.com 7dfcd0f4a1 Add ClassMirror.isAbstract to the API and VM implementation.
BUG=http://dartbug.com/12826
R=gbracha@google.com

Review URL: https://codereview.chromium.org//129883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31643 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 01:27:51 +00:00
rmacnak@google.com d8c4c637bf Revert "Add ClassMirror.isAbstract to the API and VM implementation."
BUG=

Review URL: https://codereview.chromium.org//128673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31633 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 22:51:45 +00:00
rmacnak@google.com a5e3c91936 Add ClassMirror.isAbstract to the API and VM implementation.
BUG=http://dartbug.com/12826
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//128933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31630 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 22:21:43 +00:00
zra@google.com a32a30192b Updates status file for mirror syntax error test.
Review URL: https://codereview.chromium.org//111043005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31462 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-04 01:17:12 +00:00
zra@google.com 9df57536fa Regression test for issue 15744
R=iposva@google.com

Review URL: https://codereview.chromium.org//121553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31460 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 23:59:23 +00:00
zarah@google.com caac86b4cc Revert "Support type argument substitution on unnamed mixin applications."
This reverts commit r31319.

Review URL: https://codereview.chromium.org//100413007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31330 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 11:47:44 +00:00
zarah@google.com 4fb34cb3d4 Support type argument substitution on unnamed mixin applications.
R=ahe@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//78873007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31319 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 07:32:27 +00:00
zarah@google.com 243e52fa85 Support newInstance() for class mirrors of generic classes.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//96323006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31213 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-18 08:44:08 +00:00
rmacnak@google.com 5e3a80268a Partially implement LibraryMirror.topLevelMembers.
BUG=http://dartbug.com/14632
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//111643012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31202 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-17 19:20:03 +00:00