dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1115 Commits

Author SHA1 Message Date
Alan Knight 8d5015556e Update test status for Firefox 52/Issue 28983 
BUG=

Review URL: https://codereview.chromium.org/2732963006 .
 2017-03-07 16:52:28 -08:00
Asger Feldthaus 3a7529a363 Remove status file sections for the CPS IR. 
BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d6c90a6b3d6d1be5095e12a0a633305e1d5db2a
Review-Url: https://codereview.chromium.org/2720513006 .
 2017-02-28 17:11:19 +01:00
Asger Feldthaus e7b9672b3e Revert "Remove status file sections for the CPS IR." 
This reverts commit 2d6c90a6b3.

BUG=

Review-Url: https://codereview.chromium.org/2720283002 .
 2017-02-28 17:08:04 +01:00
Asger Feldthaus 2d6c90a6b3 Remove status file sections for the CPS IR. 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2720513006 .
 2017-02-28 14:40:06 +01:00
Stephen Adams e4ffa70ba5 Redo "Flush deferred action queue" 
This is https://github.com/dart-lang/sdk/commit/8eedb9c6527f955413e47c9350d3c5114cd89942 plus status file updates

TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2726463002 .
 2017-02-27 21:10:36 -08:00
Alan Knight 81b6e01f70 Mark lib/mirrors/native_class_test slow on chrome linux 
BUG=

Review-Url: https://codereview.chromium.org/2694703005 .
 2017-02-13 13:56:20 -08:00
Zachary Anderson 0111122ca0 [Fuchsia] Update test status files 
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2693643002 .
 2017-02-10 21:34:33 -08:00
Brian Wilkerson 2ee2fe9b5c [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2679553003 .
 2017-02-06 13:26:39 -08:00
Matthias Hausner 90ed8e9d27 Update dart2js host-checked status for circular_factory_redirection_test 
Test circular_factory_redirection_test/02 no longer crashes,
probably a side effect of the new Fasta front-end.

BUG=

Review-Url: https://codereview.chromium.org/2675473002 .
 2017-02-01 14:35:49 -08:00
Jennifer Messerly 0e00b3e5c8 fix #28008, fix #28009 implement FutureOr<T> 
This implements FutureOr<T> in strong mode, otherwise it's ignored (treated as `dynamic`.

Also fixes strong mode's inference subtype function incorrectly treating `void` as a malformed type. This had the consequence of allowing `void` to be inferred as a type argument.

R=leafp@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2647833002 .
 2017-01-25 15:32:57 -08:00
Regis Crelier 97c42acc30 Support FutureOr<T> in the VM (fixes #28010). 
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2642443002 .
 2017-01-17 10:27:21 -08:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM. 
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
 2017-01-11 16:55:55 -08:00
Florian Loitsch 2547caab25 Reapply "reflectType() dynamic type arguments support (#26012)" 
This was a pull request: 8a8033a417

MirrorsUsed doesn't transitively include reflective information. However, it must still be able to create TypeMirrors for types that are used as return- or parameter types.

Initially, the patch checked that TypeMirrors had the correct number of arguments for generic types. This is now disabled.

A better approach would be to know if a class has full reflective information, or not. But this would require much bigger changes to the system.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2615943004 .
 2017-01-10 15:53:21 +01:00
Jennifer Messerly 816592a941 fixes #28236, generic methods should not cause warnings in Dart 1 
Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2621433003 .
 2017-01-09 12:46:20 -08:00
Asger Feldthaus 6bae3151e2 Revert "reflectType() dynamic type arguments support (#26012)" 
This reverts commit 8a8033a417.

There are a bunch of dart2js mirror tests that fail.

Issue https://github.com/dart-lang/sdk/pull/26012

BUG=

Review-Url: https://codereview.chromium.org/2617163002 .
 2017-01-06 19:12:27 +01:00
Anatoly Pulyaevskiy 8a8033a417 reflectType() dynamic type arguments support (#26012) 
* Basic implementation of reflecting generic types using dynamic list of type arguments

* Removed redundant expectation in test

* Added basic support for dynamic type arguments in reflectType of js_mirrors

* Fixes according to code review comments: major cleanup, added more test cases and updated docs

* Updated JS mirrors reflectType() to match behavior of VM implementation

* Terminate exception messages with a dot; Improved error handling for empty argument list and type checks;

* Use NumTypeParameters when checking provided argument list size

* Check if type arguments are malbounded; added test cases for typedefs and mixins

* Uncommented a test case

* Updated lib.status to mark some tests as failing in dart2js due to limitations in JS mirrors

* Fixed mixin test mock definition; updated configuration for tests requiring checked mode

* Handle nested generic types in type argument parsing (JS)
 2017-01-06 06:05:14 -08:00
Kasper Lund a6135a0c64 The async/timer_regress22626_test test looks flaky by design. 
Expanding the MIPS-specific flaky marker in the status file to cover all architectures after seeing this on debug-x64 too.

See https://github.com/dart-lang/sdk/issues/28254 and the older
https://github.com/dart-lang/sdk/issues/22626.

R=whesse@google.com
BUG=

Review-Url: https://codereview.chromium.org/2615593002 .
 2017-01-04 11:36:27 +01:00
Lasse R.H. Nielsen 44594277e1 Make core libraries use generic method syntax. 
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/68818315b5cc6c63fea0e10e90f515f6083ec095
Committed: https://github.com/dart-lang/sdk/commit/3f74b8d82edca8c342c43306714e68ddf84548e1
Review-Url: https://codereview.chromium.org/2529393002 .
 2017-01-03 12:05:40 +01:00
Regis Crelier 3334c2402a Second try: Fix resolution and canonicalization of typedefs and function types 
in preparation of the new typedef syntax.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2606993002 .
 2016-12-28 14:53:23 -08:00
Florian Loitsch d77af3e562 Update status file. 
Review-Url: https://codereview.chromium.org/2585483004 .
 2016-12-17 00:12:33 +01:00
Florian Loitsch 36c5cea288 Update status file and test. 
Fixes red status for dartium/drt.
Also makes one test more precise (and less likely to fail for the wrong
reasons).

Review-Url: https://codereview.chromium.org/2571583006 .
 2016-12-13 14:02:25 +01:00
Florian Loitsch cc2eba8c2a Implement FutureOr<T> for dart2js. 
In dart2js, FutureOr<T> should simply be treated as `dynamic`.

Fixes #28011
BUG= http://dartbug.com/28011
R=johnniwinther@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2559523006 .
 2016-12-12 15:21:03 +01:00
Florian Loitsch 0c3deba6df Add tests for FutureOr<T>. 
R=lrn@google.com

Review URL: https://codereview.chromium.org/2564563003 .
 2016-12-12 14:54:57 +01:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'. 
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
 2016-12-01 16:47:33 -08:00
Matthias Hausner 6e84b56256 Fix dartium test expectations 
Fallout from initializing formal access change.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/2535083002 .
 2016-11-28 14:04:14 -08:00
Matthias Hausner b48435197a Turn on initializing formal access 
Change default value of --initializing_formal_access to true.

BUG=27892
R=regis@google.com

Review URL: https://codereview.chromium.org/2540453002 .
 2016-11-28 13:15:15 -08:00
John McCutchan 2e197df37d Rehash canonical constants table for each class that can be affected by the 'become' operation 
Fixes #27803

Rehashing all classes canonical constant's takes 3milliseconds for gallery on an Nexus 7.

BUG=
R=asiva@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2497673004 .
 2016-11-17 07:41:24 -08:00
John McCutchan a584ee7141 Fix status file typo 
BUG=

Review URL: https://codereview.chromium.org/2501393002 .
 2016-11-15 10:42:07 -08:00
John McCutchan 50b47360bd Update more status files for hot reload bots 
BUG=

Review URL: https://codereview.chromium.org/2500343003 .
 2016-11-15 07:34:03 -08:00
John McCutchan 1d5df9bc8c Mark some tests as being timing dependent or slow on hot reload bots 
BUG=

Review URL: https://codereview.chromium.org/2502813002 .
 2016-11-14 14:12:52 -08:00
Siva Annamalai 84ad096687 - Turn on canonicalization verification after a reload in debug mode. 
- Rehash the canonical constants table for all new classes, this fixes
  numerous issues found with the canonical verification
  also fixes https://github.com/dart-lang/sdk/issues/26868
- Added issue https://github.com/dart-lang/sdk/issues/27803 and
  https://github.com/dart-lang/sdk/issues/27802 for remaining bugs.

BUG=#26868
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2490233004 .
 2016-11-10 16:13:33 -08:00
Lasse R.H. Nielsen 7bb7f5e6bb Handle the case of Stream.take(0) better. 
The current implementation listens to the stream and waits for it to complete.
The change makes it listen and then immediately cancel, and then return a
subscription that only sends done.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2444363004 .

Committed: https://github.com/dart-lang/sdk/commit/8cead4090cc0b1184a2ad552003ac38cae1e2c77
Committed: https://github.com/dart-lang/sdk/commit/9ebef9af7c7086a4e0f935b3ebd29aa4e990da91
 2016-11-07 11:48:48 +01:00
Florian Schneider 44418359e0 DBC: Handle constants correctly in the optimizing backend 
We don't always allocate a register for constants in optimized code. Instead
they are copied into registes as needed by parallel moves at the use site.

Fixes #27731.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2477653002 .
 2016-11-03 12:24:05 +01:00
Ryan Macnak d8bb15f915 Mark failing DBC tests. 
Issue #27731
Issue #27732
Issue #27733

R=zra@google.com

Review URL: https://codereview.chromium.org/2465253007 .
 2016-11-02 15:28:57 -07:00
Sigmund Cherem 3cdcaeda96 Fix browser test status. 
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .

Committed: https://github.com/dart-lang/sdk/commit/940e498e1788c342f6a1bafbbda6b5983c7e070f
 2016-10-18 12:50:58 -07:00
Sigmund Cherem 2200ee77f7 Revert "Fix browser test status." 
This reverts commit 940e498e17.
 2016-10-18 12:48:15 -07:00
Sigmund Cherem 940e498e17 Fix browser test status. 
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .
 2016-10-18 12:38:45 -07:00
William Hesse 25e3b30560 Update status for failing tests 
BUG=https://github.com/dart-lang/sdk/issues/27557
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2405843002 .
 2016-10-10 16:26:55 +02:00
Florian Schneider e013aaa511 Fix DBC double comparisons for NaN. 
Because NaN is not handled in a separate branch (like on other architetures -
e.g. branch-on-parity-flag on ia32), and every comparison with NaN returns false,
except "!=" we can't flip the branch condition in the same way for double
compares like we do for integer compares.

We could re-order blocks to always make the false-successor the fall-through, but
for now I just disable flipping the branch condition for double compares.

BUG=#27481
R=zra@google.com

Review URL: https://codereview.chromium.org/2400103002 .
 2016-10-07 15:30:21 -07:00
William Hesse b3d354238c Update status for Windows browser tests 
BUG=

Review URL: https://codereview.chromium.org/2402553004 .
 2016-10-07 11:42:37 +02:00
Florian Schneider 8a7dabe522 Temporarily update status for 2 tests on SIMDBC. 
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2388363002 .
 2016-10-04 09:25:44 -07:00
Florian Loitsch 6255638cd0 Return futures on Stream.cancel when possible. 
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2202533003 .

Committed: https://github.com/dart-lang/sdk/commit/395e7aaa696126b82862a9f75e7ebf742c354b56
Reverted: https://github.com/dart-lang/sdk/commit/99e5328eaca7f98641a5c6e523e80b7297792817
Committed: https://github.com/dart-lang/sdk/commit/1905ddafaa242883891e2fb2d706e2dfa059a71b
Reverted: https://github.com/dart-lang/sdk/commit/46a8579c1eb58f6a36a7d094d9b7824c92873de4
 2016-09-05 17:41:22 +02:00
William Hesse b39fa1d58d Update status for chrome 53 on linux 
BUG=

Review URL: https://codereview.chromium.org/2303263002 .
 2016-09-02 14:08:42 +02:00
Sigmund Cherem f6680d13a2 One more round of status file updates to get the bots green. 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2285213003 .
 2016-08-29 08:14:33 -07:00
Sigmund Cherem 2efdf57c92 more status updates: many tests that import mirrors also "pass" because they expect compile-time failures 
BUG=

Review URL: https://codereview.chromium.org/2284743003 .
 2016-08-26 12:56:11 -07:00
Sigmund Cherem fc0bf7a85b First set of test triage for fast-startup 
Review URL: https://codereview.chromium.org/2285823002 .
 2016-08-26 10:04:41 -07:00
Florian Schneider 2d5e87482c Fix a test to not expect NaNs to be bitwise identical. 
Different implementations may use different bit-patterns for NaN. e.g. NAN from math.h can be different from 0.0/0.0 (which is used in double.dart)

We should assert that NaNs are bitwise identical in general.

BUG=#26887
R=lrn@google.com

Review URL: https://codereview.chromium.org/2247553002 .
 2016-08-16 15:57:45 -07:00
Florian Loitsch 46a8579c1e Revert "Return futures on Stream.cancel when possible." 
This reverts commit 1905ddafaa.

Review URL: https://codereview.chromium.org/2223133002 .
 2016-08-08 19:31:04 +02:00
Florian Loitsch 1905ddafaa Return futures on Stream.cancel when possible. 
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/395e7aaa696126b82862a9f75e7ebf742c354b56

Review URL: https://codereview.chromium.org/2202533003 .

Reverted: https://github.com/dart-lang/sdk/commit/99e5328eaca7f98641a5c6e523e80b7297792817
 2016-08-08 17:30:36 +02:00
John McCutchan af46b9dc55 Fix typo in status file 
BUG=

Review URL: https://codereview.chromium.org/2203163003 .
 2016-08-03 08:34:11 -07:00