Commit Graph

1115 Commits

Author SHA1 Message Date
floitsch@google.com 4b184d887a Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField."
Revert "Update status file."

This reverts commit r32654 and r32661.

Review URL: https://codereview.chromium.org//163853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32665 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 18:36:46 +00:00
floitsch@google.com 69b2710ae4 Update status file.
Review URL: https://codereview.chromium.org//164143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32661 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 17:41:50 +00:00
floitsch@google.com dfaf149d7e Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32650
Reverted: https://code.google.com/p/dart/source/detail?r=32652

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32654 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 15:10:12 +00:00
floitsch@google.com 9cbc78cd36 Revert "Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField."
This reverts commit r32650.

Review URL: https://codereview.chromium.org//163513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32652 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 13:46:37 +00:00
floitsch@google.com 6e0b2d61c4 Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32650 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 12:39:28 +00:00
rmacnak@google.com 0c821b2457 Fix getField/setField optimization for private members.
BUG=http://dartbug.com/16773
R=hausner@google.com

Review URL: https://codereview.chromium.org//160843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32634 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 23:44:34 +00:00
kasperl@google.com aca2f3ebe8 The tests affected by issue 16719 pass in CSP mode.
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//160233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32595 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 07:58:07 +00:00
rmacnak@google.com 1c7fecac7e Add TypeMirror.isSubtypeOf, TypeMirror.isAssignableTo, ClassMirror.isSubclassOf to the API, the VM runtime mirrors and the source mirrors.
BUG=http://dartbug.com/12439
BUG=http://dartbug.com/13856
R=gbracha@google.com, johnniwinther@google.com, regis@google.com

Review URL: https://codereview.chromium.org//126823004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32577 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 20:41:32 +00:00
ricow@google.com 199621ba71 Mark lib/async/stream_transform_test and pkg/async/test/stream_zip_test as failing on drt
These started failing after the roll to chrome 33

Review URL: https://codereview.chromium.org//140483007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32556 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 13:43:12 +00:00
kustermann@google.com 1626736d2c Remove flaky markers from status file for tests that are not flaky.
R=ricow@google.com

Review URL: https://codereview.chromium.org//135243005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32553 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 11:55:55 +00:00
floitsch@google.com 9e29696abe Mark mirrors_reader_test as timeout on FF.
Review URL: https://codereview.chromium.org//150283008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32500 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 14:26:25 +00:00
kustermann@google.com 7a7d8ec896 Removed status file entries referring to non-existent tests
R=ricow@google.com

Review URL: https://codereview.chromium.org//147923014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32498 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 13:25:51 +00:00
rmacnak@google.com fa1ebab500 Mark mirrors_reader_test as slow on Dartium debug.
TBR=asiva

Review URL: https://codereview.chromium.org//142693008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32465 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-08 04:45:36 +00:00
asiva@google.com b90149a17a Fix bot breakage :
- remove line in lib.status file for mirrors/mirrors_reader_test to
account for https://codereview.chromium.org//133813008

Review URL: https://codereview.chromium.org//147543005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32464 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-08 02:23:29 +00:00
rmacnak@google.com d354d73609 Avoid printing the full token stream and doing line/column position calculations when extracting the source of a function where we don't have the original source.
Brings mirrors_reader_test from 2 minutes to 11 seconds on the standalone VM.

R=iposva@google.com

Review URL: https://codereview.chromium.org//133813008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32461 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-08 01:18:18 +00:00
rmacnak@google.com 41b3ac826d Adjust assertions in MethodMirror.source not to expect source for implicit constructors or signature functions.
BUG=http://dartbug.com/16588
R=hausner@google.com

Review URL: https://codereview.chromium.org//138383007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32454 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 21:46:01 +00:00
floitsch@google.com 0ccb0d3964 Mark mirrors_reader_test as timeout on IE9-checked.
Review URL: https://codereview.chromium.org//150573018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32436 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 17:12:47 +00:00
johnniwinther@google.com afa4a92f6c Mark mirrors_reader_test as slow.
BUG=

Review URL: https://codereview.chromium.org//150353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32420 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 12:23:24 +00:00
johnniwinther@google.com 345709d61a Update IE9 status.
BUG=

Review URL: https://codereview.chromium.org//130173012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32419 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 12:10:51 +00:00
johnniwinther@google.com 093f23bb12 Fix dartium build.
BUG=

Review URL: https://codereview.chromium.org//157453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32417 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 11:11:48 +00:00
johnniwinther@google.com 09afc118bc Mark test as slow.
BUG=

Review URL: https://codereview.chromium.org//153633007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32414 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 09:06:57 +00:00
johnniwinther@google.com 06ae891b1c Support parameter metadata.
BUG=http://dartbug.com/15820
R=floitsch@google.com

Review URL: https://codereview.chromium.org//155703004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32413 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 08:55:12 +00:00
johnniwinther@google.com 3f016c29bc Fix ParameterMirror.hasDefaultValue/defaultValue in source mirrors.
BUG=http://dartbug.com/16535
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32356

Review URL: https://codereview.chromium.org//150693005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32409 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 08:03:38 +00:00
sra@google.com 8b14fbced0 Redo "Fix for issue 16497 - fix load elimination aliasing for typed arrays"
Re-add assignment 'cast' to avoid analyzer warning.

Review URL: https://codereview.chromium.org//155123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32302 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 23:33:29 +00:00
sra@google.com 020c305407 Revert "Fix for issue 16497 - fix load elimination aliasing for typed arrays"
BUG=

Review URL: https://codereview.chromium.org//155113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32301 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 23:26:30 +00:00
sra@google.com 589123472f Fix for issue 16497 - fix load elimination aliasing for typed arrays
R=floitsch@google.com

Review URL: https://codereview.chromium.org//154353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32300 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 23:06:19 +00:00
sra@google.com 56b09ad90b Test for Issue 16497
Review URL: https://codereview.chromium.org//132883020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32272 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 03:33:02 +00:00
rmacnak@google.com 509556a094 Fix handling of CRLF line endings in Script::GetSnippet.
BUG=http://dartbug.com/16098
R=hausner@google.com

Review URL: https://codereview.chromium.org//132773006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32254 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 18:11:57 +00:00
karlklose@google.com 8fa928d1dd Reapply "Make reflectClassByName work with interceptor names."
R=floitsch@google.com

Review URL: https://codereview.chromium.org//149533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32158 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 12:48:30 +00:00
karlklose@google.com 51ca61021a Revert "Make reflectClassByName work with interceptor names."
This reverts commit 16309.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//149493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32118 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 12:10:40 +00:00
karlklose@google.com 9e27fac327 Make reflectClassByName work with interceptor names.
BUG=16309
R=floitsch@google.com

Review URL: https://codereview.chromium.org//148223008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32112 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 09:50:25 +00:00
rmacnak@google.com 0f7fd4066d Include drt in suppression of lib/mirrors/regress_16321_test/01
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//134543005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32100 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 01:04:27 +00:00
ricow@google.com 1064410340 Mark lib/mirrors/regress_16321_test/01 as giving RuntimeError on dartium
See issue 16351

Review URL: https://codereview.chromium.org//148293006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32067 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 12:35:28 +00:00
rmacnak@google.com 2ad2351f26 Update status of mirrors/regress_16321_test/01 for dartium.
BUG=http://dartbug.com/16351
TBR

Review URL: https://codereview.chromium.org//148733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32047 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 01:01:00 +00:00
rmacnak@google.com 2808e02ca0 VM: Fix crash when a type error is encountered while evaluating metadata in checked mode.
BUG=http://dartbug.com/16321
R=hausner@google.com

Review URL: https://codereview.chromium.org//148263007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32042 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-27 23:50:45 +00:00
rmacnak@google.com e83f516c31 Re-enable mirrors/immutable_collections_test on Dartium. Fix a bad constructor in Dartium's dart:js. Mark as slow.
BUG=http://dartbug.com/16027
R=vsm@google.com

Review URL: https://codereview.chromium.org//147153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31996 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-24 21:05:00 +00:00
ahe@google.com 46387633af Handle dynamic as type argument.
BUG=http://dartbug.com/15573
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//113193006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31977 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-22 18:02:29 +00:00
lrn@google.com 9357caa547 Revert "Make VM TypedList not implement ByteBuffer."
Html transferable test fails to send buffer as buffer.

Review URL: https://codereview.chromium.org//137783019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31875 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 11:48:07 +00:00
lrn@google.com c2f6609181 Make VM TypedList not implement ByteBuffer.
BUG= http://dartbug.com/10136
R=asiva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//138033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31873 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 10:18:41 +00:00
iposva@google.com 8db30180b4 Fix http://dartbug.com/16111
- Use all bits from the seed value even if passed a Bigint.
- Fix out of bounds access in BigintOperations.
- Remove obsolete implementation note.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//136453012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31859 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 00:01:55 +00:00
floitsch@google.com 536f85d168 Update status file.
Review URL: https://codereview.chromium.org//135853016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31836 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 17:00:08 +00:00
rmacnak@google.com 2b77f8b1d4 dart2js: Implement instanceMembers and staticMembers.
BUG=http://dartbug.com/14633

Review URL: https://codereview.chromium.org//137123005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31808 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 22:31:20 +00:00
rmacnak@google.com 39f69b6045 Revert "dart2js: Implement instanceMembers and staticMembers."
Review URL: https://codereview.chromium.org//137533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31763 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 22:40:36 +00:00
rmacnak@google.com 3886174aa1 dart2js: Implement instanceMembers and staticMembers.
BUG=http://dartbug.com/14633
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//94093011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31757 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 21:09:49 +00:00
lrn@google.com f31896eba4 Fix expectation after moving json test.
Also increment version number of pkg/json in anticipation of pushing.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//136433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31734 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 12:25:15 +00:00
rmacnak@google.com 499dac2ad9 Skip mirrors/immutable_collections_test on Dartium.
BUG=http://dartbug.com/16027

Review URL: https://codereview.chromium.org//132803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31722 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-11 00:03:29 +00:00
rmacnak@google.com 7dfcd0f4a1 Add ClassMirror.isAbstract to the API and VM implementation.
BUG=http://dartbug.com/12826
R=gbracha@google.com

Review URL: https://codereview.chromium.org//129883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31643 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 01:27:51 +00:00
rmacnak@google.com 8313c51650 Ensure a class is finalized before attempting any reflective invocation on it.
Avoids mysterious error that results when finalization that is triggered by the reflective invocation fails to propogate a compile-time error.

BUG=http://dartbug.com/15886
R=regis@google.com, zra@google.com

Review URL: https://codereview.chromium.org//129513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31638 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 00:18:09 +00:00
rmacnak@google.com d8c4c637bf Revert "Add ClassMirror.isAbstract to the API and VM implementation."
BUG=

Review URL: https://codereview.chromium.org//128673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31633 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 22:51:45 +00:00
rmacnak@google.com a5e3c91936 Add ClassMirror.isAbstract to the API and VM implementation.
BUG=http://dartbug.com/12826
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//128933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31630 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 22:21:43 +00:00