Commit Graph

1115 Commits

Author SHA1 Message Date
floitsch@google.com 86303df642 Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34555 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 14:22:42 +00:00
rmacnak@google.com f0626388f5 VM: Evaluate metadata on a class in the scope of its library not the scope of the class.
BUG=http://dartbug.com/17795
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//217543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34537 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 22:38:32 +00:00
kevmoo@google.com 264d172ab0 lib.status: de-duped JSON serialization in Dart2Dart + minified
R=karlklose@google.com

Review URL: https://codereview.chromium.org//215063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34508 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 16:52:31 +00:00
rmacnak@google.com 9c105f7c9c Handle creating ParameterMirrors for the parameters of forwarding constructors.
BUG=http://dartbug.com/17823
R=hausner@google.com, regis@google.com

Review URL: https://codereview.chromium.org//212883009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34494 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 01:22:03 +00:00
hausner@google.com 09f4894a9c Fix mirrors test expectation
Review URL: https://codereview.chromium.org//215633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34484 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 22:11:32 +00:00
srdjan@google.com 36d8c9a39c Fix bug in divpd x64.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//213193009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34475 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 16:43:40 +00:00
karlklose@google.com 56d8742555 Fix test expectations for convert/json2_test.
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//212653009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34465 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 08:11:34 +00:00
srdjan@google.com a0ac63bd57 Fix broken build, by disabling test; investigate failure leisurely.
Review URL: https://codereview.chromium.org//212623007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34459 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 23:28:47 +00:00
lrn@google.com 6e1d5c293a Update expectations to mark lib/mirrors/immutable_collection_test as failing.
BUG= http://dartbug.com/17823

Review URL: https://codereview.chromium.org//212543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34433 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 15:41:40 +00:00
rmacnak@google.com 78ab60a0de Implement MethodMirror.location in the VM.
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//211243009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34400 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 00:44:54 +00:00
ajohnsen@google.com 877658b6ec Fix status file.
BUG=

Review URL: https://codereview.chromium.org//206613006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34395 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 22:50:38 +00:00
ajohnsen@google.com 38e2e4a18c Mark deferred_mirrors_metadata_test as crashing with dart2js.
BUG=https://code.google.com/p/dart/issues/detail?id=17732

Review URL: https://codereview.chromium.org//199793018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34304 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 13:35:19 +00:00
johnniwinther@google.com 7c9b135629 Remove cancel and make crash exit with code 253.
BUG=http://dartbug.com/17557
R=karlklose@google.com

Review URL: https://codereview.chromium.org//206193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34238 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:44:42 +00:00
sigurdm@google.com 30ac6d116d Introduces the new syntax for deferred loading
import "lib.dart" deferred as lib;

And then injecting a function of the name "loadLibrary" into the
namespace of the import prefix.

This FunctionElement is a triggers the builder to emit special code that causes _loadLibraryWrapper in js_helper to be called.

Dart2dart will not crash on deferred loading, but calls to
loadLibrary will become calls to a (not-existing) top-level function
loadLibrary.

The old syntax (using metadata) is still working

For now keeping the language tests with the old syntax in addition to
the updated tests.

R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//201613006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34230 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 07:50:08 +00:00
whesse@google.com 62c79adbd0 Add entries for ContentShellOnAndroid runtime to status files.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//203373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33807 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 14:47:56 +00:00
rmacnak@google.com f8c59de4d6 Clean up ClosureMirror.invoke(#call, ...).
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//196513004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33790 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 23:43:32 +00:00
johnniwinther@google.com f744481c8e Mark various tests as slow for FYI
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//199893004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33743 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 13:26:25 +00:00
johnniwinther@google.com 7d19bc6001 Skip deferred tests on d8 on Windows.
BUG=
R=sgjesse@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//198853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33691 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 10:39:51 +00:00
rmacnak@google.com 8c0e1a602e Fix LibraryMirror.invoke to call through the contents of an implicit getter.
BUG=http://dartbug.com/17452
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//196953007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33682 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 01:14:06 +00:00
rmacnak@google.com 10ecef7968 Remove ObjectMirror.[].
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//165773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33543 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 18:21:13 +00:00
rmacnak@google.com 57dd1321d1 Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
Regenerate snapshot test due to change in the size of Namespace. Relate the types source mirror libraries dependencies to the runtime library dependencies.

BUG=http://dartbug.com/10360

Review URL: https://codereview.chromium.org//189843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 19:00:20 +00:00
rmacnak@google.com 62ad4b82ce Revert "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors."
Review URL: https://codereview.chromium.org//189293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33402 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:45:29 +00:00
rmacnak@google.com 2d0e54a94d Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors.
BUG=http://dartbug.com/10360
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//154733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33397 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:02:29 +00:00
rmacnak@google.com d515f61a35 Work around bug where closures are missing #call to support delegation of #call to closures.
BUG=http://dartbug.com/16995
R=iposva@google.com

Review URL: https://codereview.chromium.org//183923018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33303 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 21:10:04 +00:00
rmacnak@google.com d3a92a0f3d Hoist hasReflectedType and reflectedType from ClassMirror to TypeMirror.
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//183853022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33291 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 19:01:26 +00:00
rmacnak@google.com c4f989c768 Add TypeVariableMirror.isStatic to the API.
BUG=http://dartbug.com/16819
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//182603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33283 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 18:13:22 +00:00
sigurdm@google.com c62441401a Fix status file
R=floitsch@google.com

Review URL: https://codereview.chromium.org//185543013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33269 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 12:31:18 +00:00
sigurdm@google.com 28367869f8 Mark deferred test as flaky in IE9.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//185403015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33263 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 10:16:34 +00:00
sigurdm@google.com 49f2c7c81f Status files merge sections
R=floitsch@google.com

Review URL: https://codereview.chromium.org//180633006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33261 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 08:05:34 +00:00
rmacnak@google.com 7c4a84d130 Remove LibraryMirror.topLevelMembers.
R=gbracha@google.com

Review URL: https://codereview.chromium.org//164823006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33256 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 01:35:07 +00:00
sigurdm@google.com 1852bb6566 Status files update.
Deferred loading does not work in csp mode.

Review URL: https://codereview.chromium.org//180633005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33218 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 15:22:21 +00:00
lrn@google.com 7d4d533114 Add validation of private symbols to the dart2js mirrors.
The mirrors.getSymbol function works for non-private symbols, and
validates private symbols (but still fail to create a Symbol object).

R=ahe@google.com

Review URL: https://codereview.chromium.org//177483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33212 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 12:58:54 +00:00
karlklose@google.com 51047b6c1b Implement Mirror.isSubclassOf.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//172353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33151 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 09:38:52 +00:00
rmacnak@google.com b49aa48f07 Fix VM crash when parsing what looks like a closure call during metadata evaluation.
BUG=http://dartbug.com/17141
R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//180313003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33141 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-27 23:24:05 +00:00
floitsch@google.com 842be2c90d Use Date.getTime instead of Date.getMilliseconds in dart:js.
BUG= http://dartbug.com/14915
R=kasperl@google.com

Review URL: https://codereview.chromium.org//180723004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33116 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-27 15:13:44 +00:00
floitsch@google.com 5316f7bdfe Assign invalid name to globalized closures.
BUG= http://dartbug.com/16244
R=karlklose@google.com

Review URL: https://codereview.chromium.org//179803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33061 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-26 13:46:50 +00:00
ricow@google.com 801c48c9b8 Remove suppression for lib/async/stream_transform_test checked mode on d8
The v8 bug:
https://code.google.com/p/v8/issues/detail?id=3084
has been fixed and we rolled a new version including the fix in r33016

R=kasperl@google.com

Review URL: https://codereview.chromium.org//179953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33019 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 14:41:34 +00:00
karlklose@google.com 32ee534a3f Emit named parameter information in declaration order.
R=floitsch@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32880

Review URL: https://codereview.chromium.org//163773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33017 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 13:17:54 +00:00
karlklose@google.com 19a522a25b Revert "Emit named parameter information in declaration order."
This reverts commit 32880.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//179583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33008 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 09:35:30 +00:00
lrn@google.com 8ae4728a4f Update documentation on Symbol. Make validation match.
Changed documentation of the Symbol constructor to correctly state
which inputs are accepted.
Changed validation to match.
Disallow keywords as identifiers.
No longer accepts "x.y=" symbols which are not the name of anything
in the source.

BUG= http://dartbug.com/13716
R=ahe@google.com

Review URL: https://codereview.chromium.org//140643006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32952 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 08:11:16 +00:00
karlklose@google.com c2f4610b3b Emit named parameter information in declaration order.
R=floitsch@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//163773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32880 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 09:31:09 +00:00
lrn@google.com b27ccf41e3 Add toIso8601String to DateTime.
BUG= http://dartbug.com/16902
R=floitsch@google.com

Review URL: https://codereview.chromium.org//165723005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32786 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 13:00:09 +00:00
fschneider@google.com 5f58066c65 MIPS: Fix bug in allocation stub's slow path.
The CL r32697 that changed the argument count of the AllocateObject
runtime function from 3 to 2 did not correctly adjust SP before
the runtime call.

BUG=dartbug.com/16873
R=regis@google.com

Review URL: https://codereview.chromium.org//167893006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32735 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 10:10:06 +00:00
floitsch@google.com d743dd6513 Mark lib/async/deferred/deferred_in_isolate_test as failing in csp mode.
Review URL: https://codereview.chromium.org//164333015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32728 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 16:38:33 +00:00
sgjesse@google.com 6edd2d5bff Update status file
Add SIMMIPS pass, crash for lib/mirrors/immutable_collections_test

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//169283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32719 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 11:40:55 +00:00
sigurdm@google.com d6e8f9c47f Fix status files for deferred loading-tests.
They do not run on dart2dart nor ie9.

Review URL: https://codereview.chromium.org//166913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32703 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 14:54:31 +00:00
sigurdm@google.com 99e4bef0a2 Let deferred load work from worker isolates.
If we try to load a deferred library from a worker-isolate we cannot
inject a script tag because we do not have access to the dom. Instead we
make an XMLHttpRequest object and load the code with that.

I tried to take some care of error handling introducing a new exception.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32693

Committed: https://code.google.com/p/dart/source/detail?r=32695

Review URL: https://codereview.chromium.org//163733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32698 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 13:10:16 +00:00
sigurdm@google.com b2c93ff65d Let deferred load work from worker isolates.
If we try to load a deferred library from a worker-isolate we cannot
inject a script tag because we do not have access to the dom. Instead we
make an XMLHttpRequest object and load the code with that.

I tried to take some care of error handling introducing a new exception.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32693

Review URL: https://codereview.chromium.org//163733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32695 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 12:44:21 +00:00
sigurdm@google.com 0b1fee8131 Let deferred load work from worker isolates.
If we try to load a deferred library from a worker-isolate we cannot
inject a script tag because we do not have access to the dom. Instead we
make an XMLHttpRequest object and load the code with that.

I tried to take some care of error handling introducing a new exception.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//163733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32693 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 12:12:58 +00:00
floitsch@google.com 22ab27256e Fix null.runtimeType, reflect(null).type.superinterfaces, and reflect(null).getField.
null.runtimeType.toString() returned "JSNull".
reflect(null).type.superInterfaces mirrored on the interceptor and contained Null in the list.
reflect(null).getField was trying to cache the getters on the object and failed.

BUG= http://dartbug.com/16741
BUG= http://dartbug.com/12482
R=karlklose@google.com, kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32650

Reverted: https://code.google.com/p/dart/source/detail?r=32652

Committed: https://code.google.com/p/dart/source/detail?r=32654

Reverted: https://code.google.com/p/dart/source/detail?r=32665

Review URL: https://codereview.chromium.org//161333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32692 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 12:08:18 +00:00