Commit Graph

5559 Commits

Author SHA1 Message Date
karlklose@google.com adc83bd27c Report compile-time error when extending, mixing in or implementing a malformed type.
BUG=dartbug.com/13994
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//27494002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28721 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 12:52:11 +00:00
lrn@google.com 8b1d5720f7 Change "typedef" to "class" in core library and related tests.
R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//27300003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28712 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 09:02:46 +00:00
rmacnak@google.com 15bc17777f Add mirror tests for generic interfaces. Add base-language test for malbounded interfaces.
B=http://dartbug.com/14118
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//27378002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28703 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 01:06:56 +00:00
johnniwinther@google.com d97500ce5e Support type promotion in dart2js.
BUG=http://dartbug.com/13806
R=karlklose@google.com

Review URL: https://codereview.chromium.org//26232003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28654 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 16:27:28 +00:00
hausner@google.com c646aed258 Implement new mixin application syntax
Implment the class X = S with M syntax, add warning on deprecated
typedef syntax. Also convert a handful of tests. More tests to
be converted subsequently.

R=regis@google.com

Review URL: https://codereview.chromium.org//27223005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28652 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 16:13:02 +00:00
fschneider@google.com b5465cf7ef VM: Fix bug in canonicalization of identical in the optimizing compiler.
Make sure that BranchInstr::Canonicalize does not mutate it's input before
all conditions for the optimzations to take place are met. Otherwise, bailing out
leaves the affected comparison instruction in an invalid state.

BUG=https://code.google.com/p/dart/issues/detail?id=14109
R=srdjan@google.com

Review URL: https://codereview.chromium.org//26451006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28646 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 15:15:47 +00:00
johnniwinther@google.com 8009eb9561 Avoid generating members for classes only for needed rti.
BUG=http://dartbug.com/14105
R=karlklose@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//27318003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28643 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 15:00:48 +00:00
lrn@google.com 0b3d95a799 Fix tests that didn't fail before double got an equality operator.
Review URL: https://codereview.chromium.org//26297003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28638 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 12:42:27 +00:00
karlklose@google.com 529b2f111c Emit a compile-time error when using doubles as switch case expressions.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//26978004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28637 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 12:03:24 +00:00
karlklose@google.com 2e26824bb8 Fix language/external_test.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//25673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28633 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 09:02:08 +00:00
scheglov@google.com e273ccc395 Issue 12103. It is warning to provide wrong number of type arguments for list/map literals.
https://code.google.com/p/dart/issues/detail?id=12103

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//27179004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28588 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 16:31:16 +00:00
karlklose@google.com 5870a6cb30 Emit a compile-time error when using default values in function typed parameter.
BUG=12812,12813
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//26370004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28574 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 10:35:29 +00:00
johnniwinther@google.com 5ab3ca52d8 Handle missing const constructor.
BUG=http://dartbug.com/13911
R=kasperl@google.com

Review URL: https://codereview.chromium.org//26470006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28573 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 07:14:18 +00:00
aprelev@gmail.com a2a244ea1c Switch dart2js 'typedef name = mixinApplication' to 'class name = mixinApplication'.
BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//26651006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28561 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 00:55:17 +00:00
scheglov@google.com 626a40bb34 Don't resolve private inherited members.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//26817006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28549 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 20:35:35 +00:00
rmacnak@google.com f0bdbbea6f F-bounded equality also fails on dart2dart.
BUG=http://dartbug.com/14000

Review URL: https://codereview.chromium.org//26905008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28543 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 19:47:21 +00:00
scheglov@google.com 037710054d Issue 13703. Report CONFLICTING_TYPE_VARIABLE_AND_CLASS and CONFLICTING_TYPE_VARIABLE_AND_MEMBER.
https://code.google.com/p/dart/issues/detail?id=13703

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//27055004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28541 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 19:17:04 +00:00
rmacnak@google.com c284d119a1 Base-level test for equality of f-bounded types.
BUG=http://dartbug.com/14000
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//26124004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28534 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 17:52:55 +00:00
johnniwinther@google.com af01be2b97 Handle clash of prefix/non-prefix imports.
BUG=http://dartbug.com/5712
R=kasperl@google.com

Review URL: https://codereview.chromium.org//27008003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28514 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 12:32:16 +00:00
johnniwinther@google.com dcb98b6517 Support extends/implements of Function.
BUG=http://dartbug.com/12446
R=kasperl@google.com

Review URL: https://codereview.chromium.org//26995002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28506 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 11:33:31 +00:00
ricow@google.com 526b539a4e Suppress crash in language/source_self_negative_test on drt on mac
We are hitting an assertion, see issue 14003 for details.

R=kasperl@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//26974002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28498 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 06:13:21 +00:00
regis@google.com 15bc5b9a0a Disallow extending a malformed type (issue 13940).
Add language test and update dart2js status (issue 13994 filed).

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//26888005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28488 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 23:30:42 +00:00
scheglov@google.com efe2c8557f Propagate type arguments into type variable bounds.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//26888007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28483 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 21:52:37 +00:00
regis@google.com 42ceee4cba Allow malbounded literal types (fix issue 13952).
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//26866005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28474 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 20:45:09 +00:00
scheglov@google.com d1d0e09dda Implement type variable 'more specific than' and 'subtype'.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//26745004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28457 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 15:19:29 +00:00
karlklose@google.com 44446f0cc7 Fix language/function_type_alias5_test.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//25638009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28446 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 11:35:39 +00:00
rmacnak@google.com 7332bb3cc6 Mark dart2dart as failing malbounded_type_literal_test.
BUG=http://dartbug.com/13960

Review URL: https://codereview.chromium.org//26782002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28438 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 01:35:03 +00:00
rmacnak@google.com f6c9abbc43 Add test for using a type literal for a malbounded type. Crashes the VM in debug mode.
R=gbracha@google.com, regis@google.com

Review URL: https://codereview.chromium.org//26761002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28428 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 23:09:30 +00:00
hausner@google.com c78fe4a9ed Missing status file from last checkin.
Review URL: https://codereview.chromium.org//26287007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28421 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 21:29:04 +00:00
rmacnak@google.com 288757100c Move test status for type_variable_conflict_test on dart2js to correct section.
Review URL: https://codereview.chromium.org//26760003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28419 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 21:21:22 +00:00
scheglov@google.com afb3cc7f01 Issue 13918. final fields induce setters that are illegal to call
https://code.google.com/p/dart/issues/detail?id=13918

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//26746002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28415 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:30:42 +00:00
rmacnak@google.com 9a5bccfbe1 Also mark test for type variable name conflicts as failing on the analyzer.
Review URL: https://codereview.chromium.org//26755002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28414 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:20:48 +00:00
rmacnak@google.com d744ef69c5 Add test for conflicts between type variables and instance or static getters, methods or fields.
R=gbracha@google.com

Review URL: https://codereview.chromium.org//24650002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28413 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:06:58 +00:00
hausner@google.com b87ef6ab7f Final variables induce a setter that throws NSME
Clean up handling of const and final variables. They induce a
setter that throws a NSME, rather than a compile-time error.

Delay the AST conversion of loading a const field into loading
the literal value. The conversion is now done when we know
that the load in on the right hand side of an expression.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//26703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28408 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 17:33:10 +00:00
vsm@google.com 334fd6bf07 Mark spawnFunction tests as Fail on Dartium
See corresponding Dartium CL:
https://chromiumcodereview.appspot.com/26397003/

This disables spawnFunction on DOM enabled isolate (i.e., where
dart:html is available).  spawnFunction should continue to work on
non-DOM enabled isolated.  spawnUri should be unaffected.

R=asiva@google.com

Review URL: https://codereview.chromium.org//26616002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28406 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 16:25:28 +00:00
scheglov@google.com 912413e98b Improve REDIRECT_TO_INVALID_RETURN_TYPE check.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//26646002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28402 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 14:29:37 +00:00
lrn@google.com a56d8bb758 Mark implicit_setter_test-case failing for analyzer too.
Review URL: https://codereview.chromium.org//26539004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28401 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 13:59:09 +00:00
lrn@google.com b17b785118 Add test for new final-field implicit setter semantics.
BUG= http://dartbug.com/13917 http://dartbug.com/13918 http://dartbug.com/13919
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//26682002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28400 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 11:27:30 +00:00
kustermann@google.com f6d557f8d6 Mark language/issue13474_test as flaky on none-dartium
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//26224002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28299 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 06:46:04 +00:00
kustermann@google.com ac254a8633 Status file update for builders runnig none-dartium tests
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//26194002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28297 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-06 21:10:25 +00:00
scheglov@google.com 59fd8f58c8 New analyzer_experimental snapshot.
1. "catch (Exception e)" is translated into "on JavaException catch (e)".
2. Java exceptions now extend JavaException.
3. MemberMap moved into resolver, because it is not a generic collection and has references to elements.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//26096002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28296 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-06 05:11:15 +00:00
regis@google.com 5e817c182b It is not an error anymore to leave an instance final field uninitialized.
Fix issues 11054 and 12157.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//26023005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28289 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 22:56:53 +00:00
srdjan@google.com 1676113897 Fix runtimeType for strings, integers and double: return their interface type.
R=asiva@google.com

Review URL: https://codereview.chromium.org//25674017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28286 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 22:08:55 +00:00
srdjan@google.com 2ae1640000 Fix issue 13474. Simplify graph builder for Boolean operators AND, OR: do not optimize code when the result of the Boolean operator is not used.
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//25630002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28275 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 19:43:18 +00:00
kustermann@google.com 14dce1057e Second round of status file updates after enabling none-dartium tests on dartium-inc builders
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//25892008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28265 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 14:32:38 +00:00
karlklose@google.com 85123edd06 Fix test expectations for dartium.
R=fschneider@google.com

Review URL: https://codereview.chromium.org//25883011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28255 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 09:26:13 +00:00
kustermann@google.com edacf33810 Status file update for none-dartium
R=kasperl@google.com

Review URL: https://codereview.chromium.org//25896005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28254 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 09:25:26 +00:00
karlklose@google.com 3393756849 Don't evaluate the argument twice for unresolved static setter calls.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//25877002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28253 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 08:47:10 +00:00
hausner@google.com 942966ced4 Fix dartanalyzer status
Review URL: https://codereview.chromium.org//25908002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28236 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 18:36:37 +00:00
hausner@google.com 8fa41d5d55 Compile error on const instance variables
Another little step towards full spec compliance.

Issue 11051

R=srdjan@google.com

Review URL: https://codereview.chromium.org//25873005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28234 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 18:17:16 +00:00