dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

5559 Commits

Author SHA1 Message Date
scheglov@google.com 4382a55d89 Issue 14358. Check for assignment in any close. 
https://code.google.com/p/dart/issues/detail?id=14358

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//49383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29484 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-29 20:30:01 +00:00
regis@google.com 65379851a8 Implement stricter rule about self referencing typedefs (fix issue 13675). 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//49853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29460 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-29 17:04:21 +00:00
johnniwinther@google.com 7efd78204a Fix the more specific relation. 
BUG=http://dartbug.com/14358,http://dartbug.com/14362,http://dartbug.com/14364
R=karlklose@google.com

Review URL: https://codereview.chromium.org//47513007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29446 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-29 13:19:08 +00:00
scheglov@google.com 4587f57f5d Compile time error was removed for variable reference in its initializer. 
It was removed in https://codereview.chromium.org//27054005

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//46403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29394 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-28 20:49:42 +00:00
fschneider@google.com be9875fb2b VM: Fix bug in polymorphic inlining of recognized methods. 
The inliner has to insert a redefinition of the receiver to
prevent illegal hoisting of instructions that depend on the
receiver class id.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//47933004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29389 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-28 20:20:11 +00:00
scheglov@google.com 9039835b60 New analyzer snapshot. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//49383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29384 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-28 19:46:48 +00:00
kustermann@google.com c76242a7b7 Remove passing tests in the status file for the analyzer in --checked mode 
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//47743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29353 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-28 11:56:35 +00:00
kustermann@google.com 94ebff2225 Bugfix in test.dart, adding of specialized test outcomes for analyzer 
This CL will:
 - fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
   we did not report that the analyzer was missing a warning).
 - make the outcome of running the analyzer on a test be one of:
   * CompileTimeError
   * MissingCompileTimeError
   * StaticWarning
   * MissingStaticWarning
 - Make status file updates using the new Expectation markers
 - Remove support for '@static-clean':
     Previously running the analyer on a test could either result in
     'Pass' or in 'Fail'. The '@static-clean' annotation has been used
     as a (poor) mechanism to distinguish between errors and warnings.
     Having the 4 markers mentioned above means we can remove '@static-clean'
 - Remove 100 lines of rotted legacy code in our testing scripts.
 - Make a status file entry for every test that has analyzer errors or warnings

R=ricow@google.com

Review URL: https://codereview.chromium.org//46163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-28 10:39:38 +00:00
scheglov@google.com 90f8469aa0 Issue 14306. It is compile-time error to reference non-constructor in const redirecting constructor. 
https://code.google.com/p/dart/issues/detail?id=14306

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//47753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29337 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-28 00:00:44 +00:00
ngeoffray@google.com 5e06168ea7 Fix issue 12336: there was a bug when updating phis at exit of a block with a HTypeKnown instruction. 
By making the update an assignment, we were generating the wrong order of copies. Since the checked input of HTypeKnown may have a name, we need to make it a copy.

Review URL: https://codereview.chromium.org//44143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29331 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-27 19:29:12 +00:00
regis@google.com e9b01ccf7b Disallow explicit parameter default values in redirecting factory (issue 13662). 
Add language test.
Fix usage in core lib.

R=hausner@google.com

Review URL: https://codereview.chromium.org//45833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29298 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-25 23:02:48 +00:00
justinfagnani@google.com 1b554a70c0 Fix Function.apply() + call() + noSuchMethod() in dart2js 
BUG=https://code.google.com/p/dart/issues/detail?id=14288
R=sra@google.com

Review URL: https://codereview.chromium.org//43073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29287 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-25 20:56:49 +00:00
floitsch@google.com 6a72655d1b Very simple version of Isolates. 
R=ajohnsen@google.com, iposva@google.com, kasperl@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//27215002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-25 19:23:00 +00:00
scheglov@google.com ab4a7a15d1 New analyzer_experimental snapshot. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//42863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29260 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-25 16:55:54 +00:00
hausner@google.com e88158649a Fix language test status 
Review URL: https://codereview.chromium.org//42103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29220 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 22:30:00 +00:00
scheglov@google.com 69d9d6ced6 VM and dart2js both support ne mixin syntax. 
https://code.google.com/p/dart/issues/detail?id=13907

It seems that packages and other code were migrate too.
So, we can turn on error for the old syntax.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//41273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29211 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 21:42:07 +00:00
asiva@google.com 910c318003 Fix status file to mark spawnFunction as crashing until 14400 is fixed. 
R=vsm@google.com

Review URL: https://codereview.chromium.org//41153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29199 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 19:51:57 +00:00
scheglov@google.com fb757f6c82 Issue 14388. Remove implicit setters for final fields. 
https://code.google.com/p/dart/issues/detail?id=14388

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//40863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29196 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 19:07:11 +00:00
kustermann@google.com b3ba5c5c95 test.py: Support for running tests in checked mode on none-dartium with the browser controller 
R=ricow@google.com

Review URL: https://codereview.chromium.org//38753008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29175 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 15:37:33 +00:00
scheglov@google.com 2b2112bb68 Issue 13807. Support for function types promotion. 
https://code.google.com/p/dart/issues/detail?id=13807

Also related language tests triage.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//38353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29146 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 03:16:36 +00:00
regis@google.com 177276f059 Report compile-time error for const factories redirecting to malformed type 
(fix issue 14305).

R=iposva@google.com

Review URL: https://codereview.chromium.org//29013005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29123 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 21:03:11 +00:00
srdjan@google.com 8e7c6a5fae Move Stringinterpolation constant folding from constant propagator to canonicalizer. StrinIterpolateInstr cannot directlly refer to interpolation arguments but only to the array that holds them, therefore constant propagation cannot be applied. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org//34523007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29118 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 20:37:18 +00:00
fschneider@google.com c07c229b39 Update dart2dart status after bug fixes in the VM. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org//37463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29099 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 17:20:05 +00:00
fschneider@google.com 77669aac3e Fix VM issue 1372: super constructor invocation with redirection. 
A redirecting super constructor simply passes the phase parameter
on to the target which executes the corresponding phase.

BUG=https://code.google.com/p/dart/issues/detail?id=1372
R=hausner@google.com

Review URL: https://codereview.chromium.org//35693010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29097 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 16:18:20 +00:00
scheglov@google.com de23067621 Issue 13807. Support for type promotion rules. 
https://code.google.com/p/dart/issues/detail?id=13807

Basic version.
No union types (and hopefully no need for them).
So, language tests should be triaged.
No support for ?: yet.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//34523011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29095 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 16:09:11 +00:00
johnniwinther@google.com 1ff2bb97d5 Update status. 
BUG=

Review URL: https://codereview.chromium.org//37293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29081 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 13:53:26 +00:00
johnniwinther@google.com 12acea6f99 Check const expressions for malformed types. 
BUG=http://dartbug.com/14299
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//34993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29080 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 13:01:30 +00:00
ngeoffray@google.com e155f275fc Fix another closure/type variable error by using analyzeTypeVariables. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//34963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29061 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 06:44:59 +00:00
zra@google.com d507fb5197 Updates status files for fixed ARM builder. 
Review URL: https://codereview.chromium.org//36223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29046 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 23:19:38 +00:00
regis@google.com 3e8c130227 Fix language tests for redirecting factories (issue 14297). 
Use target constructor name in redirecting factory errors.

R=hausner@google.com

Review URL: https://codereview.chromium.org//34903006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29045 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 22:36:42 +00:00
scheglov@google.com bfe1b18ed3 Issue 13906. It is still error when typedef references itself using type variable bounds. 
https://code.google.com/p/dart/issues/detail?id=13906

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//34473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29010 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 17:07:45 +00:00
hausner@google.com e7255e091a Do not generate a compile-time error if there is more than one catch-all clause 
This includes catch clauses with malformed types, which are essentially
catch-all clauses.

The spec does not mandate such a compile-time error. (It probably did a long
time ago.)

Fixes issue 8601, 12159, 13019

R=iposva@google.com

Review URL: https://codereview.chromium.org//33813003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28999 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 15:44:28 +00:00
ngeoffray@google.com 47201ab1f1 Fix crash https://code.google.com/p/dart/issues/detail?id=14014: remove what seems to be obsolete code. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//32203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28985 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 06:39:10 +00:00
johnniwinther@google.com 7743533c9e Handle resolution of Class.named<TypeArg> correctly. 
BUG=
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//32363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28984 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 06:16:39 +00:00
hausner@google.com dbe0e4c9b4 Allow string literal concatenation in import clauses 
Added benefit: if there is no interpolation in any of the adjacent
string literals, the compiler concatenates the strings without
invoking Dart code.

Fixes issues 12521, 6877

R=regis@google.com

Review URL: https://codereview.chromium.org//32513007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28964 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 22:13:42 +00:00
kustermann@google.com d71c26f94d Status file update for ARM 
TBR=zra@google.com

Review URL: https://codereview.chromium.org//32703005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28955 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 21:47:55 +00:00
brianwilkerson@google.com 5fcd36b0b9 Fix issue 13575 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//32693003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28953 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 21:15:24 +00:00
regis@google.com 5a5edb7f0c Report use of malbounded interface in type test. 
Fix language tests related to malbounded types (issues 14123, 14131, 14132).

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//33313003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28943 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 19:49:19 +00:00
kustermann@google.com 41ccaf2334 Mark language/vm/load_to_load_forwarding_vm_test as crashing on arm 
Review URL: https://codereview.chromium.org//30683004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28938 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 17:50:53 +00:00
fschneider@google.com 369a58132e Fix bugs in load elimination and type propagation. 
Load elimination should consider the representation of loads/stores
when numbering places. Different representations result now in different
places so that there can't be mixed representations at phis after
load elimination.

Removed the flag --propagate-types because type propagation is required
for correctness of smi-check hoisting. Therefore, switching it off does not
 make sense anymore.

BUG=https://code.google.com/p/dart/issues/detail?id=6663, https://code.google.com/p/dart/issues/detail?id=14271
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//28633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28931 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 13:59:56 +00:00
ngeoffray@google.com 2b50c5d7d9 Fis crash https://code.google.com/p/dart/issues/detail?id=14242, by calling resolveArguments on the arguments of a SendSet, instead of a raw NodeList visit. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//32033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28924 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 09:31:34 +00:00
scheglov@google.com 9a411f83f0 Don't evaluate << because of possible overflow. 
Applied same change to Dart version to fix crash.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//29313003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28873 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-18 19:37:56 +00:00
brianwilkerson@google.com 0186372754 Fix issue 12654 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//29283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28864 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-18 17:36:32 +00:00
scheglov@google.com 581b368515 New analyzer_experimental snapshot. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//27278004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28831 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 22:14:19 +00:00
hausner@google.com 0e099ff048 Check that class member names do not conflict with type parameters 
Implement check that member names do not conflict with type
parameters. Simplify name checks in class namespace.
Mark typevariable_mirror_metadata_test as failing now that we
report the proper compile time errors. (The test expects no errors.)
Some co19 tests expect a name conflict between a setter X= and type
parameter X. This is still in flux from a language perspective. This
change list does not introduce an compile error for this case.

Fix for issue 13701.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//27619002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28808 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 17:39:08 +00:00
johnniwinther@google.com c8e6df9512 Add const type literal test. 
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//25535009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28794 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 09:48:22 +00:00
johnniwinther@google.com e872bec1c3 Update status. 
BUG=

Review URL: https://codereview.chromium.org//26216007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28789 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 07:59:58 +00:00
johnniwinther@google.com c7a9f21e26 Update check for cyclic typedefs. 
BUG= http://dartbug.com/9792, http://dartbug.com/11986
R=karlklose@google.com

Review URL: https://codereview.chromium.org//27019003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28786 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 07:05:18 +00:00
scheglov@google.com b7283dfe33 Issue 14133. Tweak test. 
https://code.google.com/p/dart/issues/detail?id=14133

R=brianwilkerson@google.com, johnniwinther@google.com, regis@google.com, rmacnak@google.com
BUG=

Review URL: https://codereview.chromium.org//27466002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28745 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-16 19:16:44 +00:00
scheglov@google.com ba9c5fbd25 Report CONFLICTING_DART_IMPORT when dart: import is implicitly hidden. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//27444002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28739 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-16 17:41:59 +00:00