8c1e3c45b0
Dart2js async-await. Propagate stacktraces from futures.
...
BUG= dartbug.com/22324
R=floitsch@google.com
Review URL: https://codereview.chromium.org//945783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43951 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 12:40:54 +00:00
ced919f9c4
Asyncstar - exception thrown before yield or await would not get caught
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//947433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43948 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 11:25:41 +00:00
be05129a8c
Mark async_rethrow_test as failing on Dartium as well.
...
TBR=hausner@google.com
Review URL: https://codereview.chromium.org//943093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43939 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-21 01:00:30 +00:00
093da297dc
Added a test for issue 22523.
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//950463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43935 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 22:55:23 +00:00
be3c508ffd
Fix type propagation for and operator.
...
BUG= http://dartbug.com/22427
R=floitsch@google.com
Review URL: https://codereview.chromium.org//941293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43908 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 11:49:10 +00:00
78e30804e8
Make enum a keyword in dart2js.
...
BUG=http://dartbug.com/22478
R=floitsch@google.com
Review URL: https://codereview.chromium.org//944813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43906 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 10:54:48 +00:00
a5ad3de7b0
- Mark failing dart2js test.
...
Review URL: https://codereview.chromium.org//939183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43883 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 17:13:52 +00:00
7d1785e760
- Allow any implementation of StackTrace to participate in async/
...
await exception handling.
R=hausner@google.com
Review URL: https://codereview.chromium.org//940863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43880 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 16:17:19 +00:00
4e7ecb1103
Issue 22409. Restore recognizing string concatenation in const expressions.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22409
https://code.google.com/p/dart/issues/detail?id=21000
Review URL: https://codereview.chromium.org//940853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43879 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 15:35:54 +00:00
e8b7f9cb06
Don't constant fold operation if result is incompatible with it.
...
For example we can't replace BinarySmiOp with Mint constant because we might have removed the checks based on the assumption that BinarySmiOp always returns a Smi.
BUG=http://dartbug.com/22480
R=fschneider@google.com
Review URL: https://codereview.chromium.org//938783003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43875 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:48:48 +00:00
db9faebe98
- Simplify collection of stack traces. If we determine that a stack
...
trace is needed we collect the full stack trace instead of piecing
it together as we walk up the stack.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//939773003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43863 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 02:18:53 +00:00
4d09e6a9dd
Accept constant string concatenation and constant string length as constant
...
expressions (fix issue 22408).
R=hausner@google.com
Review URL: https://codereview.chromium.org//935713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43831 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 00:38:40 +00:00
4cc4e28411
status files: trying out new SkipSlow flag
...
and selectively used SkipByDesign in more places
R=whesse@google.com
Review URL: https://codereview.chromium.org//928523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43815 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:21:39 +00:00
1c3a2fe9bb
Fix status files
...
BUG=
Review URL: https://codereview.chromium.org//928633003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43813 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 15:48:16 +00:00
3ae9ac92c5
Fix error handling in dart2js async-await
...
BUG= dartbug.com/22372
R=floitsch@google.com
Review URL: https://codereview.chromium.org//925973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43812 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 14:51:49 +00:00
24c0b1aba1
Update no-inline annotation in test.
...
Review URL: https://codereview.chromium.org//930883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43800 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-16 13:07:23 +00:00
2ffa638e82
dart2js: fix dart2js crash when getRuntimeTypeArgument was not registered.
...
R=johnniwinther@google.com , karlklose@google.com
Review URL: https://codereview.chromium.org//923113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43797 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-16 11:48:17 +00:00
726a18e9ee
Status file fixes for bugs 22411 and 22412
...
TBR=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//923913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43768 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 16:43:53 +00:00
0bde4dab58
Fix status-files for the analyzer
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//922183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43754 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 13:04:37 +00:00
0c21c996db
Add SkipSlow marker
...
This is to be used temporarily until we can start running slow tests on seperate bots.
R=whesse@google.com , kevmoo@google.com
BUG=22402
Review URL: https://codereview.chromium.org//924793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43751 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 10:02:30 +00:00
58613e8885
Revert "dart2js: Refactoring, documentation, and a few bugfixes in Namer class."
...
I'm reverting this CL because it leaves so many bots red.
You should be able to create a branhc, revert this CL, upload, fix the problem, upload again and get a code review of the fixes without the reviewer needing to review the whole CL, just the delta.
These tests fail (many browser bots are red since they run the same test):
python tools/test.py -mrelease -cdart2js -rff --use-sdk --write-debug-log --write-test-outcome-log --clear_browser_cache --dart2js-batch -t60 html/custom_element_method_clash_test
python tools/test.py -mrelease -rdrt --use-sdk --write-debug-log --write-test-outcome-log --clear_browser_cache --checked -t240 try/web/incremental_compilation_update_test
TBR=asgerf@google.com
Review URL: https://codereview.chromium.org//917083003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43739 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 20:33:28 +00:00
abc37952d4
dart2js: Refactoring, documentation, and a few bugfixes in Namer class.
...
See long doc comment in namer.dart.
BUG=
R=floitsch@google.com
Committed: https://code.google.com/p/dart/source/detail?r=43588
Reverted: https://code.google.com/p/dart/source/detail?r=43590
Review URL: https://codereview.chromium.org//891673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43724 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 13:43:25 +00:00
4f0f538076
Let the CPS ir builder bail out when given a non-sync function.
...
BUG=
R=johnniwinther@google.com , karlklose@google.com
Review URL: https://codereview.chromium.org//912293004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43720 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 09:47:48 +00:00
4150b44a24
Fix checked-mode return for async-functions.
...
BUG= dartbug.com/22332
R=floitsch@google.com
Review URL: https://codereview.chromium.org//914143002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43719 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 09:35:44 +00:00
2cab6733b2
Fix test expectations for minified dart2dart
...
Review URL: https://codereview.chromium.org//918873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43709 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 00:51:15 +00:00
2f0d13af3b
Fix yield statements in catch blocks
...
This is a partial fix for issue 22300. The VM no longer setfaults when
using yield in try statements. Yield in catch blocks work. What’s still
not working right is if a value is yielded before an exception is
propagated to the caller.
R=regis@google.com
Review URL: https://codereview.chromium.org//914303006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43707 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 00:12:07 +00:00
f7a97fa4d4
VM: Fix slow-path deoptimization environment.
...
The number of pushed arguments needs to be accounted for.
BUG=dartbug.com/22331
R=vegorov@google.com
Review URL: https://codereview.chromium.org//914133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43681 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 13:34:15 +00:00
0c5709bd0e
Fix dart2dart status file.
...
BUG=
Review URL: https://codereview.chromium.org//918523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43676 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 08:04:18 +00:00
d7c763003d
Re-apply "Fix warning in sync_generator1_test.dart"
...
This re-applies commit 43626, which was reverted in 43628.
What happened: I accidentally tested r43626 against a work-in-progress
build of the Java-based dartanalyzer that contained r43655, so I
failed to update the status files properly. This resulted in a build
failure, which was addressed by reverting r43626. Now that r43655 has
landed, the build failure should not occur.
R=hausner@google.com
Review URL: https://codereview.chromium.org//910243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43666 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 20:32:41 +00:00
6ea61b5686
Partial backport of analyzer async/await fixes to Java.
...
Backport of r43613, r43537, r43446, r43427, r43424, r43418, r43403,
r43361 to the Java-based analyzer. The backport is partial in that
the TypeProvider was not modified to include Future and Stream types
(this would have required substantial additional effort), and
consequently not all static warnings are correctly produced. However,
all NonErrorResolverTest cases were successfully backported and pass,
meaning that the Java-based analyzer shouldn't produce false positive
warnings for async/await code anymore.
BUG=dartbug.com/22252
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//913623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43655 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 16:04:50 +00:00
18e885d1ea
Use a VariableUse instead of VariableDeclaration for left-hand side of
...
assignments.
BUG=dartbug.com/22328
R=floitsch@google.com
Review URL: https://codereview.chromium.org//909113002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43651 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 15:13:19 +00:00
1316fc65af
Fix test to work on js-shell by avoiding a periodic timer.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//913713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43650 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 15:10:25 +00:00
454602332b
Only schedule the execution of an async* when the stream is
...
subscribed to.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//902783008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43646 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 14:19:54 +00:00
a789f0db5f
Use a 0-length timer in async test to make jsshell happy.
...
BUG=
Review URL: https://codereview.chromium.org//915603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43636 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 11:30:49 +00:00
2f69ab27b9
Fix a mistake in a status-file
...
Fix async behaviour for a test-case.
BUG=
Review URL: https://codereview.chromium.org//894283003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43630 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 09:39:55 +00:00
9cc2d8892e
Revert "Fix warning in sync_generator1_test.dart"
...
This reverts commit 43626
This caused failures:
http://build.chromium.org/p/client.dart/builders/new_analyzer-linux-release-be/builds/11431/steps/tests%20/logs/stdio
TBR=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//911763003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43628 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 09:00:49 +00:00
04f95cdc66
Fix warning in sync_generator1_test.dart
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//897803003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43626 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 00:36:25 +00:00
22054b3119
Make yield* throw an error if not yielding an Iterable
...
Fixes issue 22323
R=gbracha@google.com
Review URL: https://codereview.chromium.org//910923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43616 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:47:12 +00:00
67889f0c72
Fix the build
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//910733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43606 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 19:07:06 +00:00
7267bd1d1e
Update status.
...
BUG=
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//871013009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43599 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 16:37:54 +00:00
9246054981
More status-updates to async-await related tests.
...
Plus a small test-update for better async behaviour.
BUG=
Review URL: https://codereview.chromium.org//907043002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43597 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 16:23:02 +00:00
c6a7d8782a
Status updates, and minor fixes to tests of async-await.
...
BUG=
Review URL: https://codereview.chromium.org//912513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43594 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 14:30:59 +00:00
7b0bc3d220
Implementation of async-await transformation on js ast.
...
BUG=
R=floitsch@google.com , johnniwinther@google.com
Review URL: https://codereview.chromium.org//839323003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43591 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 12:02:52 +00:00
f72a18378b
Revert "dart2js: Refactoring, documentation, and a few bugfixes in Namer class."
...
This reverts commit r43588.
BUG=
Review URL: https://codereview.chromium.org//906273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43590 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 11:58:07 +00:00
c767597da3
dart2js: Refactoring, documentation, and a few bugfixes in Namer class.
...
See long doc comment in namer.dart.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//891673003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43588 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 11:31:10 +00:00
c544068f6f
dart2js: add common names to mangledGlobalNames in new emitter.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//897013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43545 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 08:52:15 +00:00
48fbf3627b
Fix status file for dartium/dart
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//898143003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43532 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 23:54:29 +00:00
999a613f00
Fix dart2dart test expectations
...
Review URL: https://codereview.chromium.org//904763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43531 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 23:12:45 +00:00
2487c76886
Add support for sync* and yield and yield*
...
R=srdjan@google.com
Review URL: https://codereview.chromium.org//888463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43516 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 18:36:40 +00:00
7ef82b92ad
Fix async_test problems.
...
+ disallow async modifier on setters.
BUG=
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//898703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43465 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 12:41:49 +00:00
sigurdm@google.com