4c064caff6
- Remove empty section from status file.
...
Review URL: https://codereview.chromium.org//1047503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44773 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-28 09:37:42 +00:00
8244428e5f
Another attempt to fix the build
...
Review URL: https://codereview.chromium.org//1045463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44769 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-28 00:04:00 +00:00
931af74488
(TBR) Another attempt to fix the build
...
Review URL: https://codereview.chromium.org//1039843003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44767 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 23:54:14 +00:00
3734765897
Attempt to fix the build
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1041663004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44763 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 21:37:58 +00:00
dc602ae96d
Mark code when it instantiates an unloaded deferred type
...
The VM registers code objects that depend on deferred library prefixes,
e.g. when calling a function in the deferred library. We didn’t do this
when instantiating a type from the deferred library.
This is a fix for issue 22443.
R=regis@google.com
Review URL: https://codereview.chromium.org//1037343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44757 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 19:39:31 +00:00
cf4d11e049
Add a test for trimming leading whitespace in multiline strings
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1042523004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44755 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 19:28:15 +00:00
f5f536351d
Add check that no aggressive & incorrect optimizations is done.
...
R=sra@google.com
Review URL: https://codereview.chromium.org//1033873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44746 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 17:33:31 +00:00
726265c92c
Fix type annotation for deferred constants.
...
BUG=
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//1033213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44730 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 10:26:47 +00:00
05fcf8ad3f
Update test expectations for new dart2dart backend.
...
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//1035093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44729 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 09:23:40 +00:00
b073936fd0
Allow "dynamic" as a constant value in analyzer.
...
BUG=dartbug.com/22989
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1004353006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44723 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 21:50:44 +00:00
f138b4a849
Allow metadata on local functions
...
Fis issue 22126.
R=regis@google.com
Review URL: https://codereview.chromium.org//1034203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44717 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 18:28:38 +00:00
bbf2eef54b
Make analyzer happy
...
TBR
Review URL: https://codereview.chromium.org//1006033004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44705 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 00:01:36 +00:00
0229072d4d
Evaluate expression before NSM
...
When assigning an expression to a final variable, evaluate the
expression before throwing the NoSuchMethod error.
This fixes issue 22936.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1027383004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44700 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 21:45:12 +00:00
abcb6c7594
Fix dart2dart test status
...
Review URL: https://codereview.chromium.org//1031193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44692 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 18:33:29 +00:00
8c49660a7e
Make await for cancel the stream when breaking out of the loop
...
Wrap the await-for loop in a try-finally statement that ensures that
the stream is cancelled. Also adding the ability to the
AsyncStartStreamController class to return a cancellation future.
The cancel() call at the end of the await-for loop is not awaiting
the cancellation future yet. This is not part of the spec at this
point.
R=regis@google.com
Review URL: https://codereview.chromium.org//1014273003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44689 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:41:39 +00:00
fd41ebe4f6
Implement new flatten specification.
...
BUG=http://dartbug.com/22921
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1035443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44659 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 11:28:30 +00:00
ecdee95907
Separate is_debuggable and is_visible again. The outer async functions (that produce the Futures or Streams) should be visible but not debuggable. Visible so their frames are included in stacktraces for return type errors during checked mode. Not debuggable so breakpoints are resolved to the function that implements the async body.
...
BUG=http://dartbug.com/22891
R=hausner@google.com
Review URL: https://codereview.chromium.org//1033483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44646 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 20:26:05 +00:00
d34664956d
Don't skip flatten_test/04 now that issue 22922 is fixed.
...
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//1032503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44634 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 16:11:27 +00:00
b5b61adba8
Fix cancel behaviour of async* in dart2js.
...
Errors thrown in finallies after a cancel would be added to the stream
(and thus suppressed) instead they now complete the future returned from
cancel.
BUG= dartbug.com/22912
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1026743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44632 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 13:28:08 +00:00
94d30c2f27
Refactor IrBuilder to use SemanticVisitor.
...
BUG=
R=floitsch@google.com , karlklose@google.com
Review URL: https://codereview.chromium.org//1004683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44628 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 08:03:27 +00:00
4b1de421ac
Revert "Mark async and generator functions as debuggable, so their frames are visible for return type errors during checked mode."
...
This makes it impossible to set a breakpoint inside a async or generator body.
TBR=hausner@google.com
Review URL: https://codereview.chromium.org//1025633003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44615 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 22:01:56 +00:00
406270bf8d
Mark async and generator functions as debuggable, so their frames are visible for return type errors during checked mode.
...
BUG=http://dartbug.com/22891
R=asiva@google.com
Review URL: https://codereview.chromium.org//1025783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44614 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 21:50:14 +00:00
eb14f56b8e
Fix status file for flatten_test in dart2dart.
...
TBR=scheglov@google.com
Review URL: https://codereview.chromium.org//1025593003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44605 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 14:02:37 +00:00
c16fc96d58
Implement the new definition of flatten() from r44569 in analyzer.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1023903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44603 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 13:29:05 +00:00
847bd37ce0
Redo "Use an explicit 'this' parameter instead of 'This' nodes."
...
BUG=
Review URL: https://codereview.chromium.org//1021813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44599 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 10:10:58 +00:00
3783f349dc
Be less aggressive in sharing contexts between scopes so that sibling contexts
...
cannot appear in nested node sequences (issue 22858), since this case cannot
be handled by the graph builder.
Add assert to graph builder to detect such occurences (uncovered async* bug).
Fix an async* issue where a scope was mistakenly reused.
Improve ast printing for node sequences.
Add regression test.
R=hausner@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//1020893004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44592 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 22:39:46 +00:00
77e8e513fc
Revert "Use an explicit 'this' parameter instead of 'This' nodes."
...
Review URL: https://codereview.chromium.org//1018403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44581 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 18:01:02 +00:00
a553590de4
Use an explicit 'this' parameter instead of 'This' nodes.
...
An explicit parameter makes it possible to visit all uses of 'this', for example, to change to a calling convention where the receiver is passed as an explicit argument.
R=asgerf@google.com
Review URL: https://codereview.chromium.org//1011383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44578 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 17:09:20 +00:00
d96262f4f1
Update staus file after -r44558
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1016033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44559 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 15:03:31 +00:00
25e11e6b29
Fix renaming of exception variables on left-hand-sides.
...
Also fix compound assignments.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1012783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44558 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 14:04:41 +00:00
745b6809e9
Update test status for flaky tests.
...
BUG=dartbug.com/22695, dartbug.com/22896
R=ricow@google.com
Review URL: https://codereview.chromium.org//1019463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44557 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 12:45:50 +00:00
a0d3c701ed
Add tests for constants from deferred loaded libraries being readable.
...
The spec says that the constant declarations accessed through a deferred prefix
are not compile time constant expressions, but they should still be accessible
as normal expressions.
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//1014023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44554 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 10:35:51 +00:00
c3418f1e63
Fix issue 22875
...
Allocate temp variables of let nodes in the async temp scope
instead of the preamble.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1017753003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44547 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 23:49:05 +00:00
b29b0d0bf7
Test that catch variables are marked as final.
...
See new test cases language/try_catch_on_synatx_test/10 and language/try_catch_on_synatx_test/11.
Dart2js fails the test. Issue 19823.
Review URL: https://codereview.chromium.org//1013933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44537 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 15:46:04 +00:00
963895af0a
Fix for issue 22780 - print the stack trace on OOM and Stack overflow exceptions too.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//1015513006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44528 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 23:32:22 +00:00
ada21bfda6
Fix do-while with await in condition
...
The await “preamble” code must be part of the expression,
not part of the body.
Fixes issue 22777
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1012933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44520 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 19:57:28 +00:00
3f8c12c425
Fix problems with async* and await for in dart2js.
...
The ssa backend would generate incorrect code for await for.
Async* finalizers would not be run when a paused stream is canceled.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1012623003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44503 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 14:10:29 +00:00
ac29738460
Fix "continue to a label" in dart2js async code.
...
Actually there were two independent problems
1: continue would jump to the starting point of the label, instead of
the continue-point of the labelled loop.
2: A for-initializer with no awaits in the for would still get its
variables hoisted, so
label: for(var i = 1; i < 10; i++) {continue label};
would transform to:
label: {
i = 1
for(; i < 10; i++) {continue label;}
}
And that fails.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//1003213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44499 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 08:45:47 +00:00
a7b1765187
Fix restoring of contexts in inlined finally code
...
When inlining code from a finally block before return or jump
instructions, do not restore the saved_try_context since the
inlined code is running in the context of the return or
jump instruction.
This is an old bug that surfaced in async code, since async code
deals with captured variables (contexts) much more than regular
code.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1006463003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44465 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 15:53:03 +00:00
2c741eed10
Fix annotations in async_and_or_test.dart.
...
TBR=sigurdm@google.com
Review URL: https://codereview.chromium.org//1008833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44461 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 13:09:16 +00:00
5bf38f9c59
Fix handling of lazy and and or in async functions.
...
The two were interchanged.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//996103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44456 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 12:11:21 +00:00
d95886b484
Make sure to bind a method to its receiver if it is stored in a temporary.
...
Otherwise `this` is not bound when the temprary is invoked.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//972063003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44449 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 08:21:48 +00:00
b232f6d070
Fix issue 22800: Unreachable exception handlers do not have their handler types initialized. Initialize the handler info for unreachable handlers as well (instead of crashing).
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//1002933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44440 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 19:18:18 +00:00
c8680b6a22
Mark tests that crashes in host-checked mode
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//998323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44433 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 15:25:57 +00:00
12df8d5bfb
Remove a test that is incredibly flaky on some platforms.
...
I have an improved version in another CL, but it found a bug in dart2js, so I'll delay committing until the bug's fixed.
Review URL: https://codereview.chromium.org//1000083003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44430 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 15:16:09 +00:00
2e087f8405
Test can fail in more than one way.
...
Review URL: https://codereview.chromium.org//997113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44403 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 15:08:06 +00:00
5976f93275
Support @NoInline for constructor bodies.
...
BUG=
R=floitsch@google.com , johnniwinther@google.com
Review URL: https://codereview.chromium.org//987393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44402 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 14:15:07 +00:00
90da3af92b
More status file updates for async tests.
...
Review URL: https://codereview.chromium.org//999633005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44398 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 11:50:19 +00:00
e697574eed
Don't do assert-based tests unless in checked mode.
...
Review URL: https://codereview.chromium.org//1001453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44396 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 10:52:08 +00:00
bddb668174
Add some async/await tests.
...
R=sgjesse@google.com , sigurdm@google.com
Committed: https://code.google.com/p/dart/source/detail?r=44368
Review URL: https://codereview.chromium.org//968963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44395 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 10:15:59 +00:00
iposva@google.com