bd90a024dc
Fix status file again
...
TBR=sra@google.com
Review-Url: https://codereview.chromium.org/2835933006 .
2017-04-24 15:21:11 -07:00
a60f823f1b
Adjust dart2js status for mixin_type_parameter6_test
...
TBR=sra1@google.com
Review-Url: https://codereview.chromium.org/2835333002 .
2017-04-24 13:28:10 -07:00
2fb5d08102
Spelling a
...
R=ahe@google.com
BUG=
Review-Url: https://codereview.chromium.org/2841543002 .
2017-04-24 14:53:51 +02:00
d977156d90
Mark dart2js test as failing.
...
BUG= http://dartbug.com/29441
Review-Url: https://codereview.chromium.org/2836813003 .
2017-04-24 11:07:58 +02:00
4c0757521d
Update status files for dart2js and analyzer (2 issues filed).
...
Review-Url: https://codereview.chromium.org/2829283002 .
2017-04-21 10:15:10 -07:00
3f6d4ec1eb
Use trail in type tests involving the call function ( fixes #29405 ).
...
Add regression test.
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2831073004 .
2017-04-21 09:14:24 -07:00
4b9bba55b4
Stoppp using trippple consonants
...
R=ahe@google.com
BUG=
Review-Url: https://codereview.chromium.org/2833073002 .
2017-04-21 17:50:13 +02:00
f7610b74b1
Update status files after adding dart2js-d8-kernel tests on buildbot
...
Review-Url: https://codereview.chromium.org/2834023002 .
2017-04-21 12:15:50 +02:00
8420947265
Update status file for debug mode.
...
Review-Url: https://codereview.chromium.org/2828273002 .
2017-04-20 13:15:12 +02:00
e2eee219ac
Complain about incorrect this/super constructor initializers.
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2800083002 .
2017-04-20 10:04:12 +02:00
cf6b2736ec
Wrap VariableDeclarations in Blocks as specified by Kernel.
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2801283002 .
2017-04-20 09:31:36 +02:00
74686b9f66
Update status file for dartk (for function_type tests)
...
Review-Url: https://codereview.chromium.org/2827023002 .
2017-04-19 16:19:41 +02:00
1c355af468
Add generated function_type tests.
...
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2707033004 .
2017-04-19 15:56:47 +02:00
6bd0085ec1
Throw isn't a constant expression.
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2801873008 .
2017-04-19 15:55:05 +02:00
e534a45cec
Handle bad rethrows.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2802203002 .
2017-04-19 15:17:10 +02:00
ba0e07846f
Produce a compile-time error if there's no main method.
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2801853006 .
2017-04-19 14:28:10 +02:00
4dd686e9df
More work on finalization of recursive types ( fixes #29357 ).
...
Add regression test.
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2822323002 .
2017-04-18 17:18:39 -07:00
b7995140f8
Revert "Fix #28740 demangle constructors in stack traces (A.A becomes new A)."
...
This reverts commit a84b6b7f7bhttps://codereview.chromium.org/2824323002 .
2017-04-18 16:48:33 -07:00
a84b6b7f7b
Fix #28740 demangle constructors in stack traces (A.A becomes new A).
...
Regular constructors and unnamed factory constructors:
- Were A.A, now are new A
Named constructors (including factory constructors):
- Were A.A.name, now are new A.name
BUG=
R=asiva@google.com , rmacnak@google.com
Review-Url: https://codereview.chromium.org/2818933003 .
2017-04-18 15:18:29 -07:00
b15cf1c490
Fix VM crash when encountering an assignment expression in a case expression.
...
Fixes #29370
Issue #29379
R=regis@google.com
Review-Url: https://codereview.chromium.org/2825843003 .
2017-04-18 13:48:06 -07:00
8f563f2c32
VM: Prohibit reload when throwing or processing language errors.
...
This fixes flaky crashes on negative tests in stress reload mode: when
we attempt to reload an isolate while throwing/formatting compile time error.
Fixes https://github.com/dart-lang/sdk/issues/27835
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2825043002 .
2017-04-18 18:51:49 +02:00
be6d22e015
Roll back files where the formatter made non-whitespace changes.
...
This is due to a bug in how the formatter handled generic functions.
BUG=
Review-Url: https://codereview.chromium.org/2822103002 .
2017-04-17 22:12:57 -07:00
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
62320cc838
Issue 25558. Report an error, but don't crash when AST it too deep.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25558
Review-Url: https://codereview.chromium.org/2823993002 .
2017-04-17 14:46:55 -07:00
024ccd3095
Mark language/vm/optimized_stacktrace_test slow on reload bots
...
BUG=
Review-Url: https://codereview.chromium.org/2814743008 .
2017-04-12 15:15:11 -07:00
54f845cfd2
Support for generic function as type arguments in DeclarationResolver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2814223002 .
2017-04-12 13:47:23 -07:00
25dbc9b28a
Fix look-ahead parsing code in the VM ( fixes #29243 ).
...
Add regression test.
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2812323002 .
2017-04-12 11:04:21 -07:00
7b5010d440
[Gardening] Mark regress_29025_test as crashing in precompiled-debug
...
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2817683002 .
2017-04-12 16:12:13 +02:00
659511d518
Fix type parameter invocation in the VM ( fixes #19725 ).
...
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2814833003 .
2017-04-11 13:31:30 -07:00
54784f1cdc
Fix bad status file modification. Tests are still failing in kernel debug mode.
...
Review-Url: https://codereview.chromium.org/2806353004 .
2017-04-10 14:50:00 -07:00
8ca244ba27
Make finalization of recursive function types more robust, especially since
...
the Kernel frontend may omit the information that a function type is a typedef.
Re-enable several previously failing tests for dartk.
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2806893002 .
2017-04-10 11:06:14 -07:00
1e70fef1a2
Small steps towards deferred loading.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2803833003 .
2017-04-07 12:23:35 +02:00
b87f7ece72
Mark 2 tests as crashing in dartk debug mode.
...
Review-Url: https://codereview.chromium.org/2800043002 .
2017-04-06 18:04:12 -07:00
427ccea1b2
Test can pass if minification accidentally picks same name
...
Ideally, we should make all tests that use x.runtimeType.toString() use classes with longer names.
BUG=
Review-Url: https://codereview.chromium.org/2798263004 .
2017-04-06 17:33:32 -07:00
32e2d2af84
Handle const list and map literals.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2802693004 .
2017-04-06 14:51:35 +02:00
f36aaa72a8
dart2js: make dominator tree traversals nonrecursive
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2799603003 .
2017-04-05 13:13:31 -07:00
b06e4d5754
Create separate scopes for constructors, setters, and other members.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2788153002 .
2017-04-05 16:07:32 +02:00
167c7243c2
many_method_calls_test sometimes passes.
...
Review-Url: https://codereview.chromium.org/2796373002 .
2017-04-05 15:03:02 +02:00
6ce24eeb23
Update dart2js status
...
Some tests no longer crash after removing recursion.
TBR=efortuna@google.com
BUG=
Review-Url: https://codereview.chromium.org/2800593002 .
2017-04-04 20:10:06 -07:00
a0b58622d7
Handle unresolved identifiers with an accessor.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2790743004 .
2017-04-04 12:43:21 +02:00
4827ac4f38
Remove references to renamed test.
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2790893002 .
2017-04-04 09:51:29 +02:00
a2e79d87cd
Fix typo in bug number.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2784133003 .
2017-04-04 09:50:15 +02:00
2155fb6f6c
Update status for Dartium.
...
Review-Url: https://codereview.chromium.org/2795973002 .
2017-04-04 09:31:51 +02:00
2b27805f07
Change test to match issue 19725.
...
R=johnniwinther@google.com , regis@google.com , vegorov@google.com
Review-Url: https://codereview.chromium.org/2781273003 .
2017-04-04 08:20:17 +02:00
c53e020e6c
Adjust status files to account for running the Dart test cases through flutter engine on linux.
...
Accounted for language, co19, lib, corelib, isolate and standalone tests.
Filed issues to track all failing tests
https://github.com/flutter/flutter/issues/9109
https://github.com/flutter/flutter/issues/9110
https://github.com/flutter/flutter/issues/9111
https://github.com/flutter/flutter/issues/9113
https://github.com/flutter/flutter/issues/9114
https://github.com/flutter/flutter/issues/9115
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2784293003 .
2017-04-03 16:35:09 -07:00
d8e291cb89
[kernel] vm: Fix a few issues in the kernel flow graph builder, update status file for checked-mode
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2792033002 .
2017-04-03 19:47:01 +02:00
41b5d7c6de
VM: Fix incorrect canonicalization rule for UnboxedIntConverterInstr.
...
The rule assumed that `UnboxedIntConverter(U->V, UnboxedIntConverter(V->U, v))` is
equal to `v` which is incorrect if the first convertion is truncating and
V is a larger representation (Mint) than U (Int32 or Uint32).
Now canonicalization rule takes into account if the first convertion is
truncating and does not try to short-circuit such convertions.
Fixes https://github.com/dart-lang/sdk/issues/29137
R=kustermann@google.com
BUG=http://dartbug.com/29137
Review-Url: https://codereview.chromium.org/2793003002 .
2017-04-03 18:51:04 +02:00
80b43ff15c
Reland "VM: Handle null-comparisons in the flow graph type propagation"
...
This reverts commit ee452a8600https://codereview.chromium.org/2772143002/
Additional bug fix: Correctly replace ToCid with ToNullableCid in
RedefinitionInstr::ComputeType.
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2789943002 .
2017-03-31 15:39:01 -07:00
761d21d414
Fix #14144 confusing error message misusing a callable object
...
New tests to make sure that:
* Error message calling a closure wrong is unchanged
* Error message calling a static function wrong is unchanged
* Error message calling a callable object wrong is unchanged
* Error message calling nonexist method is unchanged
* Error message calling nonexist method for a callable object is clearer
The new tests involving calling a closure wrong exposed a bug in the
inliner, it assumed (due to lack of ic data, it seems) that all closures
have the right number of arguments. Left that assertion/behavior, but
put a guard around closures specifically (since static and method calls
don't have that bug, due to I think better ic data).
Welcoming myself to the world of VMs.
BUG=
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2785623004 .
2017-03-31 15:09:02 -07:00
ee452a8600
Revert "Reland "VM: Handle null-comparisons in the flow graph type propagation""
...
This reverts commit e7afde47e9TBR=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2794583002 .
2017-03-31 10:53:56 -07:00
Sigmund Cherem