dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

5559 Commits

Author SHA1 Message Date
Ryan Macnak c15f6f8d94 Mark language/closure_cycles_test as slow on the arm64 bot. 
Review-Url: https://codereview.chromium.org/2945913002 .
 2017-06-19 14:08:21 -07:00
Ben Konyi 510c3f02ba Fixed language_analyzer2.status file to skip test until issue 29657 is resolved. 
BUG=

Review-Url: https://codereview.chromium.org/2950593002 .
 2017-06-19 13:36:18 -07:00
Ben Konyi 2cdfc0cdab Updated co19 status file to skip initializing_formals_execution_t02 until it is updated to expect a compilation error when trying to reinitialize a final field: https://github.com/dart-lang/co19/issues/114. 
BUG=

Review-Url: https://codereview.chromium.org/2944073002 .
 2017-06-19 13:14:03 -07:00
Ben Konyi b5cff3f68f Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658. 
BUG=
R=asiva@google.com

Example:
Foo {
  final int x = 10;
  Foo(this.x); // Error
  Foo.named() : x = 42; // Error
}
Review-Url: https://codereview.chromium.org/2939553005 .
 2017-06-19 12:07:37 -07:00
Ryan Macnak 72e1775fd1 [arm, arm64] Implemented unaligned scalar float access. 
[arm64] Fix unaligned (u)int64 stores.

Fix unaligned access test to use host endianness.

Issue #22151

R=zra@google.com

Review-Url: https://codereview.chromium.org/2940883008 .
 2017-06-19 10:28:38 -07:00
Johnni Winther 787fb75fc0 Fix dart2js-with-kernel status 
Review-Url: https://codereview.chromium.org/2939323002 .
 2017-06-16 16:32:23 +02:00
Jens Johansen 0a1583aa04 [kernel] Fix assert message. 
This mimics the behaviour of the source-based pipeline,
i.e. instead of "manually" calling _AssertionError._create and giving
the correct parameters (wrong parameters, actually), use the helper
method _AssertionError.ThrowNew.

BUG=
R=ahe@google.com, vegorov@google.com

Review-Url: https://codereview.chromium.org/2940283002 .
 2017-06-16 12:28:18 +02:00
Siva Annamalai 5e7bc9f162 Adjust status file for issue 29895 
BUG=

Review-Url: https://codereview.chromium.org/2941183002 .
 2017-06-15 16:42:28 -07:00
Siva Annamalai 114ac0bbd9 Fix status files for issue 29895 
BUG=

Review-Url: https://codereview.chromium.org/2943463003 .
 2017-06-15 11:27:19 -07:00
Jens Johansen dc72d9c34e Update language_kernel.status for closed issue. 
BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2940073002 .
 2017-06-15 13:41:13 +02:00
Peter von der Ahé 6302a5b31b Implement metadata on classes and additional semantic checks. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2938793002 .
 2017-06-14 14:59:53 +02:00
Peter von der Ahé 5f3fd3060b Restore status file comment. 
R=jensj@google.com

Review-Url: https://codereview.chromium.org/2939713002 .
 2017-06-14 08:31:37 +02:00
Peter von der Ahé 3c17c44d52 Implement metadata on methods and fields. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2935993002 .
 2017-06-14 08:25:17 +02:00
Emily Fortuna 0753ac689e Handle named mixin application in emitter 
Fixes regression in language/regress_18713_test with --csp

Closes #29844
Closes #29843

This reapplies Johnni's change from here: https://codereview.chromium.org/2934783002/

I am submitting it instead of Johnni because without this change we are blocking the new dart update internally in Google.
BUG=
TBR

Review-Url: https://codereview.chromium.org/2936063002 .
 2017-06-13 14:23:20 -07:00
Peter von der Ahé db2e915aac Improve recovery from compile-time errors. 
R=danrubel@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2938573002 .
 2017-06-13 16:00:15 +02:00
Peter von der Ahé d920dacad8 Fix typo in test. 
Closes https://github.com/dart-lang/sdk/issues/11545

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2939683003 .
 2017-06-13 15:58:27 +02:00
Karl Klose d1f6e1ca26 [Gardening] Update expectation of language/regress18713 on dart2js-csp-fast_startup 
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2939693003 .
 2017-06-13 12:48:13 +02:00
Peter von der Ahé 5b04ff8155 Update status file for dart2js with kernel. 
Review-Url: https://codereview.chromium.org/2940613002 .
 2017-06-13 11:51:59 +02:00
Jens Johansen 76336b225f [kernel] Streaming ScopeBuilder 
The old ScopeBuilder is replaced with StreamingScopeBuilder
that does not use the Ast.

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2886873008 .
 2017-06-13 11:39:31 +02:00
Peter von der Ahé ea30fb6a0d Follow-up to CLs 2933723002 and 2932973003. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2933813002 .
 2017-06-13 09:45:41 +02:00
Peter von der Ahé a78250d931 Support metadata on local variables. 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2936503002 .
 2017-06-13 09:15:54 +02:00
Peter von der Ahé 092ef81f95 Complain about cyclic typedefs. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2931303002 .
 2017-06-13 09:13:23 +02:00
Peter von der Ahé 8da7993d63 Attempt to instantiate an enum class is a compile-time error. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2935593002 .
 2017-06-13 09:12:51 +02:00
Peter von der Ahé f559a6d1e9 Throw NSM on unresolved factory redirection. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2933733002 .
 2017-06-13 09:12:20 +02:00
Bob Nystrom e5263f0c40 Removed uses of removed negated status variables. 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2935883002 .
 2017-06-12 16:04:18 -07:00
Peter von der Ahé d8783acfb3 Revert "Handle named mixin application in emitter" 
This reverts commit d109fad7f3.

Also, update status and ignore strong mode warning.

R=erikcorry@google.com

Review-Url: https://codereview.chromium.org/2933093002 .
 2017-06-12 14:21:34 +02:00
Peter von der Ahé 080a25f3a6 Various semantic checks on field initializers. 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2929383002 .
 2017-06-12 11:15:49 +02:00
Peter von der Ahé 2867303232 Various issues with duplicated names. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2934713002 .
 2017-06-12 11:11:45 +02:00
Peter von der Ahé 0c7d657333 Complain about duplicated defer. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2933723002 .
 2017-06-12 10:33:40 +02:00
Peter von der Ahé 35d77460e4 Various semantic checks regarding const and final. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2932973003 .
 2017-06-12 10:27:22 +02:00
Johnni Winther 44258bc8eb Support field initializers and static/top-level fields in compile_with_dill_test 
+ a String literal!

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2931153002 .
 2017-06-12 10:01:25 +02:00
Peter von der Ahé 96e494d534 Complain about external methods with a body. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2930093002 .
 2017-06-10 10:13:04 +02:00
Peter von der Ahé 043c0096ad Complain about use before declaration. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2924423003 .
 2017-06-10 10:12:18 +02:00
Peter von der Ahé dcbac2be00 Complain about incorrect use of null-aware operations. 
R=danrubel@google.com, johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2932723003 .
 2017-06-10 10:11:36 +02:00
Peter von der Ahé fd9716fa95 Various semantic checks on formal parameters. 
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2926953004 .
 2017-06-10 10:10:07 +02:00
Paul Berry 8f5bcddc31 Implement type inference for assignments to a static variable. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2933643002 .
 2017-06-09 17:36:20 -07:00
Paul Berry 029771d746 Add type inference for complex assignments whose LHS is an index expression. 
In later CLs I will expand on this code to handle other kinds of
complex assignments.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2926763003 .
 2017-06-08 09:25:24 -07:00
Peter von der Ahé f73e2ecf28 Clean up status files. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2928903002 .
 2017-06-08 13:50:30 +02:00
Peter von der Ahé 001ac97389 Implement initializer asserts. 
Closes https://github.com/dart-lang/sdk/issues/29762

R=kasperl@google.com

Review-Url: https://codereview.chromium.org/2930673002 .
 2017-06-08 13:46:26 +02:00
Peter von der Ahé ba345471d5 Update status files for debug mode. 
Review-Url: https://codereview.chromium.org/2928703003 .
 2017-06-07 15:04:56 +02:00
Peter von der Ahé c4a8b146e0 Semantic checks on switch cases and fall-through errors. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2926533004 .
 2017-06-07 11:26:34 +02:00
Peter von der Ahé d6a766bb14 Improve NSM handling. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2927613002 .
 2017-06-07 09:28:13 +02:00
Peter von der Ahé 470127ae46 Setup correct scope for initializers and complain about fields initialized more than once. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2916333002 .
 2017-06-06 19:35:35 +02:00
Johnni Winther 872a50cc2f Compute constants from IR nodes 
+ skip generateCodeWithCompileTimeErrors:
    KernelAstAdapter cannot handle all ConstantExpression for erroneous code
+ allow runtime-error in language/final_syntax_test/none:
    Constantifier currently don's support non-cyclic reference of final fields as constant expressions

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2916393002 .
 2017-06-02 22:03:46 +02:00
Peter von der Ahé cbcb7d4885 Clean up handling of types. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2915933004 .
 2017-06-02 14:53:20 +02:00
Peter von der Ahé 696f00d96b Implement library access restrictions and privacy. 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2916863003 .
 2017-06-02 13:13:38 +02:00
Kevin Millikin 1624c4f9c3 Kernel/VM: Set the instantiator type arguments on closures 
If a closure has uninstantiated type arguments from the enclosing
class, set them on the freshly allocated closure.

Closes issue #29409.

BUG=https://github.com/dart-lang/sdk/issues/29409
R=kustermann@google.com, regis@google.com

Review-Url: https://codereview.chromium.org/2912393004 .
 2017-06-02 11:44:15 +02:00
Lasse R.H. Nielsen 5720e3556c Add negation to single-identifier tests in status files. 
Optimize some regegps too.

Fixes #29756

BUG= http://dartbug.com/29756
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2913963002 .
 2017-06-02 10:38:14 +02:00
Sigmund Cherem 7affe8f0e5 update .status file once more: move dartk condition to the _kernel.status file. 
R=ahe@google.com, efortuna@google.com

Review-Url: https://codereview.chromium.org/2918653005 .
 2017-06-01 11:18:13 -07:00
Sigmund Cherem 77449584d0 Fix .status again. This is just embarrasing. 
BUG=

Review-Url: https://codereview.chromium.org/2919603003 .
 2017-05-31 17:07:08 -07:00