dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

5559 Commits

Author SHA1 Message Date
Robert Nystrom 1c64138e56 Migrate language_2/bool to NNBD. 
Change-Id: Id061ea5cb02e6fbac7430df95dc88786ce281363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137721
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-03-05 18:15:39 +00:00
Liam Appelbe bd6899269e [vm] Handle required params in closures and tear-offs 
I planned to make this conditional on function_.IsClosureFunction, but
the Goto is so trivial that there's no harm in doing this for all
required params (in fact it actually shrinks the prologue size).

Fixes: https://github.com/dart-lang/sdk/issues/39660
Fixes: https://github.com/dart-lang/sdk/issues/38843
Change-Id: I8e4db906ae709778d76c6b81524e45377266e32b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138328
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2020-03-04 20:57:26 +00:00
Liam Appelbe 149b799ae4 [vm] Check required flag during function resolution. 
Bug: https://github.com/dart-lang/sdk/issues/39660
Bug: https://github.com/dart-lang/sdk/issues/38843
Change-Id: I2eb5f5ac38d7b1896db5c57399c42cdb41b16094
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137737
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2020-03-02 23:05:16 +00:00
Robert Nystrom 434f7228bf Make parameter required to fix nullability error. 
It is only used in one place and is always passed.

Change-Id: I8bdc46963ee9e10591edb951dc72e065ba5678cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137760
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-02-28 01:43:01 +00:00
Robert Nystrom 16f072c783 Migrate language_2/async to NNBD. 
Change-Id: Id66e712eaf52fda2069ce5177aa091e373ad52c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134244
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-02-27 23:04:03 +00:00
Régis Crelier 21bc1ed76c [VM/nnbd] Allow instantiation of a non-nullable type parameter to a nullable type. 
Change-Id: Icc3413cd5c285fa40ee5188f39837625d78b9e67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137427
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-02-27 19:48:23 +00:00
Alexander Markov 77e1c72d04 [vm/nnbd] Type testing stubs in NNBD strong mode 
Issue: https://github.com/dart-lang/sdk/issues/38845
Change-Id: I82e7a1b3c4220abdd2a215529230fbb158adbe9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135627
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2020-02-27 04:36:24 +00:00
Mark Zhou 781cd94279 [tests] Adding test for recursive legacy class type bounds. 
See fix: https://dart-review.googlesource.com/c/sdk/+/136724

Change-Id: I85b005898579c1c6fe6904e590e13cc20f754fee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136820
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-02-27 00:06:20 +00:00
Mark Zhou 36cc80d576 [tests] Adding runtime tests for required named arguments. 
Change-Id: I1c76fa279c8c3572b48f5eb58eff53f703baca6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124106
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-02-27 00:06:14 +00:00
Konstantin Shcheglov 0c7b9cf470 Issue 40764. Use Never instead of Null when converting super-bounded to regular-bounded. 
Bug: https://github.com/dart-lang/sdk/issues/40764
Change-Id: I58f0e9860dd000aa2d8e416c5fce7e8964db0ef8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137280
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-02-26 20:12:51 +00:00
Liam Appelbe 05d2586099 [nnbd] Fix analyser error in required params test 
Bug: https://github.com/dart-lang/sdk/issues/40781
Change-Id: Id5eefd844ac80c48b8558ead859adb451eb9fcb4
Fixes: https://github.com/dart-lang/sdk/issues/40781
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137320
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2020-02-26 17:43:27 +00:00
Liam Appelbe 9e03c2c506 [vm] Add required flag to parameters, and implement subtyping rules. 
This CL only covers AST mode, and doesn't address function resolution.

Bug: https://github.com/dart-lang/sdk/issues/39755
Change-Id: I19280fb0d373aa9eb17da13677fd5bb1230385da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131701
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2020-02-26 00:38:54 +00:00
Régis Crelier d10ffdb4c3 [VM/nnbd] Check nullability of function types in strong mode (fixes #39820). 
Also added "// Requirements=nnbd-strong" to test (correctly fails in weak mode).

Change-Id: If375b912b03c50cf968fcc45bd78be3d9bc1cb33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137241
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-02-26 00:05:53 +00:00
Alexander Markov 3bd8e36bea [tests/nnbd] Fix language/async_star/throw_in_catch_test 
Fixes a compile-time error which was introduced during migration.

Change-Id: Id2b44f11481c354c76cd216cbd3190703ed968f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137200
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-02-25 22:47:43 +00:00
Konstantin Shcheglov 550ac009b3 Update tests expectations with DEAD_NULL_AWARE_EXPRESSION. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I26f585c5ea4ec872d574a8bcd09226b8d1a1cc0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-25 21:21:16 +00:00
Nicholas Shahan 9d1b5ced65 [dartdevc] Update instantiated type arguments in tear-offs 
They now become a `Object*` or `Object?` if the library where the method
is defined is legacy or null safe.

Change-Id: Ia3de0d728187b9c5bf64cc8c08aa075e63aff942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136723
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-02-22 00:34:21 +00:00
Nicholas Shahan a47b9996c8 [tests] Add tests for function type equality with Null Safety 
Change-Id: I85d9764aee2f6260267ad7b499b2c138ffcc4501
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135533
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-02-21 19:59:11 +00:00
Lasse R.H. Nielsen 98b4635aa9 Make TypeError no longer implement AssertionError. 
This means that TypeError no longer inherits a spurious `message` member.
The message of a platform-thrown TypeError is still available as `toString()`.

Fixes #40317

Bug: http://dartbug.com/40317
Change-Id: I77312859ebae3f92c2e56aeea6283b075b71c8d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136129
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-02-21 14:02:57 +00:00
Robert Nystrom b81f12a549 Migrate language_2/async_star to NNBD. 
Change-Id: I0fa2ee2561dd0bc399d88868d790d56e6df3c94d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134940
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2020-02-21 00:22:06 +00:00
Konstantin Shcheglov 303992f7a7 Don't report StrongModeCode.INVALID_CAST_* for NNBD libraries. 
Change-Id: I87e0a2cbeb1365a5facd48c154ff0986c857fabe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-18 17:35:54 +00:00
Konstantin Shcheglov ed705e8c84 Move DEAD_NULL_COALESCE reporting to ErrorVerifier. 
So, it is reported even when hints are disabled.

Change-Id: Id2df8faa5421fac00e01755a70aedf3d3f570f10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135492
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-13 19:42:48 +00:00
Robert Nystrom 86f8e3438a Migrate language_2/async_nested to NNBD. 
Change-Id: I16f1be4e17fa87aa94b294f281dfe14ea0129eb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134904
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-02-12 20:46:37 +00:00
Nicholas Shahan 69d481065b [tests] Add tests for generic function type bounds with null safety 
Testing that type arguments bounded by legacy types are equivalent
with nullable and non-nullable versions of the same types.

Re-landing this change with preapprovals for the VM configurations that
failed the last time.

Change-Id: Ic1709033dc3f3d9d7fc08357c0ad29bf976ed06b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134867
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-02-11 22:31:55 +00:00
Robert Nystrom 688801cb27 Migrate language_2/assert to NNBD. 
Change-Id: I4daa09afa52f76076374591b3e3f3420a46b169b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134240
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-02-06 22:47:25 +00:00
Lasse R.H. Nielsen 3a36439abe Tests for language operators and constructs with (non-)nullable operands. 
Test that the NNBD implementation does not allow a nullable expression
where a non-null value is expected for language constructs.

Similarly that null-aware operations used on non=-nullable values
are caught.

Change-Id: I877e9b464666698b7f25b355b0474eb171bfc4b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134160
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-02-05 10:00:27 +00:00
Nicholas Shahan f831f121d7 Revert "[tests] Add tests for generic function type bounds with null safety" 
This reverts commit 21535e540f.

Reason for revert: VM test bots are failing and the approval system is down so I can't turn them green again. Reverting until I can approve the failures.

Original change's description:
> [tests] Add tests for generic function type bounds with null safety
> 
> Testing that type arguments bounded by legacy types are equivalent
> with nullable and non-nullable versions of the same types.
> 
> Change-Id: Ibd1166af68a74041920940789464cbb8afb091ec
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132969
> Commit-Queue: Nicholas Shahan <nshahan@google.com>
> Reviewed-by: Bob Nystrom <rnystrom@google.com>
> Reviewed-by: Erik Ernst <eernst@google.com>

TBR=leafp@google.com,rnystrom@google.com,eernst@google.com,nshahan@google.com

Change-Id: Iad45fcd1498bdd46bfb908cd40df7ca38ef47d2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134461
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-02-05 00:58:27 +00:00
Nicholas Shahan 21535e540f [tests] Add tests for generic function type bounds with null safety 
Testing that type arguments bounded by legacy types are equivalent
with nullable and non-nullable versions of the same types.

Change-Id: Ibd1166af68a74041920940789464cbb8afb091ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132969
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-02-04 22:37:35 +00:00
Erik Ernst 3fb7f6a724 Adjusted language/assign/to_type_test.dart to avoid irrelevant 
nnbd type error.

By the way, I don't understand why the trybots didn't complain about
this, all trybots were green when
https://dart-review.googlesource.com/c/sdk/+/134224 was auto-submitted.

Change-Id: Id410fc18e9ebf9be6c180740067857e2309f47ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134291
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Erik Ernst <eernst@google.com>
 2020-02-04 22:04:40 +00:00
Robert Nystrom 68e904e444 Migrate language_2/abstract to NNBD. 
Change-Id: I265933f36f68df6f8e542a3f85ce0b04e1dfd549
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134205
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-02-04 18:57:26 +00:00
Liam Appelbe a793c36c77 [test] Run late field tests in optimised mode 
Fix the tests by disabling the optimisation that turns getter calls into
raw gets if the field is late, and by calling recording the null init
store in bytecode mode.

Change-Id: I8f12e3237cd32c890b5cef8d00c32940e937330d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134180
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-02-04 16:51:38 +00:00
Robert Nystrom c5cba24124 Migrate language_2/argument to NNBD. 
Change-Id: Ic1963eb1962bc1341a68783e9c44f3e04bfbc43a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134223
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-02-04 15:07:11 +00:00
Robert Nystrom 3414b51675 Migrate language_2/assign to NNBD. 
Change-Id: I71947bc5726f168fc036a7fece8a3b6b7bf964f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134224
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-02-04 10:37:43 +00:00
Robert Nystrom 56ca547c8c Migrate language_2/accessor_conflict to NNBD. 
Change-Id: I136befc5fa77bfa2a118f9bd032250abcde2da68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134222
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-02-04 09:52:03 +00:00
Nicholas Shahan 703bc0086d [tests] Create null is T tests in legacy and null safe libraries 
Change-Id: I2054b6da8b66e7c6de81d9fb18fdc1c264db376c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132420
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-02-03 23:12:02 +00:00
Johnni Winther 8991dc33d2 Fix language/operator/invalid_operators_test 
Closes #40415

Change-Id: If179bc6802e6193aea4c011d889f9ecbfa3020b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133993
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-02-03 13:35:15 +00:00
Mayank Patke ed441e48d0 Update all Slow tests to be Slow, Pass. 
Change-Id: I610b272355b045eab80cf941210774fb12d775eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134103
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2020-02-01 00:17:42 +00:00
Johnni Winther 42246f7f96 [cfe,analyzer] Disallow type parameters on operator methods 
This was never supported by the grammar but unfortunately allowed by
both the analyzer and the CFE.

Change-Id: Id669c934fe08eda41973d6d2cef8340da2e7d72c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133591
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-01-31 14:05:02 +00:00
Lasse R.H. Nielsen 36a6b1b5ce Analyzer: Don't do recursive flattening of FutureOr in await. 
The current behavior (removing all outer `FutureOr`s,
then calling *flatten* on the result) was never specified as correct behavior.

Since Dart 2.0, the await has not recursively flattened futures,
so the static analysis behavior did not match run-time behavior.


Change-Id: Ie1da323aedb4b0f51e2c1e3eebe84552576c5f37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121846
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-01-28 11:16:07 +00:00
Sigmund Cherem 89fb48c648 add mixed subtype test 
Change-Id: I4d21d7fae09dd4ed861e560d53fec7b86ed01173
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133141
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2020-01-24 18:43:29 +00:00
Liam Appelbe f5a830a087 [vm] Update late final fields with init to match new spec 
Spec was updated here: https://github.com/dart-lang/language/pull/720

Bug: https://github.com/dart-lang/sdk/issues/40204
Change-Id: Id4f5bc9a62d9cf5c0b3e4d12a13b3049cbe07a56
Fixed: https://github.com/dart-lang/sdk/issues/40204
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132408
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2020-01-17 23:51:59 +00:00
Sigmund Cherem 53134fc57c [dartdevc] Using a single cache for _typeObject and normalized types. 
Change-Id: I7e3c994b7eec2cb4bc25a153fa177a39d5217b38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132101
Commit-Queue: Mark Zhou <markzipan@google.com>
Reviewed-by: Mark Zhou <markzipan@google.com>
 2020-01-17 20:53:46 +00:00
Johnni Winther 45e966a9eb [cfe] Ensure internal fields for late lowering are not overridden. 
Change-Id: I3b40c311cd81966d3c09ee362b96cc7d98890d66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131829
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-01-17 08:01:45 +00:00
Konstantin Shcheglov 1f511151b5 Restore runtime check for language/nnbd/syntax/late_modifier_final_local_var_test 
Change-Id: I1acb883285985ca1df0904582033f3569c5f7c13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132026
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-16 21:16:08 +00:00
Konstantin Shcheglov a477e051ca Fix language/nnbd/syntax/late_modifier_final_local_var_test.dart 
It is a compile time error to assign to a late final local variable
that is definitely assigned.

Change-Id: I1fe0f8567a4a7ede2bb3983495ca24d6f0efe886
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-16 18:36:24 +00:00
Leaf Petersen 12310ebcc0 Convert late field syntax test to static error test 
Change-Id: I725cec70cb2a93d2fb2c92b5cb8d7efb156bae94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131040
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-01-14 19:06:06 +00:00
Liam Appelbe 2b249a5be1 [testing] Fill out equality_test 
With more plumbing in place, these reified types now have the correct
nullability, so we can test the various eqality cases.

Bug: https://github.com/dart-lang/sdk/issues/39755
Fixes: https://github.com/dart-lang/sdk/issues/39755
Change-Id: Iabf5b808621d1da3e0435cd7ef450f60a0816f44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129203
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-12-20 20:18:54 +00:00
Liam Appelbe ba9e4116ab [testing] Fix unchecked_use_of_nullable_test 
typeParametersNullableBounds and typeParametersNullableUses are never
invoked, so can't generate runtime errors.

Bug: https://github.com/dart-lang/sdk/issues/39755
Change-Id: If1b17264c0376d0046851553e3ab282926c97da2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129201
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-12-20 16:40:20 +00:00
Konstantin Shcheglov d321f6e452 Issue 39773. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER when no default value is allowed. 
This partially reverts https://dart-review.googlesource.com/c/sdk/+/126801

Bug: https://github.com/dart-lang/sdk/issues/39773
Change-Id: Ib147ed770d9bf328dd7792a37a72291070411964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129142
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-19 23:35:13 +00:00
Leaf Petersen e50d98cd56 Fix some incorrect NNBD tests. 
Closes https://github.com/dart-lang/sdk/issues/39814
Closes https://github.com/dart-lang/sdk/issues/39823
Closes https://github.com/dart-lang/sdk/issues/39816

Change-Id: I5015d5cb43b27a555360423cc9567c5880c948e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128777
Reviewed-by: Erik Ernst <eernst@google.com>
 2019-12-19 18:43:03 +00:00
Liam Appelbe 730191fcbd [vm] Implement nullability check in type equality intrinsic 
I'm not able to write a test for this yet, but I manually verified that
it's doing the kLegacy -> kNonNullable mapping correctly, on all 4
architectures.

Bug: https://github.com/dart-lang/sdk/issues/39755
Change-Id: I8d1b014c4d4d067fd55e96166b19015d50c9cc6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128982
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-12-19 16:55:23 +00:00