dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

5559 Commits

Author SHA1 Message Date
Riley Porter ed086f0f95 [tests] Remove more deprecated List constructor usage in tests 
Change-Id: I9a6da832ee51f9362bb2ea4f17931a109b36456e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142721
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Riley Porter <rileyporter@google.com>
 2020-04-07 20:09:26 +00:00
Erik Ernst e2e722463c Adjust member signature expectations for mixed inheritance 
The rule NNBD_TOP_MERGE(S*,T) = NNBD_TOP_MERGE(S,T) and the converse
imply that when a legacy member signature and a null-safe member
signature are brought together by two different superinterfaces,
the null-safe signature prevails (so the legacy signature is ignored).

This CL makes adjustments to 'legacy_resolves_conflict_3_test.dart'
to match this. Note that this means that a class like DiB3 has a
member signature `int Function(int) get a` even though it inherits an
implementation with signature `int? Function(int?) get a`, so we may
have to make such classes an error. [Edit: Based on the notion of
a 'class implementation', which is consolidated in the same sense as
the class interface, but which records the concrete member
declarations available in superclasses, with the declaration in the
nearest superclass prevailing over declarations in more remote ones,
the conflict disappears in the usual way: The class implementation
of a legacy class is legacy-erased. So there are no errors for those
classes after all.]

Change-Id: Ie72e6b80064764fa722304f32bee5e9188710a2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142372
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-04-07 12:20:21 +00:00
Konstantin Shcheglov 8a8c2e74d2 Update constants_2018/constant_types_test to allow type parameters in 'as'. 
Change-Id: I37b0413914d6677e2be53fb0ce98c51f81694edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142568
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-07 06:50:28 +00:00
Leaf Petersen 6cb98c55d5 Add tests for extended GLB. 
This adds tests for the specification change from
 https://github.com/dart-lang/language/pull/903


Change-Id: I2344ea32ac1ca51360ed262f761d14e8db7045bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141841
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-07 02:57:18 +00:00
Robert Nystrom 5f655a8c27 Migrate language_2/covariant to NNBD. 
Change-Id: Icb4eae77fab5257ea00ff948d3f775725398e6ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142067
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-07 01:05:28 +00:00
Robert Nystrom 8f85a9efe4 Migrate language_2/constants_2018 to NNBD. 
Change-Id: I52dee4ed475611ce4ea5d0d45914717ff13f5b8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141768
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-06 23:32:25 +00:00
Konstantin Shcheglov 4558607b05 Update language/constructor/return_test 
Change-Id: I432bbe74a84ad7c0dfe7e974b1f0962dfeb9a312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142548
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-06 23:08:38 +00:00
Robert Nystrom 9be92b28f1 Migrate language_2/double to NNBD. 
Change-Id: I72b95b7d84847c1b7c4e89ba607dfca6d9069854
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142212
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-04 00:25:17 +00:00
Robert Nystrom 8cb5ba4adc Migrate language_2/double_literals to NNBD. 
Change-Id: I6c9041c80cec102c301e59b3bc30d8a86b9b98b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142300
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-04 00:20:37 +00:00
Robert Nystrom ed571882d2 Migrate language_2/constructor to NNBD. 
Change-Id: I2f638cbf6b0fc6e91b3666143a34eb12a66c6fea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141780
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-04-04 00:14:32 +00:00
Konstantin Shcheglov f91880f9e6 Update analyzer expectation for language/const/switch2_test 
Change-Id: I787c81947f0396243ac97cdd694ae300639d33f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142442
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-04 00:12:32 +00:00
Robert Nystrom a4b09ac192 Migrate language_2/control_flow_collections to NNBD. 
Change-Id: I8b9b7d70abc47d672c68db65bc67d08beb7d41a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142089
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-04-04 00:04:27 +00:00
Konstantin Shcheglov 90574ee9fd Add default values for optional parameters in const/constructor2_test 
Change-Id: Ibf8066d7c4eb5c047a6423efb4529ac9fa620459
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142403
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-04-03 21:44:06 +00:00
Robert Nystrom fd3882091c Migrate language_2/deferred to NNBD. 
Change-Id: I6c936a9ad34befccf1b6775d7c9bdc621995a96f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142280
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-04-03 20:04:47 +00:00
Aske Simon Christensen f41de20d46 [vm] Fix unsound code motion through checks. 
Fixes https://github.com/dart-lang/sdk/issues/40765

Change-Id: If3b239c832c5137ad6999ab6e6ff3196bf54a6af
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137970
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2020-04-03 15:55:15 +00:00
Erik Ernst 72e4d14983 Moved several classes with compile-time errors to 3_error_test 
Johnni Winther noted that several classes in
'legacy_resolves_conflict_3_lib2.dart' must be flagged as errors,
because they have incorrect override relationships between declarations
in the class and a the member signatures of a direct superinterface.

This CL moves those classes out of
'legacy_resolves_conflict_3_lib2.dart' and into
'logacy_resolves_conflict_3_error_test.dart',
such that they are only in scope in the library that expects compile-
time errors. Adjusted other libraries to stop referring to these
classes, and marked the classes with the expected errors.

Change-Id: Ia40f56efcb3dea17e60652dd8a2bbb892f89e5b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142142
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-04-03 07:02:46 +00:00
Robert Nystrom e736495eb7 Migrate language_2/const to NNBD. 
Change-Id: I464275799b3e7a21326d35503b776f9c1101a599
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141764
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-04-03 00:56:36 +00:00
Robert Nystrom d132c9163c Migrate language_2/covariant_override to NNBD. 
Change-Id: Ia32edbf3a6a9900b621f3a7b1ae5b0c0b80e7949
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142260
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-02 19:04:39 +00:00
Robert Nystrom f205141a42 Migrate language_2/closure to NNBD. 
Change-Id: Ib798b9573ee8ec924f87104684934785fadc8189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141702
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-04-02 17:29:25 +00:00
Alexander Markov 6e53ac6e4c [vm/nnbd] Fix supertype check in GenerateSubtype1TestCacheLookup 
Before calling Subtype1TestCache stub, there was a quick check if
supertype's class id matches tested class id.
Null extends Object, so supertype of Null matches Object.
However, in NNBD strong mode Null is not assignable to Object.

Fixes https://github.com/dart-lang/sdk/issues/41272

Change-Id: Icc3efaf90992b5083cbe086af81db7504724b855
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142085
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-04-02 01:39:10 +00:00
Erik Ernst b177e44ffa Add mixed inheritance tests 
Updates Mar 19, for better precision in tests (that is, catching
more bugs):

Added tests where `r.m(null).isEven` is used
to near-verify that the receiver `r` implements `A<int*>`:
With `A<int>` it's an error to pass `null`, and with `A<int?>`
it is an error to invoke `isEven`.

Added '1_error' test to detect that `r.m(null).isEven` is a
compile-time error in cases where the receiver has a different
member signature for `m`.

Added '3_error' test to detect that it is a compile-time error to assign
'D().a' to a specific type, for many `D`. This helps catching the
situation where the member signature of `a` is legacy: if that were
true then this test will fail because there is no error).

Change-Id: If6abafbadb51dcb04d13876b577d15c74bf47ccc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139817
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-04-01 13:18:04 +00:00
Alexander Markov 0f89df0c00 [tests/nnbd] Fork language/bool tests for weak and strong mode 
Migrated language/bool tests expect TypeError when null value is used
in a condition (which is still possible if static type of condition is
dynamic). This is right in NNBD strong mode, as implicit cast of null
to bool will fail with TypeError. However, in NNBD weak mode implicit
cast passes, and then AssertionError is thrown as before.
Before migration language_2/bool tests expected AssertionError.

This change forks the tests to behave differently in weak and strong
modes.

Change-Id: Iaba9e606bafe5740a998a60a74a6b54e38cac86b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141800
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-04-01 00:35:37 +00:00
Robert Nystrom 2eed35d650 Migrate language_2/class to NNBD. 
Change-Id: I5f9aa5799cf88a320675debb919011f8a19b6faa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141742
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-03-31 18:16:55 +00:00
Robert Nystrom 80ff59ed27 Migrate language_2/cascade to NNBD. 
Change-Id: I2b3a52b6df08bf31c4fc0cfe0512ccf65bd0506b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141701
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-03-31 18:06:40 +00:00
Robert Nystrom 959bf6e1c3 Migrate language_2/compile_time_constant to NNBD. 
Change-Id: I6cbad15f7151a1a5e1ece71f91ddfb826dca5de5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141762
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-03-31 15:51:50 +00:00
Robert Nystrom 7cf6e52cd1 Migrate language_2/canonicalize to NNBD. 
Change-Id: I603740794fc286527f7f37c0d57feb9b57157784
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141661
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2020-03-31 00:42:49 +00:00
Konstantin Shcheglov 4a5e6e649a Update default_list_constructor_test to reflect that any use of the default List constructor is an error. 
Change-Id: I97657eb8c44fd07c4940b757d6962534b8276e36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140766
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-24 20:01:55 +00:00
Johnni Winther 9ea09ce17b [cfe] Improve message on final variable assignment 
Closes #40242

Change-Id: Iccdfbf01da18ddd501dc705b678358c974003551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140654
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2020-03-24 13:11:29 +00:00
Erik Ernst e3af7e724f Update usage of int/String fromEnvironment 
Breaking change 40678 requires the constructors int.fromEnvironment and
String.fromEnvironment to get new default values for the named
parameter `defaultValue`. This CL changes usages of these constructors
such that they do not depend on the default value, such that it
becomes a non-breaking change for code in the SDK repo to perform the
change in sdk and in sdk_nnbd.

Change-Id: I82af0e1f92d6cd3618b65c0c50d754ae8c39eb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140284
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-03-24 11:19:14 +00:00
Johnni Winther 62f84880ef [cfe] Report error on missing return from non-nullable function 
Closes #40520
Closes #40948
Closes #40425

Change-Id: I0aa3cfa51b410c90dd0bea963846eeb6b2e73efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140540
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-03-24 08:21:36 +00:00
Johnni Winther b8544e8220 [cfe] Don't report nnbd errors/warnings in top level inference 
Closes #41102

Change-Id: Ieede171d92aa28b0ad9478a1b4293ddf35418d7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140040
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-03-23 16:39:03 +00:00
Leaf Petersen 7aace6fa60 Make StackTrace generally not nullable in migrated NNBD library. 
Bug: https://github.com/dart-lang/sdk/issues/40130
Change-Id: I13aba0c2a3fa5b1c3d3995f075ffd38f03aca897
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139880
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-19 23:31:30 +00:00
Nicholas Shahan 3ae7394979 [tests] Update test expectation methods 
`Expect.identical()` --> `Expect.equals()`

The spec defines runtime type object equality but not that they are
identical.

Issue: https://github.com/dart-lang/sdk/issues/41005
Change-Id: I57a0a5da0af18974d4081ea463ec0bff86f7d3e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139843
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-03-17 23:43:05 +00:00
Nicholas Shahan fa77a43c76 [tests] Add analysis options file to migrated test directories 
The intent of this change is to make editing the tests in these
directories more user friendly. When you open these directories in an
analyzer enabled editor it will produce results consistent with the
language features being used in the test.

Change-Id: I68e9cdc0e9fccfc360a2649261a5fdca042ec108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139560
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-03-16 20:51:26 +00:00
Konstantin Shcheglov 0f8238efe9 Issue 41036. Add null-shorting for prefix/postfix expressions. 
Bug: https://github.com/dart-lang/sdk/issues/41036
Change-Id: Iccff235bc81b6e65a3b40f972aaa75707ac2232c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139462
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 20:23:16 +00:00
Nicholas Shahan 9301c2f593 [tests] Fix analysis errors in tests 
Non-nullable and optional method arguments need default values. Embedded
the generic type argument into a List as an easy way to create a default
value.

Change-Id: Ib171c272c75b114447d356d423c45dc9aeff9bb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139160
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2020-03-12 18:16:36 +00:00
Nicholas Shahan 33349076ee [tests] Add tests for type object equality after FutrureOr normalization 
Change-Id: I61d0b35fff087091eafa921f679a29760b00b84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138103
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2020-03-12 01:20:50 +00:00
Leaf Petersen 5e9be81d5e Make all CastErrors be TypeErrors. 
This makes CastError implement TypeError, and changes all test
expectations to look for TypeError.  A followup CL will deprecate
CastError.

Bug: https://github.com/dart-lang/language/issues/787
Bug: https://github.com/dart-lang/sdk/issues/34097
Change-Id: I7102c6260901317572d2df08c4be9c4c48197688
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138670
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-03-11 23:31:06 +00:00
Konstantin Shcheglov a44f680932 Update assignment in language/nnbd/operator_type_test 
Change-Id: I81b87af6bd8ae51d626afb79412730c4bc39204a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138980
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 15:09:24 +00:00
Konstantin Shcheglov 0e0cde55a0 Add default values for tests/language/nnbd/type_equality/function_type_equality_test 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I5f1f356e96f66b4b0098fba6ab61109ae5cc3ac5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139026
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 15:01:29 +00:00
Konstantin Shcheglov 21cddbd4cf Fix language/nnbd/syntax/late_modifier_error_test 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Icdefdfcae39a496fff6f8cf0b505b0a67a282ef2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 15:01:21 +00:00
Konstantin Shcheglov d7f697f64a Include additional analyzer errors in language/nnbd/syntax/class_member_declarations_error_test 
Change-Id: Iee4344a65e85890c3361294a6bdaa0920a3a4f10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-11 00:45:41 +00:00
Leaf Petersen f34fa57d98 Update null aware subscript test 
Change-Id: Ib3a37f575906c125b850fa82732595f1532c9d9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138721
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-10 17:41:51 +00:00
Konstantin Shcheglov bbb449dfa4 Issue 40931. Update inference constraint for T? to be non-nullable. 
Bug: https://github.com/dart-lang/sdk/issues/40931
Change-Id: I483c3febad236b366f911f38339c712dd928cfcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138790
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-10 02:19:50 +00:00
Konstantin Shcheglov 24c8021f03 Replace initialize() with declare(). 
Fixes https://github.com/dart-lang/sdk/issues/38791

Change-Id: I954059160c75de91e1e32fe2f82ebfdc5569d947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138666
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-09 18:24:51 +00:00
Brian Wilkerson 9a62df57fa Fix a test to get the analyzer nnbd bot to pass 
Change-Id: I5892c245d4aa984c896471bf18cd71362958d0c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138782
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-09 17:47:47 +00:00
Liam Appelbe 2c5a56e7bb [vm] Disable late field init for constructor initialized fields 
Change-Id: Ibdab37839d07b77bf2c92a09f760f44b54d94bcb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138620
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2020-03-06 17:10:08 +00:00
Liam Appelbe 331067017f [vm] Fix late field store bug 
Late field stores were being incorrectly marked as initializations,
causing them to be incorrectly optimised out in some cases.

Change-Id: I7487d24238af3b3922e76a9ca6ae6df4bf5ab849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138566
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2020-03-05 23:34:16 +00:00
Robert Nystrom 739852d99d Migrate language_2/call to NNBD. 
Change-Id: I3356296e72dfa07b0ac994da0ce96f766b182e80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137722
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-03-05 19:56:49 +00:00
Robert Nystrom f6b0a70230 Migrate language_2/await to NNBD. 
Change-Id: I59ae5b01c00f3bebda0ba74eb5eb1950ade59925
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137720
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2020-03-05 18:17:29 +00:00