dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

321 Commits

Author SHA1 Message Date
brianwilkerson@google.com 5e90751367 Rename Identifier.getElement. Prior to this change the method getElement() was semantically equivalent to getBestElement(), but that was rarely the correct method to be using. I have divided it into getBestElement() and getPropagatedElement(), but in most cases replaced its use with getStaticElement(). 
Please check this carefully. Although all of the tests pass, there's still a possibility that I translated something wrong at some point (especially in code outside engine) and I'd like to catch any mistakes as early as possible.

R=jwren@google.com, messick@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//22854024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26380 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 18:50:28 +00:00
scheglov@google.com d554cd90c4 Rules for finals were loosened, contradiction in spec was fixed. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//23216006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26320 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-19 17:58:09 +00:00
regis@google.com f9df206e2e Report compile-time errors for conflicting overrides as specified by latest 
language spec (fix issue 12342).
Add override conflict tests.
Update status files.
Add support for 'ok' status in multi-tests.

R=hausner@google.com

Review URL: https://codereview.chromium.org//22999022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26302 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-16 23:39:41 +00:00
jwren@google.com 7a9a98445a Turn strict mode off in the dartanalyzer 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//22997004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26139 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 19:32:54 +00:00
ngeoffray@google.com b50b1f1e8b Make analyzer happy and use annotations the right way. 
R=ahe@google.com

Review URL: https://codereview.chromium.org//22999005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26120 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 13:29:53 +00:00
scheglov@google.com 2a93d0d0fd Issue 12404. Treat 'dynamic' identifier as a Type object. 
https://code.google.com/p/dart/issues/detail?id=12404

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//23056003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26070 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-13 18:20:50 +00:00
scheglov@google.com 48c56552eb Report StaticWarningCode.UNDEFINED_IDENTIFIER when name is hidden, but not defined yet in block. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//22846005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26060 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-13 16:24:50 +00:00
scheglov@google.com e9529b3dab Report CTEC.CONST_CONSTRUCTOR_WITH_NON_CONST_SUPER 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22935003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26058 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-13 16:16:48 +00:00
rmacnak@google.com f58a00b4b7 Mark dynamic_test as failing on the analyzer. 
TBR=

Review URL: https://codereview.chromium.org//22923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26045 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-13 00:34:44 +00:00
scheglov@google.com ebbb8daf29 Fix for function type assignable check. 
It is not the same as for interface types.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22846003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26032 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-12 21:03:27 +00:00
regis@google.com 9eb12ad303 Implement updated method overriding rules in the vm (issue 11495). 
Introduce --error-on-bad-override flag and use it when generating snapshots.
Fix signature checking when patching methods.
Fix errors in patch files.
Fix receiver type of constructors.
Fix finalization of mixin application typedefs.
Update tests and status files.

R=asiva@google.com

Review URL: https://codereview.chromium.org//22685007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26027 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-12 20:28:52 +00:00
scheglov@google.com c691cb8bcb Report DEFAULT_VALUE_IN_FUNCTION_TYPE_PARAMETER. 
Also triage the test that was initially marked with this issue, but now is not.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22926002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26025 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-12 19:56:08 +00:00
jwren@google.com 420fab6771 Fix for issue 11497- liberalize warnings about bad overrides 
TODO- This is all of the changes in the analyzer, before this lands however the status files will need to be updated with now 30 failing language/co19 tests.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//22339023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26018 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-12 18:34:55 +00:00
scheglov@google.com 0535260c7a Issue 11892. It is compile-time error when unqualified invocation with unresolved identifier. 
https://code.google.com/p/dart/issues/detail?id=11892

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22871003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26016 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-12 18:06:32 +00:00
scheglov@google.com ab9b9f9a97 Report INVALID_ASSIGNMENT if default value type cannot be assigned to the parameter type. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//22759003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26010 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-12 16:10:24 +00:00
scheglov@google.com ac5ca53953 Report INSTANCE_ACCESS_TO_STATIC_MEMBER. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//22710009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25984 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-09 22:10:28 +00:00
johnniwinther@google.com 991c9a14f5 Fix uses of throw/rethrow. 
BUG=

Review URL: https://codereview.chromium.org//22557002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25863 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-07 08:55:30 +00:00
johnniwinther@google.com 130f5ae816 More throw/rethrow fixes. 
BUG=

Review URL: https://codereview.chromium.org//22534004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25861 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-07 08:04:38 +00:00
johnniwinther@google.com b7faf57835 Update analyzer status. 
BUG=

Review URL: https://codereview.chromium.org//22542002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25856 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-07 06:25:47 +00:00
scheglov@google.com 190ed7012c Issue 12158. Report error when user code uses 'native' clause. 
https://code.google.com/p/dart/issues/detail?id=12158

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//22481002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25839 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-06 22:50:22 +00:00
regis@google.com 09bcdc6d6d Fix VM implementation of CastError not to extend TypeError (issue 5280). 
Remove non-compliant fields in various Error classes (issue 10144).
Remove implicit constructor when patching in a constructor (issue 12217).
Patch corelib Error classes instead of declaring subclasses.
Update tests and status files.

R=asiva@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//21832003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25782 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-05 18:35:04 +00:00
scheglov@google.com 6990320e9c Issue 11987. Make typedef self-reference more restrictive. 
https://code.google.com/p/dart/issues/detail?id=11987

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//22159004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25775 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-05 17:40:15 +00:00
scheglov@google.com 1ffea8cae7 Issue 12106. Ambiguous import is now always static warning, never error. 
https://code.google.com/p/dart/issues/detail?id=12106

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//21499005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25734 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-02 16:48:02 +00:00
scheglov@google.com abe238736b Report ASSIGNMENT_TO_CONST. 
Also more language tests triage.
Some of the tests were already 'fixed' by reporting warnings, but still fail because they are negative (but should not be negative according to the spec).

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//21513005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25713 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-01 17:24:13 +00:00
scheglov@google.com 31e79dba9f Triage the rest of the language tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//21429002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25703 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-01 04:07:34 +00:00
johnniwinther@google.com a7d13fa228 Treat ambiguous types as malformed. 
BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org//21065002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25605 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-30 05:59:15 +00:00
johnniwinther@google.com 514633d0c9 Update analyzer status. 
BUG=

Review URL: https://codereview.chromium.org//21047003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25556 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-29 10:58:27 +00:00
johnniwinther@google.com 9678639ff0 Update analyzer status. 
BUG=

Review URL: https://codereview.chromium.org//21055002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25555 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-29 10:41:54 +00:00
regis@google.com 7b9a84dfbb Implement more restrictive checking of typedefs illegally referring to 
themselves and fix vm issue 9611.
Update a test and add a test.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//19997003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25382 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-23 23:17:42 +00:00
ngeoffray@google.com 9ddf8e2bef Continue fiddling with status files. 
Review URL: https://codereview.chromium.org//19802005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25209 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-19 12:44:20 +00:00
ngeoffray@google.com e418bb5ee0 Update status for dartanalyzer. 
Review URL: https://codereview.chromium.org//19802004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25207 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-19 12:14:34 +00:00
kustermann@google.com 1cfac5f445 Status update for language/illegal_invocation_test 
TBR=scheglov@google.com

Review URL: https://codereview.chromium.org//19543007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25157 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-18 17:33:53 +00:00
brianwilkerson@google.com 34ee1e7515 Add implicit blocks in 'if', 'do', 'for', and 'while' statements. This is a result of a change in the specification. See issue 11817 for context. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//19681002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25123 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-17 21:03:50 +00:00
scheglov@google.com 41d8e6ee39 Test running changes. 
1. Change in the test runner to consider any warning as warning.

After this following was required:

2. Triage language tests.

3. Triage co19 tests.

R=brianwilkerson@google.com, kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//18174010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25069 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-16 20:35:51 +00:00
regis@google.com 71f88546cc Stop resolving classes prematurely in the vm (issue 11023). 
Add missing class finalization to mirrors tests.

R=hausner@google.com

Review URL: https://codereview.chromium.org//19030004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24965 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 17:59:17 +00:00
floitsch@google.com 73a0db0692 Update test and status file. 
R=ahe@google.com

Review URL: https://codereview.chromium.org//18531006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24910 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-11 11:36:45 +00:00
scheglov@google.com c53342b996 Report MIXIN_TYPEDEF_CYCLE. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//18293017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24902 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-11 01:34:21 +00:00
scheglov@google.com 891af98050 NEW_WITH_INVALID_TYPE_PARAMETERS is warning 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//19018005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24901 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-11 01:28:46 +00:00
scheglov@google.com 15239a3a3a Report EXPECTED_ONE_LIST_TYPE_ARGUMENTS. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//18660007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24888 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-10 21:32:55 +00:00
scheglov@google.com 9f9f62000b Report MAP_VALUE_TYPE_NOT_ASSIGNABLE warning/error. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//18197003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24880 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-10 16:53:06 +00:00
scheglov@google.com 4875b2776b Report LIST_ELEMENT_TYPE_NOT_ASSIGNABLE warning/error. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//18473006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24862 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-09 19:59:31 +00:00
regis@google.com e8a722870b Support type parameters and classes as expression in the vm. 
Turn many compile-time errors into runtime errors per latest spec.
Triage affected tests.

R=hausner@google.com

Review URL: https://codereview.chromium.org//18801007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24861 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-09 19:35:56 +00:00
scheglov@google.com 21b2cc4d8d Fix for parsing top-level variable named 'get' or 'set'. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//18532010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24851 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-09 16:44:27 +00:00
scheglov@google.com 4f382a4092 Report EXTENDS_NON_CLASS for 'extends dynamic'. 
From the old Gilad message: Dynamic is not a class, so this is invalid as well, but for other reasons. In particular, there is no need for a special rule banning it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//18523012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24834 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-09 02:25:00 +00:00
scheglov@google.com 9daa818057 Report REDIRECTION_IN_NON_FACTORY_CONSTRUCTOR. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//18341022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24833 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-09 02:21:15 +00:00
scheglov@google.com 8bfdd280e9 Report IMPLEMENTS_SUPER_CLASS 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//18808002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24804 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-08 16:36:42 +00:00
scheglov@google.com 9a05cff056 Report RETURN_IN_GENERATIVE_CONSTRUCTOR for ExpressionFunctionBody in generative constructor. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//18810002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24802 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-08 16:30:22 +00:00
scheglov@google.com b3f151638e Report RESULT_NUM when constant value is String + String. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//18772003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24800 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-08 16:27:18 +00:00
scheglov@google.com 58e638766c Report CTEC.ARGUMENT_TYPE_NOT_ASSIGNABLE and extra/not-enough arguments as errors. 
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//18690009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24790 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-07 18:11:36 +00:00
floitsch@google.com 898a3d8867 Relax method override restrictions. 
This implements part of issue 11495.

BUG= http://dartbug.com/11495
R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24731
Reverted: https://code.google.com/p/dart/source/detail?r=24733

Review URL: https://codereview.chromium.org//18600007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24736 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-03 18:02:11 +00:00