Commit Graph

321 Commits

Author SHA1 Message Date
floitsch@google.com 5539ee1908 Update status file.
Review URL: https://codereview.chromium.org//233143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34923 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 12:39:40 +00:00
iposva@google.com 46ab956f9d - Mark language/function_literals2_test as failing.
Review URL: https://codereview.chromium.org//231983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34911 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-10 03:24:23 +00:00
hausner@google.com 6051d21b5c Conflicting inheritance from superinterface is not a compile time error
Test override_inheritance_mixed was partially wrong.

Inheriting conflicting members from superinterfaces is not a compile time error,
just a static type warning.

See also bug 16137 for details.

R=gbracha@google.com

Review URL: https://codereview.chromium.org//230423004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34883 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 17:43:14 +00:00
johnniwinther@google.com eaad3cd8b2 Handle type checking of generic compile time constants.
BUG=http://dartbug.com/14348
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32154

Review URL: https://codereview.chromium.org//146733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34871 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 11:14:04 +00:00
johnniwinther@google.com fbe2b8bcc7 Compute frontend/backend specific constants.
BUG=
R=floitsch@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34811

Review URL: https://codereview.chromium.org//221873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34862 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 07:40:54 +00:00
jwren@google.com c38bb2fc79 Fix for 16134- class members modify the set of members that are inherited from superclasses.
As part of this fix, 4 tests now fail in the language test, issue 17983 was created with the bug, and failing tests are also introduced to show the issue.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//223033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34707 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 17:39:04 +00:00
jwren@google.com 7ee7453157 Fix for 16133.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//218993013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34603 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 17:28:31 +00:00
hausner@google.com 18f8f69400 Fix analyzer test expectations
Deferred loading not yet supported by analyzer.

Review URL: https://codereview.chromium.org//219833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34568 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 18:24:42 +00:00
johnniwinther@google.com 62866300da Update analyzer status.
BUG=

Review URL: https://codereview.chromium.org//212543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34413 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 09:26:41 +00:00
johnniwinther@google.com 1692a15f4e Add 'static type error' tags to multitests.
BUG=http://dartbug.com/16411
R=ricow@google.com

Review URL: https://codereview.chromium.org//150223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34412 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 09:03:47 +00:00
sigurdm@google.com 30ac6d116d Introduces the new syntax for deferred loading
import "lib.dart" deferred as lib;

And then injecting a function of the name "loadLibrary" into the
namespace of the import prefix.

This FunctionElement is a triggers the builder to emit special code that causes _loadLibraryWrapper in js_helper to be called.

Dart2dart will not crash on deferred loading, but calls to
loadLibrary will become calls to a (not-existing) top-level function
loadLibrary.

The old syntax (using metadata) is still working

For now keeping the language tests with the old syntax in addition to
the updated tests.

R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//201613006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34230 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 07:50:08 +00:00
sigurdm@google.com 26387eca98 Constrain constant references from deferred libraries
Now any reference to a constant from a deferred library in a constant context will give an static error.

Also fixed the const-new expression constraint so it works with named constructors.

Split the deferred_constraints_test into deferred_constraints_type_annotation_test and deferred_constraints_constants_test

R=floitsch@google.com

Review URL: https://codereview.chromium.org//195983006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33734 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 09:13:30 +00:00
rmacnak@google.com 6927c21987 Separate analyzer issue from spec issue.
Review URL: https://codereview.chromium.org//197823011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33664 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 20:46:35 +00:00
rmacnak@google.com e30591546f Mark analyzer failure on language/call_closurization_test.
Review URL: https://codereview.chromium.org//198943006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33663 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 20:41:25 +00:00
hausner@google.com 77dd0fda7e Fix is_malformed_test annotations
Simpler way to annotate the expected test outcome.

R=ricow@google.com

Review URL: https://codereview.chromium.org//192723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33491 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-10 13:21:53 +00:00
sigurdm@google.com 0e9a7a32ec Introduce constraints of deferred constants.
Deferred classes can not be used in const new instance expressions.

This CL depends on: https://codereview.chromium.org/177543002/

R=floitsch@google.com

Review URL: https://codereview.chromium.org//183743031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33425 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 13:11:09 +00:00
sigurdm@google.com 7d8fe13b6c Constrain type annotations with deferred types.
This implements the constraint that a type imported with a deferred import
cannot be used in type annotations in the importing module.  They can still be
used in new-expressions. A violation will trigger a warning, and replace the
type with a MalformedType.

Was reverted by: Issue 185053005 r33277

R=floitsch@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33273

Review URL: https://codereview.chromium.org//177543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33417 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 10:04:37 +00:00
scheglov@google.com 9d622fc1d9 Unroll 'synchronized {}' in java2dart.
...and corresponding 'analyzer' snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//185403018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 02:30:21 +00:00
sigurdm@google.com ac702a92da Revert "Constrain type annotations with deferred types."
This reverts commit 33273 and 33276.

R=karlklose@google.com

Review URL: https://codereview.chromium.org//185053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33277 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 15:27:09 +00:00
sigurdm@google.com 1607192c30 Constrain type annotations with deferred types.
This implements the constraint that a type imported with a deferred import
cannot be used in type annotations in the importing module.  They can still be
used in new-expressions. A violation will trigger a warning, and replace the
type with a MalformedType.

R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//177543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33273 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 14:12:17 +00:00
hausner@google.com 97e7f2c299 Fix type checks with malformed types
Parser must continue to parse the rest of an expression that contains
a type test with a malformed type.

Before:
'file:XXX’: error: line 5 pos 12: ')' expected
  if (3 is X && 2 == 2) print("foo");

After:
'file:XXX’: malformed type: line 5 pos 12: type 'X' is not loaded
  if (3 is X && 2 == 2) print("foo");
           ^
type error.
#0      main (file:XXX:5:12)
#1      _startIsolate.isolateStartHandler (dart:isolate-patch/isolate_patch.dart:216)
#2      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:115)

R=regis@google.com

Review URL: https://codereview.chromium.org//183743015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33253 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 23:27:44 +00:00
jwren@google.com e2cc1ecb30 Fix for 16498.
This fixes this issue, but also re-implements much of the inheritance logic to bring the analyzer closer to spec-compliance with the changes that landed in January.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//178173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32982 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 20:34:17 +00:00
sigurdm@google.com 1bcf50eb73 Change the negative tests called language/deferred* to multitests.
Update the status files correspondingly.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32890

Reverted: by https://codereview.chromium.org/175123002/ r32895

Review URL: https://codereview.chromium.org//169483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32958 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 11:47:03 +00:00
sigurdm@google.com a27abd6f0b Revert "Change the negative tests called language/deferred* to multitests."
This reverts commit r32890.

Review URL: https://codereview.chromium.org//175123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32895 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 12:56:45 +00:00
sigurdm@google.com 3f28d6a271 Change the negative tests called language/deferred* to multitests.
Update the status files correspondingly.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//169483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32890 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 12:12:23 +00:00
sigurdm@google.com f1a7409206 Fix analyzer status.
Review URL: https://codereview.chromium.org//174953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32885 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 10:13:16 +00:00
johnniwinther@google.com d75b2291ca Fix language tests wrt. warnings.
BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32689

Review URL: https://codereview.chromium.org//158733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32691 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 11:59:12 +00:00
johnniwinther@google.com d5cbe5d330 Revert "Fix language tests wrt. warnings."
This reverts commit r32689.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//166433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32690 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 10:10:29 +00:00
johnniwinther@google.com 7d33875b66 Fix language tests wrt. warnings.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//158733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32689 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-14 09:35:00 +00:00
brianwilkerson@google.com 11a553b4f0 Fix for issue 16037
R=jwren@google.com

Review URL: https://codereview.chromium.org//164123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32667 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 18:43:55 +00:00
kustermann@google.com 453873b334 Mark override_inheritance_field_test as flaky again
Although these tests pass on the buildbot, they fail on some developer machines.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//159873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32561 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 16:32:54 +00:00
kustermann@google.com 1626736d2c Remove flaky markers from status file for tests that are not flaky.
R=ricow@google.com

Review URL: https://codereview.chromium.org//135243005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32553 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 11:55:55 +00:00
brianwilkerson@google.com 7b6cf617b4 Fix for issue 15471
R=scheglov@google.com

Review URL: https://codereview.chromium.org//137813006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32455 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 21:52:31 +00:00
floitsch@google.com 5cc26461ec Fix typechecks for constant assignments of function to typedefs.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//132313012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32432 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 16:53:12 +00:00
brianwilkerson@google.com 7ca113a5ac Fix the build. Not sure why this test passes on my local machine but not on the bot.
Review URL: https://codereview.chromium.org//144953004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32262 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 20:55:31 +00:00
brianwilkerson@google.com b4d20f6c94 Rename getNextAnalysisTask and clean-up one method
R=scheglov@google.com

Review URL: https://codereview.chromium.org//153043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32261 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 20:14:25 +00:00
johnniwinther@google.com 99d4b3343d Another analyzer nondeterminism.
BUG=

Review URL: https://codereview.chromium.org//152583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32238 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 09:50:24 +00:00
johnniwinther@google.com 3f54abdff5 Fix analyzer redness.
BUG=

Review URL: https://codereview.chromium.org//152543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32235 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 08:22:21 +00:00
johnniwinther@google.com 957bab39c2 Perform override and inheritance checks.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//140803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32192 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 12:21:49 +00:00
johnniwinther@google.com accfb9e184 Revert "Handle type checking of generic compile time constants."
This reverts commit r32154.

BUG=

Review URL: https://codereview.chromium.org//130143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32156 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 10:03:54 +00:00
johnniwinther@google.com 83a5ed7d96 Handle type checking of generic compile time constants.
BUG=http://dartbug.com/14348
R=karlklose@google.com

Review URL: https://codereview.chromium.org//146733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32154 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 08:48:03 +00:00
scheglov@google.com 37b6debef7 New analyzer snapshot.
There are some problems with JDT and line comments.
Interesting, that it works almost everywhere, and also worked coupld weeks ago.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//137143010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32052 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 04:24:41 +00:00
floitsch@google.com 4bad045428 It's the analyzer and not dart2dart that is failing on the bom test.
Review URL: https://codereview.chromium.org//145583006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32017 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-27 13:09:05 +00:00
regis@google.com 5832bdbbb3 Handle wrong method invocation of a type parameter (fix issue 13134).
Add test.

R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//134083005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31944 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-18 01:03:22 +00:00
scheglov@google.com 3ad3ff9a2e New analyzer snapshot.
Extracts SdkLibrariesReader_LibraryBuilder into sdk.dart library.
https://code.google.com/p/dart/issues/detail?id=14791

R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//135653008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31939 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-18 00:05:43 +00:00
regis@google.com c2f0dec5ec Support bounded mixins in the VM (fix issue 14453).
Add tests.

R=gbracha@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//137543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31794 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 18:41:27 +00:00
johnniwinther@google.com b5b91448f8 Compute correct constructor type for synthesized mixin constructors.
BUG=http://dartbug.com/15717
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31438

Review URL: https://codereview.chromium.org//120423006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31467 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 09:41:17 +00:00
johnniwinther@google.com baa8bb3c6b Revert "Compute correct constructor type for synthesized mixin constructors."
This reverts commit r31438.

BUG=

Review URL: https://codereview.chromium.org//111283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31439 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 15:25:05 +00:00
johnniwinther@google.com a11482202b Compute correct constructor type for synthesized mixin constructors.
BUG=http://dartbug.com/15717
R=floitsch@google.com

Review URL: https://codereview.chromium.org//120423006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31438 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 14:01:01 +00:00
brianwilkerson@google.com 4b4bf1cf08 Constant evaluation support. This fixes most of the open issues related to constants and makes it (theoretically) possible to fix the rest.
R=jwren@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//113143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31303 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 21:26:54 +00:00