Commit Graph

1846 Commits

Author SHA1 Message Date
hausner@google.com 03d1af54b0 Fix crash with cyclic exports
Issue 6060, 6595

R=srdjan@google.com

Review URL: https://codereview.chromium.org//23658007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26957 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 23:09:35 +00:00
zra@google.com c012196222 Evaluates arguments before throwing a NoSuchMethodError in constructor
calls and static function calls.

Fixes issue 12820.

R=regis@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//23482004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26827 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 23:39:43 +00:00
sgjesse@google.com 44e5bc9bf9 Update language status file
Add issue numbers.

Change a test to not rely on the toString() value if a TypeError.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23599002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26764 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 06:48:31 +00:00
regis@google.com c726663bba Fix bad language test (issue 12757, 12758).
Update status files accordingly (new VM issue was filed).

R=srdjan@google.com

Review URL: https://codereview.chromium.org//23582004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26742 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 20:37:21 +00:00
iposva@google.com 2125bde307 - These tests do not rely on --compile_all any longer.
Review URL: https://codereview.chromium.org//23543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26727 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 17:22:06 +00:00
hausner@google.com c2fa1cf490 Add compilation error on named parameters with private names
Remove bogus test cases.

Fixes issue 5743, 3502

R=srdjan@google.com

Review URL: https://codereview.chromium.org//23478005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26719 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 16:41:33 +00:00
kustermann@google.com 013ac3b1d1 Reland "Enable running multitests in browsers""
R=ricow@google.com

Review URL: https://codereview.chromium.org//23545003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26695 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 09:12:05 +00:00
ricow@google.com 160c745a18 Readd reflect_core_vm test suppression.
This was accidentially removed in the refactor in revision 26638

Review URL: https://codereview.chromium.org//23075027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26643 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 12:29:45 +00:00
sgjesse@google.com 7c39a59017 Move all dart2dart information to the dart2js status file
Also added a few issue numbers

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23425002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26638 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 11:44:48 +00:00
fschneider@google.com b11c9d34d6 Temporarily mark a test as failing on Dartium.
I'm looking into why and will remove that line once the
problem is fixed.

TBR=ricow@google.com

Review URL: https://codereview.chromium.org//23241026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26637 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 11:40:50 +00:00
sgjesse@google.com 550f3ab7f4 Add issue numbers to language tests status files
Moved VM specific tests to a separate directory

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23103010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26596 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 11:31:25 +00:00
sgjesse@google.com 311800da34 Update language.status
Add failing test on dart2dart.

Remove bogus line.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23190037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26588 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 09:34:54 +00:00
sgjesse@google.com cf33b82c6c Update more test for assignment to final variables
This is a follow-up to
https://code.google.com/p/dart/source/detail?r=26519, as there where
more tests checking assignments to final variables. Changed the
negative tests to multi-tests for running with the analyzer(s).

The latest spec (0.51) says:

Attempting to assign to a final variable anywhere except in its
declaration or in a constructor header will cause a runtime error to
be thrown as discussed below. The assignment will also give rise to a
static warning.

R=ricow@google.com
BUG=7062, 11591, 12184

Review URL: https://codereview.chromium.org//23112017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26583 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 08:14:57 +00:00
iposva@google.com 08b38c9f4a - More configurations pass.
Review URL: https://codereview.chromium.org//22999044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26569 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 23:27:41 +00:00
iposva@google.com cb77eb4ab8 - Fix broken test from http://dartbug.com/12634
Review URL: https://codereview.chromium.org//22901025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26564 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 22:34:37 +00:00
kustermann@google.com 3f148045fb Removed status file entries refering to non-existent multitests
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//22909033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26525 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 14:29:36 +00:00
sgjesse@google.com bab2500197 Update test for assignment to final variables
The latest spec (0.51) says:

Attempting to assign to a final variable anywhere except in its
declaration or in a constructor header will cause a runtime error to
be thrown as discussed below. The assignment will also give rise to a
static warning.

R=ahe@google.com
BUG=7062, 11591

Review URL: https://codereview.chromium.org//22914028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26519 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 13:15:19 +00:00
sgjesse@google.com d72b992eaf Update the language.status
Mainly adding issue numbers.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//22861024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26516 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 12:02:59 +00:00
rmacnak@google.com ef72ff32fb Test that importing dart:core with a prefix does not hide dynamic.
BUG=http://dartbug.com/12478
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//22825009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26450 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 17:55:27 +00:00
regis@google.com 0ab840ae98 Fix bound checking in self referencing type (issue 12553).
Added test.

R=hausner@google.com

Review URL: https://codereview.chromium.org//23295020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26444 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 17:22:18 +00:00
kustermann@google.com bc051d0a91 Remove entries in status refering to non-existent files
R=ricow@google.com

Review URL: https://codereview.chromium.org//23245015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26438 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 16:40:40 +00:00
sgjesse@google.com c7bef43f06 Update language status files
Update bug number and move a line to the correct file

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23079010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26435 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 15:49:50 +00:00
sgjesse@google.com d642996240 Update language.status
Remove some references to closed bugs. Add new bugs number and remove reference to non-existing test.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23183009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26431 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 14:45:08 +00:00
lrn@google.com 34ca90cc41 Fix test that contains compile-time error.
This doesn't affect dart2js, which fails to detect the compile-time error.
Filing separate bug for that.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23314005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26430 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 14:28:47 +00:00
sgjesse@google.com 9ff0a2a071 Update language status file
Updated one bug whic was closed (created new)

Removed test for source as a reserved word, as it is not anymore.

Removed reference to a multitest id which was not in the file

R=kustermann@google.com, ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//23313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26427 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 12:37:25 +00:00
sgjesse@google.com e95bb89f6d Remove some bogus rules from the staus files
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//22854029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26357 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 14:19:51 +00:00
sgjesse@google.com 6b514b1a0c Remove all remaining references to dartc
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//23301004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26338 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 06:17:03 +00:00
regis@google.com f9df206e2e Report compile-time errors for conflicting overrides as specified by latest
language spec (fix issue 12342).
Add override conflict tests.
Update status files.
Add support for 'ok' status in multi-tests.

R=hausner@google.com

Review URL: https://codereview.chromium.org//22999022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26302 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 23:39:41 +00:00
lrn@google.com fd5a11d514 Analyzer: Don't allow extending or implementing Null.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//22872008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26258 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 07:52:33 +00:00
lrn@google.com 6ecdf2db1d Fix static type warnings in language/null_test.
Update status file to mark analyzer as failing. It does not detect
extending or implementing Null.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//22978011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26188 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 11:39:00 +00:00
lrn@google.com 14a75969c3 Add Null class to dart:core.
Make dart2js accept this class as the type of `null`.

Dart2js still fails on tests on the form: x is Null
VM does not recognize Null as the type of `null`.

BUG= http://dartbug.com/12382
R=fschneider@google.com, karlklose@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//23012003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26175 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 09:12:19 +00:00
fschneider@google.com 447ddebd68 Fix equality of implicit closures in the Dart VM.
This CL also lifts the restriction that classes could not
extends or implement 'Function'.

BUG=https://code.google.com/p/dart/issues/detail?id=10849
BUG=https://code.google.com/p/dart/issues/detail?id=12411

TEST=tests/language/bound_closure_equality_test.dart,
tests/language/black_listed_test.dart

R=iposva@google.com

Review URL: https://codereview.chromium.org//22425006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26114 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 11:43:50 +00:00
zra@google.com 8ffef7528d Bug fix and status file updates for MIPS HW.
R=regis@google.com

Review URL: https://codereview.chromium.org//22828004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26037 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:45:41 +00:00
regis@google.com 9eb12ad303 Implement updated method overriding rules in the vm (issue 11495).
Introduce --error-on-bad-override flag and use it when generating snapshots.
Fix signature checking when patching methods.
Fix errors in patch files.
Fix receiver type of constructors.
Fix finalization of mixin application typedefs.
Update tests and status files.

R=asiva@google.com

Review URL: https://codereview.chromium.org//22685007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26027 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 20:28:52 +00:00
fschneider@google.com 2793f7ad63 Fix bug with optimized try-catch on ARM/MIPS.
The constant pool pointer must be restored before any parallel
moves at the catch-entry block.

In addition, this CL removes CatchEntryInstr and folds its
functionality into CatchBlockEntryInstr. Until now every catch-block
started with CatchBlockEntryInstr followed by a CatchEntryInstr.

This simplifies a lot of code in the compiler and avoids issues
with allocator-move code inserted between the two instructions.

BUG=https://code.google.com/p/dart/issues/detail?id=12291
TEST=tests/language/try_catch4_test.dart
R=regis@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//22590002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25918 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 08:20:10 +00:00
kustermann@google.com c6b32a0599 Marking language/licm2_test as SKIP on ie9/ie10
R=ricow@google.com

Review URL: https://codereview.chromium.org//22594003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25880 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 15:56:08 +00:00
hausner@google.com e390ba9871 Fix access to type variables in initializer expressions
Allow initializer expressions to capture type arguments.
This used to crash because the receiver is not accessible
in initializer expressions. We don't need the receiver, we
just need to mark it as captured.

Fixes issue 8847.

R=ahe@google.com

Review URL: https://codereview.chromium.org//22415002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25877 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 15:15:02 +00:00
johnniwinther@google.com 63f6d5ce6c Handle int/double case expression types correctly.
BUG=http://dartbug.com/11536
R=ahe@google.com

Review URL: https://codereview.chromium.org//21292003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25864 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 09:14:33 +00:00
regis@google.com 09bcdc6d6d Fix VM implementation of CastError not to extend TypeError (issue 5280).
Remove non-compliant fields in various Error classes (issue 10144).
Remove implicit constructor when patching in a constructor (issue 12217).
Patch corelib Error classes instead of declaring subclasses.
Update tests and status files.

R=asiva@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//21832003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25782 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 18:35:04 +00:00
fschneider@google.com 086b60dada Fix a bug in compilation of try-finally.
When nesting try-finally, the outer finally was incorrectly executed
twice under certain conditions (a return in the inner try-block and a outer
finally-block that ends with throw)

This was because finally-code was inlined at return/break/continue statements
and it was associated with the wrong catch-handler when compiling.

This CL tracks indices of try-blocks in the parser so that each inlined
finally block has the correct catch handler index.

BUG=https://code.google.com/p/dart/issues/detail?id=11972
TEST=test/language/throw8_test.dart
R=hausner@google.com

Review URL: https://codereview.chromium.org//22184003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25767 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 13:49:48 +00:00
hausner@google.com 2c4b0c880a Forwarding constructors are never const
Forwarding constructors of mixing application classes do not
inherit the super constructor's const-ness. They are also
never abstract or external.

Fixes issue 11917.

R=ahe@google.com

Review URL: https://codereview.chromium.org//22183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25765 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 12:13:36 +00:00
regis@google.com 3b7cdf80a0 Update VM to handle malformed types according to revised spec (issues 9055,
12105, 7247).
Update language tests.
Update status files.
Allow map literals to specify a key type that is not a String.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//21049012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25666 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 15:20:28 +00:00
johnniwinther@google.com a7d13fa228 Treat ambiguous types as malformed.
BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org//21065002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25605 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 05:59:15 +00:00
johnniwinther@google.com 62c042d679 Support new malformed types semantics.
BUG=http://dartbug.com/8325,http://dartbug.com/9056
R=karlklose@google.com

Review URL: https://codereview.chromium.org//19097003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25553 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-29 10:19:58 +00:00
zra@google.com dad3270d95 Implements far branch targets for MIPS.
This change adds a flag --mips-far-branches, which when set causes
relative branches to be converted to absolute branches by determining
the PC, adding the branch offset to it, and using the jr or jalr
instruction to jump if the branch test passes.

This procedure clobbers the assembler temporary TMP, so TMP can no
longer be used in a branch test or in the branch delay slot of a
relative branch. Because TMP can't be used in a branch test, a
new temporary is introduced CMPRES2. This change replaces TMP with
CMPRES1 or another register where TMP can no longer be used.

Tests that were failing due to a too-far relative have the
--mips-far-branches flag set.

R=regis@google.com

Review URL: https://codereview.chromium.org//20369003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25543 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 23:30:32 +00:00
asiva@google.com c538002bc1 Fix status file (error_stacktrace_test fails only on dart2js)
Review URL: https://codereview.chromium.org//20507002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25500 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 21:23:50 +00:00
asiva@google.com 1b535a42e4 Mark error_stacktrace_test as Failing on dart2dart (Issue 11681).
Review URL: https://codereview.chromium.org//20426004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25495 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 20:31:36 +00:00
regis@google.com 7b9a84dfbb Implement more restrictive checking of typedefs illegally referring to
themselves and fix vm issue 9611.
Update a test and add a test.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//19997003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25382 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 23:17:42 +00:00
floitsch@google.com 1c1dfeff27 Add failing throw test.
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//19670015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25339 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 12:06:25 +00:00
ngeoffray@google.com 8130feb2f8 Update status for dart2dart.
Review URL: https://codereview.chromium.org//19653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25216 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 14:00:27 +00:00