0e099ff048
Check that class member names do not conflict with type parameters
...
Implement check that member names do not conflict with type
parameters. Simplify name checks in class namespace.
Mark typevariable_mirror_metadata_test as failing now that we
report the proper compile time errors. (The test expects no errors.)
Some co19 tests expect a name conflict between a setter X= and type
parameter X. This is still in flux from a language perspective. This
change list does not introduce an compile error for this case.
Fix for issue 13701.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//27619002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28808 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 17:39:08 +00:00
e872bec1c3
Update status.
...
BUG=
Review URL: https://codereview.chromium.org//26216007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28789 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 07:59:58 +00:00
c7a9f21e26
Update check for cyclic typedefs.
...
BUG= http://dartbug.com/9792 , http://dartbug.com/11986
R=karlklose@google.com
Review URL: https://codereview.chromium.org//27019003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28786 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 07:05:18 +00:00
15bc17777f
Add mirror tests for generic interfaces. Add base-language test for malbounded interfaces.
...
B=http://dartbug.com/14118
R=gbracha@google.com , regis@google.com
Review URL: https://codereview.chromium.org//27378002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28703 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 01:06:56 +00:00
c646aed258
Implement new mixin application syntax
...
Implment the class X = S with M syntax, add warning on deprecated
typedef syntax. Also convert a handful of tests. More tests to
be converted subsequently.
R=regis@google.com
Review URL: https://codereview.chromium.org//27223005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28652 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 16:13:02 +00:00
a2a244ea1c
Switch dart2js 'typedef name = mixinApplication' to 'class name = mixinApplication'.
...
BUG=
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//26651006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28561 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 00:55:17 +00:00
c284d119a1
Base-level test for equality of f-bounded types.
...
BUG=http://dartbug.com/14000
R=gbracha@google.com , regis@google.com
Review URL: https://codereview.chromium.org//26124004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28534 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 17:52:55 +00:00
526b539a4e
Suppress crash in language/source_self_negative_test on drt on mac
...
We are hitting an assertion, see issue 14003 for details.
R=kasperl@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//26974002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28498 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 06:13:21 +00:00
42ceee4cba
Allow malbounded literal types (fix issue 13952).
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//26866005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28474 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 20:45:09 +00:00
f6c9abbc43
Add test for using a type literal for a malbounded type. Crashes the VM in debug mode.
...
R=gbracha@google.com , regis@google.com
Review URL: https://codereview.chromium.org//26761002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28428 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 23:09:30 +00:00
d744ef69c5
Add test for conflicts between type variables and instance or static getters, methods or fields.
...
R=gbracha@google.com
Review URL: https://codereview.chromium.org//24650002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28413 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 20:06:58 +00:00
b87ef6ab7f
Final variables induce a setter that throws NSME
...
Clean up handling of const and final variables. They induce a
setter that throws a NSME, rather than a compile-time error.
Delay the AST conversion of loading a const field into loading
the literal value. The conversion is now done when we know
that the load in on the right hand side of an expression.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//26703002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28408 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 17:33:10 +00:00
334fd6bf07
Mark spawnFunction tests as Fail on Dartium
...
See corresponding Dartium CL:
https://chromiumcodereview.appspot.com/26397003/
This disables spawnFunction on DOM enabled isolate (i.e., where
dart:html is available). spawnFunction should continue to work on
non-DOM enabled isolated. spawnUri should be unaffected.
R=asiva@google.com
Review URL: https://codereview.chromium.org//26616002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28406 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 16:25:28 +00:00
b17b785118
Add test for new final-field implicit setter semantics.
...
BUG= http://dartbug.com/13917 http://dartbug.com/13918 http://dartbug.com/13919
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//26682002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28400 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 11:27:30 +00:00
f6d557f8d6
Mark language/issue13474_test as flaky on none-dartium
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//26224002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28299 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 06:46:04 +00:00
ac254a8633
Status file update for builders runnig none-dartium tests
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//26194002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28297 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-06 21:10:25 +00:00
1676113897
Fix runtimeType for strings, integers and double: return their interface type.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//25674017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28286 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 22:08:55 +00:00
14dce1057e
Second round of status file updates after enabling none-dartium tests on dartium-inc builders
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//25892008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28265 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 14:32:38 +00:00
85123edd06
Fix test expectations for dartium.
...
R=fschneider@google.com
Review URL: https://codereview.chromium.org//25883011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28255 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 09:26:13 +00:00
edacf33810
Status file update for none-dartium
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//25896005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28254 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 09:25:26 +00:00
3393756849
Don't evaluate the argument twice for unresolved static setter calls.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//25877002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28253 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 08:47:10 +00:00
3f238a01a5
Add type check to const conditional expression evaluation
...
issue 13746
R=srdjan@google.com
Review URL: https://codereview.chromium.org//25456005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28182 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 21:08:24 +00:00
a1cbe467e6
Wrong test expectation in const_conditional_test/08
...
Review URL: https://codereview.chromium.org//25674006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28169 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 16:30:00 +00:00
af4976424c
Mark const_conditional_test/08 as failing on drt/dartium
...
TBR=kasperl@google.com
Review URL: https://codereview.chromium.org//25526006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28166 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 14:55:58 +00:00
a7dedab49b
Update status.
...
BUG=
Review URL: https://codereview.chromium.org//25677005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28160 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 13:37:20 +00:00
41135e1734
Handle compile-time constness for conditionals and type literal calls.
...
BUG=http://dartbug.com/13270
R=karlklose@google.com
Review URL: https://codereview.chromium.org//25478009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28154 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 12:43:48 +00:00
22d20313b4
Implement testing support for "--compiler=none --runtime=dartium"
...
This is implemented without the broken unittest-based wrapping of tests.
R=kasperl@google.com
Review URL: https://codereview.chromium.org//25514002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28141 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 07:37:50 +00:00
8a26a3e665
Status file fix
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//25249002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28046 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-30 11:28:04 +00:00
37858af9e7
Fixed status file update: Restrict MissingCompileTimeError to VM (drt doesn't support it)
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//25246002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28045 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-30 10:41:10 +00:00
b470d2572a
Report MissingCompileTime errors on the VM, status file updates for the remaining issues
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//25229002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28043 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-30 08:37:59 +00:00
6531272706
Support forwarding constructors for mixin typedefs (issue 11888).
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//24896002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27979 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-27 00:26:22 +00:00
b0780d316b
Check types of case expressions
...
Implement checks to make sure all case expressions are of the same type and other restrictions.
This change assumes that it's ok to use double values in switch expressions. Will verify with those who are in the know.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//24768004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27968 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 18:54:15 +00:00
3b5628fd1b
Support mixin application typedef as mixin in the VM (issues 9383, 12773).
...
Disallow Object as mixin (issue 10952).
Detect illegal cycles in mixins.
R=hausner@google.com
Review URL: https://codereview.chromium.org//24397002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27791 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 00:25:01 +00:00
81b8e04b61
VM: Fix bug in constant propagation with integer division and modulo.
...
BUG=https://code.google.com/p/dart/issues/detail?id=13498
TEST=tests/language/div_with_power_of_two2_test.dart
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//24360002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27757 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 11:52:09 +00:00
e6fa7db30d
Add crashing test.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//24350004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27749 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 10:24:51 +00:00
26cb84addd
Marking language/lazy_static3_test as failing, it's been failing for a day or so.
...
TBR
BUG=
Review URL: https://codereview.chromium.org//24261009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27728 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 23:33:50 +00:00
72499cf8b5
Add mixin language tests.
...
Update status files.
R=hausner@google.com
Review URL: https://codereview.chromium.org//23465033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27679 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 22:20:36 +00:00
f3baeeb6a5
Implement symbol literals in the VM compiler
...
Issue 12171
R=iposva@google.com
Review URL: https://codereview.chromium.org//24240010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27668 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 17:39:16 +00:00
b490fb55a6
Let the inferrer know that lazy variables can also be null incase their initializer throws.
...
R=karlklose@google.com
Review URL: https://codereview.chromium.org//24211003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27664 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 15:40:55 +00:00
cda093e7e0
Fix redirecting constructors
...
Field initializer expressions must not be executed in redirecting
constructors.
Fixes issue 13347
R=regis@google.com
Review URL: https://codereview.chromium.org//23542051
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27628 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 16:02:30 +00:00
9e77e5dac0
Do not evaluate inlined field initializations twice in a redirecting constructor.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//24125005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27549 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-17 07:31:31 +00:00
bbcf74a569
Make "as" a built-in identifier aka pseudo keyword
...
Fixes issues 12551, 13021
R=regis@google.com
Review URL: https://codereview.chromium.org//23542041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27461 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 23:45:41 +00:00
35ac21ec9b
Mark language/field_type_check_test/none as flaky crashing on mac dartium (drt)
...
Filed issue 13266 to track this
Review URL: https://codereview.chromium.org//23460036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27419 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 06:13:03 +00:00
77a766e06b
Add a test for a generic mixin as mixin.
...
Update test status files.
R=hausner@google.com
Review URL: https://codereview.chromium.org//23444040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27221 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 22:51:31 +00:00
5c0b92e347
Fix number scanning
...
Removing an old, Dash-era hack that makes 2is a faulty number
literal rather than the number 2 followed by the identifier or
keyword "is".
Also fix number_identifier_test.dart which contains an access
to a non-existent getter "memberName" of class NoSuchMethodError.
Review URL: https://codereview.chromium.org//23711004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27216 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 22:11:50 +00:00
a2865875f2
Update language.status
...
Add some more issue numbers. Rewrite some tests
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23621022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27193 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 12:37:31 +00:00
0b6479cdaf
Change language/number_identifier_test to be correct.
...
Also make it more comprehensive.
BUG: http://dartbug.com/13014 http://dartbug.com/13015
R=ahe@google.com
Review URL: https://codereview.chromium.org//23868006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27187 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 10:28:29 +00:00
0c6d6fb90e
Update the tests testing the use of built in identifiers
...
Updated the actual list of built in identifiers as of the current spec (0.51).
Changed the names of the tests from pseudo_kw_* to built_in_identifier_*
Try to track the actual identifiers which are not working in dart2js.
R=ahe@google.com , kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//23716002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27117 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 12:09:32 +00:00
c8f4cbb263
Support symbol literals.
...
BUG=
R=ahe@google.com
Review URL: https://codereview.chromium.org//21511003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27095 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 06:32:44 +00:00
92e97e5d1a
Fix bug with reflection on VM-internal native methods.
...
My previous approach was not enough, since methods can
be invoked via reflection before they are parsed/compiled.
This CL fixes the problem at hand, but I'd like a more general
approach to mark those methods. Maybe an annotation at the declaration
would be better.
I also refactored the test case as suggested in the previous code review.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//23458008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27009 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 10:43:59 +00:00
hausner@google.com