Commit Graph

3219 Commits

Author SHA1 Message Date
regis@google.com aa6bc1b190 Enable co19 tests on SIMARM and mark 12 of them as failing.
R=zra@google.com

Review URL: https://codereview.chromium.org//16232010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23449 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 00:38:55 +00:00
jwren@google.com 30c9e6eb7a Implementation of CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE error code.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//15855005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23440 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 20:06:28 +00:00
scheglov@google.com c082d9f570 Report CompileTimeErrorCode for 'const' argument mismatch.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//15797007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23374 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 01:22:56 +00:00
karlklose@google.com ec4d0c7a5d Reapply "Make int a double in argument type checks."
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23229

Review URL: https://codereview.chromium.org//16008003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23267 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:40:55 +00:00
ngeoffray@google.com 70e8ff8403 Fix issue 9228, by nopt doing some optimizations in checked mode.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//15988003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23263 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:04:11 +00:00
kustermann@google.com a8857ed49c Status file updates for arm -> remove Skip markers
R=ricow@google.com

Review URL: https://codereview.chromium.org//15956005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23242 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 09:09:38 +00:00
scheglov@google.com 33327969d3 Ensure that 'throw' has expression.
Both VM and dart2js support "rethrow" now, so it is time to start to report error for "throw" without exception.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15758006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23231 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 19:01:38 +00:00
karlklose@google.com 1a54bf654b Revert "Reapply "Make int a double in argument type checks.""
This reverts commit r23229.

R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//16110002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23230 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 17:05:47 +00:00
karlklose@google.com 8f283695b6 Reapply "Make int a double in argument type checks."
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//16008003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23229 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 16:47:47 +00:00
ngeoffray@google.com e5b94c9a7d Fix dart2dart status.
Review URL: https://codereview.chromium.org//16101006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23222 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 13:13:07 +00:00
ngeoffray@google.com a8da79c004 Create a new scope when analyzing then and else of an if.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//16043007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23215 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 12:15:57 +00:00
karlklose@google.com f75af837f5 Revert "Make int a double in argument type checks."
This reverts commit r23139.

TBR=ngeoffray@google.com

Review URL: https://codereview.chromium.org//16008002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23143 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 12:55:46 +00:00
karlklose@google.com 853af76aa6 Make int a double in argument type checks.
BUG=dartbug.com/10841
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//15744017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23139 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 12:38:15 +00:00
floitsch@google.com d6e469c7e4 Update status files with co19 issue numbers.
R=lrn@google.com

Review URL: https://codereview.chromium.org//15881002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23134 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 11:56:01 +00:00
kustermann@google.com 6f8f27dfc0 First status file updates for chromeOnAndroid runtime
R=ricow@google.com

Review URL: https://codereview.chromium.org//15915007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23124 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 08:28:25 +00:00
asiva@google.com a1da7e93a4 Fix some of the negative language tests in preparation for implementing
delayed class parsing in Dart VM.
- Some of the tests under tests/language expect compile-time errors but
  these tests do not use the class which has errors. When the VM will
  implement delayed parsing of classes (classes are parsed only if they
  are used) these tests will fail as the Dart VM will not report these as
  compile-time errors. The option VMOptions=--compile_all has been added
  to these tests to ensure that all classes are compiled and the error
  is reported.
- One co19 test has a similar issue and a bug has been filed against it
  (co19 issue 415). the co19-runtime.status file has been updated to
  skip this test until issue 415 is resolved.

R=iposva@google.com

Review URL: https://codereview.chromium.org//15496005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23113 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 23:38:56 +00:00
scheglov@google.com e30c1c3fab Issue 10091. Type literal is a constant.
https://code.google.com/p/dart/issues/detail?id=10091

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15763006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23112 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 23:15:36 +00:00
scheglov@google.com 9c459f8ae0 Issue 8801. Report problems for missing [] or []=
https://code.google.com/p/dart/issues/detail?id=8801

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23078 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 16:31:10 +00:00
floitsch@google.com 09d7da9250 Rewrite double.parse.
BUG= http://dartbug.com/5654
R=lrn@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23062

Reverted: https://code.google.com/p/dart/source/detail?r=23065

Committed: https://code.google.com/p/dart/source/detail?r=23066

Reverted: https://code.google.com/p/dart/source/detail?r=23068

Review URL: https://codereview.chromium.org//15333006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23071 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 14:30:16 +00:00
scheglov@google.com 8f26879fe9 Report parameters/arguments count mismatch
https://code.google.com/p/dart/issues/detail?id=10108
https://code.google.com/p/dart/issues/detail?id=10302
https://code.google.com/p/dart/issues/detail?id=10494

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//15745013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23039 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-22 19:36:50 +00:00
ngeoffray@google.com ce27cf3491 Remove this test. It is covered by tests/language/factory_return_type_checked_test.dart.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//15714002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23002 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-22 09:53:50 +00:00
scheglov@google.com 9782f5dd95 Fix status files and test.
Forgot to rollback one test.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//15563012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22947 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 16:15:35 +00:00
scheglov@google.com 9bb9bd3c36 Report DUPLICATE_CONSTRUCTOR_NAME and other scope fixes
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//15271006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22945 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-21 15:35:43 +00:00
scheglov@google.com 1242ab6487 Report MULTIPLE_REDIRECTING_CONSTRUCTOR_INVOCATIONS and other redirection related.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//15316011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22899 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-20 19:49:44 +00:00
scheglov@google.com 5ef1199b61 Report ParserErrorCode.CONST_CONSTRUCTOR_WITH_BODY and other body-related errors
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//15269005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22891 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-20 15:56:52 +00:00
scheglov@google.com e79e1c52c7 Report CTEC.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15409002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22888 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-19 23:47:10 +00:00
scheglov@google.com e18c8801df Update CONST_CONSTRUCTOR_WITH_NON_FINAL_FIELD to check also super/mixin types
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15409004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22887 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-19 23:38:00 +00:00
scheglov@google.com f072f62f11 Handle the new analyzer type warnings in tests.
Unfortunately we are back to 600+ failing tests.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//14858051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22876 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 21:55:52 +00:00
scheglov@google.com 14cebd0b05 Report ParserErrorCode.MISSING_IDENTIFIER
Fixes many trivial co19 tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15260002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22875 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 21:37:14 +00:00
scheglov@google.com f9b3d290cd Report UNDEFINED_CONSTRUCTOR_IN_INITIALIZER and others
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//14856021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22855 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 16:09:04 +00:00
scheglov@google.com c1e870fc03 Report CTEC.RECURSIVE_CONSTRUCTOR_REDIRECT
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15162010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22852 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 15:35:33 +00:00
karlklose@google.com 35da54ead7 Reapply "Enable full type-checks in checked mode."
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//15299002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22846 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 11:46:39 +00:00
karlklose@google.com 7be3121cb7 Revert "Reapply "Enable full type-checks in checked mode.""
This reverts commit r22840.

Review URL: https://codereview.chromium.org//15287002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22843 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 10:24:30 +00:00
karlklose@google.com c4c7c4ba98 Reapply "Enable full type-checks in checked mode."
This reapplies codereview.chromium.org/13019003/ with a bug fix for type-variable references in factory constructors.

R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//15023021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22840 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 09:53:19 +00:00
johnniwinther@google.com cb7bedf860 Implement continue for switch.
The overall strategy is to convert the following:

switch (e) {
  l_0: case e0: s_0; break;
  l_1: case e1: s_1; continue l_i;
  ...
  l_n: default: s_n; continue l_j;
}

into this:

var label;
switch (e) {
  case e0: label = 0; break;
  case e1: label = 1; break;
  ...
  default: label = n; break;
}
l: while (true) {
  switch (label) {
  case 0: s_0; break l;
  case 1: s_1; label = i; continue l;
  ...
  case n: s_n; label = j; continue l;
  }
}

BUG=http://dartbug.com/8270
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//14969004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22838 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 09:35:05 +00:00
ngeoffray@google.com 0ef85d0e68 JS engines have different evaluation order for a.foo(b.foo). Now that we de nore inlining, b.foo always gets evaluated first.
Review URL: https://codereview.chromium.org//15278002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22837 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-17 09:24:08 +00:00
scheglov@google.com f7f4a68d72 Report ParserErrorCode.CONSTRUCTOR_WITH_RETURN_TYPE
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15063006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22824 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 23:13:29 +00:00
scheglov@google.com e2d48ce25a Report CTEC.FIELD_INITIALIZER_REDIRECTING_CONSTRUCTOR
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//14951006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22821 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 22:46:29 +00:00
scheglov@google.com 0523ecb9db Report CompileTimeErrorCode.REFERENCE_TO_DECLARED_VARIABLE_IN_INITIALIZER
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//14569025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22795 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-16 15:02:50 +00:00
scheglov@google.com b1ac8785fa Report NON_CONSTANT_VALUE_IN_INITIALIZER
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15096008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22747 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-15 16:59:17 +00:00
scheglov@google.com 4a64347799 Report CompileTimeErrorCode.INVALID_CONST_FACTORY
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//14654013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22746 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-15 16:24:00 +00:00
karlklose@google.com a80f7eb610 Revert "Enable full type-checks in checked mode."
This reverts commit r22735.

BUG=

Review URL: https://codereview.chromium.org//14698026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22740 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-15 14:18:56 +00:00
karlklose@google.com e78c52f366 Enable full type-checks in checked mode.
BUG=
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//13019003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22735 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-15 13:40:59 +00:00
scheglov@google.com 76e2c6438d Report CompileTimeErrorCode.INVALID_FACTORY_NAME_NOT_A_CLASS
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//14671018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22706 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-14 21:39:51 +00:00
scheglov@google.com 88943dfad4 Report CompileTimeErrorCode.SUPER_IN_INVALID_CONTEXT
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//14622019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22694 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-14 18:13:54 +00:00
scheglov@google.com bae1738fbc Report CTEC.CONST_WITH_TYPE_PARAMETERS
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15095009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22651 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 20:55:03 +00:00
scheglov@google.com 0b9c15a102 Report CompileTimeErrorCode.CONST_WITH_UNDEFINED_CONSTRUCTOR
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//14985013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22631 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 16:23:03 +00:00
scheglov@google.com e5a8305015 Report CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_OPERATOR
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//14592005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22630 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 16:06:49 +00:00
scheglov@google.com fca6f20722 Report CompileTimeErrorCode.NON_CONST_MAP_AS_EXPRESSION_STATEMENT
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//14761016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22627 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-13 15:34:16 +00:00
scheglov@google.com 1360d1f830 Report StaticWarningCode.NEW_WITH_NON_TYPE and CompileTimeErrorCode.CONST_WITH_NON_TYPE
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//14855015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22590 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-10 18:00:48 +00:00