Commit Graph

3219 Commits

Author SHA1 Message Date
scheglov@google.com 58023de103 Report WRONG_NUMBER_OF_PARAMETERS_FOR_SETTER for optional/named parameters.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//17574003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24344 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 16:24:41 +00:00
scheglov@google.com c5f42c2fb3 Report CTEC.INSTANCE_MEMBER_ACCESS_FROM_STATIC
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//17587006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24343 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 16:20:48 +00:00
scheglov@google.com b4ec80d99d Report NO_DEFAULT_SUPER_CONSTRUCTOR_EXPLICIT as CTEC.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//17581003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24342 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 16:16:26 +00:00
scheglov@google.com 98b7f1b750 Report ParserErrorCode.NORMAL_BEFORE_OPTIONAL_PARAMETERS
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//17582003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24341 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 16:10:53 +00:00
scheglov@google.com 05b5467dcd Report CONST_EVAL_TYPE_BOOL when left operand of || is 'true'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//17583005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24340 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 16:06:20 +00:00
floitsch@google.com 506a2b3a61 Revert "Make Error capture a stacktrace when it is created."
Revert "Mark co19 test as flaky (crashes on buildbot, not locally)."

This reverts commit r24323.
This reverts commit r24327.

Review URL: https://codereview.chromium.org//17580020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24337 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 14:19:28 +00:00
kasperl@google.com 9f6e5773a0 Update status files.
TBR'ed.

R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//17573013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24336 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 14:09:59 +00:00
karlklose@google.com 63d4b42a35 Update dart2dart test expectations.
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//17578004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24334 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 13:50:00 +00:00
kasperl@google.com 271a6bd788 Limit the amount of inlining we do to try to avoid generating too much code.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//17580016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24332 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 13:26:32 +00:00
lrn@google.com 300ff71016 Mark co19 test as flaky (crashes on buildbot, not locally).
Review URL: https://codereview.chromium.org//17582010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24327 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 13:04:42 +00:00
johnniwinther@google.com eb2b22d356 Remove dart2dart status failures.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//17569012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24321 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 10:46:56 +00:00
johnniwinther@google.com 28acc13c57 Update status files.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//17573005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24313 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 09:09:07 +00:00
johnniwinther@google.com 2432ac4647 Support runtime check of function types.
New scheme for checking function subtyping:

1) Generate an $isX predicate on objects that are statically known subtypes of a given function type
2) Generate a signature encoding the whole function type on objects when a runtime check is needed.

A check succeeds if either 1) or 2) is true.

If too many predicates are needed a signature is generated instead, and if a signature is needed, no predicates are generated. Maximum number of predicates is currently determined by the magic constant MAX_FUNCTION_TYPE_PREDICATES in emitter.dart.

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24286

Review URL: https://codereview.chromium.org//12334070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24309 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 06:58:55 +00:00
johnniwinther@google.com 90bf6203ee Revert "Support runtime check of function types."
This reverts commit r24286.

BUG=

Review URL: https://codereview.chromium.org//17413013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24288 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 14:02:47 +00:00
johnniwinther@google.com 2ce76ed94a Support runtime check of function types.
New scheme for checking function subtyping:

1) Generate an $isX predicate on objects that are statically known subtypes of a given function type
2) Generate a signature encoding the whole function type on objects when a runtime check is needed.

A check succeeds if either 1) or 2) is true.

If too many predicates are needed a signature is generated instead, and if a signature is needed, no predicates are generated. Maximum number of predicates is currently determined by the magic constant MAX_FUNCTION_TYPE_PREDICATES in emitter.dart.

R=karlklose@google.com

Review URL: https://codereview.chromium.org//12334070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24286 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-21 13:35:56 +00:00
karlklose@google.com ad097aba4c Fix dart2dart test expectations.
Review URL: https://codereview.chromium.org//17497002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24227 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 13:49:04 +00:00
ricow@google.com 166314d75c Fix status file that broke the build in last commit
Review URL: https://codereview.chromium.org//17471004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24226 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 13:20:50 +00:00
ricow@google.com d301b86ea0 Mark co19/LibTest/core/Stopwatch/elapsed_A01_t01 as flaky on the vm on windows.
Filed http://dartbug.com/11382

R=kustermann@google.com

Review URL: https://codereview.chromium.org//17315019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24225 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 13:02:29 +00:00
ngeoffray@google.com 4dd4831e6e Update status file.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//16938012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24224 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 13:00:53 +00:00
karlklose@google.com 28d5718b86 Add type arguments to constants.
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//16549004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24223 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 12:52:12 +00:00
zra@google.com 8240363b78 Enables co19 tests for SIMMIPS.
Also fixes a bug in division.

R=regis@google.com

Review URL: https://codereview.chromium.org//17312003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24147 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-18 15:51:27 +00:00
kasperl@google.com 9ab39a0fab Update status file for weird co19 issue.
TBR'ed.

R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//17401002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24143 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-18 14:05:40 +00:00
hausner@google.com 457bb1bdcb Remove support for + prefix in number literals
Also fix some tests that expected + prefix in hex numbers to be illegal. According to our documentation, int.parse() accepts + for numbers in all formats/radixes.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//17103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24051 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 21:16:46 +00:00
zra@google.com 826b6ce267 Fix status files for SIMARM, SIMMIPS.
R=asiva@google.com

Review URL: https://codereview.chromium.org//16972005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24014 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 22:28:34 +00:00
lrn@google.com 7142acf5ef Also mark co19/.../RegExp/allMatches_A01_t01 as always failing.
Was only marked as failing in checked mode.

Review URL: https://codereview.chromium.org//16928011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23986 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 14:43:27 +00:00
lrn@google.com 381ef586fb Fix bug in co19-status for pattern test, should also fail in unchecked mode.
Review URL: https://codereview.chromium.org//16958007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23983 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 14:24:33 +00:00
lrn@google.com 701101247a Move incorrectly placed co19 test expectations.
Review URL: https://codereview.chromium.org//16843011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23981 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 14:10:35 +00:00
lrn@google.com 9b67f92679 Use Pattern.matchAsPrefix to let String.indexOf/lastIndexOf/startsWith accept Pattern.
Rearranged co19-runtime.status to only have one section for each configuration,
and tried to keep them in a logical order.

BUG=http://dartbug.com/11129
R=floitsch@google.com

Review URL: https://codereview.chromium.org//16957002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23974 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 12:49:44 +00:00
srdjan@google.com 1affede0be Fix broken Mac SIMARM by adapting the status files. We need to find a better way to handle this :-).
R=zra@google.com

Review URL: https://codereview.chromium.org//16871006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23947 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 00:36:12 +00:00
srdjan@google.com 5543ce104c When canonicalize instances check if all fields are canonical. If a field is a non-canonical number or strings, canonicalize it. Otherwise report an error if a field is not canonical.
R=hausner@google.com

Review URL: https://codereview.chromium.org//16780009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23934 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 21:27:37 +00:00
regis@google.com 264d28744f Fix decoding of object pool access in code patching on ARM.
Fix shift by zero and divide by one on ARM.
Update test status files.

R=zra@google.com

Review URL: https://codereview.chromium.org//16695007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23920 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 16:57:06 +00:00
lrn@google.com 8f0ed0b941 Mark dart2dart failing on co19 tests.
Review URL: https://codereview.chromium.org//16193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23737 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-07 09:46:35 +00:00
zra@google.com 7718086a5f Fixes small ARM bugs, and updates status files.
R=srdjan@google.com

Review URL: https://codereview.chromium.org//16054007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23718 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 21:52:26 +00:00
scheglov@google.com 80fea8fd8e More fixes for java2dart and status files.
Now DDA passes/fails the same tests as Java version.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15675016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23705 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 18:13:44 +00:00
jwren@google.com 104baea740 Fix for the broken analyzer-FYI bot
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//16410006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23697 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 16:57:58 +00:00
lrn@google.com 7823dcbc1f Fix expectations for co19 RegExp tests.
Fix dart2js validation errors.
The tests were assuming the incorrect VM behavior for Match.pattern.

Review URL: https://codereview.chromium.org//16146011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23677 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 12:21:16 +00:00
lrn@google.com 450e0f64d9 Fix-up RegExp implementations.
VM _JSRegExpMatch didn't have correct "pattern" getter and exposed
too many members. Also didn't allow matching an empty match at the
end of the string with .allMatches.

JS RegExp didn't advance the position correctly after an empty match.

BUG=http://dartbug.com/1301, http://dartbug.com/6554
R=floitsch@google.com, ngeoffray@google.com

Review URL: https://codereview.chromium.org//16206008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23675 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 11:44:04 +00:00
scheglov@google.com d775a9cef3 Fixes for translator and DDA status files.
Almost everything is again translated automatically.

There are three fragments which we have to replace to source level.
One for performance reasons; two others - to avoid using IO.

Now we are green for co19 tests, execute 4034 of them in 2:07, 132 failures.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//16103010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23624 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 00:59:32 +00:00
srdjan@google.com d883e45e43 Update status files for simarm tests on Mac OS X.
R=zra@google.com

Review URL: https://codereview.chromium.org//16286022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23609 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 19:46:16 +00:00
scheglov@google.com 5dd168e367 Share DartSdk instance in Java-based CLI Dart Analyzer.
Running all shared tests is just 1:40 with this CL!

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//16359011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23603 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 16:54:42 +00:00
scheglov@google.com 0d3e47da2c Basic dart^2 analyzer tests running.
Status file only for co19 now, more status files in next CL.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//16357010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23602 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 16:09:13 +00:00
fschneider@google.com 004a1f81c9 Enable optimization of try-finally in the VM's optimizing compiler.
I changed the status of two co19 tests that crash with a stack overflow
because of recursion in dart2js. Optimized functions may take more stack
space, and this CL enables optimizations for more functions in dart2js.

I added smaller versions of those two tests to our own test suite.

BUG=dart:8857
R=ahe@google.com

Review URL: https://codereview.chromium.org//15934013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23597 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 14:35:43 +00:00
lrn@google.com 3266bf4c4b Fix expectations now that we actually throw CyclicInitializationError.
Review URL: https://codereview.chromium.org//16356005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23587 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 11:06:12 +00:00
jwren@google.com cec8d9040a Update status files to mark passing tests as passing for the dart-analyzer.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//16337009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23555 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 18:27:15 +00:00
zra@google.com 1eaa74c013 Updates status files so that arm and simarm are the same.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//15927015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23550 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 16:44:20 +00:00
regis@google.com 64bd9656a1 Third try.
Review URL: https://codereview.chromium.org//15715028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23478 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 17:22:56 +00:00
regis@google.com 4546d7f19f Second try.
Review URL: https://codereview.chromium.org//15715025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23477 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 16:58:42 +00:00
regis@google.com 75f17ebadb Mark a co19 test as flaky on SIMARM until further investigation.
Review URL: https://codereview.chromium.org//16255008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23474 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 16:23:52 +00:00
jwren@google.com df47dc0740 Cover the 'extends' and typedef cases of the CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE error code.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//16231012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23473 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 16:19:56 +00:00
kasperl@google.com 87d2467ded Fix issue with dart2dart translation of parameters (collision risk).
R=antonm@google.com
BUG=http://dartbug.com/10996

Review URL: https://codereview.chromium.org//15959017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23458 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 08:54:43 +00:00