Commit Graph

774 Commits

Author SHA1 Message Date
zra@google.com 3eba8b8f77 Avoids MIPS32r2 instructions on MIPS32.
Adds necessary feature detection to tell the difference.

R=regis@google.com

Review URL: https://codereview.chromium.org//211363007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34391 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 21:30:51 +00:00
whesse@google.com e1511e8392 Add more ContentShellOnAndroid entries to status files.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//204103007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34111 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 12:52:21 +00:00
johnmccutchan@google.com 76ef3034d1 Fix VM status
TBR

Review URL: https://codereview.chromium.org//195893039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34072 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:14:42 +00:00
johnmccutchan@google.com 6952f5ddfe Use VM tag in profile and add stack trace trie
R=asiva@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//201213004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34064 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 21:20:41 +00:00
whesse@google.com 9b1a6aa809 Add mips failures to status files.
BUG=dartbug.com/17440
R=kustermann@google.com

Review URL: https://codereview.chromium.org//203313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33811 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 16:20:36 +00:00
whesse@google.com 04fc336f32 Update mips test status files for new mips build slaves.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//196133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33585 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:21:15 +00:00
fschneider@google.com d6178535b2 Landing: Write protect executable pages in the VM.
Change executable pages to be read/execute but not writable by default.

All pages are made temporarily writable just before a full GC, because both
the mark and sweep phases write to the pages. When allocating in a page and
when patching code, the pages are made temporarily writable.

The order of allocation of Code and Instructions objects is changed so that
a GC will not occur after Instructions is allocated. (A full GC would
render the Instructions unwritable.) A scoped object is used to make memory
protection simpler.

Original CL: https://codereview.chromium.org/106593002/

I added a cc test that is expected to crash.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//136563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32493 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 12:18:06 +00:00
johnmccutchan@google.com 7f75b32faa Mark Service_Coverage as Skip on SIMMIPS
BUG=

Review URL: https://codereview.chromium.org//140253010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31976 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-22 16:39:22 +00:00
johnmccutchan@google.com c55a51e081 Disable profiler
Review URL: https://codereview.chromium.org//128953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31618 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 18:41:05 +00:00
hausner@google.com c571528323 Make return statements single steppable
Replace the code smashing breakpoints at function returns with a call
to a runtime stub that checks whether the debugger is single stepping.
The call to the stub is only emitted in unoptimized code.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//106053011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31435 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-02 23:31:52 +00:00
hausner@google.com 15e8f121dd Change how debugger handles source breakpoints
- Identify a source breakpoint by a script and a token position
  rather than a function object.
- When a new breakpoint is set, iterate over all compiled functions
  to see whether code breakpoints must be set.

This change fixes issues with functions that get compiled several
times, for example as implicit closures or a copies of mixin
functions or local closures of mixing functions. We did not detect
all duplicates of functions.

Eliminated recently introduced const modifiers in SourceBreakpoint
class. They tend to be in the way because several accessor methods
of SourceBreakpoint compute data lazily and modify the object as a
side effect.

Review URL: https://codereview.chromium.org//117133005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31372 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-26 20:53:58 +00:00
johnmccutchan@google.com 919dc2d6eb * Introduce ThreadInterrupter which calls a TLS set callback when thread is interrupted.
* Threads can only register and unregister themselves with ThreadInterrupter.
* Profiler is no longer involved in interrupting threads. It's just a callback and the buffer.
* Profiler operates lock free using an atomic operation to reserve sample in sample buffer.
* Linux, Mac, and Windows done.

R=asiva@google.com

Review URL: https://codereview.chromium.org//109803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31170 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-16 18:52:15 +00:00
rmacnak@google.com 07c3de9310 Mirror implementation removals: async invoke, mirrorSystemOf(port), Mirror.mirrors.
(API was removed in r29492)

R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//23460050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29698 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 21:01:59 +00:00
rmacnak@google.com 0abc881d9e Mirror API removals: async invocations, mirrorSystemOf(port), Mirror.mirrors.
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//45293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29492 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 21:14:19 +00:00
kustermann@google.com 94ebff2225 Bugfix in test.dart, adding of specialized test outcomes for analyzer
This CL will:
 - fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
   we did not report that the analyzer was missing a warning).
 - make the outcome of running the analyzer on a test be one of:
   * CompileTimeError
   * MissingCompileTimeError
   * StaticWarning
   * MissingStaticWarning
 - Make status file updates using the new Expectation markers
 - Remove support for '@static-clean':
     Previously running the analyer on a test could either result in
     'Pass' or in 'Fail'. The '@static-clean' annotation has been used
     as a (poor) mechanism to distinguish between errors and warnings.
     Having the 4 markers mentioned above means we can remove '@static-clean'
 - Remove 100 lines of rotted legacy code in our testing scripts.
 - Make a status file entry for every test that has analyzer errors or warnings

R=ricow@google.com

Review URL: https://codereview.chromium.org//46163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:39:38 +00:00
iposva@google.com 6267207e64 - Account for hidden frames when concatenating throw and
catch traces.

R=asiva@google.com

Review URL: https://codereview.chromium.org//41503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29218 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 22:08:33 +00:00
iposva@google.com e8f2abb833 Fix build:
- Dartium is skipping some numbers when creating frames.

Review URL: https://codereview.chromium.org//38833003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29140 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 01:16:10 +00:00
rmacnak@google.com 879539c348 Skip redirection_type_shuffling_test on dart2js.
Review URL: https://codereview.chromium.org//29103011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28968 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 23:10:11 +00:00
rmacnak@google.com 7c67d66df1 Skip mirrored_compilation_error_test on dart2js and Dartium.
Review URL: https://codereview.chromium.org//33673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28951 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:00:42 +00:00
rmacnak@google.com 6a0920d2a6 isolate_mirror_local_test no longer fails the analyzer.
Review URL: https://codereview.chromium.org//33053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28948 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 20:38:40 +00:00
vsm@google.com 334fd6bf07 Mark spawnFunction tests as Fail on Dartium
See corresponding Dartium CL:
https://chromiumcodereview.appspot.com/26397003/

This disables spawnFunction on DOM enabled isolate (i.e., where
dart:html is available).  spawnFunction should continue to work on
non-DOM enabled isolated.  spawnUri should be unaffected.

R=asiva@google.com

Review URL: https://codereview.chromium.org//26616002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28406 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 16:25:28 +00:00
kustermann@google.com 22d20313b4 Implement testing support for "--compiler=none --runtime=dartium"
This is implemented without the broken unittest-based wrapping of tests.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//25514002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28141 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 07:37:50 +00:00
ajohnsen@google.com fac6baef28 Clean up status file.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//24750003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27956 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 14:35:18 +00:00
kustermann@google.com dfbf264f40 Automatically converted general Fail status file markers to one of the more specific markers
R=johnniwinther@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//23494066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27876 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 12:47:03 +00:00
ajohnsen@google.com 0cc1e648e2 Re-enable VM isolate tests.
BUG=https://code.google.com/p/dart/issues/detail?id=6890
R=ricow@google.com

Review URL: https://codereview.chromium.org//24542002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27868 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 09:20:40 +00:00
zra@google.com 6282267aae Fixes slow object pool search on x64.
Issue 13144.

R=iposva@google.com

Review URL: https://codereview.chromium.org//23723008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27494 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-13 18:10:04 +00:00
zra@google.com eb28abc920 Updates status file for slow test on x64.
Review URL: https://codereview.chromium.org//23654018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27299 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 16:54:03 +00:00
zra@google.com df2054dae7 Sets a register aside on x64 for use as a pool-pointer. It is loaded and restored from the code object on Frame entry and exit. All LoadObject calls that can, and many calls and jumps through ExternalLabels now use the pool-pointer. The --compiler-stats flag when running dart2js indicates that code size is reduced ~13%, and more is probably possible.
R=fschneider@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//22825023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27295 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 15:39:26 +00:00
ahe@google.com 37a5567eb8 Triage Safari bug 7414.
BUG=http://dartbug.com/7414
R=floitsch@google.com, kustermann@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//23595002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26726 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 17:17:35 +00:00
lrn@google.com f02f2c0a6b Mark CustomIsolates test as potentially crashing.
Review URL: https://codereview.chromium.org//23572002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26702 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 10:41:25 +00:00
lrn@google.com 88b242b66a Mark some tests as failing instead of skipping.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//23550002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26698 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 09:26:10 +00:00
zra@google.com 8ffef7528d Bug fix and status file updates for MIPS HW.
R=regis@google.com

Review URL: https://codereview.chromium.org//22828004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26037 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:45:41 +00:00
kustermann@google.com cb18d8ba87 Removed compiler/ directory from repository
R=ricow@google.com

Review URL: https://codereview.chromium.org//20722006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25728 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-02 08:31:15 +00:00
zra@google.com c09f0f5697 Fixes status file for arm hardware.
After the bugfix in BitVector.Equals(), these vm tests pass.

R=regis@google.com

Review URL: https://codereview.chromium.org//18917002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24849 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 16:30:46 +00:00
zra@google.com 99772465b5 Updates status files for arm hardware
R=regis@google.com

Review URL: https://codereview.chromium.org//17732002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24431 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 20:16:02 +00:00
zra@google.com 8edda78ccc Enables more tests for SIMMIPS.
. Fixes register allocation bugs
. Implements float <-> double conversion in assembler and simulator.
. Fixes floating point argument passing for simarm and simmips,
  and floating point return for simarm, and adjusts tests to match.

R=regis@google.com

Review URL: https://codereview.chromium.org//17502002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24365 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 20:16:16 +00:00
srdjan@google.com b8531f4f49 Mark test pass, crash for simarm, in order to make bot green.
Review URL: https://codereview.chromium.org//17585007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24357 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 18:29:18 +00:00
srdjan@google.com 47de186e76 Store arguments descriptor in ICData. Remove loading of arguments descriptor at unoptimized call site (the ones using ICData).
R=asiva@google.com, zra@google.com

Review URL: https://codereview.chromium.org//17421003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24239 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 16:29:39 +00:00
regis@google.com 68041e2d0d Fix more register allocation bugs in optimized code on ARM.
R=zra@google.com

Review URL: https://codereview.chromium.org//17176004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24191 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 16:21:27 +00:00
regis@google.com 8ea9116067 Fix register allocation bug in optimized code on ARM.
R=zra@google.com

Review URL: https://codereview.chromium.org//17348005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24172 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 08:28:32 +00:00
zra@google.com 826b6ce267 Fix status files for SIMARM, SIMMIPS.
R=asiva@google.com

Review URL: https://codereview.chromium.org//16972005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24014 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 22:28:34 +00:00
regis@google.com 264d28744f Fix decoding of object pool access in code patching on ARM.
Fix shift by zero and divide by one on ARM.
Update test status files.

R=zra@google.com

Review URL: https://codereview.chromium.org//16695007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23920 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 16:57:06 +00:00
zra@google.com c004b84376 Enables more VM tests for SIMMIPS.
Implements:
- Megamorphic instance calls
- Left-shift
- Equality
- and various bug-fixes.

R=regis@google.com

Review URL: https://codereview.chromium.org//15934025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23877 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 20:08:40 +00:00
kustermann@google.com b13c4123b9 Don't skip vm/corelib/isolate/lib/standalone tests on ARM
TBR=zra@google.com

Review URL: https://codereview.chromium.org//16775004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23860 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 15:57:21 +00:00
scheglov@google.com 80fea8fd8e More fixes for java2dart and status files.
Now DDA passes/fails the same tests as Java version.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//15675016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23705 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 18:13:44 +00:00
zra@google.com 1eaa74c013 Updates status files so that arm and simarm are the same.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//15927015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23550 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 16:44:20 +00:00
regis@google.com b7eb5aedbe Cleanup various test status files.
R=zra@google.com

Review URL: https://codereview.chromium.org//16232012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23450 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 00:39:37 +00:00
regis@google.com f4dd36d634 Implement shift left on ARM and re-enable previously disabled test.
Fix bug on ia32 and x64.

R=zra@google.com

Review URL: https://codereview.chromium.org//15827006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23307 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 21:10:32 +00:00
regis@google.com fbd3ba074e Fix equality code on ARM.
R=zra@google.com

Review URL: https://codereview.chromium.org//16048002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23293 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 17:14:47 +00:00
sgjesse@google.com 675156b27f Skip test crasking the ARM simulator
Starting failing after https://code.google.com/p/dart/source/detail?r=23266

TBR=regis@google.com
BUG=

Review URL: https://codereview.chromium.org//15688009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23280 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 14:50:56 +00:00