Commit Graph

774 Commits

Author SHA1 Message Date
asgerf@google.com 2c90643171 dart2js cps: Introduce GetStatic/SetStatic.
The GetStatic is used for reading static fields and tearing off
static methods.

Invoking a static getter/setter (not from a field) is still an
InvokeStatic, which IMO is the way it should remain.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1134063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45735 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 13:35:49 +00:00
karlklose@google.com 0eaa4d4717 cps-ir: Support compilation of methods that use interceptor calling convention.
This is a modified version of sra@'s CL https://codereview.chromium.org/1020243002/ with kmillikin@'s comments addressed.

R=sigurdm@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1109403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45680 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-11 12:38:14 +00:00
ricow@google.com e92f697236 Remove dart2dart support from testing scripts and status files
I will leave it to the dart2js people to remove the support from the dart2js tools (there is also a bunch of comments still in code, do a git grep)

R=kustermann@google.com, floitsch@google.com, kmillikin@google.com
BUG=

Review URL: https://codereview.chromium.org//1126363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45588 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-07 11:29:55 +00:00
ricow@google.com 005befeba2 Skip huge array allocation in ARM tests.
This is suspected to cause flaky C++ OOM crash on the build bot.

R=ricow@google.com

Review URL: https://codereview.chromium.org//1124713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45518 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 06:11:11 +00:00
koda@google.com db58faa53e Fix array allocation overflow check on arm/arm64/mips.
When adding an object size in bytes to the allocation top address,
we must check for *unsigned* overflow, not signed overflow. 32-bit example:
if top is 0xfffff000 and size is 0x1008, then top + size is an unsigned,
but not a signed, overflow.

Add similar unit test for typed data (same issue).

BUG=23254
R=regis@google.com

Review URL: https://codereview.chromium.org//1096063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45354 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 18:32:37 +00:00
zra@google.com a1c3f3356a Marks crashing test as crash on MIPS.
Review URL: https://codereview.chromium.org//1062743004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45283 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 14:42:18 +00:00
koda@google.com db7d4bb417 Skip vm/cc/ArrayLengthMaxElements on simulators while debugging issue 23254.
BUG=23254
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//1062463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45267 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-18 02:36:49 +00:00
zra@google.com 86bfd7cb30 Adds a simarmv5te build and test target.
Also:
- Removes command line flags to choose simulated arm version.
  I think we should use build targets instead, like in this change,
  to make building and testing more obvious.
- Skips pkg tests on all simulators.

R=regis@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//1077823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45181 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 20:44:43 +00:00
karlklose@google.com d839c64766 Establish test expectations for dart2js running with the CPS based backend.
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45162 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 11:44:02 +00:00
zra@google.com 6dc0a4b7a0 Updates status file for fixed test on Android content shell.
R=asiva@google.com

Review URL: https://codereview.chromium.org//1060983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44913 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 15:53:43 +00:00
rmacnak@google.com cb1294bf3c Fix spawning a data uri on Windows.
BUG=http://dartbug.com/22943
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1017923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44691 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 18:15:12 +00:00
rmacnak@google.com 8dcd1db870 Suppress data_uri_spawn_test crash on Windows.
BUG=http://dartbug.com/22943

Review URL: https://codereview.chromium.org//1028633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44618 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 22:55:24 +00:00
rmacnak@google.com 29041fdecc Adjust status of data_uri_failures_test to allow for the browser's more permissive handling of data uris. Don't print in the child isolate to avoid a timeout.
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//1024253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44617 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 22:36:07 +00:00
rmacnak@google.com 0fafad9691 Skip data uri tests on dart2js and the analyzer.
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//1022183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44612 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 20:55:59 +00:00
fschneider@google.com 431f96710c Re-enable and adjust skipped VM debugger tests.
They were skipped because of a long-resolved issue. This required changing
the set of reported variables according to the current debugger implementation.

I adjusted the test to check for substring for the expected function names:

Dart_ActivationFrameGetLocation returns Debugger::QualifiedFunctionName nad
and Dart_FunctionName returns Function::UserVisibleName.
Should the two be made consistent instead?

cc/IsolateInterrupt was skipped on x64 for unknown reasons. It seems to pass fine
(tested locally)

R=hausner@google.com

Review URL: https://codereview.chromium.org//1018373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44597 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 09:25:46 +00:00
whesse@google.com 454a7263ef Update test status for mips tests.
BUG=dartbug.com/22597
R=ricow@google.com

Review URL: https://codereview.chromium.org//962153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44086 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 10:37:56 +00:00
koda@google.com 2a74e16a4f Update status for no longer crashing test.
This issue is made obsolete by r43927.
(Still, I'd still like to figure out why our assumption about the stack was violated.)

TBR=johnmccutchan@google.com

BUG=dart:22488

Review URL: https://codereview.chromium.org//948593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43938 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-21 00:37:05 +00:00
koda@google.com e33cceed6a Correct status for crashing (not failing) Windows test.
R=whesse@google.com
TBR=whesse@google.com

Review URL: https://codereview.chromium.org//937153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43870 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 13:17:04 +00:00
koda@google.com ddfb4a1b3a Mark cc/IsolateSpawn as failing on win debug builds.
BUG=dart:22488
TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//939773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43864 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 04:04:16 +00:00
koda@google.com 8c24d57e15 Update test status for slow ASAN bot.
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//916473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43664 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:58:35 +00:00
ricow@google.com 922f06abad fix status file entry for the vm
SkippedByDesign -> SkipByDesign

R=iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//898043005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43512 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 16:36:48 +00:00
iposva@google.com 23c1843a78 - Only attempt to spawn processes on the VM.
Review URL: https://codereview.chromium.org//899273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43509 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 16:28:30 +00:00
zra@google.com d077e38107 Fix MIPS assembler test.
R=regis@google.com

Review URL: https://codereview.chromium.org//791953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42746 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:59:11 +00:00
regis@google.com 953c735532 Enable more tests on MIPS.
R=zra@google.com

Review URL: https://codereview.chromium.org//778223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42149 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 21:40:05 +00:00
koda@google.com db32247d47 Fix old bug in VirtualMemory::Commit on Windows.
This was recently exposed by VerifiedMemory, which was the first time we commit something that's not the initial part of a reservation.

BUG=dart:21469
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//701113004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41533 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-05 21:29:55 +00:00
whesse@google.com 3da2c473cd Update status for vm and analyzer.
BUG=dartbug.com/21468 dartbug.com/21469
R=ricow@google.com

Review URL: https://codereview.chromium.org//684133006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41418 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 12:33:50 +00:00
koda@google.com d718e29fe9 Fix unintended effects in vm.status.
Review URL: https://codereview.chromium.org//688143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41404 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 21:00:19 +00:00
koda@google.com b6b054e3f1 Add VerifiedMemory helper for write-barrier verification.
Allocates hidden extra memory after VirtualMemory, and
verified writes are duplicated at a fixed offset.

This CL only adds the helper.
Next steps:
1. Use Reserve when reserving semi-spaces and heap pages.
2. Use Write for storing pointers (+ offset in generated code).
3. Use Accept for GC-related object lifecycle.
4. Call Verify regularly.
5. Fix failures (= places where we forget/ignore write barriers).

Review URL: https://codereview.chromium.org//641243004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41399 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 19:56:12 +00:00
rmacnak@google.com 128148aafc Preserve the contents of Dart strings with unmatched surrogate halfs by avoiding a UTF16 -> UTF8 -> UTF16 conversion.
Clean up some confusion between code points and code units.

BUG=http://dartbug.com/20583
BUG=http://dartbug.com/20874
R=turnidge@google.com

Review URL: https://codereview.chromium.org//558853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40174 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 18:42:04 +00:00
iposva@google.com 175815c43a - Update vm.status for failing Windows test.
R=koda@google.com

Review URL: https://codereview.chromium.org//554953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40077 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 03:00:12 +00:00
koda@google.com a82cf5960a Add lost usage update to TryAllocateInternal.
BUG=dart:20056
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//531153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39785 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 23:36:31 +00:00
rmacnak@google.com c7d3dde161 Don't leak memory between iterations of the message serialization benchmarks.
BUG=http://dartbug.com/20767
R=asiva@google.com

Review URL: https://codereview.chromium.org//528073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39781 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 22:07:12 +00:00
whesse@google.com 745857950c Update vm test status on mips.
BUG=dartbug.com/20767
BUG=dartbug.com/20056
BUG=dartbug.com/19328
R=ricow@google.com

Review URL: https://codereview.chromium.org//525373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39728 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-01 14:00:49 +00:00
whesse@google.com 19beb61abc Update mips test status.
R=ricow@google.com

Review URL: https://codereview.chromium.org//439283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38861 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 15:19:10 +00:00
rmacnak@google.com a9db9d480c Fix handle leak in EvalExpressionExhaustCIDs test.
BUG=http://dartbug.com/20056
R=asiva@google.com

Review URL: https://codereview.chromium.org//396403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38315 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-16 22:25:46 +00:00
whesse@google.com c3f10dc026 Skip a vm test on MIPS hardware
The test takes almost 1 GB memory - this is causing crashes.
BUG=dartbug.com/20056
R=kustermann@google.com

Review URL: https://codereview.chromium.org//397683003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38281 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-16 12:12:50 +00:00
rmacnak@google.com bfd342fd8a Remove MirroredCompilationError from the VM.
Regenerate snapshot test due to removed symbol.

BUG=http://dartbug.com/16562
R=regis@google.com

Review URL: https://codereview.chromium.org//389573007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38202 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-14 18:00:04 +00:00
mlippautz@google.com 85ce6bffb9 Coverage data for single entities can be obtained by querying:
* script: isolate/id/script/name/coverage
 * class: isolate/id/class/id/coverage
 * library: isolate/id/library/id/coverage

Some numbers (curl on vm service):
 * old base line (full coverage of dart:core + script computing faculty): ~1.2s
 * generation for just the script file: ~12ms
 * generation of dart:core (after executing fac script): ~150ms
 * generation of dart:core-patch/array.dart: ~12ms

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//346003003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37676 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-25 00:06:53 +00:00
mlippautz@google.com e404ee32cf Update tests/vm/vm.status to exclude Coverage_MainWithClass.
BUG=

Review URL: https://codereview.chromium.org//356463007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37671 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 21:35:18 +00:00
mlippautz@google.com 93feacec1b Exclude coverage test from mips.
TBR

BUG=

Review URL: https://codereview.chromium.org//353743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37667 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-24 19:39:25 +00:00
whesse@google.com a9fcd11101 Update mips status for crashing test
Test vm/cc/JSON_JSONStream_Options is crashing in debug mode on mips hardware.

BUG=dartbug.com/19328
R=ricow@google.com

Review URL: https://codereview.chromium.org//324053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37167 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 08:24:20 +00:00
zra@google.com cc07656a94 Skips snapshot reading benchmark in debug mode for timeout.
Review URL: https://codereview.chromium.org//319173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37080 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 14:48:44 +00:00
zra@google.com ea99b1e6f8 Adds debugger patching to arm64.
Also other small fixes.

R=regis@google.com

Review URL: https://codereview.chromium.org//274043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36003 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-09 23:20:14 +00:00
zra@google.com 5d94e8900f Adds single-precision and SIMD load/store to arm64.
Also adds conversion between double an single-precision floats.

R=regis@google.com

Review URL: https://codereview.chromium.org//269343010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35933 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 19:06:04 +00:00
rmacnak@google.com f4f4713eb8 Put metadata fields in their owner class to maintain the class-field bidirectional relationship asserted Field::PrintJSON.
Extended metadata scope test based on suspicions regarding the ordering of adding type parameters metadata fields versus ordinary fields of a class.

BUG=http://dartbug.com/18652
R=iposva@google.com, regis@google.com

Review URL: https://codereview.chromium.org//269253005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35926 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 18:15:33 +00:00
ajohnsen@google.com c98c3cd65b Mark PrintJSON as crashing.
BUG=

Review URL: https://codereview.chromium.org//271453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35797 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-06 12:09:00 +00:00
hausner@google.com d7524ee0ba Generate escape sequence for non-printable ascii characters
Fix issue 17857.

R=iposva@google.com

Review URL: https://codereview.chromium.org//254553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35411 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-24 22:55:52 +00:00
lrn@google.com 49853292aa Add crash expectation for test in debug mode due to Issue 17857.
Review URL: https://codereview.chromium.org//225023037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34815 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 09:19:13 +00:00
lrn@google.com 88ba8efed9 Optimize one-byte string's toUpperCase.
R=ajohnsen@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//213293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34812 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 07:19:33 +00:00
zra@google.com 2fe51715e5 Begins work on ARM64, first assembler test.
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}

The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.

R=regis@google.com

Review URL: https://codereview.chromium.org//221133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:39:32 +00:00