dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1103 Commits

Author SHA1 Message Date
Alexander Markov 34651d204e [gardening] Update status 
Change-Id: I50470052bd646684d36c793424485a88f1b84ee6
Reviewed-on: https://dart-review.googlesource.com/c/78869
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-10-09 21:24:36 +00:00
Alexander Markov 70317473f0 [gardening] Update status 
Change-Id: Idb7feb6749df6824b0e3029ddc86112b18a7d7b2
Reviewed-on: https://dart-review.googlesource.com/c/78864
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-10-09 18:46:41 +00:00
Ryan Macnak 0039aff1e3 [test] Remove use of --error_on_bad_type and --error_on_bad_override. 
Change-Id: I5b74a4265b25051acfbb35ae9721160b03988121
Reviewed-on: https://dart-review.googlesource.com/c/78708
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-09 16:46:48 +00:00
Alexander Aprelev a2cf88bee6 [vm] Fix sync-async stack navigation to handle inlined functions. 
Bug: http://dartbug.com/34673
Change-Id: I92affde6e9e8e6e2fbf5c2a8ed20bb8a3ad4d028
Reviewed-on: https://dart-review.googlesource.com/c/78580
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-10-09 15:56:07 +00:00
Ryan Macnak 89d753588c [test] Speed up get_vm_timeline_rpc_test.dart. 
Timing out on IA32 optcounter bot.

Change-Id: I1c9324b4712c963c2b22aaf10965c31c92f75406
Reviewed-on: https://dart-review.googlesource.com/c/78704
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-09 01:18:15 +00:00
asiva de18295924 Adjust some status files for the new build configurations added to the buildbots. 
Change-Id: I5b80e45780078e5613a7934751173b091e93628f
Reviewed-on: https://dart-review.googlesource.com/c/78707
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-09 00:49:41 +00:00
Alexander Aprelev 0bd4cc880d [gardening] Mark more tests slow 
Change-Id: I25c9e14b8831de910ba15999f9823604bf5a6885
Reviewed-on: https://dart-review.googlesource.com/c/78402
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-06 05:52:18 +00:00
Alexander Aprelev 20e57c1bcc [gardening] Differentiate windows bot test failures on ia32 vs x64 
Change-Id: I9e7751acb3d68d4916a17eb79f86014a428ba1bf
Reviewed-on: https://dart-review.googlesource.com/c/78401
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-06 05:20:49 +00:00
Alexander Aprelev d54b262888 [gardening] Windows test status adjustments 
Change-Id: If721a2994cd4992d861453f0293625dee9aa076c
Reviewed-on: https://dart-review.googlesource.com/c/78400
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-10-06 04:36:48 +00:00
Alexander Aprelev 35a825ab5f [gardening] Mark service/pause_on_unhandled_async_exceptions2_test with dartk slow. 
Change-Id: I423649e2232dfbb52c7da2a72fee749484af3f14
Reviewed-on: https://dart-review.googlesource.com/c/78325
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 21:54:23 +00:00
Alexander Aprelev ea45756a7b [gardening] Windows dartk test status update. 
Change-Id: I30694678354943edeb2effc108bb922ee6fcb093
Reviewed-on: https://dart-review.googlesource.com/c/78342
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 21:46:58 +00:00
Martin Kustermann 1cd2fc5883 [Gardening] Mark pause_on_unhandled_async_exceptions_test also flaky on kernel 
Issue https://github.com/dart-lang/sdk/issues/34673

Change-Id: I668e0ca670ef380860109653a66e5603fc8ebbbb
Reviewed-on: https://dart-review.googlesource.com/c/78124
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-10-04 16:39:47 +00:00
Martin Kustermann 22da7488ac [Gardening] Mark two service tests as passing on dartk-windows 
Change-Id: I9a905214d5ffa5275e4541740bc61c22d5b0d041
Reviewed-on: https://dart-review.googlesource.com/c/78120
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-10-04 14:51:54 +00:00
Ryan Macnak 7f9a9feae1 [vm, service] Rename 'invoke' parameter 'receiverId' to 'targetId'. 
For consistency with the documentation and other service methods.

Change-Id: Ife4a4cf2445b7dad72e0a911fe1b94cec6ab5db5
Reviewed-on: https://dart-review.googlesource.com/77007
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-09-27 22:02:42 +00:00
asiva 7c54fab8a5 Adjust status files. 
Change-Id: If9432c0b441b06df0873fa2cd7740b95fb1103bd
Reviewed-on: https://dart-review.googlesource.com/76783
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-09-27 02:13:36 +00:00
asiva 355c73d4ee [VM] Remove support for option --no-preview-dart-2 
- option --no-preview-dart-2 will now result in an error
- change aot-assembly build rule to generate AOT snapshot using Dart 2
- generate coresnapshot using Dart 2 (this snapshot is not used yet, next CL which switch the isolate create code to use this snapshot)
- by pass all Dart1 test runs in the status file
- change the default compiler setting in test.py to use dartk
- have test.py not pick up any configuration for --no-preview-dart-2

Change-Id: Ia136943ebfd0fed0c52683b330745b3e2c7a7ce6
Reviewed-on: https://dart-review.googlesource.com/75820
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2018-09-24 20:38:08 +00:00
Jens Johansen 867c5271be Debugging dart in methods with dynamic type arguments 
Before this CL, debugging code like this:
```
import "dart:developer";

main() {
  Foo foo = new Foo();
  foo.bar<dynamic, dynamic>(1, 2);
}

class Foo {
  bar<A, B>(A a, B b) {
    debugger();
    print("a: $a; b: $b");
  }
}
```

and trying to print for instance `a` or `b` when the debugger is stopped
in `bar` (e.g. `p a`) would yield a wrong result. I.e., this happends
when debugging methods taking type arguments, but where the type
arguments are all `dynamic`.

This also surfaces when hovering variables in e.g. VSCode with the
Dart Code plugin.

Fixes: #34353.
Change-Id: Iddf1ed119700fea61a0e29eb6ad763a8d2b657a0
Reviewed-on: https://dart-review.googlesource.com/74583
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-09-20 06:33:27 +00:00
Ryan Macnak 0d71b8aa40 Revert "[vm] Add a timeline stream for recording the zone high watermark." 
This ended up not being helpful, and just makes the timeline harder to read.

This reverts commit 8590919ca6.

Change-Id: I0063dea0c4f6b37bf66a54df9b1c20a73dea40d9
Reviewed-on: https://dart-review.googlesource.com/75209
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-09-18 17:06:03 +00:00
Peter von der Ahé 56c2ed5e9e Avoid deprecation in source_loader 
Change-Id: Idf3250bd8fcc56f7d52e3f245671d2c1b91d0956
Reviewed-on: https://dart-review.googlesource.com/63144
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-09-13 08:10:15 +00:00
Ryan Macnak 02613eee3a [vm] Mark various service tests as now passing on -capp_jitk. 
Change-Id: I628ca476e7365a3af27834496c543a3926af10c3
Reviewed-on: https://dart-review.googlesource.com/74674
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-09-12 22:55:09 +00:00
Samir Jindel cbd17b535f Re-land "[vm/precomp] Use @pragma("vm:exact-result-type") to specify method behavior." 
We need to block interrupts while evaluating pragmas to prevert reentrant class finalization.
Original revision is in patchset 0.

Change-Id: I872cec4eaf4ca85567c9657c458ed39c8b2e30de
Cq-Include-Trybots: luci.dart.try:vm-kernel-win-release-x64-try, vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/73160
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-09-11 18:14:51 +00:00
Martin Kustermann e0f0f4b6a9 [gardening] Mark service/regexp_function_test as flaky 
Change-Id: Ib39bb6353b92ce89821256170c099828f72ebd05
Reviewed-on: https://dart-review.googlesource.com/74160
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-09-10 13:33:29 +00:00
Martin Kustermann a6c76475a9 [gardening] Mark service/regexp_test as Crashing on windows 
Issue https://github.com/dart-lang/sdk/issues/34422

Change-Id: I723512bfb68f58cf14d47a79dd443107db355507
Reviewed-on: https://dart-review.googlesource.com/74080
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-09-10 12:09:05 +00:00
asiva eb8350aaf7 Adjust status settings for service/rewind_test.dart 
Change-Id: I541dca5d498c82aaa7b0faad5d1ef38bb8401362
Reviewed-on: https://dart-review.googlesource.com/74014
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-09-07 23:11:01 +00:00
Samir Jindel 0227b0f25f [vm] Update status file for rewind_test. 
Change-Id: I080088762b11fae963b37bb338a866f25ead8790
Reviewed-on: https://dart-review.googlesource.com/71944
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-08-29 13:10:36 +00:00
Kevin Millikin 6e63df3bfb Revert "Avoid the deprecated input error in source_loader" 
Reverted because of failures on the VM reload tests.

Change-Id: I880523a5f3e14cc6d318d4493f037b79515b1dce
Reviewed-on: https://dart-review.googlesource.com/71401
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-08-24 11:03:28 +00:00
Kevin Millikin 0eb0f700b8 Avoid the deprecated input error in source_loader 
Avoid using deprecated errors by hadling them on a case-by-case basis.
This is a version of https://dart-review.googlesource.com/c/sdk/+/63144
with merge conflicts resolved.

Fixes #33686

Change-Id: I726740af2db5d32f15c8103c903376bc8ea948e6
Reviewed-on: https://dart-review.googlesource.com/71161
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-08-24 09:14:15 +00:00
Alexander Aprelev b878c21046 [gardening] Mark coverage_optimized_function_test slow on arm64. 
Change-Id: Iae9d3bb1721d84ff246a147cf2f44c7bb27c4d60
Reviewed-on: https://dart-review.googlesource.com/71181
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-08-22 16:14:07 +00:00
Alexander Aprelev e8e1ed6419 [vm] Fix hot reload when root script changes. 
This addresses https://github.com/dart-lang/sdk/issues/34025#issuecomment-408867998.

Change-Id: Ic3bfaaf9a43f42ffff15c5d8a8317dab83569b98
Reviewed-on: https://dart-review.googlesource.com/67400
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-08-16 14:24:19 +00:00
Alexander Markov 9f9682e8f3 [gardening] Filter out failing tests 
Issue: https://github.com/dart-lang/sdk/issues/34143
Change-Id: Idc8c1dd51a9763b30a0b4206aacdaa0732cf4f28
Reviewed-on: https://dart-review.googlesource.com/69982
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-08-14 19:01:32 +00:00
Martin Kustermann 2915e98de9 [gardening] Skip app-jitk tests which evaluate source and therefore need IKG 
Change-Id: I80c834174ea95ff9272a1904d747f2b265b2b2c1
Reviewed-on: https://dart-review.googlesource.com/69304
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-10 13:30:09 +00:00
Ryan Macnak 7b9fb893d2 [vm] Add a service method for 'invoke' as the dual to 'eval'. 
Refactor the implementation of 'invoke' for sharing between the embedding API, mirrors, and the VM service. The fixes various issues in the embedding API:
 - Dart_Invoke, Dart_GetField and Dart_SetField now generate the same NoSuchMethodErrors as dart:mirrors and ordinary Dart code.
 - Dart_GetField and Dart_SetField now accept a null receiver.
 - Dart_GetField now handles closurization.
 - Dart_Invoke now handles calls through function-typed getters.
In mirrors, it also changes:
 - LibraryMirror.invoke/getField/setField now see members in the export namespace, not just local declarations. I.e., invocation with a LibraryMirror behaves the same ways as invocation against a library prefix in ordinary Dart code.

Bug: https://github.com/dart-lang/sdk/issues/11870
Bug: https://github.com/dart-lang/sdk/issues/13643
Bug: https://github.com/dart-lang/sdk/issues/29893
Bug: https://github.com/dart-lang/sdk/issues/33417
Bug: https://github.com/dart-lang/sdk/issues/34006
Change-Id: I913e8eef16943a3e86eda55c8d122819e41ad7cc
Reviewed-on: https://dart-review.googlesource.com/67302
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-08-09 18:16:03 +00:00
Martin Kustermann d0f28884ff [VM] Fix expression evaluation implementation: Never register temporary/unused classes with the system. 
Until now the expression evaluation implementation was using normal kernel loader
functionality, which registered a new class with the isolate. Then the cid of that
class was set to kIllegalCid.

This caused the direct_subclasses/direct_implementors CHA information to contain a
class with kIllegalCid.

This CL fixes this by ensuring we never register the libraries/classes
created for expression evaluation (which are not even used, they are an artifact
of how the expressions are encoded in kernel).

Issue https://github.com/flutter/flutter/issues/20255
Issue https://github.com/flutter/flutter/issues/20307

Change-Id: Ie6dd76c7ff696cd8adf4f27e9a072274afd90136
Reviewed-on: https://dart-review.googlesource.com/68681
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-09 15:31:15 +00:00
Alexander Aprelev dac348c8c9 [observatory] Only run field guards test if it is enabled in the vm. 
Change-Id: I83c5dba9b85fc0f99585fbd90cdc66d8c3fb865b
Reviewed-on: https://dart-review.googlesource.com/68850
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-08-08 00:38:52 +00:00
Alexander Aprelev 6bdf3b7ed6 [observatory] Fix _guardLength serialization to output a string, rather than an int. 
Change-Id: I12e3505649ebe9bb72f479dc7e2fc2dd19226ed7
Reviewed-on: https://dart-review.googlesource.com/68802
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-08-07 22:58:36 +00:00
Jens Johansen 6814dace8d Add bug number to kernel service status line 
Change-Id: I2f503ce783c8b32ac01a7c94df62559e6d1e40f4
Reviewed-on: https://dart-review.googlesource.com/68640
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-08-07 09:55:16 +00:00
Jens Johansen ad1d9e4f85 Update status for app_jitk after 164c7e3 
Change-Id: I5bba0e4a3db3c6c40356b1f1db1c2f54f6f55476
Reviewed-on: https://dart-review.googlesource.com/68661
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-08-07 09:43:05 +00:00
Jens Johansen f36ab38bf3 Detect isKernel better in service tests 
Change-Id: I38ef62dd7db1dbda8bdc0477d16f92192cf8bff3
Reviewed-on: https://dart-review.googlesource.com/68621
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-08-07 09:10:08 +00:00
Jens Johansen 164c7e3195 Debugging sync* and yield 
Set position on yield in sync* functions; use yield position in VM.

Change-Id: I1c92fd47e3c8d4f747242e076007c122ea0d2186
Reviewed-on: https://dart-review.googlesource.com/68366
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-08-07 08:39:32 +00:00
William Hesse 46743f3868 Remove $runtime == drt sections and uses of drt from status files. 
Change-Id: Iffd934a67668901176a84c9b01512711a011652d
Reviewed-on: https://dart-review.googlesource.com/67803
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-08-03 12:40:46 +00:00
Jens Johansen 1c2043e3a6 Update service test more to not be different in sync async mode 
Before this CL the test fails because the stacktrace was not as expected
when running in sync async mode.
This CL changes the test so async methods are not executed synchronously
by adding an "await null;" as the first thing in those methods.

An alternative fix would have been to pass --no-sync-async.

Bug: #29158

Change-Id: Idd9bd159610405bbdd479d50d823953a9ad1abde
Reviewed-on: https://dart-review.googlesource.com/63742
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-02 07:24:02 +00:00
Jens Johansen ac8fdb5a58 Add :controller_stream and call _asyncStarListenHelper 
This changes how we step out of async* functions slightly to match how
Dart1 behaves.

Bug: #29158

Change-Id: I8ee2df5eee8167fd1907a6e9f30c9dc7ab6939b1
Reviewed-on: https://dart-review.googlesource.com/63625
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-02 06:49:47 +00:00
Jens Johansen 2e98da68f9 Call _asyncStarMoveNextHelper in kernel 
This changes how we step into async* functions slightly to match how
Dart1 behaves.

Bug: #29158
Change-Id: I4969ca48f798bd51f9d2d5bc26dd224fa7eff627
Reviewed-on: https://dart-review.googlesource.com/63624
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-02 06:16:15 +00:00
Alexander Aprelev 70e58189d5 Update awaiter_async_stack_contents_2_test test status as failing in app_jitk config. 
This is follow-up to https://dart.googlesource.com/sdk/+/5d98fe159a622361f27804faab0b35fa02112797
which added the test.

Change-Id: Ib59a33244e520d93bd7b945e0a62594e02bb5f60
Reviewed-on: https://dart-review.googlesource.com/66841
Commit-Queue: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-07-25 23:37:25 +00:00
Alexander Aprelev 5d98fe159a Fix ExtractTokenPositionFromAsyncClosure on kernel 
Previously (e71bd048e5) it was assumed that kernels
`script.yield_positions` was for the single function, not for the entire
script. That's not the case.
This resulted in the wrong stack-trace sometimes being produced.

This is technically tested in a service test, though that test also
tests other things and fails before getting to test this.

This CL adds a test that tests only this and fixes the problem.

Cloned from https://dart-review.googlesource.com/c/sdk/+/63741 to
untangle it from two other changes.

Bug: https://github.com/flutter/flutter/issues/17838
Change-Id: I4c24342d63865cb7cbd25c42ba686007bdbde1b1
Reviewed-on: https://dart-review.googlesource.com/66800
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-07-25 21:11:35 +00:00
Ryan Macnak 6a4d64fe0c [vm] Notify the service isolate of all isolate shutdowns, not just those triggered by Dart_ShutdownIsolate. 
Bug: https://github.com/dart-lang/sdk/issues/33514
Bug: https://github.com/flutter/flutter/issues/19490
Change-Id: Ia2ffaa3aae86c771fa46ab395e93d10bba940a4c
Reviewed-on: https://dart-review.googlesource.com/66409
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-07-24 20:51:09 +00:00
Ben Konyi 57e11e3d55 [ VM / Testing ] Added status file entry for debugger regression test which is expected to fail for app-jit in Dart 2 
Change-Id: I1b21234fd0d659bff80e51aa12ff41d7dc9ec31c
Reviewed-on: https://dart-review.googlesource.com/66220
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-07-23 17:52:52 +00:00
Ben Konyi 6bddb6c112 [ VM / Debugger ] Use existing Function object to set breakpoints instead of finding "best fit" when possible. 
Change-Id: I8bad37129f907d500a024acc8e17ad265b8b04b1
Reviewed-on: https://dart-review.googlesource.com/65793
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-07-20 21:15:49 +00:00
Alexander Aprelev b1a68a408e [vm] Clean up bad_reload_test as it works as expected now. 
Bug: https://github.com/dart-lang/sdk/issues/32341
Change-Id: I54e9d2bf6a7b3fe0976e1895c4dce35aa1cdaa99
Reviewed-on: https://dart-review.googlesource.com/63721
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-07-18 01:00:52 +00:00
Ryan Macnak 296319d2f0 [observatory] Switch to static mode. 
Bug: https://github.com/dart-lang/sdk/issues/32503
Change-Id: I9ff65d1598031473fa8ca97a27e340e722f038fa
Reviewed-on: https://dart-review.googlesource.com/65382
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-07-17 18:04:10 +00:00