dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1103 Commits

Author SHA1 Message Date
Ryan Macnak 6d934b94c5 [vm, service] Remove _getCrashDump. 
This has been broken since Dart 2.

Bug: https://github.com/dart-lang/sdk/issues/36281
Change-Id: I1b92c079ca3d7720a654c56457fd5aebeb7b8df4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97445
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-04-02 18:00:49 +00:00
Zichang Guo c2f014064e [vm/debugger] Ensure TopLevel class is finalized when setting breakpoint 
Following the revert #98360, make sure the finalizing happens only in debugger.
Create the test cases to demonstrate the behavior.

Bug: https://github.com/dart-lang/sdk/issues/35859
Change-Id: Ib27fef18a7c0696ec6dc6d045fa06f60677333c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98422
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-04-01 23:36:33 +00:00
Ben Konyi 0fdaec1b8e [ Service ] Removed extra print statement in test 
Change-Id: I0d156dc0bb94ddb75e70a728af4bd0a4b3fca960
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98420
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-04-01 17:43:03 +00:00
Ben Konyi 15b4e57510 [ VM / Service ] Fixed failing isolate_lifecycle_test 
Change-Id: I7cf18b36ccd55aeca368343a02e036f9a8ba2e0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98221
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-03-28 19:03:32 +00:00
Ben Konyi ac2c934563 Reland "[ VM / dart:isolate ] Added ability to set names for spawned isolates." 
This reverts commit 638f13ff3d.

Change-Id: Ib5015539b1c93791c2469be6995789f8f0362806
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97845
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-03-28 16:39:50 +00:00
Ben Konyi e5bc8c2d39 [ VM / Service ] Remove Platform.pathSeparator from test and replace with / to fix Windows failure 
Change-Id: Icddbcf46ba17d36e2832f9b86022461b6b71e074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98047
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-03-27 23:10:20 +00:00
Ben Konyi ca2f03c5f8 [ VM / Service ] Allow for breakpoints to be set using either file: or package: URIs for packages. 
Additional minor changes:
- Sorted list of Symbols in symbols.h by name
- Added Symbol::PackageScheme() to symbol list

Change-Id: I2f739bfb5c8cbbe1e318614124695ae45dee4f23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98043
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-03-27 20:38:20 +00:00
Stevie Strickland 8e0bb64bd1 [gardening] Mark reloaded files as other resources. 
This way, they'll be copied to the output directory and
can be loaded appropriately by the reload test.

This fixes https://github.com/dart-lang/sdk/issues/35506.

Change-Id: Id297703679068ae674b93b6adf0015bb966a6e33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97512
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-03-25 18:18:51 +00:00
Stevie Strickland 81b984d735 [gardening] Fix up name detection in isolate tests. 
This change addresses the test failures seen in
https://github.com/dart-lang/sdk/issues/36232.

Change-Id: I062669c07f4963291450b35a46fb73256505c706
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97220
Auto-Submit: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2019-03-22 09:24:33 +00:00
Jens Johansen 58882ffdd4 VM reads import uri if kernel binary version >= 22 
This CL also includes a service test for setting
a breakpoint in a part file from a package.

Fixes #35859.

Change-Id: I0199006a87746dc1c27721ba0d51e502e76cb107
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97104
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-03-20 09:39:33 +00:00
Daco Harkes 638f13ff3d Revert "[ VM / dart:isolate ] Added ability to set names for spawned isolates." 
This reverts commit 59525264e8.

Reason for revert: causes Flutter test observatory and protocol to deadlock.
Issue: https://github.com/dart-lang/sdk/issues/36232

Original change's description:
> [ VM / dart:isolate ] Added ability to set names for spawned isolates.
> 
> Fixes issue #34059
> 
> Change-Id: I315498b02edc184e9e408c93eddb78aa1a5a8a1d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90341
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

TBR=bkonyi@google.com,rmacnak@google.com,asiva@google.com,sigmund@google.com

Change-Id: I5f2115a2ac394a8d4c7c175bc97f2b88b65fcb49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97107
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2019-03-15 14:40:37 +00:00
Ben Konyi 59525264e8 [ VM / dart:isolate ] Added ability to set names for spawned isolates. 
Fixes issue #34059

Change-Id: I315498b02edc184e9e408c93eddb78aa1a5a8a1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90341
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-14 22:23:09 +00:00
Ben Konyi 1efe7e2518 [ VM / Service ] Added getMemoryUsage RPC and MemoryUsage object to service protocol 
Change-Id: If15e49d7aab93382c15529a738b492552faf5376
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95489
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-14 21:53:49 +00:00
Kevin Moore 8c3f74817e dartfmt -w --fix dart:collection 
Change-Id: Ia643bb49fe22150f794a187a71c19ad4c61b5694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96663
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2019-03-13 13:31:52 +00:00
Ben Konyi 585eb7f507 [ VM / Service ] Added disableBreakpoints parameter to evaluate, evaluateInFrame and invoke RPCs 
- Setting the `disableBreakpoints` parameter to true will result in any
breakpoints hit during execution resulting from an evaluate or invoke
call to be ignored.
- Default behavior is the same (break on breakpoints).
- Updated Observatory eval box to disable breakpoints.
- Added tests

Change-Id: Ibf40f8a8de018718435118e13cc2e969f8ed7944
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95320
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2019-03-08 02:19:06 +00:00
Zichang Guo 4ec72c1eb1 [VM-Runtime]Fix source report coverage to not include field without function initializer 
Fix issue created by 89173. Also rename HasInitializer to HasInitializerFunction to distinguish from has_initializer.

Bug= https://github.com/flutter/flutter/issues/28542

Change-Id: Id9f898937c2f4f350a6d619019dc12611505801f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95680
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-03-07 02:04:41 +00:00
Zichang Guo 7e81f56ad7 Save Initializer for field and pass into debugger to enable breakpoint setting. 
Change-Id: I9f7afcdd057f161873d3c6e47cb0ce171806f301
Reviewed-on: https://dart-review.googlesource.com/c/91120
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
 2019-02-06 03:20:35 +00:00
Alexander Markov bd51d6f120 [vm] Build scopes for implicit getters of static const fields 
Usually implicit getters are not used for static const fields.
However, coverage can force their compilation. In order to compile
implicit getter of a static const field, its initializer is
evaluated in a constant evaluator. Initializer may have Let
expressions and can declare local variables.

Before this fix scope builder was not visiting initializer body for
implicit getters, which caused crashes in constant evaluator.

Fixes https://github.com/dart-lang/sdk/issues/35808

Change-Id: I807aeaa90886d84169c27275abdd0cfd0f3ff777
Reviewed-on: https://dart-review.googlesource.com/c/91705
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-02-04 19:03:39 +00:00
Jens Johansen 14b2255584 Status update after c3c5250 
app_jitk also fails.

Change-Id: I7252d2a7b6e05151337dfff1cc7470ea34f8484a
Reviewed-on: https://dart-review.googlesource.com/c/91740
Auto-Submit: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-01-31 12:36:34 +00:00
Jens Johansen c3c525079b Demonstrate bug for the VMs way of doing initializers in face of mixins 
See http://dartbug.com/34841#issuecomment-458917175
and test in this CL for explanation.

Change-Id: Ie1d15078a9c5f71aa6edacd792b440520a3eb877
Reviewed-on: https://dart-review.googlesource.com/c/91660
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-31 10:08:15 +00:00
Zichang Guo 970390a36e Add field evaluation to source report generation 
Change-Id: I62808852a35ef53c05ac1ea715d4559db46bb3d5
Reviewed-on: https://dart-review.googlesource.com/c/89173
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-01-18 19:15:44 +00:00
Ben Konyi a10ddca1b1 [ VM / Service ] Allow for profile_period flag to be set via the service protocol 
`profile_period` has been added to the list of flags which can be
changed at runtime via the `setFlag` RPC. Changing this flag at runtime will
cause the ThreadInterrupter to be shutdown, reinitialized, and started with the
new profiling period.

Fixes #35654.

Change-Id: I2f365fdf8e404270f2eed1e172c8d21b48e0aff9
Reviewed-on: https://dart-review.googlesource.com/c/89445
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
 2019-01-16 18:08:19 +00:00
William Hesse a533753bec Remove --fast-startup flag support from testing scripts and status files 
Change-Id: Icfb4aa228c0f13bf9fce25aeb7bacbf1e38497ee
Reviewed-on: https://dart-review.googlesource.com/c/89582
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-01-16 11:32:44 +00:00
Ben Konyi b0900cf494 [ VM / Service ] Fixed issue where VMOptions were not being passed to app_jitk tests. 
Fixes #35512.

Change-Id: I34abbf0f73215b6695a0aa4ec6af6cb1c219d5e9
Reviewed-on: https://dart-review.googlesource.com/c/88429
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-01-08 00:44:38 +00:00
Daco Harkes e8c60f7ba6 [gardening] Mark service/simple_reload_test as Timeout for issue 35506 
Issue: https://github.com/dart-lang/sdk/issues/35506
Change-Id: I1d82426bf7f2af2253f6197abb47468f8c2b9fd4
Reviewed-on: https://dart-review.googlesource.com/c/88443
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-01-04 10:39:58 +00:00
Ben Konyi b61efcd3c4 [ VM / Service ] Started cleaning up tests for the service protocol. 
Mostly focused on app_jitk tests in this CL, but updated issue numbers
and statuses where appropriate.

Change-Id: I6b57d0a3091ad10ddd143c5b420f6b2121e9cc73
Reviewed-on: https://dart-review.googlesource.com/c/88128
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-12-28 20:53:39 +00:00
Régis Crelier cb8c0ab8f5 [vm] Remove MixinAppType VM class and VM code supporting type resolution. 
In Dart2, mixin application classes are generated by kernel and type resolution
is performed by kernel. In Dart1, using the VM parser, these tasks were done
during class and type finalization.

Change-Id: I927b1446d906ffd76ed9591c96e0d974df09f3bf
Reviewed-on: https://dart-review.googlesource.com/c/87025
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-12-13 20:18:36 +00:00
Ryan Macnak 566ae2490d [test] Update async stepping tests to reflect the status quo. 
Note that stepping behavior has degraded since support for Dart was removed, and now includes spurious steps through the async implementation.

Bug: https://github.com/dart-lang/sdk/issues/34746
Change-Id: I573e1a945d96a9ddda839f22e66e1f68202005c5
Reviewed-on: https://dart-review.googlesource.com/c/86828
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-12-12 02:31:02 +00:00
Martin Kustermann 25e38ebd60 [Gardening] Change tests to use default --sync-async behavior (this is what we care about), remove Crash status file marker 
To avoid Crashes for non-supported configurations (which --no-sync-async
is), this CL changes the tests to run in the default mode.

The tests are still failing because the new behavior does not match what
the test expects. -> The tests need to be changed.

Issue https://github.com/dart-lang/sdk/issues/34746

Change-Id: I920ca4e0070f9cfb43ecf2ee3ee754ec1fe80e4a
Reviewed-on: https://dart-review.googlesource.com/c/86352
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-12-06 12:10:33 +00:00
Samir Jindel 085ebcab58 [vm] Mark some service tests as slow. 
Change-Id: Ib459a8bc373a5c7090ce22b78574632dda9470b9
Reviewed-on: https://dart-review.googlesource.com/c/86205
Commit-Queue: Samir Jindel <sjindel@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-12-05 15:51:00 +00:00
Alexander Markov 66f81c30b1 [gardening] Increase allowed time difference in a test from 5s to 10s. 
This is done to avoid flaky failures of runtime/observatory/tests/service/udp_socket_service_test.dart
test on slow debug-simdbc64 configuration.

This test failed with time difference being 6.4 seconds while only 5 seconds
difference was allowed:

Expected: a numeric value within <5000> of <1543951695426>
  Actual: <1543951689020.038>
   Which:  differs by <6405.9619140625>
Change-Id: I40f70045291b238a43322bdd9c5b9bb670e08e48
Reviewed-on: https://dart-review.googlesource.com/c/86083
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-12-04 21:25:42 +00:00
Martin Kustermann ad7fbb6dd7 [VM] Fix flow graph builder to not generate different code in unoptimized/optimized mode 
Change-Id: I752be6bd97dcd892ea6ba5d7fdd30575d4cee489
Reviewed-on: https://dart-review.googlesource.com/c/84720
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-22 14:05:47 +00:00
Ryan Macnak edba6fbfaa [vm, gc] Add --force-evacuation flag to aid finding untracked pointers. 
Bug: https://github.com/dart-lang/sdk/issues/34934
Change-Id: Ibba2ae5837985a32bd84da4b33bd091dcec3427d
Reviewed-on: https://dart-review.googlesource.com/c/85141
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-11-21 22:58:57 +00:00
Ryan Macnak be670f0362 [test] Update status files for tests with code objects newly-passing on 64-bit Windows. 
Change-Id: I155a7e2ad338cb9a9aadf4a7699cf163c490112c
Reviewed-on: https://dart-review.googlesource.com/c/84836
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-11-20 01:25:08 +00:00
Vyacheslav Egorov cdcb76e12b [gardening] Fix runtime/observatory/tests/service/udp_socket_service_test 
Accommodate for the situation where service connects to the testee
before testee actually received the datagram.

Change-Id: Iacfbd2f8dedddc23a0657cc97420e18fa9431cd6
Reviewed-on: https://dart-review.googlesource.com/c/84609
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-11-16 17:56:08 +00:00
Ryan Macnak 2535b1e021 [vm] Account for bytecode in profile processing and Observatory. 
Change-Id: I220eca1f4a3aadaa271ead4de698c28e4a7b653a
Reviewed-on: https://dart-review.googlesource.com/c/84447
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-11-15 17:42:13 +00:00
Ben Konyi 5afc1ec336 [ VM / Observatory ] Fixed tests that were failing due to lack of sources in app_jitk mode 
Change-Id: I74504cc5dea30a0b6841e0bf77d99c1cf3889269
Reviewed-on: https://dart-review.googlesource.com/c/84049
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2018-11-14 18:00:53 +00:00
Kevin Moore 037792876a Fix analysis hints/warnings in runtime/observatory 
Change-Id: I1afee0f09476185b2690e0c2bc98a4b7ae7bffa6
Reviewed-on: https://dart-review.googlesource.com/c/83480
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-11-09 00:52:44 +00:00
Ryan Macnak bf26f2c022 [test] Update status for get_vm_timeline_rpc_test: Slow doesn't imply Pass. 
Change-Id: If6f4db659e8bdc31ec47367f8468b18947392918
Reviewed-on: https://dart-review.googlesource.com/c/83900
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-11-09 00:25:47 +00:00
Samir Jindel 56ea31b3d6 [vm/gardening] Mark get_vm_timeline_rpc_test as slow. 
Threads appear to still be doing real work when the timeout occurs. Local testing confirms
that the test is actually slow.

Change-Id: I3b0dfa467c5b2eeda481e31716cfc1e79583100d
Reviewed-on: https://dart-review.googlesource.com/c/83762
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2018-11-08 23:09:15 +00:00
Ben Konyi c086064565 [ VM / Gardening ] Mark flaky test get_vm_timeline_test as Pass, Timeout 
Change-Id: Id13e201e368ceded4adabc466e6c56938d1ff566
Reviewed-on: https://dart-review.googlesource.com/c/82523
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-11-02 05:35:28 +00:00
Ben Konyi 06c1ee0441 Reland "[ VM ] Delete code for _RegExp._ExecuteMatch and _RegExp._ExecuteMatchSticky before creating an app-jit snapshot." 
This reverts commit 022d181a4d.

Change-Id: Idcc9d681fea79ded731a49debb5faf88b88ca63c
Reviewed-on: https://dart-review.googlesource.com/c/82527
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
 2018-11-02 05:28:43 +00:00
Ben Konyi 022d181a4d Revert "[ VM ] Delete code for _RegExp._ExecuteMatch and _RegExp._ExecuteMatchSticky before creating an app-jit snapshot." 
This reverts commit 428a832a4b.

Change-Id: I7fb7dde39fd7575fb8885850007ca155b24b308e
Reviewed-on: https://dart-review.googlesource.com/c/82541
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-11-01 23:01:43 +00:00
Ben Konyi 428a832a4b [ VM ] Delete code for _RegExp._ExecuteMatch and _RegExp._ExecuteMatchSticky before creating an app-jit snapshot. 
Fixes issue #34422, where evaluating a RegExp on Windows during the
kernel isolate startup would crash when the '--interpret_irregexp' flag
was passed.

Change-Id: I4e8cd6a17973203b56ba0684a36a61b060f99670
Reviewed-on: https://dart-review.googlesource.com/c/82300
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-11-01 20:07:04 +00:00
Ben Konyi 7c0b225666 [ VM / Service ] Added 'getScripts' RPC. 
'getScripts' returns a 'ScriptList' object which represents all loaded
scripts for the isolate. This is the fix for issue 30061 and b/115567301.

Change-Id: I41248e97cb78a39d286020c7fdd7ee72f0cc55db
Reviewed-on: https://dart-review.googlesource.com/c/82360
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
 2018-11-01 17:44:30 +00:00
Martin Kustermann 06f9a9e354 [VM] Introduce function and osr entrypoints to the VM's IR 
Similar to how we treat catch entry instructions, this cl adds new
function and osr entry instructions. The [FunctionEntry] and
[OsrEntry] - just like [CatchBlockEntry] - have now their own initial
definitions. The [GraphEntry] has only initial definitions for
constants.

Explicit phis are inserted for all parameter / special parameter
instructions if necessary.

Future work is:

  a) Minimize parallel moves due to the phis on parameters
  b) Cleanup frame setup: Move it entirely into FunctionEntry/CatchEntry
    (instead of the split version we have now)

Fixes https://github.com/dart-lang/sdk/issues/34435
Fixes https://github.com/dart-lang/sdk/issues/34287

Change-Id: Iefa0280a709716f748d6fb0523b8d0f4d8de1fec
Reviewed-on: https://dart-review.googlesource.com/c/74782
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-10-15 13:02:51 +00:00
Ryan Macnak 662ff7f112 [vm] Remove TokenStream, TokenValue, CompilerStats. 
(CompilerStats timers have been replaced with the timeline events.)

Change-Id: Iddcb752c085de9762eb802371b6d2905fa608a76
Reviewed-on: https://dart-review.googlesource.com/c/79086
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-10 21:39:45 +00:00
Alexander Markov 5deb1c6e81 [vm] Remove strong mode and sync-async flags from pkg/vm 
Change-Id: Icd2920274ca4c402b38e5774bb408d6b5e529169
Reviewed-on: https://dart-review.googlesource.com/c/79082
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-10 20:11:35 +00:00
Martin Kustermann 16ddfc1565 [VM] Use assert assignable implementation for explicit downcasts 
This makes explicit downcasts more efficient by re-using the
optimizations we already have for implicit downcasts.

For implicit/explicit as checks we use the symbol to distinguish which
exception to throw if the check fails.  So this does not actually
require unification of _CastError and _TypeError.

Issue https://github.com/dart-lang/sdk/issues/34582
Issue https://github.com/dart-lang/sdk/issues/30632
Issue https://github.com/dart-lang/sdk/issues/30571

Change-Id: I7b8818d2698e249c90a3e1b8790bad69ada649a9
Reviewed-on: https://dart-review.googlesource.com/c/78748
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-10-10 12:36:42 +00:00
Alexander Markov 2695f36016 [Gardening] Status update (co19_2, optcounter/ia32) 
Change-Id: Ica90e83995ad2e89548c07824dc525f1cd84fd71
Reviewed-on: https://dart-review.googlesource.com/c/78921
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-10-09 23:56:31 +00:00