dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

150 Commits

Author SHA1 Message Date
Ben Konyi 82cf4cc374 Added methods to surface number of zone and scoped handles for each isolate. 
Added methods to surface number of zone and scoped handles in each isolate. These values are displayed in the isolate view page in the Observatory. These handle counts for the native IO isolate will be surfaced in another CL.

BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2601153002 .
 2017-01-03 12:21:16 -08:00
Ben Konyi e28b3e3c60 Revert "Added isolate + thread high watermark tracking to Observatory" 
This reverts commit 0a1a534fd9.

BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2605933003 .
 2016-12-28 16:49:47 -08:00
Ben Konyi 0a1a534fd9 Added isolate + thread high watermark tracking to Observatory 
Added tracking of memory usage inside of threads. In addition, the max memory usage is kept track of using a high watermark for both the threads and the isolates. Isolate high watermark information is updated when a thread exits the isolate. The isolate high watermark consists of the sum of all thread high watermarks (including the high watermark of the exiting thread). High watermark information for both threads and isolates is now visible in the isolate view in the Observatory.

BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2608463002 .
 2016-12-28 14:59:22 -08:00
Ben Konyi 5bf4fcee29 Added thread.dart and zone.dart to the observatory sources to resolve build issues. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2583313002 .
 2016-12-19 12:36:36 -08:00
Ben Konyi f1de9b09d7 Revert "Added ability to request zone memory information for all isolates through the VM service and added tests." 
This reverts commit 9622f1a2df.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2588083002 .
 2016-12-19 10:31:29 -08:00
Ben Konyi 9622f1a2df Added ability to request zone memory information for all isolates through the VM service and added tests. 
BUG=
R=johnmccutchan@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2574643003 .
 2016-12-19 10:08:19 -08:00
Ryan Macnak 0cf02040f8 Add a version of heap snapshots that use only fields and stack frames as roots and only include instances. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2502283003 .
 2016-11-28 16:00:06 -08:00
Ryan Macnak aa47407ab8 Observatory: Add view of dominator tree with siblings merged by class. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2480293003 .
 2016-11-15 09:43:48 -08:00
John McCutchan 2d0a08baf9 Make reloadSources service RPC public 
- [x] Make `reloadSources` RPC public.
- [x] Add an optional 'pause' parameter to `reloadSources`. When set to true, the isolate will enter the debug pause loop immediately after reloading sources and before resuming execution. This makes it possible for debugger clients to set breakpoints before resuming.
- [x] Add reload_sources_test which tests pausing after reload.
- [x] Fix a bug in `GetVarDescriptors` where a null code object could be used.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/2411153002 .
 2016-10-13 07:45:56 -07:00
John McCutchan 7fca076fbb Use dartfmt on Observatory code 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2345023003 .
 2016-09-16 06:59:51 -07:00
Ryan Macnak 47cc06ae66 Shrink AOT snapshot size and memory usage. 
- Conditionally remove fields of Code, Function and ICData that are not used in the AOT runtime.
 - Don't include RawClosureData.context_scope_ in AOT snapshots.
 - Remove parameter names not needed for method resolution.
 - Remove parameter types not needed for function type tests.
 - Deduplicate parameter name and parameter type lists.
 - Shrink and share the initial MegamorphicCache table.

Flutter gallery (IsolateSnapshotReader event)
snapshot size 2731129 -> 2199999 (-19.4%)
initial heap  7899568 -> 5433176 (-31.2%)

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2326483005 .
 2016-09-15 15:06:42 -07:00
Carlo Bernaschina cfefe97495 Converted Observatory metrics-page element 
Major restyle

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2303173002 .
 2016-09-06 09:56:16 -07:00
Carlo Bernaschina 2eab4de315 Converted Observatory logging-page element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2299893003 .
 2016-09-02 10:27:48 -07:00
Carlo Bernaschina 741d99f100 Converted Observatory code-view element 
Not fully testable

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2306483002 .
 2016-09-01 13:56:45 -07:00
Carlo Bernaschina 90c50c52f2 Converted Observatory vm-view && isolate-view elements 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2304463002 .
 2016-09-01 10:46:36 -07:00
Carlo Bernaschina 1341e94321 Converted Observatory class-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2294073003 .
 2016-08-31 17:03:38 -07:00
Carlo Bernaschina bf7d220741 Converted Observatory instance-view element 
R=turnidge@google.com

Review URL: https://codereview.chromium.org/2291233002 .
 2016-08-30 14:53:24 -07:00
Carlo Bernaschina 19e9627ea0 Converted Observatory library-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2289953003 .
 2016-08-30 13:58:15 -07:00
Carlo Bernaschina 0083d2610e Converted Observatory object-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2294473002 .
 2016-08-30 13:39:12 -07:00
Carlo Bernaschina b63546ac57 Converted Observatory function-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2291823002 .
 2016-08-29 16:39:38 -07:00
Carlo Bernaschina a326a56eb1 Converted Observatory object-pool-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2283863003 .
 2016-08-29 11:14:18 -07:00
Carlo Bernaschina 8e7725a8b4 Converted Observatory field-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2287793002 .
 2016-08-29 10:47:05 -07:00
Carlo Bernaschina 5e1b224ef8 Converted Observatory megamorphiccache-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2279203003 .
 2016-08-26 15:22:51 -07:00
Carlo Bernaschina 12e8f86cf6 Converted Observatory persistent-hangles-page element 
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2273203004 .
 2016-08-26 10:15:34 -07:00
Carlo Bernaschina 4f96ad0440 Converted Observatory objectstore-view element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2274013006 .
 2016-08-26 09:44:24 -07:00
Carlo Bernaschina c39868c8a5 Converted script-inset, source-inset and eval-box elements 
Testing postponed

R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2277543004 .
 2016-08-26 09:27:56 -07:00
Carlo Bernaschina 942918347c Supporting both FieldRef and InstanceRef in RetainingPathItem.parentField 
Fixes=https://github.com/dart-lang/sdk/issues/27146

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2277093002 .
 2016-08-24 16:56:57 -07:00
Carlo Bernaschina 3d415d5ac0 Converted Observatory icdata-view element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2271083002 .
 2016-08-24 09:33:37 -07:00
Carlo Bernaschina 44d2b85d3d Converted Observatory cpu-profile-table element 
Fixes=https://github.com/dart-lang/sdk/issues/27116

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2273993002 .
 2016-08-24 08:51:37 -07:00
Carlo Bernaschina fc6954171e Converted Observatory context-view element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2270013002 .
 2016-08-23 13:16:23 -07:00
Carlo Bernaschina 547d71add7 Converted Observatory heap-snapshot element 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2266343002 .
 2016-08-23 12:55:43 -07:00
Carlo Bernaschina c6fdc01b91 Converted Observatory ports-page element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2267863002 .
 2016-08-22 09:47:22 -07:00
Carlo Bernaschina d272f763d8 Converted Observatory object-common element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2265513003 .
 2016-08-19 17:07:07 -07:00
Carlo Bernaschina 0b4fe4825f Removed Instructions object from Observatory models 
Review URL: https://codereview.chromium.org/2252273002 .
 2016-08-17 18:51:18 -07:00
Carlo Bernaschina b0582b3bb7 Converted Observatory heap-profile element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2255613002 .
 2016-08-17 15:51:38 -07:00
Carlo Bernaschina d31a942640 Restore missing properties 
TBR=johnmccutchan@google.com,rmacnak@google.com

Review URL: https://codereview.chromium.org/2259573002 .
 2016-08-17 13:13:38 -07:00
Carlo Bernaschina a1edad30ea Converted Observatory refs elements 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2244433003 .
 2016-08-17 12:31:38 -07:00
Carlo Bernaschina 9ce171ac33 Converted Observatory cpu-profile element 
Fixes https://github.com/dart-lang/sdk/issues/26043

R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2204563003 .
 2016-08-09 14:34:00 -07:00
Carlo Bernaschina a5443086a0 Converted Observatory isolate-summary element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2217723004 .
 2016-08-09 13:15:21 -07:00
Carlo Bernaschina 3c786269cb Converted Observatory class-tree element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2212253002 .
 2016-08-05 12:48:07 -07:00
Carlo Bernaschina ba0f803fbe Centralized event streams 
R=turnidge@google.com

Review URL: https://codereview.chromium.org/2211603002 .
 2016-08-04 17:11:16 -07:00
Carlo Bernaschina 60afd8bddd Converted observatory flag-list element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2213613002 .
 2016-08-03 19:53:05 -07:00
Carlo Bernaschina c9b1215870 Converted general-error tag 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2199403002 .
 2016-08-03 18:16:19 -07:00
Carlo Bernaschina e76ad0353b Converted Observatory code-ref function-ref element 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2194383002 .
 2016-08-01 17:23:21 -07:00
Carlo Bernaschina 445180ad41 Converted Observatory source-link & script-ref elements 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2180553002 .
 2016-08-01 16:29:49 -07:00
Carlo Bernaschina cb468c2c47 Converted Observatory vm-connect element 
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2180803002 .
 2016-07-27 13:43:38 -07:00
Carlo Bernaschina 61e34b244b Converted Observatory nav-notify element 
Still writing tests.

R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2167053002 .
 2016-07-24 12:54:04 -07:00
Carlo Bernaschina a66cee26bd Converted Observatory class-nav-menu element 
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2165913004 .
 2016-07-22 17:22:50 -07:00
Carlo Bernaschina e71c000ce4 Converted Observatory vm-nav-menu element 
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2170723002 .
 2016-07-22 15:08:05 -07:00
Carlo Bernaschina 3ccc1f337f Converted Observatory isolate-nav-menu element 
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2168463004 .
 2016-07-22 14:27:34 -07:00