dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6018 Commits

Author SHA1 Message Date
Dmitry Stefantsov 58d3d71df4 [fasta] Don't report errors on NNBD features if experiment is enabled 
Change-Id: Ic3247440413b6135d4f1090c5729854bb3c4fbbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111429
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-07-31 13:56:34 +00:00
Paul Berry 6c1523410f Flow analysis: Create definite assignment test cases. 
The test cases are based on
pkg/analyzer/test/src/dart/resolution/definite_assignment_test.dart,
however those tests are removed because they exercise the old definite
assignment logic (which was never hooked up to the rest of the
analyzer, and was abandoned in favor of flow analysis).  This CL also
removes the old definite assignment logic itself.

There are two behavioral regressions compared to the old definite
assignment logic:

- Assignments inside assert bodies are erroneously assumed to always
  execute (they don't, because assertions may be disabled).

- Flow analysis does not yet understand that a function may be known
  to never return (with NNBD, such a function would have a return type
  of Never).

These regressions have been flagged with TODO comments (in the test
files assert.dart and if.dart respectively), and will be addressed in
later CLs.

Change-Id: I4a3923f667b151fe31cdcca69373ee1f8fb85607
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110400
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-31 13:55:54 +00:00
Paul Berry 7557a14a74 Move test cases from type_promotion_test.dart into front end. 
We still verify that the analyzer passes these tests, but we now do
the verification using the "ID test" mechanism that's shared with the
CFE.  This will allow the front end to run these tests as soon as its
integration with flow analysis is complete.

Change-Id: I1a7e5ef9698ebac72a72d992f4d765723224fc95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110343
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-31 13:55:54 +00:00
Johnni Winther 59aa4cd693 [cfe] Merge more Kernel*Builder classes into *Builder classes 
* Remove EnumBuilder and rename KerneEnumBuilder to EnumBuilder
* Merge KernelInvalidTypeBuilder into InvalidTypeBuilder
* Merge KernelTypeAliasBuilder into TypeAliasBuilder
* Merge KernelTypeVariableBuilder into TypeVariableBuilder

Change-Id: Ie5554146fc0c073b48453bae446f36592e46ecab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110903
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-31 11:19:52 +00:00
Johnni Winther fe2f82650b [cfe] Remove generics from Loader and UnresolvedType 
+ cleanup raw types to remove severity rewrite for codeMissingExplicitTypeArguments

Change-Id: I30af950db640cb15ddeeb86e17d9e9cb960a76d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110902
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-07-31 11:19:52 +00:00
Dmitry Stefantsov 20e4c74f7f [fasta][nnbd] Print NNBD type modifiers in Kernel's text representation 
Change-Id: I48c43858094e2b7264a15be05238bfc3dadd5ecb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108264
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-31 08:26:14 +00:00
Johnni Winther b9dbdffe6f [cfe] Remove generics from LibraryBuilder, FieldBuilder and ProcedureBuilder 
Change-Id: I1c3f6089bd1ab7eb129d6adb8f018d128fe4d3ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110901
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-07-29 15:58:08 +00:00
Johnni Winther 1b06a1cd1b [cfe] Remove generics from TypeDeclarationBuilder hierarchy 
Change-Id: Ied9be1426c7f77e1e209666dd243086acd00db56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110900
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-07-29 15:58:08 +00:00
Johnni Winther 3992be71c7 [cfe] Add this parameter to extension methods 
Change-Id: I25326e755d63b5707f8f7ce52b3d80c3965372aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110725
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-07-29 15:58:08 +00:00
Johnni Winther 28a7369146 [cfe] Merge KernelClassBuilder into ClassBuilder 
Change-Id: I0af957969863a69cd5c9b7a2da6ffc9550018e48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110723
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-07-29 15:58:08 +00:00
Johnni Winther 1e43d65d4a [cfe] Merge KernelFunctionBuilder into ProcedureBuilder 
+ rename ProcedureBuilder to FunctionBuilder
+ rename KernelProcedureBuilder to ProcedureBuilder
+ rename KernelConstructorBuilder to ConstructorBuilder
+ rename KernelRedirectingFactoryBuilder to RedirectingFactoryBuilder
+ move all classes to procedure_builder.dart

Change-Id: Ia139b36730f8dafa151e19a08637d17363262c77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109962
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-28 18:19:00 +00:00
Johnni Winther 8b6badda35 [cfe] Add static type test 
Change-Id: Id7a0fba20fe03fce2809131ae81bde1f2b5c50fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110724
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-28 13:41:09 +00:00
Alexander Markov 16f7076547 [vm/bytecode] Generate bytecode for expression evaluation 
Issue: https://github.com/dart-lang/sdk/issues/36427

Change-Id: I0a07bd8ff1be357d2962e6745c8ef1e500d45477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109984
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-26 18:22:51 +00:00
Johnni Winther 78224f9b0c [cfe+analyzer+dart2js] Support union markers in id-testing 
Supports markers like `cfe|analyzer.` to annotated that the expected
result is for both `cfe` and `analyzer`.

Change-Id: Ie69809db5f63a9ee9b87ff1513b819fe85ce0bce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110500
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-26 17:18:01 +00:00
Johnni Winther bcfe26cba0 [cfe] Fail early on unsupported evaluated constants 
The many different entrypoints to the CFE have repeatedly shown problems
with targets that do not support unevaluated constants being used
without providing an environment.

Making the targets opt-in to supporting unevaluated constants will
give the users of CFE early notice that CFE is used inconsistently
(as opposed to the backends failing when they happen to see an
UnevaluatedConstant node that they don't support).

Change-Id: I98c80df3a551823598e413e2895f5649f22f7c22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110561
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-26 16:57:51 +00:00
Johnni Winther 5357056a20 [cfe] Report errors when extension declarations are used as types 
Change-Id: Iad0c7df54fac476c2f23af2fe4ba30ee5bf49167
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110222
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-25 17:20:54 +00:00
Siva Annamalai d9287f4fe6 Reland "[dart] Enable constant-update-2018" 
This reverts commit 83d2aaa072.

Reason for revert: Want to reenable const-update-2018 by default.

Original change's description:
> Revert "[dart] Enable constant-update-2018"
> 
> This reverts commit 9bbd3192f4.
> 
> Reason for revert: Reverting enabling of constant-update-2018 by default as some blocking issues were found that are breaking Flutter and preventing rolls of Dart into Flutter. Once the blocking issues are addressed and fixed this CL will be relanded.
> 
> Original change's description:
> > [dart] Enable constant-update-2018
> > 
> > Change-Id: Ib3942b4f6e336a02826305d9f81839333a5464a0
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106943
> > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> > Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> 
> TBR=paulberry@google.com,vegorov@google.com,athom@google.com,vsm@google.com,aadilmaan@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: I5796881412cec464f450ff3894ca253c58edc4a2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109308
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>

TBR=paulberry@google.com,vegorov@google.com,athom@google.com,vsm@google.com,asiva@google.com,aadilmaan@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I06fbeef318706074c0efcfd42b459bf37c3c92e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109661
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-07-25 16:58:49 +00:00
Paul Berry b716a4e3cd Flow analysis: document how state methods are expected to be used. 
I focused on the methods where the intended usage wasn't already
obvious from the method name or its documentation comment.

Change-Id: I8aeb01ccf8795e2f7a45b5cf1341d5ebbc77caaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110242
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-25 16:03:35 +00:00
Paul Berry 41907fd4a5 Flow analysis: clarify when variables are removed from the "promoted" map. 
Change-Id: I72fe7d59ccce0dea507af63e1d7910ade8325544
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110241
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-25 15:55:54 +00:00
Paul Berry fdfad8d2f2 Flow analysis: fix a typo 
Change-Id: I13d55745923c18fbdf959e440c26c143efe340fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110240
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-25 15:22:13 +00:00
danrubel 5713caaf09 prepend all remaining scanner error tokens 
Change-Id: I325f0681a26e336a41ade9250a2ee0e90a658492
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-25 01:51:43 +00:00
Paul Berry bf4bde6ea2 Move test cases from flow_analysis_test.dart into front end. 
We still verify that the analyzer passes these tests, but we now do
the verification using the "ID test" mechanism that's shared with the
CFE.  This will allow the front end to run these tests as soon as its
integration with flow analysis is complete.

Still to do: migrate tests of type promotion and definite assignment
so that they can be shared by the front end.

Change-Id: I3c2ac6ff8b66e3a27110dcdb1f1d2dece447c18d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-24 20:20:09 +00:00
Dan Rubel 3c05b8199b move identifier recovery into scanner 
Change-Id: I1e4f4fa900b72e4fd405ae8dc86dfa9bc13f370f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110183
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-24 18:38:43 +00:00
Dan Rubel c62bd8f3f4 prepend unterminated comment error token and others 
Change-Id: I18fd270e9b74e1fd94403ef90f275001983aa86d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-24 18:38:43 +00:00
Dan Rubel 34ed30f020 prepend unterminated string error code 
Change-Id: I95884700f7a43abfb89753b7381167bac19e4c2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-24 18:38:43 +00:00
Dan Rubel 24d1e511df improve missing hex digit recovery 
Change-Id: I12d9e3fe314e850a6ee9599187d67dfa5455b18a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-24 18:38:43 +00:00
Johnni Winther 82f657d7cb [cfe] Support error testing in annotated tests 
Change-Id: I545ded4d82147f22efc80f4ed8ee833cd75a9be7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109963
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-24 07:10:23 +00:00
Johnni Winther b9828b5ac7 [cfe] Merge KernelFormalParameterBuilder into FormalParameterBuilder 
Change-Id: I1904b14aa78f7cbadf61a3542e5146c4c7bf4a07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109961
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-24 07:10:23 +00:00
Paul Berry 6c43390cd8 Begin running the shared "ID tests" for constants on the analyzer. 
This exposed an analyzer bug--see #37608.

Change-Id: I96af785ce81ebb7b142b4f71cb43942b2b15f879
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-23 22:08:12 +00:00
Dan Rubel a082f8ce65 merge ArrayBasedScanner into AbstractScanner 
There is no need for two separate abstract scanner classes,
so ArrayBasedScanner functionality has been moved into AbstractScanner.

Change-Id: I88765b0b1fa5bf5c73f457ceb5f85cae73b33a5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-23 20:19:52 +00:00
Dan Rubel 9c148623c5 prepend missing hex digits error token 
This prepends (rather than append) another error token to the token stream
similar to https://dart-review.googlesource.com/c/sdk/+/110100

In addition, this addresses a comment in
https://dart-review.googlesource.com/c/sdk/+/110140

Change-Id: I27c739b0ee3213cdbce92c3ff18c31fde862251c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-23 18:08:37 +00:00
Dan Rubel b41b868797 prepend UnmatchedToken error tokens 
This change ensures that instances of UnmatchedToken are always prepended
to the token stream. This should prevent the exception that occurs in
https://github.com/dart-lang/sdk/issues/37491.
This addresses only one type of error token and we may see a similar
exception with other types of error tokens.

Future CLs will prepend other and eventually all error tokens.

Change-Id: I99cdc331c03f47b21c5a67d436a0e62ebf416e94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-23 15:21:04 +00:00
Paul Berry 7fa49a285a Update the minimum SDK constraint to 2.2.2 for kernel and front_end packages. 
This allows us to use ui-as-code and set literal features in these
packages.

This should be safe because (a) when these packages are used within
the SDK itself, they are used with the most recent SDK (whose version
is greater than 2.2.2), and (b) the only significant dependency on
these packages in pub is from the analyzer, which already has a
minimum SDK version of 2.2.2.

Change-Id: I4f7d4c9506904ee3016db95297b45e5bcf7989b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110060
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-07-23 12:55:11 +00:00
Paul Berry baaeafa2bb Flow analysis: move into front_end. 
This will allow it to be used by both the front end and the analyzer.

Change-Id: I3af67aaf3ad7ff2cca0cb245518570892ad473e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109986
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-07-23 12:55:11 +00:00
Johnni Winther ed38b6d664 Remove KernelMixinApplicationBuilder and KernelNamedTypeBuilder 
NamedTypeBuilder and MixinApplicationBuilder are only subclassed by
KernelNamedTypeBuilder and KernelMixinApplicationBuilder, respectively,
so the distinction can be removed.

Change-Id: If0a6434d76c20c3c10a8e25b86d2a5542d5244b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109263
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-23 09:20:28 +00:00
Johnni Winther 0177076f2f [cfe] Merge KernelBodyBuilder into BodyBuilder 
Change-Id: Ica7d23a54659606ef8d01c647dc8d89f10796bb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109712
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-23 08:02:18 +00:00
Johnni Winther 05b5883813 [cfe] Add documentation to some Generator implementations 
Change-Id: I0a57b08da639557376b1b6f666d2d8aa6344f59c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109711
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-23 08:02:18 +00:00
Dan Rubel d7cb52b863 capture more info to debug 37528 
This updates the exception message to capture more information
about where the exception is occurring. Hopefully that information
can be used to fix https://github.com/dart-lang/sdk/issues/37528

Change-Id: Iaf10395091f8bd8b540dddc59001f23b6dc6a073
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-07-22 20:18:17 +00:00
Johnni Winther cddd21dde1 [cfe] Merge ExpressionGenerator into Generator 
+ Make more internal properties private
+ Add documentation on more properties/methods

Change-Id: I40779c83fcb7f888e485ccbc7b1fad312199806c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109710
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther b52328e528 [cfe] Remove unneeded indirect generator construction through Forest 
Change-Id: Ic535bfe84395608c9b0764edf8646fd2606429b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109708
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther 2a199f3993 [cfe] Merge KernelExpressionGenerator with ExpressionGenerator 
We no longer need the distinction between *Generator and Kernel*Generator
so the Kernel*Generator classes are now merge into the *Generator classes.

Change-Id: I9f9650fc4ab88a0952b8d2bd346e1d416d68eac6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109707
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther 948b60f8dc [cfe] Add test for extension member parameters 
Change-Id: I6ceb66bbef561b0c86e6f529e9d90a35dd82f628
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109705
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther 11755e537c [cfe] Add tests for extension members 
+ Avoid creating default constructors.

Change-Id: Ie0ed967d9be4cf31a2eb6991767887de1f88149a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109702
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther 610183d5f9 [cfe] Rename operator[] to getLocalMember on Library/ClassBuilder 
Change-Id: I8d03cf939e15de53b3768ee946815cf31e3a1124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109700
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther b3b6533c3d [cfe] Create ClassBuilder for extension declarations 
Change-Id: Ic372b89588ed9ec3afc43f7db7e3d38a81846ad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109264
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther 7075ae7026 [cfe+dart2js] Move features to CFE 
To share support for annotated tests based on Features.

Change-Id: Ic319442e2e016bf4d1584825ea019d13a74acedb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109560
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-22 16:00:28 +00:00
Johnni Winther d68b482f26 [cfe] Handle constructor from external libraries 
Closes #37532

Change-Id: I8b07addeb1da6bc4fe165ff535944fab8c6698b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109261
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-07-17 06:26:34 +00:00
Siva Annamalai 83d2aaa072 Revert "[dart] Enable constant-update-2018" 
This reverts commit 9bbd3192f4.

Reason for revert: Reverting enabling of constant-update-2018 by default as some blocking issues were found that are breaking Flutter and preventing rolls of Dart into Flutter. Once the blocking issues are addressed and fixed this CL will be relanded.

Original change's description:
> [dart] Enable constant-update-2018
> 
> Change-Id: Ib3942b4f6e336a02826305d9f81839333a5464a0
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106943
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

TBR=paulberry@google.com,vegorov@google.com,athom@google.com,vsm@google.com,aadilmaan@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I5796881412cec464f450ff3894ca253c58edc4a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109308
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-07-16 22:30:36 +00:00
Johnni Winther dfa12c7456 [cfe+dart2js] Support library and error ids in annotated tests 
Change-Id: Ife808a7d4aa1d4cf459ac3c04ee6ff02042442d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108810
Reviewed-by: Stephen Adams <sra@google.com>
 2019-07-16 14:32:37 +00:00
Johnni Winther d5af4ed8c2 [cfe] Remove KernelTypeBuilder and KernelFunctionTypeBuilder 
TypeBuilder and FunctionTypeBuilder are only subclassed by
KernelTypeBuilder and KernelFunctionTypeBuilder, respectively, so the
distinction can be removed.

Change-Id: I2cccd0d6b08f695ecb6ccb543f858edd4919cfda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108819
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-07-16 05:40:41 +00:00