dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6018 Commits

Author SHA1 Message Date
Aske Simon Christensen 95c9f732de Expire spread and control-flow collection flags. 
Change-Id: I59fe3ad2bdd90681e6d40dc39f04a0e53125e707
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113989
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-08-22 10:52:51 +00:00
Johnni Winther 9e676aa228 [cfe+dart2js] Add error testing to constant_test 
Change-Id: I0eb809960a13f70942923e7756f128bf0c096ce7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114066
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-22 10:31:59 +00:00
Jens Johansen 5dcec3c93e [CFE] Disallow exports internally 
This CL adds a lint, but doesn't cleanup the failures we have.

Change-Id: I711af6d012e0b1f1b7dfe422dd615f32f0084119
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113993
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-22 08:09:21 +00:00
Jens Johansen 40589f80aa [CFE] Fourth batch of fixes for requiring explicit types 
Change-Id: I13f62232287b84cc82da2bbb0cee4b4d337de8ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113992
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-22 07:08:27 +00:00
Paul Berry 51cd16ecf0 Flow analysis: support for and for-in elements in collections. 
Change-Id: Ia73c68c2b8a57c62ce2b4984184cf8a712b554af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113944
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-08-21 21:57:54 +00:00
Paul Berry 4bf5a72ca0 Flow analysis: support functions whose bodies are expressions. 
Change-Id: I01a66fb2c897e0cabbdfb4b7423cab53291b3adf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113947
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-21 20:41:13 +00:00
Jens Johansen f2e04caeaf [CFE] Fix CQ race condition with lint status 
TBR

Change-Id: Ie99cd8a0d93c765f1c9bc90b97393359b625abdb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113995
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-08-21 13:39:30 +00:00
Jens Johansen 48edb2362a [CFE] Update lint for explicit types to also look at fields and top level fields 
Oversight that it didn't always do that.

Change-Id: Ib515ed0f77efcdfb932d5fad9c5b269eeb45a160
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113988
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-21 12:33:45 +00:00
Aske Simon Christensen 5905fe41a9 [CFE] Explicit return types and overrides in constant evaluator 
Change-Id: Ibdba0689a7de58f3ab999d10d963dac43dbfc1e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113984
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-08-21 12:25:32 +00:00
Jens Johansen 698c5b1a36 [CFE] Add 'double import' lint 
Add a lint to discourage importing the same file more than once.
The idea being that it was probably done by mistake (e.g. automatically
by an editor).
This is done in a number of places and they are currently added to the
status file.

Change-Id: I16bc9c04c5a607f87ead1fb34922a7edb408c3da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113985
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-21 12:20:22 +00:00
Johnni Winther 7f9f4ad774 [cfe] Delete legacy tests 
+ make sdk_test test non-legacy

Change-Id: Ie9861e54d12301f454d4fccf6eccd3516e0387d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113825
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-21 09:01:44 +00:00
Johnni Winther 91c8cf7167 [cfe] Support per folder experimental flags in testcases 
Change-Id: Ia4d795959f6b192d83c97c45870c5fc59d406f4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113824
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-08-21 09:01:44 +00:00
Alexander Markov 922c2bfbb0 [vm/bytecode] Include source info and asserts into platform with bytecode 
* Include source positions, source text (if provided by front-end, which is
  controlled by a separate option) and assertions into platform with bytecode.
  Also use environment defines if provided.

* Omit bytecode for synthetic static fields '_redirecting#' injected
  by front-end, as they contain invalid AST nodes (taking tear-off of
  a constructor). This is needed to avoid emitting bytecode which cannot be
  loaded.

* Correctly merge source information such as source text and line numbers
  in bytecode generator if the script was originally created for an
  anonymous mixin application without such information.

* Always include import URIs into source information, even if other information is
  excluded (for members in anonymous mixin applications / noSuchMethod forwarders /
  forwarding stubs).

* Set native resolvers for vm/cc/PrintJSON test, as printing all objects to JSON
  involves collecting token positions, which may read bytecode from platform and
  need native resolvers to process native method entries.

Change-Id: I971e880c25439c0ec69db3a231a0085ccd5d15ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113780
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-08-21 01:08:24 +00:00
Paul Berry 1d9b6427ef Prepare to publish analyzer version 0.38.1. 
Change-Id: I5c900310be1c66b3e8dfbd363aef3089bb07fbbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113922
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-20 22:17:03 +00:00
Dan Rubel 3e69627752 Fix type argument parsing crash 
Fix https://github.com/dart-lang/sdk/issues/37706

Change-Id: Ifc54c3fa4f57c772f8059d59e0265c4677a400fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Dan Rubel e2777454cc Fix dartfmt bug 
... by changing ANNOTATION_WITH_TYPE_ARGUMENTS to be a syntax error

Fix https://github.com/dart-lang/dart_style/issues/836

Change-Id: I2ac1b1105b817b6728ecc3d73875581a9cf65861
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-20 20:04:19 +00:00
Johnni Winther 027071318f [cfe] Change outline test to test strong mode 
Closes #37904

Change-Id: I75cd093922dbcf29c0b073d6a37aaba9d6c1f5f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113697
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-08-20 13:51:10 +00:00
Jens Johansen 363ae34c55 [CFE] Third batch of fixes for requiring explicit types 
Change-Id: Ie4c8e66acf942901602c91819640967e49044233
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113822
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-20 13:11:12 +00:00
Jens Johansen e60cbdfd9e [CFE] Add test for running old dills 
This CL:
* adds a test that runs the VM with old dills (compilations of dart2js
  with old checkouts) with the --compile_all argument (1).
* adds a number of old dills (for binary version 25, 27, 28, 29)
  (by mistake binary version 26 sort of didn't really happen)
* adds a PRESUBMIT check in kernel that verifies that we have an
  "old dill" for the current binary version, so one don't bump the
  version without creating a new dill.

(1): It uses --compile_all to force the VM to "read and understand"
     everything in the dill file. The hope being that we try out
     all/most language constructs and thus verifies that they can be
     read by the VM.

Old "old dill" files should be removed once the VM stops supporting that
version. That is a manual process, but a test should complain that the VM
cannot read the old "old dill"(s) once/if that happens.

This should (help) detect errors such as the one recently where a merge
error caused a single "if >= 28" (that should have been "if >= 29" and
thus stopped the VM from reading dills from version 28) to slip through
and require a lot of debugging a few days later.

Change-Id: Id79e16c7ad896c0ccc4e181465b05b67822ac31a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113698
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 12:27:52 +00:00
Dan Rubel f5f942684b Fix invalid literal list element crash 
Fix https://github.com/dart-lang/sdk/issues/37697

Change-Id: Icefae7ca0c0f6b0d317c6aa48039fa6e6967409d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113705
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-20 12:03:12 +00:00
Johnni Winther d153e98447 Revert "[cfe] Gather constraints from both possibilities for FutureOr" 
This reverts commit 00e9561798.

Original change's description:
> [cfe] Gather constraints from both possibilities for FutureOr
> 
> Closes #37778.
> 
> Bug: http://dartbug.com/37778
> Change-Id: Ic06da9cf4e24e397e1f2a180b743190a4165dc3e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113033
> Commit-Queue: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

TBR=dmitryas@google.com,johnniwinther@google.com

Change-Id: I64677971c865180334958de13d2d82fec3daec85
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: http://dartbug.com/37778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113821
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-20 10:57:52 +00:00
Jens Johansen b99df2be86 [CFE] Language versioning - additional tests 
Change-Id: I0dd93c3a1d422bbbbbd920fae21569a7bdc91e61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112341
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 10:08:20 +00:00
Jens Johansen 10e63b7840 [CFE] Get fragment from default package - use language version if any 
Language versioning specifies that an empty-name-entry in .packages
specifies a sort of "default package" that a non-package file should
pretend to be a part of "for any purpose where that matters,
including choosing the default language level."

Change-Id: I16f4b2f5e4d3ca1e82d2189321e2be5c43e3b260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112089
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 09:06:32 +00:00
Johnni Winther 00e9561798 [cfe] Gather constraints from both possibilities for FutureOr 
Closes #37778.

Bug: http://dartbug.com/37778
Change-Id: Ic06da9cf4e24e397e1f2a180b743190a4165dc3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113033
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-20 08:43:22 +00:00
Dan Rubel bb076a20c5 Fix unsupported initializer exception 
... and add a new ParserErrorCode.INVALID_INITIALIZER error code

Fix https://github.com/dart-lang/sdk/issues/37693

Change-Id: I0a30ad97f90aab35cd3af76d1546e1e78f1de2db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 19:55:12 +00:00
Dan Rubel 3568f78fe7 ensure super constructor invocation param list not null during recovery 
Fix https://github.com/dart-lang/sdk/issues/37735

Change-Id: I727cd7aeb141c5abb779b3c15f338f3d43f6541f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 18:34:32 +00:00
Dan Rubel a984c5ce57 improve invalid string literal recovery to fix crash 
Fix https://github.com/dart-lang/sdk/issues/37877

Change-Id: If9fe3d42659608bf7cd050de515ec41ca45a697b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-08-19 17:46:47 +00:00
Dan Rubel bdd77cd0b2 Ensure function type param has non-null identifier 
Fix https://github.com/dart-lang/sdk/issues/37733

Change-Id: I552d67aa048eeb5ae4417205f641d71ca7ecadd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 17:46:47 +00:00
Paul Berry 0ff0cc1229 Flow analysis: remove unnecessary argument to doStatement_end. 
And add unit testing of do statements.

Change-Id: I976780a400cbd852f71d915f1c67b5433ba8807c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113267
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-19 15:49:43 +00:00
Johnni Winther ee37965e49 [cfe] Handle static access of static extension members 
Change-Id: I9c52ddc7b0c7ef0952471542ee41c231989d80d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113441
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-19 14:47:33 +00:00
Jens Johansen 0e201edeeb [CFE] Second batch of fixes for requiring explicit types 
Change-Id: If4f35550e1df10763b4c13d15eba1d9f53e6095e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113324
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-19 07:19:45 +00:00
Johnni Winther 9c649e67df [cfe] Handle most accesses to extension members from within the extension 
Change-Id: I1be167bff0f398793c67834bb80328418e9bb4c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113020
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-08-18 12:25:34 +00:00
Paul Berry 14e84afb63 Flow analysis: fix incorrect comment 
Change-Id: Iec2229fcf1e1688ead0acb094d3397cf4278ab46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113400
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-08-16 20:31:10 +00:00
Mike Fairhurst 0477f8df9e Fix keyword infinite loop 
Change-Id: I92bee9991400c229bbf665414a096efae72c14c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113126
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2019-08-16 20:08:30 +00:00
Johnni Winther eae781c73e [cfe] Add Field.isLate, VariableDeclaration.isLate and VariableDeclaration.isRequired 
Add support for the `late` modifier on fields and local variables in
CFE, and `required` on named parameters When using the option
--enable-experiment=non-nullable the `isLate` and `isRequired` flags will be set
accordingly on Field and VariableDeclaration nodes.

Closes #37686
Closes #37684

Change-Id: If37fc93defdabc5cc974f3f068f57752a665f4cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113036
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-08-16 19:39:05 +00:00
Paul Berry 8ab978b6d4 Flow analysis: remove unnecessary parameters from conditional_* methods. 
Also rework the flow analysis tests a bit to allow tests to be written
in a more compact way.

Change-Id: I6642ce9987bb89b9b858e709575ce12510c8f442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-08-16 18:44:00 +00:00
Johnni Winther 2fda7f8002 [cfe] Handle qualified name as an AmbiguousBuilder. 
+ strengthen checkState invariants in the path of the error.

Handles problem brought out by #37776

Change-Id: I55165a1bdaa3a8a0910d71c6d56472bdbfe592c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113183
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-08-16 16:12:58 +00:00
Aske Simon Christensen 528292bd30 Expire constant-update-2018 flag. 
All uses of no-constant-update-2018 in the Dart SDK, Flutter and
Fuchsia have been cleaned out, which means we can expire the flag.

Closes https://github.com/dart-lang/sdk/issues/37874

Change-Id: Ie31dfbf87db52d37fdf4218afa8c6f7a894bafff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113182
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-08-16 13:48:27 +00:00
Jens Johansen a3b579d5c3 [CFE] Add PRESUBMIT.py that runs a little smoke testing 
Runs pkg/front_end/tool/smoke_test_quick.dart if changing either
* A .dart file, or
* A messages.yaml file
inside the front_end folder.

Change-Id: I466fda1436806e280e38f90afe77f1c7aa53d021
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113321
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-16 12:28:07 +00:00
Jens Johansen 7136d9e4e7 [CFE] Add a 'tool' that runs a quick smoke test 
Runs a number of tests that are quick, currently:
* Messages test in a new fast mode which skips compilation
* The spelling tests
* The custom CFE lint test

Change-Id: I7b444e5be1cf2397d6d776aac96dd7c2ad2b302d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113320
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-16 11:14:07 +00:00
Aske Simon Christensen e611357309 [CFE] Error on bitwise or shift operation on a double constant. 
Fixes https://github.com/dart-lang/sdk/issues/36823

Change-Id: I9aeb34b9f80261889434f85bf39af3d78a38202e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112391
Reviewed-by: Mayank Patke <fishythefish@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-08-16 11:11:27 +00:00
Jens Johansen 050ec9eebd [CFE] Spelling tests give proper error messages 
Change-Id: I5a145b070acc4388ecf0ac5dab1a36f5647f6150
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113185
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-16 07:24:57 +00:00
Paul Berry fecc4c8f2d Breaking changes for analyzer version 0.38. 
Change-Id: I93fbcb9e86c6c809c4610d2d90dc8bc8b69c45c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108162
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 19:42:31 +00:00
Paul Berry 23387d636b Flow analysis: merge APIs for handling && and ||. 
This will make it easier to integrate flow analysis into the migration
tool, since the migration tool has a shared code path for handling
`&&` and `||`.

Change-Id: Ibf1c7362dfeaab505a2ecf7298b2569a40fca781
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113038
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-15 13:34:30 +00:00
Johnni Winther 06ab457ff3 [cfe] Merge Fangorn into Forest 
+ rename creation methods of AST node X to createX to simplify usage.

Change-Id: I323c0dba9417f93cd43f409c3f55d17108f53013
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112395
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-08-15 13:14:50 +00:00
Jens Johansen 9552646dc4 [CFE] First batch of fixes for requiring explicit types 
Change-Id: Ic27f8508bc95409a5ee8f90b72f34a73d0f8e2e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113034
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-15 13:13:20 +00:00
Johnni Winther 9d4e778cde [cfe] Support getters, setters, fields and operators in extensions 
Change-Id: Ic84380ea767691bbbb802c65cb72fe43893f78a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112257
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-08-15 12:12:00 +00:00
Jens Johansen 93d4d28f6c [CFE] Add lint test: Require explicit types 
This CL adds a test (lint_test.dart) that gives errors if using e.g.
"var foo = 42;".
We opted to not use the lint "always_specify_types" as that does
more than what the team voted for.

Change-Id: Ia37066ee04ff676d15f41222751557a9245f953f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113032
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-08-15 10:21:00 +00:00
Jens Johansen cae08c6813 [CFE] Apply lines_longer_than_80_chars lint 
Change-Id: I35b62b34d3ccc7098c21a680a80612c0bb927123
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113030
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-08-15 10:01:20 +00:00
Johnni Winther 54f26e3554 [cfe+ddc] Support --target=dartdevc in _fasta/compile.dart 
Change-Id: I7288dd3dd03fb58188e3652d9b86e5751c104142
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113037
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-08-15 09:08:40 +00:00