97d6ac21d5
[CFE] Spell check on kernel src; presubmit on kernel & _fe_analyzer_shared
...
Change-Id: I3ca7c856bdf9e6ad6e4474c804fd4f7f6b23571e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126730
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-12-02 13:00:47 +00:00
1454a67e09
[cfe] Don't use multiple null-aware guards in opt-out
...
Change-Id: I15bd991577ffcc309569ee4a5512dfb29c7874ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126732
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-12-02 12:19:27 +00:00
12d9bedb33
[CFE] Let spell checker report all reported words at the end
...
Change-Id: Iefa2b72cc1af12957e34525e263fe2dfcf076dd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126727
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-12-02 10:41:27 +00:00
88630cc235
Move real resolveConstructors from ClassBuilderImpl to SourceClassBuilder
...
Change-Id: I9855130de2e9947d1cc574512f75cee82fc24e3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125969
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-12-02 10:19:37 +00:00
c1d21c368a
Move a few methods from ClassBuilderImpl to SourceClassBuilder
...
Change-Id: I85553b68f497f58d32721a93a718a069c8d783e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125968
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-12-02 09:34:32 +00:00
1c3468a646
[kernel] Remove Library.isExternal
...
Change-Id: I6638b915c1189838e7081069a0075e4ecd9ee9d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125600
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-12-02 09:24:42 +00:00
f7549f6dd7
[cfe] Test suites runner: improve format of timing information
...
Change-Id: I5f5b648501e61c224d5faffd8bbd7d62391558e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126721
Auto-Submit: Karl Klose <karlklose@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-29 23:48:26 +00:00
63333deed6
[vm/cfe] Elaborate for-in statements during async transform
...
This allows us TFA to analyze the iterator calls and we generate much tighter
code in AOT.
However, due to the increased inlining opportunities, we end up emitting 0.5%
more code. Inlining of the _GrowableList iterator specifically also includes the
concurrent modification check and error handling.
Calls to get:iterator, moveNext and get:current account for 7.12% of all InstanceCall
instructions in Flutter Gallery.
Fixes https://github.com/dart-lang/sdk/issues/39516
Issue https://github.com/dart-lang/sdk/issues/39566
Issue https://github.com/dart-lang/sdk/issues/39565
Change-Id: I8dcc08b7571137e869a16ceea8cc73539eb02a5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126381
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-11-29 16:42:36 +00:00
f9cedb6813
[vm/ffi] Fix source information in generated AST nodes
...
Fixes: https://github.com/flutter/flutter/issues/39916
Fix verified by manually generating the assembly snapshot and seeing the offending DWARF output be fixed.
Old DWARF:
```
.string "" // Empty filename in file table.
.uleb128 0
.uleb128 0
.uleb128 0
```
New DWARF:
```
.string "dart:ffi/struct.dart"
.uleb128 0
.uleb128 0
.uleb128 0
```
Change-Id: I60b6ff349deb70148c1a475b242c99e7c582d8c4
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126650
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2019-11-28 16:07:45 +00:00
659b32ffc8
[cfe] Handle chained null shorting and null aware if-null set
...
Change-Id: I39d2448a957ca7f4f3d1f027e543f773b300ce9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126645
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2019-11-28 12:44:55 +00:00
8d874a5bd8
[cfe] Avoid cascading errors from part versioning mismatch
...
Change-Id: I8a233ff6c3b727176b812db203dac87f022f8a84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126643
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-28 10:48:34 +00:00
cd229de42b
[cfe] Increase unit test suites time out to 15 minutes
...
Change-Id: Iad751b95875b2b7a82f3d19cb4e49552d67e9ee5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126640
Auto-Submit: Karl Klose <karlklose@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-11-28 07:59:08 +00:00
a17809ad18
[kernel] Add TypeEnvironment.forInElementType
...
Adds convenience method for computing the element type of a for-in
iterable.
Change-Id: Idd1bf0a9b80523c49130b2d7f17590dcf86d3e40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126581
Reviewed-by: Samir Jindel <sjindel@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-27 19:18:21 +00:00
10f158654e
Return the URL of recently published docs
...
Change-Id: Iea19a318182a5c8c3ad1368f9655cf6f5f304301
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126480
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-11-27 14:19:50 +00:00
61f5e88454
[CFE] [Strong test] Check non-serialized expectations first
...
This gives a "MismatchExpectations" error instead of
"MismatchExpectationsSerialized" if the serialization doesn't matter in
getting to the mismatch.
The serialized version is skipped when updating expectations to not
makeing the serialized version the "right" verison (which could get
you into a position where updating expectations and rerunning would
tell you the (normal) expectations needed updating).
Change-Id: I99b3af5fa823010d4abbf0837faf00e17b303c0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126540
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-11-27 13:04:00 +00:00
b563d6cad5
[kernel] Exclude pkg/kernel from front_end spell checking
...
Excludes pkg/kernel and pkg/front_end/fasta/api_unstable/
Includes pkg/_fe_analyzer_shared
Change-Id: Id855c4262dffd3e0fd3b116844af39af68f43987
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126341
Auto-Submit: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Clement Skau <cskau@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-26 14:28:39 +00:00
cdb9830a54
[cfe] Shard text_serialization tests
...
Change-Id: Ibfa8a254f4918f96dee2a7fe72250766dcbdca65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126321
Auto-Submit: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Karl Klose <karlklose@google.com >
Reviewed-by: Karl Klose <karlklose@google.com >
2019-11-26 09:56:53 +00:00
18f23124ad
[cfe] Print nullability on types in messages for opt-in libraries.
...
This CL changes the message template generator to add an extra
'isNonNullableByDefault' parameter to 'withArguments' for all
messages that include types, thus forcing the reporter to specify
whether the library that the message belongs to is opted in to NNBD.
When the message is formatted, a '?' is added to all nullable types
if the message is reported for an opt-in library.
Change-Id: I4e1861eba48043c570afad3f40bc3dccfd2e5668
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124984
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-25 14:58:45 +00:00
e84af9b761
[cfe] Disallow annotations on type parameters of function types
...
Also, do not copy annotations on type parameters of functions into
their inferred types.
See https://github.com/dart-lang/language/issues/656
Change-Id: I1460007645a32ac56a505b23ab3ee8a457c3f994
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123732
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2019-11-25 14:55:55 +00:00
cb6ab6eaa2
[cfe] Handle untyped initializing formals for late fields
...
Change-Id: I7cd0612ea7690d1679fbd7269f628ec5bc65dd05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126040
Reviewed-by: Jens Johansen <jensj@google.com >
2019-11-25 13:59:25 +00:00
4d884229ab
[kernel] Add (internal) relink method
...
Think of this as an internal method. You probably shouldn't call this
method without being told to by the kernel team.
Change-Id: I76d55870ee781646a648e8e253a33a1d497eed81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125963
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-25 12:44:25 +00:00
ecaa3e643a
[cfe] Move inference visitor to its own library and rename kernel_shadow_ast to internal_ast
...
Change-Id: I2a30efc08568380017230dd2af16329488687e9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126041
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-22 16:08:44 +00:00
e78a2fd0df
[cfe] Remove optional parameter to toString
...
Violates usual toString interface for no good reason.
Change-Id: I8f92f1c91c40bcab192e0862b920a4dabf259d57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125262
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2019-11-22 14:37:54 +00:00
1f382890a7
[cfe] Make inference NNBD-aware
...
Change-Id: I7a793c87b00c97a7d4b05ba94116215d8f6d2a89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125970
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2019-11-22 12:09:14 +00:00
bd06f1bf51
[cfe/infra] Unit test suites: print re-run command when a test fails
...
Closes #39423
Change-Id: Ifa3fbe4d670f4f95beceb2aae8769a553a9fbe7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125604
Commit-Queue: Karl Klose <karlklose@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-22 10:45:54 +00:00
970c164826
[cfe] Use correct types in transformations and start verifying getStaticType
...
With this fix Expression.getStaticType no longer throws on any known cases.
Users of getStaticType can therefore avoid enclosing static type computation
in try-catch.
Closes #38597
Change-Id: I52eaacd30256333d7c368e5d14f4e4956bafc96f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121988
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-11-21 22:15:58 +00:00
0b9665fc8b
[cfe] Use library's non-nullable modifier when creating new types
...
It's a part of internal cleanup of pkg/kernel and pkg/front_end. The
library's status is queried when the new types are created for it in
order to determine the value of the nullability modifier of the type.
Change-Id: Id653c511d17b3811a26b1751876a6e5036cdbed9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125261
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-21 16:00:25 +00:00
3ed0ce2419
[cfe] Reuse nullability modifier when creating a copy of a type
...
It's a part of internal cleanup of pkg/kernel and pkg/front_end. The
nullability modifier is reused whenever a type object is created as a
(potentially modified) copy of another type object.
Change-Id: I9d09a744281e33814289a4f4dd65c764a7905eff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125260
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-21 16:00:25 +00:00
6808c563aa
Adjusted front end to allow non-function type aliases
...
This change does not enable much (because the backends do not support
non-function type aliases), but this change makes it possible to work
on this feature in dart2js code, without making the changes to the
front end and the changes to dart2js part of the same cl.
Change-Id: I0d8a27a0e87cf6908f914b2c10d97ef3d02ebec5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125961
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-21 15:40:45 +00:00
acff31ed26
[cfe] Support null-aware index access
...
Change-Id: I54b58624722845e4b008b90e675516ec274bc2da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125960
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-21 14:36:30 +00:00
4c8c44ec78
[cfe] Implement lowering for constructor initialization of late fields
...
Change-Id: Ia6187c3eac630a2bd4351868aadfaa8771648830
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125821
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2019-11-21 09:36:35 +00:00
f692a2fbb8
[cfe] Eliminate Nullability.legacy in transformers
...
Nullability.legacy is replaced with an appropriate invocation of a
method on Library to retrieve the appropriate nullability. Only
transformers in pkg/kernel and pkg/front_end are affected. The
inference transformers are excluded from the scope of this CL.
Change-Id: I691c4343def913388a1277227b760fd7e1aa194c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125666
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2019-11-21 09:12:05 +00:00
2e32972929
[pkg/vm] Remove usage of Library.isExternal
...
Change-Id: I014184e2324ab0379653cb8c23cb7eed52677aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124985
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-21 08:36:54 +00:00
aa2b3a5eaa
[cfe] Inference constraint solving takes contravariance into account.
...
Implements https://github.com/dart-lang/language/issues/658 .
Change-Id: I28857c40bbc5db76f7312ed540052fed40dac4b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125552
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2019-11-21 00:05:18 +00:00
246b23e5be
[cfe] Implement late lowering for local variables.
...
Change-Id: I18f848561f7eca61f662f8083f7ca1451a8a0b3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125605
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2019-11-20 08:30:18 +00:00
195dd200ab
[cfe] Support statement replacement in inference_visitor
...
Change-Id: Ib4cfbab9478eda43ad9f6271511120c782349440
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125603
Reviewed-by: Jens Johansen <jensj@google.com >
2019-11-20 08:30:18 +00:00
1f933abcee
Convert a compile time error into a parse error (issue 39389)
...
Change-Id: I115c7bb4ab05f8c6e9ddc566985126a1b9a09842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125621
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-11-19 18:25:29 +00:00
db64f9ecb2
Delete standalone_2/io/process_exit_negative_test.dart.
...
I am trying to migrate all of the negative tests to something more
precise. As far as I can tell, this test stopped being useful with Dart
2.0. Now that all compilation errors are reported eagerly, the file
simply doesn't run at all. It's now just another test of an unresolved
identifier.
(This is a good example of *why* I want to get rid of negative tests.
This test silently went from a desired runtime failure to a compile-time
failure.)
Change-Id: Iec3cdd32a15612c0760119e92d618e3a5ba1f5ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125555
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2019-11-19 18:23:30 +00:00
c2584d8046
[kernel] Align TypeParameterType.hashCode with the equality strategy
...
Since we use a unification strategy for function type type parameter
equality, we have to assume they can end up being the same. The
implementation of TypeParameterType.hashCode now reflects that.
Closes #39409
Change-Id: I5054b591253fb7d17208ffebdc5236a7100974de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125607
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-19 16:49:59 +00:00
fae6affeea
[CFE] Incremental compiler has experimental invalidation strategy (first checkpoint)
...
This CL adds an option to the incremental compiler that enables an experiment
invalidation strategy that only rebuilds bodies for changed libraries (if possible).
As far as we know, for valid applications this should work fine, although,
applications with errors in them (or where the changed libraries have errors in them)
might not issue those errors correctly.
Known caveats:
- Doesn't work on dill library builders (aka if you load from dill we
still have to invalidate transitively).
- Only body-in-brace-changes --- cannot add new private members for
instance, nor changed fields.
- It doesn't track which bodies has changed so there's room for
improvement in regards to for instance mixin stuff where we bail
if a class from an invalidated file is used as a mixin.
- Offsets for methods, for instance, isn't updated
- Any errors issued at the outline stage won't be issued.
Change-Id: I6edf073ec47ea31429479ffe67e2e8b6d2cb80dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124980
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-19 13:27:14 +00:00
7543d27445
[CFE] Disable colors for incremental compiler test suite
...
Before this change, running the tests via a terminal with colors enabled
would result in expectation file mismatches.
Change-Id: I958180074e65b4d0530c79be6bac11ba6d849b5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125602
Reviewed-by: Karl Klose <karlklose@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-11-19 13:26:54 +00:00
d9d5fbc109
[cfe] Create TypeParameterTypes with default nullabilities
...
Change-Id: I85be937240ba5cc39840e78f374902c1e36521a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124327
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2019-11-19 11:22:43 +00:00
1b295ef956
[cfe] Make nullability parameter of SubtypeTester.futureType required
...
Change-Id: I6be7cda9b976e83e2453dfc1c851efa75eb4fb40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124326
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-19 11:22:43 +00:00
203583b41b
[cfe] Account for invalid type being part of a type in subtype check
...
Bug: http://dartbug.com/39421
Change-Id: I9d70f6722134ece7f567d0aab9b6a0d661ea650e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125268
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2019-11-19 09:42:03 +00:00
62c67e40dc
Added language test for reified torn-off methods with explicit variance.
...
Change-Id: I51892de84245bc31f442b5b01ab3d03ac869e86f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124913
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2019-11-18 22:50:55 +00:00
7c1f58f9fe
[cfe] Demote inferred type variables when used as type arguments
...
Closes #39346
Change-Id: I997347d04e7a3c3cb9786f31cd6c24513307de92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125502
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-18 14:57:43 +00:00
043885676c
[CFE] Mark initializer as inferred and don't redo work
...
No reason to do the same work twice.
Change-Id: I8cea469f91dc7087b31bb80352723f0158dcaa6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125402
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-18 13:50:43 +00:00
06e6554d2e
[CFE] getFormal via Identifier (name and offset) and not just String (name)
...
Change-Id: I78059e627edaf8876eee74f878b36cfce990b78f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125265
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-11-18 13:48:53 +00:00
129565a71d
[kernel] Handle property invocation in MethodInvocation.getStaticType
...
Change-Id: I4a1ecdb9842f4f189be67e5f5d1b99ddb40d41da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125202
Reviewed-by: Jens Johansen <jensj@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2019-11-18 10:15:08 +00:00
9e03a639ea
[cfe] Split inferMethodInvocation into invocation variants
...
Change-Id: I4ca0cb419652b4d822d8eb945a77b7243012ed1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125411
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2019-11-18 10:03:33 +00:00
Jens Johansen