dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

6018 Commits

Author SHA1 Message Date
Dmitry Stefantsov d8a211206a [cfe] Fix upper bound algorithm for optional positional parameters 
Closes #39930.

Bug: http://dartbug.com/39930
Change-Id: If102ccfbd7fe439c29e803cf9bb16f2dfa317892
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130366
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-01-07 09:16:12 +00:00
Johnni Winther 96a8282cd9 [cfe] Use structural equality for generic function types 
Change-Id: Iecff57779243e042c5e9cad96c96139da9d93380
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129719
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-01-07 07:52:32 +00:00
Jens Johansen 871cd09121 Make flutter-frontend test pass again 
Ignore a test that us web-only which the current setup doesn't
support.
Also fix a issue with how we answer configurable import questions ---
something that for now is untested (except that it makes a test work here).

Change-Id: Ic19858838c45f1d4ce718aae0f526b2f16f3e9d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130365
Commit-Queue: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-01-06 14:46:19 +00:00
Dmitry Stefantsov 89e95a550c [cfe] Choose parameter's bound of LHS in lower / upper bounds algorithms 
Change-Id: I2757e1a64928f0e8247c75a703b0ab28d7c59667
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130363
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2020-01-06 14:27:59 +00:00
Dmitry Stefantsov 9283a168dc [cfe] Add upper / lower bounds tests with generic functions 
Change-Id: I4ab715617dba52efeb96d9542ac6a33040f3465d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130362
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2020-01-06 11:41:09 +00:00
Johnni Winther 679705faf6 [cfe] Include nullability in implicit tearoff 
Change-Id: If350915c13840c06d9fb2191972edf52758de252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129287
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-01-03 15:19:29 +00:00
Johnni Winther fdf362e9bb [cfe] Replace isImplicitCall with ExpressionInvocation node 
Change-Id: I05ebe260b9f35cacf59390963da9d0c39ede2096
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129286
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-01-03 15:19:29 +00:00
Johnni Winther e3a20bf361 [analyzer,cfe,dart2js] Support annotated code generation 
Add support for generating annotations from actual data using
option -g

Change-Id: I88d9cdb62a38d579234b15097c9e9bb3d81ebe8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129708
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-01-03 13:57:39 +00:00
Johnni Winther 6128ffd579 [cfe] Handle type variables as mixin superclasses 
Closes #39774

Change-Id: Id6a247a73322f8ab06df56ea3e8c68d4e6813092
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129283
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-20 15:37:00 +00:00
Johnni Winther 21a7cec251 [cfe] Don't report "missing input" on unknown command line option 
Change-Id: I59da6c993c34e02fcb0ee6f09517cc8f9842578f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129281
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-12-20 15:37:00 +00:00
Johnni Winther 52090670eb [cfe] Add tests for late extension fields 
Change-Id: I2cd4fd1903ec97c513a803d687f2269bbde7c5ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129061
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-19 11:34:30 +00:00
Kallen Tu aa6709974d [cfe] Fix inference for variant parameters leaking UnknownTypes. 
Change-Id: I056535cbfc74554de408ce4f9d89c142c4c860cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128771
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-12-19 02:14:59 +00:00
Sigmund Cherem 884f7af3ce Whitelist _2 suites as opted out from NNBD 
Change-Id: I66cc12858b3166b7c635fc91693dddc7ba362fca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128779
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-18 18:11:31 +00:00
Dmitry Stefantsov a7a73e23b4 [cfe] Report an error if thrown expression isn't assignable to Object 
Closes #39659.

Bug: http://dartbug.com/39659
Change-Id: Ibf54cf25ed9593c33e3d6576bab345070bb44d6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128669
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-18 15:26:01 +00:00
Dmitry Stefantsov 01a8d76307 [cfe] Fix compiler crashes on for-in iterables with Null type 
Closes #39817.

Bug: http://dartbug.com/39817
Change-Id: Id60a3d35d73880c68e6a73adffd4c8c96e9b49fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128664
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-18 15:14:21 +00:00
Dmitry Stefantsov 578e22fd10 [cfe] Fix bug with assigning an object with .call to a Function 
Change-Id: I3066a2453737b1e88a778d660b57b93986164a2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128734
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-18 13:19:11 +00:00
Jens Johansen 464b254d58 [CFE] Test for FFI and incremental compilation 
This currently crashes the compiler.

Bug: #39840
Change-Id: I59d625158c8011846a3181eba8b4da2ce4b49cd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128731
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-12-18 10:26:51 +00:00
Johnni Winther a5f028ee06 [cfe] Add ForInVariable to encapsulate handling of for-in without variable declaration 
Change-Id: I5e6ce4bfca26e8afd7fbf4dd60a3ffc3afafdf26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128586
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-18 10:02:51 +00:00
Dmitry Stefantsov 2af5aec84e [cfe] Infer type of x! as Never if x's type is Null 
Closes #39822.

Bug: http://dartbug.com/39822
Change-Id: I9600efcd4e69e331de5d9fa8f2b676c402df6502
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128661
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-12-18 09:01:30 +00:00
Dmitry Stefantsov f10fa3df28 [cfe] Split the lines that span over the 80-symbols boundary 
Change-Id: Id21b1ca238d080cbe5a108def7d66b5c955b823c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128680
Auto-Submit: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 16:32:06 +00:00
Johnni Winther 904a822432 [cfe+analyzer] Use TryStatement for try/catch and try/finally in CFE 
This includes an alignment of assigned variables info collection between
analyzer and cfe by always collecting assigned variables info for both
the try statement and the try block.

Change-Id: I789527adc24da025a85e73cdd98392efe7fc97bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128407
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-16 13:55:50 +00:00
Dmitry Stefantsov c85979a280 [cfe] Implement the NNBD variation of the assignability property 
Change-Id: I802e5668952f918919bd4fda4fd0102623a20ae7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128544
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-12-16 12:38:27 +00:00
Johnni Winther f521734ce7 [cfe] Handle setter import conflicts 
Fixes the underlying problem for the crash reported in
https://github.com/flutter/flutter/issues/46823

Change-Id: I392c7bae3679cae52b694f3bd08b0b700ee9c56f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128540
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-16 12:02:47 +00:00
Johnni Winther eda5188a0e [cfe] Implement flow analysis on if elements 
Change-Id: I5d8afac580c0bd038e3287bea6dd74cb51f3f2f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128541
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-16 11:48:07 +00:00
Johnni Winther 77d066fd7d [cfe] Report errors on nnbd features used in opt-out libraries 
Change-Id: I8131464fff9f09a90083581f10933430133cfaed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128406
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-16 09:02:17 +00:00
Sigmund Cherem 35bc105c45 Whitelist all packages in the .packages file as opt-out from nnbd. 
Change-Id: Ic52130d4853a32664ab0fe9db32be12e55d763db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128421
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-12-13 21:19:54 +00:00
Johnni Winther 818ec6db92 [cfe] Implement nnbd-top-merge 
+ and use nnbd-top-merge and legacy erasure in hierarchy computation

Change-Id: I4bf06ce8d3c68a9926865ebf84b24b4029828d73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128065
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-12-13 17:19:59 +00:00
Johnni Winther a577d0aea5 [cfe] Add weak mode testing 
Change-Id: I3670e77a205404c0b35ee551a18c6ebdc2ecab33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128069
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-13 09:20:08 +00:00
Johnni Winther 72eb475f6c [cfe] Refactor for-in loops to handle flow analysis 
Change-Id: Iddbf84e9d878fc828280c76cdaa22f3082b6b842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128067
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-12-12 13:53:59 +00:00
Dmitry Stefantsov 4df5b5458a [cfe] Implement NNBD-aware lower / upper bound algorithms 
Change-Id: I1def2843f41938e8aee39d12fc4e2807b0c5a1b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126725
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-12 11:00:21 +00:00
Jens Johansen e2d5aa352c [parser] Allow ?? after Type? 
Fixes #39697.

Change-Id: I65c762304881038b205f1221d6cfdd1125ba71e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127890
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-12-12 06:59:53 +00:00
Jens Johansen 2a886d257f [parser] Allow '?.' and '?.[' after '!' 
Fixes #39723

Change-Id: Ic98b7ddefcbbfefe33e6306b8fb4215419355f6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127887
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-12-12 06:59:33 +00:00
Johnni Winther d9fa37e85d [kernel] Use Never as static type for throw/rethrow 
Change-Id: Iba61a834827747e656a6dc14d73ee152f66864cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127882
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-11 08:37:59 +00:00
Nicholas Shahan 7974f3f899 [dartdevc] Reduce the number of SDK libraries in the platform 
We are temporarily building a smaller SDK platform to make progress building
applications against the forked sdk_nnbd sources. This is because some of the
libraries have not yet been ported and they don't compose well.

I needed to thread the status of the non-nullable experiment through the front
end entry point and into the target options, and native types.

Also includes some standardization of the flag name in DDC.

https://github.com/dart-lang/sdk/issues/39698

Change-Id: I4bdd503be694b28d7f95828d4af28d1d5fb3691f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127486
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-09 22:25:48 +00:00
Johnni Winther de11b7b373 [cfe] Implement legacy erasure 
Change-Id: I4f152264469e7cb6d23c7502e277004cd35e8527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127463
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-12-09 13:07:07 +00:00
Konstantin Shcheglov 52dc7690ef Issue 39667. Use flow analysis in IfElement. 
Bug: https://github.com/dart-lang/sdk/issues/39667
Change-Id: I4528869a8d39d1b27c0cdf21ab20173bdb0efbc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127482
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-12-07 03:32:14 +00:00
Sam Rawlins a455e099bb Ignore _printEvent as an unused element 
This is required for #37116

Change-Id: Ia061a423b2455f4e64d5a90f35cc5d7461fa57d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127343
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-06 16:02:15 +00:00
Erik Ernst 80a400297a [cfe] Add initial version of support for nonfunction-type-aliases 
Change-Id: I9ff3f0c18a31bd1e0d16ba8b6ccd0cc261250c11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127005
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-06 13:35:30 +00:00
Johnni Winther 97c2ca5ff1 [cfe] Use valid static types and file offsets in collections transformation 
Closes #39566

Change-Id: I589d0dd568b3ea939bb1238b1c61fca6867e737e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127320
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-06 10:58:20 +00:00
Jens Johansen 0dc6d59d52 [CFE] Fix crash caused by name clash of loadLibrary tearoff method 
Fixes #39682

Change-Id: I0e326df9390e05ede939f0019e94f8abe1fb7983
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127460
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-12-06 09:29:19 +00:00
Samir Jindel 1d4c45d2d0 Re-land "[vm/cfe] Elaborate for-in statements during async transform" 
This removes the component of the change which updates the kernel binary
format.

Change-Id: I86dbfe0ea61453bbea6eee200743961d0d0c3814
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127002
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Teagan Strickland <sstrickl@google.com>
 2019-12-05 14:06:08 +00:00
Dmitry Stefantsov 47a9ebea76 [cfe] Make API of as-instance-of and legacy LUB/GLB library-specific 
Change-Id: I1991c66e654ef537243d9f25f17070acbfa13af9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126380
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-12-05 13:32:28 +00:00
Johnni Winther e4e3f3fbc4 [cfe] Handle for-in on type variables in TypeEnvironment.forInElementType 
Closes #39565

Change-Id: I5b4c437879be0a97b306c5cc3579faac917d7e7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127162
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-05 12:26:58 +00:00
Johnni Winther 42a4442521 [cfe] Handle promotion of Null to Never 
Change-Id: If784cc315e0ea179e98df45a06d4a99179e4c197
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127140
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-04 12:41:38 +00:00
Johnni Winther 2ea8ff5ae7 [cfe] Don't continue shorting in explicit extension null aware access 
Change-Id: Icd4ca31d4ca3c1601f190c3661cfd61b3f96db3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126735
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-04 09:24:49 +00:00
Johnni Winther 441a17d1f9 [cfe] Fix flow analysis for type parameter promotion, initializers, switch continue and for loops 
Change-Id: Ia0bbbeb7f968961846a30a31471399bef9065842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127003
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-03 14:28:48 +00:00
Clement Skau 89e31069e8 Revert "[vm/cfe] Elaborate for-in statements during async transform" 
This reverts commit 63333deed6.

Reason for revert: Causes failures on Flutter HHH CI in the "flutter test hostonly_devicelab_tests" step due to kernel binary format version mismatch.

Original change's description:
> [vm/cfe] Elaborate for-in statements during async transform
> 
> This allows us TFA to analyze the iterator calls and we generate much tighter
> code in AOT.
> 
> However, due to the increased inlining opportunities, we end up emitting 0.5%
> more code. Inlining of the _GrowableList iterator specifically also includes the
> concurrent modification check and error handling.
> 
> Calls to get:iterator, moveNext and get:current account for 7.12% of all InstanceCall
> instructions in Flutter Gallery.
> 
> Fixes https://github.com/dart-lang/sdk/issues/39516
> Issue https://github.com/dart-lang/sdk/issues/39566
> Issue https://github.com/dart-lang/sdk/issues/39565
> 
> Change-Id: I8dcc08b7571137e869a16ceea8cc73539eb02a5a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126381
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,sjindel@google.com,johnniwinther@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I89b88c3d9f7c743fc340ee73a45c3f57059bcf30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126734
Reviewed-by: Clement Skau <cskau@google.com>
Reviewed-by: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2019-12-03 12:29:35 +00:00
Johnni Winther f7941eb850 [cfe] Handle break/continue in flow analysis 
Change-Id: Ic02e60237b8eda3c98c0715e3fcc668d21e1bf62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126728
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-12-03 11:25:51 +00:00
Konstantin Shcheglov 0dc58fdcea Format long lines in shared_type_tests. 
Change-Id: Iaa5c65c24d0d16bfa5493aa6f927c74340d9fa69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126907
Auto-Submit: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-12-03 10:58:40 +00:00
Johnni Winther 5013ce6e5d [cfe] Use correct types and errors in late lowering 
Change-Id: I6e7dcbd96e151a69fc67a6cd5e5af1620760b02a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126647
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-12-02 15:00:18 +00:00