Commit Graph

91 Commits

Author SHA1 Message Date
Johnni Winther 34fb48bb8a [kernel,front_end] Migrate first wave of pkg/kernel and pkg/front_end
Migrates libraries dependent only on already migrated libraries.

Change-Id: I0e85ee8dbc2afce031b92e0009e71c206a55af28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179502
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2021-01-18 15:40:21 +00:00
Devon Carew 8cba879f46 Add additional validations to the pkg/ package pubspecs.
TEST=these are additional validations that we run on the bots

Redux of https://dart-review.googlesource.com/c/sdk/+/161040

Change-Id: Ia32ced5d48fbfeafacfa9e51dc4774d2e9425091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174601
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2020-12-02 17:27:18 +00:00
Nate Bosch aaf13b5247 Update to the latest package:yaml
Expand the range allowed by the dep from `package:analyzer`.

Switch dependencies to `any` for the packages which are `publish_to:
none`. The actual constraints aren't useful in these packages since they
are always pinned exactly by DEPS and so we can't trust they are kept up
to date.

Change-Id: Ibd937e8646574d49105f4dd0de2529e7ab30862a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172380
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2020-11-16 22:16:50 +00:00
Johnni Winther c4622003a2 [kernel] Remove dynamic access from text_serializer
Change-Id: Ic1012992472f8798c384af8795db8b1f42f8ccb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171945
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2020-11-16 08:16:39 +00:00
Kevin Moore 063c3ede72 Update pkg dependencies on pkg:analyzer
Now `pub get` actually succeeds on `pkg:front_end`

Change-Id: Ifdab9d6741efba034ecd56f27fd83e288267e46c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168662
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
2020-10-26 19:30:06 +00:00
Jens Johansen e663257b72 [CFE] Use path-overrides in front_end/pubspec.yaml
a) front_end is not published anyway so it shouldn't hurt.
b) Having some specific version is potentially (and likely) wrong as
   it is only every compiled against the path version and thus likely
   also only compatible with the path version.
c) If one were to make a project with it's own path-override to point
   to front_end (and e.g. kernel) running pub get on that wouldn't work
   because one would thus have two kernel versions (the wrong version
   one in front_end/pubspec.yaml and the path one added in the other
   project.

Change-Id: Ia37dec7db7ccee677a38dd771f938c5089bbc522
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161103
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2020-08-31 10:52:17 +00:00
Devon Carew d26469f715 update the pubspec.yaml files to reflect actual package usage
Change-Id: I7a46c42dff3506cd5d09d3d793c072258e09a6e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159143
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-08-20 16:08:59 +00:00
Michael Thomsen 2451ff786f Mark front_end and kernel as private packages
Change-Id: I84e8933ece361cb4e058a1305b67208896ea85b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152006
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
2020-06-23 13:22:31 +00:00
Paul Berry 47293f3030 Prepare to publish analyzer 0.39.5
Change-Id: Ib5c8319fab68d52bdf06d72678647e9212597c8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-04-03 17:28:47 +00:00
Lasse R.H. Nielsen 3f28a3496c Change SDK to use package_config v1.9 (unreleased).
Change-Id: I405ac5e59d0b330c6fc6c63fab48d2d303734e59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136123
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2020-02-18 10:56:59 +00:00
Jens Johansen 81d4ac07d4 [CFE] Use package config v2
Change-Id: I32da9e8b2c1040db1521af4345f8e952c22bd30d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130864
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2020-02-12 10:07:25 +00:00
Jens Johansen 6aa7407d63 [CFE] Proof of concept of using vm service to find leaks
Use the VM service to find leaks in the incremental compiler via the
incremental compiler test suite.

Currently the following tests leak:

incremental_load_from_dill/no_outline_change_2
incremental_load_from_dill/no_outline_change_6
incremental_load_from_dill/no_outline_change_7
incremental_load_from_dill/no_outline_change_10
incremental_load_from_dill/no_outline_change_34

Change-Id: Ie05ad5994f518422c553dc52bd57908ebbf1b16b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132283
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2020-01-23 08:30:07 +00:00
Paul Berry e56612020c Prepare to publish analyzer 0.39.1.
Change-Id: I57132f7ba1e876ce94ae9acd95e702713d79de83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123700
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-10-31 15:44:23 +00:00
Paul Berry 499815842c Create a package to hold code shared between front_end and analyzer.
Previously such shared code was in the front_end package, but that
created problems because there is a lot of code in front_end that
isn't intended to be shared with the analyzer (including, notably, the
dependency on kernel).

This CL just moves over the flow_analysis logic to the new shared
package.  Follow-up CLs will move over other shared logic and tests.
The end goal is that the analyzer package will no longer have a
dependency on front_end.

Change-Id: I5642d6565204422d79808ca47648462db85e442a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123624
Reviewed-by: Jens Johansen <jensj@google.com>
2019-10-31 13:05:53 +00:00
Paul Berry 5d4cd6d589 Breaking changes for analyzer version 0.39.
Change-Id: Ifa9ca24487f93f3eb0ec95eeb64f5bbb5aa32714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113216
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-10-21 18:23:10 +00:00
Nate Bosch 2ffdc54d24 Handle exported extensions in dill library builder
- Add a modular test to demonstrate the bug.
- Handle `Extension` nodes in `finalizeExports`.

Change-Id: Ie16f0c97059d24a122150a607e26fba258d80cfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120926
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2019-10-09 18:48:54 +00:00
Paul Berry d93a6b596b Prepare to publish analyzer version 0.38.5
Change-Id: I314944fb68375644860477185c88ce93a8839341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-10-07 16:34:01 +00:00
Paul Berry 39a1baef6b Prepare to publish analyzer 0.38.4
Change-Id: I251e7bde7b3423cbfb2ee6fe1150088bf44747dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118647
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-09-25 19:00:01 +00:00
Jacob MacDonald bd1ca04b79 add meta dependency to kernel and front_end
Towards https://github.com/dart-lang/sdk/issues/38482 and  https://github.com/dart-lang/sdk/issues/38483

Change-Id: I4a8431d7864fbfa682a3fa80696e2f8a998f0f38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118320
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2019-09-25 15:51:27 +00:00
Paul Berry dcd5cd13fb Prepare to publish analyzer version 0.38.3.
Change-Id: I338f5a5ae9f3384ecb1d3e9ae5d3231e0288552d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-09-19 20:42:17 +00:00
Paul Berry e5b139e6d9 Prepare to publish analyzer 0.38.2
Change-Id: I1f86fdc6e49b73bb171795fcf2a13f3cc9712329
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-08-28 18:18:01 +00:00
Jens Johansen 74e09abc6e [CFE] Remove/move file that wasn't needed by frontend; cleanup pubspec.yaml a bit
Change-Id: I204b844e7f1cb892a529bca3a13017ed836275f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114074
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2019-08-23 07:42:03 +00:00
Paul Berry 1d9b6427ef Prepare to publish analyzer version 0.38.1.
Change-Id: I5c900310be1c66b3e8dfbd363aef3089bb07fbbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113922
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-08-20 22:17:03 +00:00
Jens Johansen 10e63b7840 [CFE] Get fragment from default package - use language version if any
Language versioning specifies that an empty-name-entry in .packages
specifies a sort of "default package" that a non-package file should
pretend to be a part of "for any purpose where that matters,
including choosing the default language level."

Change-Id: I16f4b2f5e4d3ca1e82d2189321e2be5c43e3b260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112089
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-08-20 09:06:32 +00:00
Paul Berry fecc4c8f2d Breaking changes for analyzer version 0.38.
Change-Id: I93fbcb9e86c6c809c4610d2d90dc8bc8b69c45c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108162
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-08-15 19:42:31 +00:00
Paul Berry bb12829571 Prepare to publish analyzer version 0.37.1.
Change-Id: I92f8177c6ca63d510d985adeb9cc338191ffc06b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-08-13 17:20:44 +00:00
Paul Berry 7fa49a285a Update the minimum SDK constraint to 2.2.2 for kernel and front_end packages.
This allows us to use ui-as-code and set literal features in these
packages.

This should be safe because (a) when these packages are used within
the SDK itself, they are used with the most recent SDK (whose version
is greater than 2.2.2), and (b) the only significant dependency on
these packages in pub is from the analyzer, which already has a
minimum SDK version of 2.2.2.

Change-Id: I4f7d4c9506904ee3016db95297b45e5bcf7989b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110060
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-07-23 12:55:11 +00:00
Paul Berry 5d77657e7a Prepare to publish analyzer version 0.37.0.
Change-Id: Ie3fda7b0783d8feb7f13bcb6d0d10ba0fb5e3587
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107835
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-07-03 18:20:41 +00:00
Paul Berry e47ac38227 Prepare to publish analyzer 0.36.4
Change-Id: I90da29f75e94666b199df2802570e9496c404cfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107141
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-06-25 13:15:27 +00:00
Paul Berry 3f90f04a74 Prepare to publish analyzer 0.36.3
Change-Id: Ibe4fb287ff6774fa71fd9d5e5a67b0f3f8b8c530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-05-03 16:57:54 +00:00
Paul Berry d6a09ff02f Prepare to publish analyzer version 0.36.2
Change-Id: I4ae73e8a55cf8c0d013152eb15bea74f2c1f69e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-04-24 02:32:36 +00:00
Paul Berry 2d6313c9e4 Prepare to publish analyzer version 0.36.1
Change-Id: I84e132ff2b2635cc5703a58c88f5ab1767e4970e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99965
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-04-22 18:05:19 +00:00
Nate Bosch 8fee2596e5 Remove some unused front_end dependencies
There are no imports to these packages.

Change-Id: I51c194cd48b7fb594070616524f817267ae11d56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2019-04-02 16:55:29 +00:00
Paul Berry 61e71e785f Prepare to publish analyzer version 0.36.0
Change-Id: I858ebe2a1717a467ef1901d5e643fe3e416036f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97544
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-03-21 19:08:11 +00:00
Paul Berry 44753660ec Prepare to publish analyzer 0.35.4
Change-Id: I265b0d0bf970f3962a66689895e7dd640fea91a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97006
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-03-15 22:33:45 +00:00
Paul Berry 545ebe1741 Prepare to publish analyzer 0.35.3
This is needed so that we can publish a version of analyzer_plugin
that depends on it; also so that dartfmt work on "UI as code" features
can proceed.

Change-Id: I7647fd69fec28b9e788f89e915c14779815fcc02
Reviewed-on: https://dart-review.googlesource.com/c/94803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-02-28 20:54:19 +00:00
Paul Berry 9b55682a5c Prepare to publish analyzer 0.35.2
Change-Id: I532d805f26e453aec0a38f4ce5f9213f6acd0b95
Reviewed-on: https://dart-review.googlesource.com/c/94020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-02-22 22:20:42 +00:00
Paul Berry 9d280198a4 Prepare to publish analyzer version 0.35.1.
Change-Id: Ib3d31fa14ec2144a04d95f33bac385f38a47d6a7
Reviewed-on: https://dart-review.googlesource.com/c/92820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-02-12 19:39:21 +00:00
Paul Berry 6f5556c88a Prepare to publish analyzer version 0.35.0.
Change-Id: Icd0cd786a2b7746046367ca4315748d33381c590
Reviewed-on: https://dart-review.googlesource.com/c/91580
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-01-29 20:27:37 +00:00
Paul Berry 7984dc4fcc Prepare to publish analyzer version 0.34.2.
Change-Id: I70f9036cd18fc5aa4d30b0005dfe577d0bb11fb7
Reviewed-on: https://dart-review.googlesource.com/c/89821
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-01-16 16:44:43 +00:00
Paul Berry 6ece9f910c Prepare to publish analyzer version 0.34.1.
Change-Id: I81a9053e4ab3dacd1dcbb8e72d2b80f19752b758
Reviewed-on: https://dart-review.googlesource.com/c/87609
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-18 23:02:44 +00:00
Paul Berry 1d14b8a94e Prepare to publish analyzer 0.34.0.
Change-Id: I66fe8810655b6ae2089e70d50af327909fecd5e1
Reviewed-on: https://dart-review.googlesource.com/c/85418
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
2018-11-29 22:13:08 +00:00
Paul Berry b72ca19f33 Merge commit 'c9aaa7a654b1cac1307c854ba38f4dc995c86f09' into analyzer 2018-11-29 09:43:36 -08:00
Paul Berry 03b7ade6b7 Relax front_end's pubspec SDK requirement
This is necessary in order for the latest version of the front_end to
be used with Flutter, since Flutter is currently pinned to version
2.1.0-dev.9.4.flutter-f9ebf21297.

Change-Id: Ic556ca900c2e839d9e5c36d199bf30779a323623
Reviewed-on: https://dart-review.googlesource.com/c/85544
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-11-28 22:02:22 +00:00
Brian Wilkerson e4a5ab06e4 Update the SDK version for the front_end package
Change-Id: I790195f429482ebf43cccab01d67e38096f5cef7
Reviewed-on: https://dart-review.googlesource.com/c/84641
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-11-19 19:45:47 +00:00
Brian Wilkerson 716c9dcde2 Add a hint when Future is imported from core in code targeted to run with an SDK prior to 2.1
Change-Id: I925412b9c7c3023836a0a2a7d3d00847adf0b0c7
Reviewed-on: https://dart-review.googlesource.com/c/84547
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-11-16 19:07:27 +00:00
Paul Berry 85d225e3f6 Move parameter context into NodeLintRule and make it required.
This is a breaking change, so the analyzer major version number is
bumped.  However, we don't need to publish a new analyzer yet so we
use a "-dev" version number.

This breaking change requires upgrading to the latest version of the
linter package.

Change-Id: I90637068acee646c41613e7b7f7d66496bb260e9
Reviewed-on: https://dart-review.googlesource.com/c/82946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-11-05 23:32:47 +00:00
Kevin Moore 4d5c5ecdbf Update synced version of pkg:test
Also updated the package references in a number of pubspecs to
more closely align with the package versions that are in the SDK

Change-Id: I061951587befa4211ac7455cf1179911eb07efc0
Reviewed-on: https://dart-review.googlesource.com/c/79920
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2018-10-16 16:12:38 +00:00
Peter von der Ahé e4840ec239 Remove byte_store and performance_logger stubs
Change-Id: Ia64c6c42a8737a23d7f708bd6905088f9444951e
Reviewed-on: https://dart-review.googlesource.com/c/78200
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
2018-10-08 12:03:38 +00:00
Peter von der Ahé 45cb0815bc Move PerformanceLogger to package:analyzer
Change-Id: I89a60ae9ab639c7907a92976e1eb8007d0f4ee9b
Reviewed-on: https://dart-review.googlesource.com/c/77760
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
2018-10-04 08:44:43 +00:00