dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4770 Commits

Author SHA1 Message Date
Konstantin Shcheglov 5ea30b4e3d Rename performace_logger.dart to performance_logger.dart 
R=paulberry@google.com, sigmund@google.com

Bug:
Change-Id: Ib7b6d122dff3ddabde3db2270daa777a269e04ed
Reviewed-on: https://dart-review.googlesource.com/18512
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 20:24:00 +00:00
Konstantin Shcheglov 611475aaaa Separate KernelDriver.getKernel() and getKernelSequence(). 
The reason to have both is that IKG needs kernels for all libraries,
potentially not even deserialized from bytes, if we eventually get this
optimization.

OTOH, Analyzer always needs just one library, with enough outlines
to make sense of the dependencies. For now, getKernel() is implemented
using getKernelSequence(), this will change with switching to
outline based compilation.

R=paulberry@google.com, sigmund@google.com

Bug:
Change-Id: Iba02bc3a4cdb67a896c4faa2f809c7cb8069aa9e
Reviewed-on: https://dart-review.googlesource.com/18509
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 20:00:01 +00:00
Sigmund Cherem 24e4d3bb39 Define a location of the synthetic __loadLibrary_foo method 
Change-Id: I8fd950cf7a6e6aed79240daed085f2a02e16666e
Reviewed-on: https://dart-review.googlesource.com/18430
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-11-03 18:59:40 +00:00
Konstantin Shcheglov cd2f4a1e44 Update references to Class and TypeParameter, updates for tests. 
R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com

Bug:
Change-Id: I8a922df8c21fe2ff54c60da989f87524b0cff56c
Reviewed-on: https://dart-review.googlesource.com/17340
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 18:55:11 +00:00
Brian Wilkerson cfa3a809f0 Rework Parser.parseFunctionBody 
Change-Id: Ie19d902ad9d456d3c05ecbf04d9a0f1ebecf7d18
Reviewed-on: https://dart-review.googlesource.com/18620
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-03 17:47:01 +00:00
Konstantin Shcheglov b2b813a37a Update ProtectedFileByteStore in IKG on acceptLastDelta(). 
So, we don't leak result keys to IKG clients.

Bug:
Change-Id: Ib3002aad690bf98884816a3978f759acd88b12ec
Reviewed-on: https://dart-review.googlesource.com/17342
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2017-11-03 17:31:23 +00:00
Dan Rubel 15a0abf956 Fix OutlineBuilder native class and AnalyzerDietListener tests 
Update the OutlineBuilder and AstBuilder to fix native handling,
and in the process, fix several AnalyzerDietListener tests.

Fix https://github.com/dart-lang/sdk/issues/30836

Change-Id: I7e3b6c4c7d241f1325a5fce1e117e277c6166e49
Reviewed-on: https://dart-review.googlesource.com/18500
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-03 17:16:51 +00:00
Brian Wilkerson a44283d34f Rewrite Parser.parseEnum 
Change-Id: Iacf6fdc75020ba50584d4763ae6eded0394a7f39
Reviewed-on: https://dart-review.googlesource.com/18600
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-03 15:51:43 +00:00
Brian Wilkerson f403dfe899 Convert Parser.parseMember 
Change-Id: I4ae0c7d277f19a5089d793b1c3f924a91b3c889a
Reviewed-on: https://dart-review.googlesource.com/18580
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-03 15:51:42 +00:00
Brian Wilkerson 5a00e53abb Convert several more parser methods 
Change-Id: I34ff24d2dec93475ddfb10f1032945d09ddc4f9d
Reviewed-on: https://dart-review.googlesource.com/18462
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-03 13:25:44 +00:00
Brian Wilkerson 3cafc5db3f Convert several parser methods 
Change-Id: I1d5ae303dfb2b4e23b5b9274ccc181de2a48cc71
Reviewed-on: https://dart-review.googlesource.com/18460
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-03 13:19:41 +00:00
Aske Simon Christensen e3c11c2703 Retain erroneous import, export and part (of) directives 
If the URI of a directive is invalid, use a special URI with a
scheme marking it as malformed. In the loader, treat a file with
an invalid URI as empty.

Order all dependencies (imports and exports) by source position to
allow the DietListener to match them up properly with metadata.

For the same reason, add imports and exports within parts to
dependencies even though they are not permitted here.

Closes https://github.com/dart-lang/sdk/issues/30997
Closes https://github.com/dart-lang/sdk/issues/31004

Change-Id: Ic7efd0da058c246531c165508b7474475b4bdad2
Reviewed-on: https://dart-review.googlesource.com/17901
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 12:55:19 +00:00
Peter von der Ahé aaa76d7e45 Read patch files directly from Fasta. 
Change-Id: I91ff7979d1976db97069ae5463f275f28bac3905
Bug:
Reviewed-on: https://dart-review.googlesource.com/8640
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2017-11-03 11:11:49 +00:00
Brian Wilkerson 381ceca587 Local changes to prepare for more conversions 
Change-Id: I1d65460bc556ab51b9061659927a8eac7288dd99
Reviewed-on: https://dart-review.googlesource.com/18440
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-02 23:39:40 +00:00
Brian Wilkerson 8567741525 Address review comments 
Change-Id: If7d22e6c769e1d94e1362b9f45e6a7dccaded657
Reviewed-on: https://dart-review.googlesource.com/18300
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-02 18:11:48 +00:00
Samir Jindel 9029ee09c5 Revert "[kernel] Fix NoSuchMethod errors for generic functions." 
This reverts commit 52e1466588.

Bug:
Change-Id: Ic1b37a5df2f50ede4f6873b6d2a701663673bcbb
Reviewed-on: https://dart-review.googlesource.com/18261
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-02 16:52:32 +00:00
Brian Wilkerson 62ee6d42f1 More parser conversion 
Change-Id: Idfd6afe6cce71ff852b746e52aa5810692c43dbd
Reviewed-on: https://dart-review.googlesource.com/18240
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-02 16:33:39 +00:00
Paul Berry 00b292511d Avoid a crash when an invalid assignment is detected during top level inference. 
Change-Id: I382a4fdcd25bca529ca424ccdb7fd313d6a95066
Reviewed-on: https://dart-review.googlesource.com/18143
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-02 15:22:55 +00:00
Samir Jindel 52e1466588 [kernel] Fix NoSuchMethod errors for generic functions. 
Bug:
Change-Id: I8ad90e34a7b1f77b29f1d711f158bcb69f5928f4
Reviewed-on: https://dart-review.googlesource.com/17941
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2017-11-02 15:16:08 +00:00
Brian Wilkerson 27fd7cad98 Clean-up parseUnit 
Change-Id: Icbcef86609c5b84a129b6c68a1311cb4447c90a9
Reviewed-on: https://dart-review.googlesource.com/18100
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-02 13:33:08 +00:00
Brian Wilkerson 38a170cca9 Make parseTypeVariable accept the last committed 
Change-Id: I64e29df367fca45709beb450b5aff1f9073f0b78
Reviewed-on: https://dart-review.googlesource.com/18080
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-02 13:19:20 +00:00
Brian Wilkerson 6661da9b86 Make parseMapLiteralEntry accept the last consumed 
Change-Id: I0d4c393ece13bbe8f1edad032053df90bd4fcf5d
Reviewed-on: https://dart-review.googlesource.com/18040
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-01 21:12:23 +00:00
Brian Wilkerson 0d94dfaf5c Make parseLiteralStringOrRecoverExpression accept the last consumed 
Change-Id: Ia8b8ad0d9e8a86c7a782185ef00dd667bc2e457a
Reviewed-on: https://dart-review.googlesource.com/18002
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-01 21:07:18 +00:00
Brian Wilkerson 1e6490dbef Return last committed from parseTopLevelMember, parseTopLevelKeywordDeclaration, and parseTopLevelDeclarationImpl 
Change-Id: If9fe159f4926c250cf06937cea9f1f4a78e21269
Reviewed-on: https://dart-review.googlesource.com/18003
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-01 20:31:36 +00:00
Brian Wilkerson 895f771726 Make parseTopLevelMethod return the last consumed 
Change-Id: I65b9a2a6842ed1ec8ce986cb83fa108ce38be6ba
Reviewed-on: https://dart-review.googlesource.com/18001
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-01 19:02:47 +00:00
Paul Berry d2e3c54941 Allow arguments of type DartType in error message templates. 
Change-Id: Ief2c253dc287cb416f35d03d796383725c2982c3
Reviewed-on: https://dart-review.googlesource.com/17981
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-01 18:53:15 +00:00
Brian Wilkerson f95e1475fc Remove the unused Listener.beginDottedName 
Change-Id: I1c5752a9610f21dad62db6655972b4006ce632e9
Reviewed-on: https://dart-review.googlesource.com/17862
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-11-01 18:35:45 +00:00
Brian Wilkerson 87a096e992 Remove the unused Listener.beginIdentifierList 
Change-Id: I3644aaff3fa7a8a97b9e9bcc83f549f628a1fb71
Reviewed-on: https://dart-review.googlesource.com/17861
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-01 17:21:05 +00:00
Brian Wilkerson dd18ef841b Parser conversion, part 3 
Change-Id: Ibe48da9bfa89887fb04a4b958b913fe7c0087cf1
Reviewed-on: https://dart-review.googlesource.com/17600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-11-01 16:32:45 +00:00
Paul Berry 08b0120186 Begin reporting "invalid assignment" errors. 
Change-Id: I1e47acd662032c63e56cb2349b2f349e9825b990
Reviewed-on: https://dart-review.googlesource.com/17680
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-01 16:28:35 +00:00
danrubel 9319716c4f Ensure progress in parseUnit 
This adds a check in the top level parseUnit loop to ensure
that parsing has not stalled causing an infinite loop.

Fix https://github.com/dart-lang/sdk/issues/31151

Change-Id: Ief7c12d60bd7e09111f9b1bbefa4a29b9fcf9175
Reviewed-on: https://dart-review.googlesource.com/17460
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-01 14:22:40 +00:00
Peter von der Ahé b7060891c1 Mention that libraries.json is generated. 
Change-Id: I48fcc8443a0980c435e87642cf6a7aede07e68f0
Reviewed-on: https://dart-review.googlesource.com/17161
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-01 12:55:42 +00:00
Peter von der Ahé 16e4875629 Update supertype builder when breaking cyclic hierarchy 
Change-Id: Ibae0a3d1759d79bf0d2e350347e390936fa314ff
Reviewed-on: https://dart-review.googlesource.com/16953
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-11-01 10:08:40 +00:00
Jens Johansen c8e51ef922 [kernel] Add offset to this[i] and super[i] 
Bug:
Change-Id: Ic65b69c4977be834c7b69638d6c030727c7210e5
Reviewed-on: https://dart-review.googlesource.com/17441
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-11-01 09:57:00 +00:00
Paul Berry f382f3980c Run kernel type checker during front end strong mode unit tests. 
This should help make sure that the front end is inserting all of the
necessary implicit downcasts.

The type checker is run after comparing to golden files, and before
running the test in the VM.  So if a test case fails to match its
golden file, the test's status will be "Fail" regardless of whether it
type checks.  If the test case matches its golden file but fails to
type chek, the test's status will be "TypeCheckError".  Rationale: the
type checker is still under development; if it has bugs leading to
false failures, we don't want that to get in the way of comparing
against golden files.

Change-Id: I6764aa5c7f2aab92a10edfa41afcdb056946530b
Reviewed-on: https://dart-review.googlesource.com/17522
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-10-31 21:25:45 +00:00
Dan Rubel 2b681b2149 Disable scanning of &&= and ||= assignment operators 
Fix https://github.com/dart-lang/sdk/issues/30340

Change-Id: Id27f37af9805ca09deaa3c6252817e3d9a926216
Reviewed-on: https://dart-review.googlesource.com/17361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-31 18:51:24 +00:00
Konstantin Shcheglov 9b8e8c2344 Add memory cache directly into ProtectedFileByteStore. 
So, it can be used standalone, without wrapping into
MemoryCachingByteStore, and IKG can check for it to protect keys.

Bug:
Change-Id: I50635c773b73ad7e57d0dfe1fd9e3c4574f1a1aa
Reviewed-on: https://dart-review.googlesource.com/17560
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-31 18:10:05 +00:00
Peter von der Ahé 8ac1307f60 Prepare buildBuilder for patching 
Change-Id: I900f7ce8e0e80fff703ca23aeb9f08b154f839ab
Reviewed-on: https://dart-review.googlesource.com/16949
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2017-10-31 17:32:25 +00:00
Brian Wilkerson b6ef64ffbd Parser conversion, part 2 
Change-Id: I7fb782d5f9ac9a3ac024da953f1e72faa6e557b3
Reviewed-on: https://dart-review.googlesource.com/17280
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-31 17:05:35 +00:00
Paul Berry 8620e6b24a Insert implicit downcasts for ??= assignments. 
Change-Id: I272eeea96a19ad5c781113211ee466f844ffbe4b
Reviewed-on: https://dart-review.googlesource.com/17240
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-10-31 15:58:55 +00:00
Brian Wilkerson 0f25913463 Remove unused error code 
Change-Id: I178aa3f70108eda870aba2f75a93e2a833a94915
Reviewed-on: https://dart-review.googlesource.com/17480
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-31 15:33:26 +00:00
Peter von der Ahé 2a9d762b4b Remove unneeded section on creating platform.dill 
Change-Id: I5f7a781d6ade52f1a9a4cf77ec333acc5e4f64d6
Reviewed-on: https://dart-review.googlesource.com/17180
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-10-31 15:06:05 +00:00
Peter von der Ahé 674acc9cce Cache Uri.base 
Change-Id: I8c3da7e9fcfa3a05aaa52c8b821bc52a9ec8440c
Reviewed-on: https://dart-review.googlesource.com/17442
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-10-31 13:38:55 +00:00
Leaf Petersen 4270b99d75 Fix dynamic as bottom uses in front end and dart2js. 
Re-enable the dynamic as bottom hint in analysis_options.yaml and fix
the code to be hint clean again.

Fixes #30589
Fixes #30590

Bug:
Change-Id: Idb7910b3ab1c6d931a3ead3eed885d8bd172e621
Reviewed-on: https://dart-review.googlesource.com/17062
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-10-30 19:54:26 +00:00
Peter von der Ahé 8071fa9053 Prepare external handling for patches. 
Change-Id: Ib4299fcb87657d5b5b001404a60c4b701a366f3a
Reviewed-on: https://dart-review.googlesource.com/16543
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-10-30 18:46:25 +00:00
Peter von der Ahé b6eb82a993 Various checks to ensure correct parent 
Change-Id: I74f66380f30c3344bb0865e14eb8742d70144ddf
Reviewed-on: https://dart-review.googlesource.com/16760
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-10-30 17:15:35 +00:00
Brian Wilkerson 61faf35b32 First set of Parser method conversions 
Change-Id: If911c37f2324e45e5118de22e5fd636638a27d6a
Reviewed-on: https://dart-review.googlesource.com/17063
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-30 16:05:15 +00:00
Peter von der Ahé fa225e4a19 Prepare for patching: origin and readPatchFiles. 
Change-Id: Id81e05d5c71d6c55fb86e230b054271b27c48023
Reviewed-on: https://dart-review.googlesource.com/16523
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-10-30 15:01:34 +00:00
Peter von der Ahé 5c9ec5222b Don't process libraries from a different loader. 
Change-Id: Id4b00d4510adcaf43efc5cb661d95f98f8c5012c
Reviewed-on: https://dart-review.googlesource.com/16481
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-10-30 14:15:55 +00:00
Dan Rubel a2c5217e8d Update several fasta/analyzer covariant and type errors 
* report "missing const, final, var, or type" error in several situations
* fix several top level covariant errors
* report final and covariant error

Change-Id: Iffe313c1b3cd2413be5f7763cb726436722e6a74
Reviewed-on: https://dart-review.googlesource.com/17140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-30 13:28:46 +00:00