dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4770 Commits

Author SHA1 Message Date
Jens Johansen a2ecf3954d [fasta] Add end offset to classes 
The kernel file format includes the class end offset, but it doesn't
appear to  be set by fasta.
This CL sets it for normal classes.

Bug:
Change-Id: I3ad555b581f0acae242177a222139e9c93aa32c8
Reviewed-on: https://dart-review.googlesource.com/22482
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2017-11-22 08:26:37 +00:00
Paul Berry d22b6950c1 Insert implicit downcasts for the operands of logical expressions. 
Change-Id: I25a2ca31d09d3577d1d056ca156146472c999c97
Reviewed-on: https://dart-review.googlesource.com/22900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-22 04:49:28 +00:00
Paul Berry ffdae2fd4d Insert implicit downcast checks for the expressions in a map literal. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I40b4b45d5ea32dc34aee68bfe39912141e4d7d35
Reviewed-on: https://dart-review.googlesource.com/22806
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-22 01:18:38 +00:00
Paul Berry 2d00ba15b3 Insert implicit downcast checks for the expressions in a list literal. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I1a4a2eed0f7b8ebb5cab0a993d7cf26e925b9425
Reviewed-on: https://dart-review.googlesource.com/22802
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 00:03:56 +00:00
Dan Rubel bac8cf868c Add fasta parser argument list recovery 
Change-Id: Ic45e95a130eb01f6bd8d390607e2b110bc8f9d99
Reviewed-on: https://dart-review.googlesource.com/22760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-21 22:05:17 +00:00
Dan Rubel 4e5118ba0a Add fasta parser formal parameter recovery 
Change-Id: I1f7772634b583ba798ea933a7876f8a520b9f414
Reviewed-on: https://dart-review.googlesource.com/22680
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-21 21:26:26 +00:00
Brian Wilkerson c8fc4e7659 Make debugging support members private to avoid possible collisions with subclasses 
Change-Id: I66ead4f15775d3acae1ab8ff641cd2e4f9621326
Reviewed-on: https://dart-review.googlesource.com/22640
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-21 20:11:33 +00:00
Paul Berry 00bf0d3136 Insert implicit downcast checks for the argument to a combiner in a compound assignment. 
Change-Id: I4827013dc060f530e553b95932db8cbacebc2bfc
Reviewed-on: https://dart-review.googlesource.com/22603
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-21 20:03:31 +00:00
Brian Wilkerson 83d98f98ac Address comments from previous CLs 
Change-Id: I89081dcdab88ee396ef316104e18b933f95aa98a
Reviewed-on: https://dart-review.googlesource.com/22580
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-21 17:30:39 +00:00
Brian Wilkerson 0bc552c533 Improve type inference debugging output 
Change-Id: I0ca50c95e007d8d7f525ed2ef719c5535918e14b
Reviewed-on: https://dart-review.googlesource.com/22361
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-21 16:11:40 +00:00
Dan Rubel cc7833f786 Add more top level recovery 
Change-Id: I870afcf405288e9dad14553054da06bbd93e1205
Reviewed-on: https://dart-review.googlesource.com/22302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-21 14:29:49 +00:00
Peter von der Ahé a689397a36 Revert "Implement support for generic comment syntax in Fasta." 
This reverts commit f1959d6cd4.

Reason for revert: insufficient approval.

Original change's description:
> Implement support for generic comment syntax in Fasta.
> 
> Change-Id: I4c15a4adf2dbb50efd799b801dcb75a538bbe7d6
> Reviewed-on: https://dart-review.googlesource.com/21223
> Commit-Queue: Paul Berry <paulberry@google.com>
> Reviewed-by: Dan Rubel <danrubel@google.com>

TBR=paulberry@google.com,danrubel@google.com,sigmund@google.com

Change-Id: I047e4e87913002c6bd77e455599189349c123146
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/22460
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-11-21 10:08:39 +00:00
Paul Berry 8cdd9d323c Insert implicit downcast checks for invocation arguments. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I1fa7490f6143bd6ceca80f831e0196b16c497966
Reviewed-on: https://dart-review.googlesource.com/20907
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 00:17:37 +00:00
Paul Berry a595dc2af5 Move isTopLevel check inside checkAssignability. 
We never need to add assignability checks when doing top level
inference; putting the check inside checkAssignability avoids the need
to remember to put it at every call site.

In order to keep type inference consistent between top level and local
type inference, I've modified the handling of assignments so that the
computations performed by checkAssignability do not influence the
inferred types.  For example, when performing type inference on `a =
b`, we used to consider the resulting expression to have the type of
`a` if a downcast was required, otherwise the type of `b`.  Now we
always consider the type of the assignment to be the type of `b`.
This is consistent with the informal spec of type inference.  This
change introduces some mal-typed kernel nodes in error recovery
situations, which I will fix in a future CL--see issue #31417.

Change-Id: I02e8dff54e2184e6f059d1339e51edf42c4cd058
Reviewed-on: https://dart-review.googlesource.com/22260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-20 23:18:11 +00:00
Dan Rubel fc8a09892e Add fasta parser top level operator recovery 
Change-Id: I015de2ebf9315d7e114b5f886f7f1efcf2e5b74a
Reviewed-on: https://dart-review.googlesource.com/22203
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-20 23:07:32 +00:00
danrubel fbf16b7c70 Address comments 
https://dart-review.googlesource.com/c/sdk/+/21100/2/pkg/front_end/lib/src/fasta/parser/parser.dart#4117
Change-Id: Ib4b472ba9c6d083356b5f9c78aef22aa7e5ca30a
Reviewed-on: https://dart-review.googlesource.com/22240
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-20 23:00:27 +00:00
Brian Wilkerson a60299bc90 Convert several methods to accept the last consumed token 
Change-Id: Ife53e5ec7bd15adb399b39e1e1431b16f169f3a1
Reviewed-on: https://dart-review.googlesource.com/22220
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-20 22:43:08 +00:00
Konstantin Shcheglov e67cd0daab The very first CL for end-to-end integration of FrontEnd resolution into Analysis Server. 
At this point KernelDriver is used only by Analyzer, so I don't include
anyone from the FrontEnd team. We will merge to get the same performance
benefits of the latest IKG approach, but later.

Only just enought integration is done - we can store and apply
types in the local variable declaration.

Everything is in disarray, I will follow up with improvements.


R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ie3434e26233b84fb019c50a7cc834a08d0dadbed
Reviewed-on: https://dart-review.googlesource.com/22202
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-20 22:42:09 +00:00
Sigmund Cherem 32c306bca6 Add whitelist of error codes for fasta_perf and incremental_perf 
Closes #31405

Change-Id: I272830b953590300b27a3b7ac41761936f35f454
Reviewed-on: https://dart-review.googlesource.com/22200
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-20 22:08:47 +00:00
Paul Berry f1959d6cd4 Implement support for generic comment syntax in Fasta. 
Change-Id: I4c15a4adf2dbb50efd799b801dcb75a538bbe7d6
Reviewed-on: https://dart-review.googlesource.com/21223
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-11-20 22:01:27 +00:00
Konstantin Shcheglov 64d9c683b0 Create DillTarget once and keep for body changes. 
This brings IKG recompilation time from 20-30 ms range to 5-10 ms range,
i.e. 3-4 times faster.

Of course performance of the system in general starts depending now
on how how many libraries we need to send to VM, and how fast the client
of IKG can serialize the returned libraries.

1. Leaf library.
   Compilation: 10 ms
   Returned libraries: 8
   Serialization time: 1 ms.

2. A deep library.
   Compilation: 10 ms
   Returned libraries: 222
   Serialization time: 60 ms.


R=paulberry@google.com, sigmund@google.com

Bug:
Change-Id: I5eab99c0bd7916d605696696d5e570c5fa6f1978
Reviewed-on: https://dart-review.googlesource.com/21900
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-20 21:03:30 +00:00
Brian Wilkerson 56ac62bdcc Convert Parser.parsePrimary 
Change-Id: I84bf93b89487254f887f4d8390aff45f93b64cba
Reviewed-on: https://dart-review.googlesource.com/22180
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-20 20:27:07 +00:00
Brian Wilkerson cdcfa447a6 Convert six methods to return the last consumed token 
Change-Id: I7bb32215173e4a7a191a930c8f869e4fa3096017
Reviewed-on: https://dart-review.googlesource.com/22101
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-20 17:52:27 +00:00
Paul Berry a2109ee71c Insert implicit downcast checks for conditional expressions. 
Change-Id: If5a2add32129800f14e6da03593ce6cafc173ba5
Reviewed-on: https://dart-review.googlesource.com/22100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-20 15:50:57 +00:00
Dan Rubel ee5a1fb187 Address comments 
This addresses comments from several CLs:
* https://dart-review.googlesource.com/c/sdk/+/21461/4/pkg/front_end/lib/src/fasta/parser/parser.dart#1546
* https://dart-review.googlesource.com/c/sdk/+/21461/4/pkg/front_end/lib/src/fasta/parser/parser.dart#1590
* https://dart-review.googlesource.com/c/sdk/+/21463/3/pkg/front_end/lib/src/fasta/parser/parser.dart#1589
* https://dart-review.googlesource.com/c/sdk/+/21523/2/pkg/front_end/lib/src/fasta/parser/parser.dart#1096

Change-Id: I2fca69458b912ae5dcfb38ce86c1064f049d9bb2
Reviewed-on: https://dart-review.googlesource.com/22060
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-20 14:39:57 +00:00
Brian Wilkerson 9fe83f779e Convert Parser.parseFunctionBody and two related methods 
Change-Id: I3c1e8a83816f180c116a7fcd99b16ac18f50d453
Reviewed-on: https://dart-review.googlesource.com/21860
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-20 14:15:57 +00:00
Brian Wilkerson 5adb7c9796 Convert three more methods and add a TODO 
Change-Id: I974f71a2b64fb32799f642dd64b6975e8a1ef341
Reviewed-on: https://dart-review.googlesource.com/21840
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-18 20:47:07 +00:00
Dan Rubel 783190248a Add fasta parser missing name recovery 
* update parser missing parameters error message
* update AstBuilder to insert () when needed
* reorder error converter mapping

Change-Id: Ibe57615f8f06644210c6b8babb8a7c1aa4a60fb3
Reviewed-on: https://dart-review.googlesource.com/21792
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-18 18:47:36 +00:00
Paul Berry f043446962 Insert implicit downcast checks for the RHS of variable declarations. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I5be5fb6f47430d390d53d9f195b6a75ca566f8b9
Reviewed-on: https://dart-review.googlesource.com/21701
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-18 15:35:45 +00:00
Dan Rubel 374a7c9e00 Add fasta parser missing named parameter name recovery 
Change-Id: Iedbf0059b0b33706b36f5dcdd9d10e8136a0c373
Reviewed-on: https://dart-review.googlesource.com/21703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-17 20:06:45 +00:00
Brian Wilkerson 6f57467887 Rework multiple methods in preparation for converting other methods 
Change-Id: I7dc4daf5e6e4d44b353d059fd4f7897212c75ffc
Reviewed-on: https://dart-review.googlesource.com/21680
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-17 17:39:24 +00:00
Paul Berry 18fd8b75bd Change the representation of ShadowSyntheticExpression to allow replacement. 
Previously, a ShadowSyntheticExpression was its own kind of Expression
unrelated to any of the Expression types defined in the kernel.  It
responded to visit requests by forwarding the visit request to the
desugared expression.  This had the advantage that for serialization
purposes, ShadowSyntheticExpressions would automatically disappear.
But it had the disadvantage that if a ShadowSyntheticExpression ever
needed to be replaced with another node (e.g. because an implicit
downcast was needed), the _ChildReplacer would get confused by the
visitor forwarding and fail to replace the node properly.

This CL fixes the problem by changing ShadowSyntheticExpression to a
Let node of the form `let _ = null in desugaredExpression`.  Since
this is a genuine kernel expression, it no longer needs special
visiting semantics, and node replacement works properly.

In most circumstances, we replace the ShadowSyntheticExpression with
its desugared equivalent during type inference, so the final
serialized kernel representation is unchanged.  However, in a few rare
circumstances involving error recovery, a ShadowSyntheticExpression
remains in the tree.  Semantically this shouldn't be a problem, since
the behavior of `let _ = null in x` is the same as the behavior of
`x`.  Nonetheless, I hope to get rid of these rare circumstances in
follow up CLs.

Change-Id: Iacf8c0028c424ac9ef98ef8302680e289bf7a017
Reviewed-on: https://dart-review.googlesource.com/21571
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-17 12:18:53 +00:00
Konstantin Shcheglov 079d41b519 Compute canonical names only for the new library. 
This makes changes to method bodies cheaper, now in 20-30 ms range
when I change flutter/lib/src/widgets/text.dart code.

R=sigmund@google.com

Bug:
Change-Id: I9009d12330ab64969630dc92aa0404cfc581e5e3
Reviewed-on: https://dart-review.googlesource.com/21524
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-17 08:58:55 +00:00
Paul Berry 3be7a55c4c Ensure that all expressions have parent pointers before type inference. 
This is necessary in case type inference has to replace one expression
with another.

Change-Id: Id549f0e1357757f84a753079f500d2d1905bca68
Reviewed-on: https://dart-review.googlesource.com/21569
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-17 05:22:07 +00:00
Brian Wilkerson 574618d173 Convert more methods to accept the last consumed token 
Change-Id: I5ad765251b266083c21ca90530ba1b604f5443d2
Reviewed-on: https://dart-review.googlesource.com/21483
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-16 22:27:02 +00:00
Dan Rubel d5105da9ca Split parser method 
Change-Id: Ic162b678c5d6316104428b20b8b85843551abe39
Reviewed-on: https://dart-review.googlesource.com/21523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-16 21:57:21 +00:00
Dan Rubel f6acd76f94 Add fasta parser missing operator keyword recovery 
Change-Id: I940fa31a006dc088b8f4166a9e3e48bcf65a5341
Reviewed-on: https://dart-review.googlesource.com/21500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-16 21:28:12 +00:00
Brian Wilkerson 8556269166 Convert some of the methods used to parse function bodies 
Change-Id: Ia8addbbc057768dac83695d7c8e2a7de98c86ebb
Reviewed-on: https://dart-review.googlesource.com/21482
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-16 20:37:12 +00:00
Brian Wilkerson d290c080f4 Convert the rest of the methods used to parse class headers 
Change-Id: I11c64d5c560b2de86e7e588b9afd3c1c5e3c1621
Reviewed-on: https://dart-review.googlesource.com/21481
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-16 19:40:42 +00:00
Konstantin Shcheglov 7d16cec034 Rewrite IKG to be much faster on incremental changes. 
This version does not store any compiled kernels into ByteStore.
We might get back to it, if we have time, and if it can be done without
slowing down returning results.

Here are numbers for the flutter_gallery sample.

Minimal KG.
1. Initial start: 3600 ms.
2. Change a leaf library (logic.dart): 30-40 ms.
3. Change a method body in a deep library (widgets/text.dart): 600-800 ms.


This IKG.
1. Initial start: 4300 ms.
2. Change a leaf library (logic.dart): 30-40 ms.
3. Change a method body in a deep library (widgets/text.dart): 30-40 ms.
4. Change API of a deep library: 600-800 ms.


  So, this new version is very fast when you change a method body.
  This is the most often and useful case.
  We might want to create a new benchmark for it.

R=paulberry@google.com, sigmund@google.com

Bug:
Change-Id: I134050c5bafec195d8a1eceb2ee9ea1468c819fc
Reviewed-on: https://dart-review.googlesource.com/21282
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-16 19:38:51 +00:00
Dan Rubel 65bf242e6d Add fasta parser invalid field name recovery 
Change-Id: Ie58efb0616b8e66da9fb478f8c1927f7328808ce
Reviewed-on: https://dart-review.googlesource.com/21463
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-16 19:04:41 +00:00
Brian Wilkerson bff16a518e Convert parseMixinApplicationRest and skipUnexpectedTokenOpt 
Change-Id: Iaa941f7dce8c0887e7f5404e7bf42b3ed70265b4
Reviewed-on: https://dart-review.googlesource.com/21480
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-16 18:54:12 +00:00
Dan Rubel a9c7e0ae6d Add fasta parser invalid method name recovery 
Fix https://github.com/dart-lang/sdk/issues/31183

Change-Id: I7fb757061295f4ef5c6c0b23adf7dee7ddc323c1
Reviewed-on: https://dart-review.googlesource.com/21461
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-16 18:41:21 +00:00
Brian Wilkerson 5591f802ae Return the last consumed from several more methods 
Change-Id: I2b56b98dfbb596f60bb04efc84ead1c5848d4faf
Reviewed-on: https://dart-review.googlesource.com/21101
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-16 15:27:43 +00:00
Aske Simon Christensen 6dcea4d28c Error on super call as expression. 
Closes https://github.com/dart-lang/sdk/issues/31198

Change-Id: Iaa2c026dbd22baefded4cef36a1d8a81bede5b34
Reviewed-on: https://dart-review.googlesource.com/21160
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2017-11-16 14:23:21 +00:00
Aske Simon Christensen 851ff574a3 Avoid crash for type argument on type variable. 
Closes https://github.com/dart-lang/sdk/issues/31190

Change-Id: Ifb2d721d5816a3656df47bfe2a5328594b8d0e83
Reviewed-on: https://dart-review.googlesource.com/21121
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2017-11-16 10:20:02 +00:00
Aske Simon Christensen 43bc36ac72 Recover from multiple errors in for initializer. 
Closes https://github.com/dart-lang/sdk/issues/31184

Change-Id: Ie453ed0b1aff88bd9799949f97e9d2fc0077e8c0
Reviewed-on: https://dart-review.googlesource.com/21141
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2017-11-16 10:03:23 +00:00
Dan Rubel a25b0a8d07 Revert "Add fasta parser invalid method name recovery" 
This reverts commit d2579b6d3c.

Revert until I can figure out why co19/Language/Expressions/Identifier_Reference/syntax_t06 is failing.

Original change's description:
> Add fasta parser invalid method name recovery
> 
> Fix https://github.com/dart-lang/sdk/issues/31183
> 
> Change-Id: I1c3d0f5f665e8b1ab02901b470da0bf70871e5e1
> Reviewed-on: https://dart-review.googlesource.com/21261
> Commit-Queue: Dan Rubel <danrubel@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,danrubel@google.com

Change-Id: Ia1c1cc26b819f309bb6c2b603318904d0b786b56
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/21360
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-16 03:15:22 +00:00
Dan Rubel d2579b6d3c Add fasta parser invalid method name recovery 
Fix https://github.com/dart-lang/sdk/issues/31183

Change-Id: I1c3d0f5f665e8b1ab02901b470da0bf70871e5e1
Reviewed-on: https://dart-review.googlesource.com/21261
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-15 23:15:51 +00:00
Konstantin Shcheglov 0b80b0e028 Add MinimalIncrementalKernelGenerator with in-memory only caching and simplified dependency tracking. 
R=paulberry@google.com, sigmund@google.com

Bug:
Change-Id: I828ff64afcdb735dc06cb4b200a97b51bc651e8f
Reviewed-on: https://dart-review.googlesource.com/20323
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-15 23:06:22 +00:00