Commit Graph

2821 Commits

Author SHA1 Message Date
Vijay Menon 9732138317 Testing support for FF and Safari
Also travis support for testing FF.  See:

https://travis-ci.org/dart-lang/sdk/builds/159331789

On FF 48, 1965 out of 1979 tests are passing.  Run locally:
DDC_BROWSERS=Firefox npm test

On Safari 10 (tech preview), it fails immediately due to a static method named "caller".  We disallow it as a field, but not a method right now.  If I hack that out, 1972 out of 1979 tests appear to pass.

Run locally by installing tech preview and running:
DDC_BROWSERS=Safari SAFARI_BIN=/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview npm test
R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2334763002 .
2016-09-14 08:41:43 -07:00
Brian Wilkerson 1f10422fd5 Update uses of deprecated API in ddc
R=jmesserly@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2338883002 .
2016-09-13 11:44:38 -07:00
Vijay Menon ab47c33f3d Bump pub version
We seem to be hitting an error on travis:

https://travis-ci.org/dart-lang/sdk/jobs/159136296

  The pubspec for analyzer 0.28.2-alpha.0 from path has version 0.29.0-alpha.0.
  The command "pub get" failed and exited with 65 during .

Looks like the analyzer version bumped forward and was incompatible
with the pubspec.lock entry?  Is there a way to avoid this?

TBR=rnystrom@google.com,jmesserly@google.com

Review URL: https://codereview.chromium.org/2336443002 .
2016-09-11 20:06:36 -07:00
Vijay Menon e52613f151 Fix error message
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2329493002 .
2016-09-09 09:02:50 -07:00
Bob Nystrom 33ff9a3d4f Fix type errors in sort().
If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.

A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2311513002 .
2016-09-08 17:14:36 -07:00
Bob Nystrom 8c7dd5cd04 Cast InternalMap to Map.
It's a tag interface that doesn't declare that it implements Map but all
classes that implement it also implement Map, so just do a cast.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2304323002 .
2016-09-08 16:23:45 -07:00
John Messerly b797899b35 ignore hints in DDC's build
R=vsm@google.com

Review URL: https://codereview.chromium.org/2316093003 .
2016-09-08 08:59:11 -07:00
John Messerly 6d31434983 Have setters use strict -> like methods
R=leafp@google.com

Review URL: https://codereview.chromium.org/2319233002 .
2016-09-07 14:01:14 -07:00
John Messerly 5968e2b9e9 configure travis notifications for DDC, take 2
deletes the obsolete travis.yml file

R=vsm@google.com

Review URL: https://codereview.chromium.org/2316983003 .
2016-09-07 11:57:23 -07:00
John Messerly 48817e61f7 fix strong mode messages in pkg/dev_compiler
R=vsm@google.com

Review URL: https://codereview.chromium.org/2314193002 .
2016-09-07 09:06:24 -07:00
John Messerly ef14d1460c configure travis notifications for DDC
Review URL: https://codereview.chromium.org/2317933002 .
2016-09-07 09:04:35 -07:00
Vijay Menon d837bc1e67 Simple node runner
Handy utility to run a test from command line via node.

E.g.:

> node tool/run.js lib/math/math2_test

/Users/vsm/dart/sdk/pkg/dev_compiler/lib/js/amd/dart_sdk.js:1747
    throw obj;
    ^
Expect.equals(expected: <true>, actual: <false>) fails.

> node tool/run.js lib/math/pi_test
pi_test seed: 29735
3.1405

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2318723002 .
2016-09-06 12:40:10 -07:00
Jacob Richman 38724f0626 Update web_command code so that it continues to use the legacy module loader. Drive by removal of misleading comments.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2303163002 .
2016-09-06 09:57:05 -07:00
Vijay Menon df832444ed Skip flaky (timeout) test
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2298883005 .
2016-09-01 16:02:51 -07:00
Vijay Menon 0c8cd45dea Regen and fix expectations
Caught by travis :-)

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2300753006 .
2016-09-01 15:11:40 -07:00
Vijay Menon 9af2fb0115 More DDC mirrors support
(Note, this is a straight migration of the old DDC repo CL. :-))

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2301973002 .
2016-09-01 10:13:31 -07:00
Vijay Menon b220f63954 Travis config
See try-run here: https://travis-ci.org/dart-lang/sdk/builds/156699868

R=kevmoo@google.com

Review URL: https://codereview.chromium.org/2301833002 .
2016-09-01 08:33:50 -07:00
John Messerly ade24133a1 remove unused DDC status files
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/2298933004 .
2016-08-31 18:32:00 -07:00
Vijay Menon 367b3626f0 Mark test flaky
TBR'ing to get travis green

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2294333002 .
2016-08-31 09:51:18 -07:00
Vijay Menon 2bc19eaa64 Remove deprecated code
Updating to the latest analyzer.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2289263004 .
2016-08-30 15:39:38 -07:00
Vijay Menon feb77b40a4 Bind this in ng2 hack code
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2291873002 .
2016-08-29 16:41:29 -07:00
Vijay Menon 6a1a03add4 Make source map paths relative
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2288453002 .
2016-08-26 16:31:53 -07:00
Bob Nystrom 4b321d0ecd Import "NoInline" into core so StackTrace's use of it resolves.
R=vsm@google.com

Review URL: https://codereview.chromium.org/2277753005 .
2016-08-25 17:08:52 -07:00
John Messerly 8081afc785 fix travis bots
- increase timeout so we load all tests
- mark a few more failures
- skip unittest tests until we re-triage them

Review URL: https://codereview.chromium.org/2279053002 .
2016-08-25 13:23:14 -07:00
John Messerly bc50963a61 fix writing summaries
I also renamed "outPath" so this bug is less likely to happen in the future :)

R=vsm@google.com

Review URL: https://codereview.chromium.org/2279833002 .
2016-08-25 10:40:09 -07:00
John Messerly c1139934a7 fix #626, add AMD module format and make it default
R=nweiz@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2249233002 .
2016-08-25 09:39:36 -07:00
Jacob Richman 87577db2b2 Add dart:js_util library and tests to ddc. This library is already added to dart2js and dartium.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2269963005 .
2016-08-24 09:13:06 -07:00
John Messerly 9d8ae169de Revert "simplify build sdk"
This reverts commit 4cf8eebec783fbc3ac8e027bf5a64b5bf2178ad3.

apparently we use it for code coverage. go figure.

Review URL: https://codereview.chromium.org/2261183004 .
2016-08-22 13:11:36 -07:00
John Messerly 822f65386f simplify build sdk
the .dart script is left over from when we couldn't build SDK via normal compile path

R=vsm@google.com

Review URL: https://codereview.chromium.org/2265303002 .
2016-08-22 13:01:09 -07:00
Vijay Menon 124e71473a Add mirrors tests
Doh!

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2265533002 .
2016-08-19 08:37:45 -07:00
Vijay Menon 0516f9f545 Regression test dart:mirrors
About 50 tests pass right now.  A bunch more fail.

See #199

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2256393002 .
2016-08-19 08:27:20 -07:00
Vijay Menon 8442efa4d3 Support call methods on functions
Fixes #624

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2255993002 .
2016-08-18 07:51:17 -07:00
Vijay Menon d90d172d8b Remove deprecated DirectoryBasedDartSdk
We're getting bot failures due to analyzer deprecation messages.

R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2258873002 .
2016-08-18 07:47:45 -07:00
John Messerly a076edad94 roll analyzer
R=vsm@google.com

Review URL: https://codereview.chromium.org/2254883002 .
2016-08-17 21:10:21 -07:00
John Messerly 9b421ebb4f fixes #627, update DDC Future.then signature
R=leafp@google.com

Review URL: https://codereview.chromium.org/2259433002 .
2016-08-17 10:25:10 -07:00
John Messerly 90a8667c06 remove unused test baseline files 2016-08-16 08:22:18 -07:00
John Messerly 43fe94ae35 remove unused test expectation files
R=vsm@google.com

Review URL: https://codereview.chromium.org/2246353002 .
2016-08-16 08:19:18 -07:00
vsmenon 280b100a3a Update USAGE.md
'compile' command is obsolete
2016-08-15 07:27:15 -07:00
vsmenon 830dd542f5 Update USAGE.md 2016-08-14 15:32:48 -07:00
John Messerly 36273565e3 fixes #610, incorrect help output
R=nweiz@google.com

Review URL: https://codereview.chromium.org/2244703003 .
2016-08-12 15:06:41 -07:00
John Messerly 0aa5cbd128 fix #620, infer the input files from sources
also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing

R=nweiz@google.com

Review URL: https://codereview.chromium.org/2234343003 .
2016-08-11 13:19:36 -07:00
Kevin Moore fc3aa408c5 Dart SDK works on precise again 2016-08-11 09:07:12 -07:00
Priscilla Lee 386ad0aea4 Removed copy of dart sdk summaries. No longer needed to run the dev compiler in the browser.
BUG=

Review URL: https://codereview.chromium.org/2230743002 .
2016-08-10 10:01:16 -07:00
John Messerly 94085a662e a few cleanups to get IDE message clean
R=priscillalee@google.com

Review URL: https://codereview.chromium.org/2221253003 .
2016-08-09 13:40:45 -07:00
Priscilla Lee 1233b35daa Restructured the set up for the compiling function. Also added room for list of additional summaries.
BUG=
R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2208243002 .
2016-08-09 10:40:35 -07:00
Vijay Menon 8fec051a8e Mark recursive_inheritance_test as passing
This will get the dev and master bots green.

Will need to bump the pubspec on analyzer (once published) to make stable green after this.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2214263005 .
2016-08-05 09:35:01 -07:00
Vijay Menon a8a6107c04 Run travis on trusty
TBR=whesse@google.com

Review URL: https://codereview.chromium.org/2219893002 .
2016-08-05 08:34:51 -07:00
Vijay Menon 3ddb76b95c Reify type params on map literals
Fixes #621

R=jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/2211293002 .
2016-08-05 07:16:02 -07:00
Vijay Menon c2cb395798 Enforce green on travis with dev analyzer
Note, tip analyzer is red - the analyzer is now type checking a test that used to statically fail:

Chrome 54.0.2818 (Linux 0.0.0)  recursive_inheritance_test FAILED
       Error: test marked as 'notyetstrong' due to strong mode errors, but passed

R=leafp@google.com

Review URL: https://codereview.chromium.org/2216703002 .
2016-08-04 09:52:49 -07:00
Vijay Menon 144cca4b62 Roll DDC to latest dart:html
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2207273002 .
2016-08-03 17:55:05 -07:00