69f0218802
Mark test pass on Chrome 55
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/2554523002 .
2016-12-05 05:55:44 -08:00
41d18b72ed
Revise generic method doc.
2016-12-02 15:07:00 -08:00
4024328758
Update generic methods docs to use the new syntax.
...
- Move the old doc to a separate file and link to it.
- Update the new doc to use the new syntax.
I also took the liberty of trying to make it a little shorter and use
more concrete examples. I hope I still cover the same bases. If not,
let me know what I missed.
2016-12-02 13:50:05 -08:00
7a1b6e75b3
restrict generic function type subtyping
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2540903003 .
2016-12-01 19:24:15 -08:00
201c5b9297
Fix runtime strong mode error in ListMixin
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2544163002 .
2016-12-01 15:41:46 -08:00
ec81359fc0
Fixes #27960
...
For "m.call(..)", the function is "m".
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2539033004 .
2016-12-01 15:38:46 -08:00
1ff09b431f
Keep only a single active stack trace, enables traces for thrown non-exceptions
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2545923002 .
2016-12-01 13:41:08 -08:00
2d289c2df6
Modify dev_compiler to use analyzer's new AstFactory class.
...
The old mechanism for creating analyzer ASTs (factory constructors on
the interface classes) will be going away in analyzer 0.30.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2545843002 .
2016-12-01 10:37:22 -08:00
106c623a9f
Some fixes for lazy JS types
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2542833002 .
2016-12-01 07:44:38 -08:00
aa749dbd8d
Sprinkle some types on the SDK like the static typing fairy.
...
When I'm looking at the dynamic call profiles of an internal app test,
I see a bunch coming from the SDK itself. In fact, the top five most
common dynamic call sites are in the SDK.
This fixes four of them. (The fifth is in runUnary() in Zone, and I
don't think can be made typed yet.)
R=vsm@google.com
Review URL: https://codereview.chromium.org/2542723003 .
2016-11-30 17:04:54 -08:00
667fc8dbe9
Make the dart:developer library available in DDC so debugger statement works
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2534263002 .
2016-11-29 16:13:45 -08:00
88c5dd5745
Better mirrors support for mixins and private fields
...
This is generally motivated by pageloader usage.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org/2535273002 .
2016-11-29 14:00:01 -08:00
1370b6bb46
Fix handling of static names for JS interop and improve test coverage.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2536823003 .
2016-11-29 13:33:19 -08:00
22f85df76e
Fix expectation
...
I copied over the new version of the test for sdk/tests and dropped the 'negative'.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2536903005 .
2016-11-29 10:28:27 -08:00
3e51e6d3c9
Fix reference to validate method
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org/2536233002 .
2016-11-29 09:57:27 -08:00
1b339deab2
Support lazy JS types.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2515353003 .
2016-11-22 10:55:35 -08:00
f109556fb7
remove unused DDC --package-paths options and MultiPackageResolver
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2527433002 .
2016-11-22 11:20:23 -05:00
180107cec3
add test, fixes #27807
...
this appears to have been already working correctly
R=vsm@google.com
Review URL: https://codereview.chromium.org/2517193004 .
2016-11-21 16:44:16 -08:00
de9e3a3005
Set auto breakpoint at various errors
...
Any reason not to do this? I generally find when framework code wraps these errors, it just complicates finding the original bug. Better to just trap.
Perhaps should just inline the call to debugger though. I put in dart.debugger with the thought of making it configurable.
R=jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org/2519873004 .
2016-11-21 14:40:46 -08:00
5595b9698d
Fix typos 'overriden' to 'overridden' and '@mustCall super' to '@mustCallSuper' ( #27853 )
...
* fix overriden typos to overridden
* Fix @mustCall super to @mustCallSuper
2016-11-18 09:36:25 -08:00
37029a22de
fix #27336 , ddc with recursive generic class type args
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2516483002 .
2016-11-17 15:38:33 -08:00
365d9a000a
fix #27784 and fix #27785 , fromEnvironment constants in DDC
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2503803004 .
2016-11-16 12:20:43 -08:00
fb467ef68a
Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously surprisingly generating a direct call to set instead of a call to dsetindex.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2504733002 .
2016-11-15 12:52:28 -08:00
926df1e5b3
Rewrite build_pkgs.sh and build_test_pkgs.sh in Dart.
...
The bots need to run these before running the tests, so I'm porting them
to Dart so they'll run on Windows.
As a nice bonus, they're much faster now, I'm assuming because we use
one warmed up VM for all of the packages.
build_test_pkgs.sh on my machine went from ~12 seconds to ~4.
R=jmesserly@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2498673003 .
2016-11-15 11:14:37 -08:00
588f10ee8e
Skip queryall_test on canary. See #27794
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2492903002 .
2016-11-15 09:49:05 -08:00
27287baa57
Only re-export the main methods. The ddc codegen doesn't depend on any other methods being exported and export code for top level fields and all JS interop types was broken. This change reduces code size of a large Angular2 app by 6%.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2500283002 .
2016-11-15 09:35:44 -08:00
9da150f2fb
Mark two more tests as passing on DDC / FF
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/2498423002 .
2016-11-15 08:42:41 -08:00
5716000c23
Mark test as passing on FF
...
Now passing on FF 50.
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/2506663002 .
2016-11-15 08:18:09 -08:00
48d02a0f87
update codereview.settings for DDC
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2505443002 .
2016-11-14 15:28:50 -08:00
22c27800b6
Support for debugging DDC tests under devtool
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2501183002 .
2016-11-14 15:21:12 -08:00
bc980498a1
Fix ddc whitelist op
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2492523004 .
2016-11-09 15:23:04 -08:00
3356f82eb3
Fix crashing bug for closures of the form () { return; }
...
BUG=
R=jmesserly@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2484913004 .
2016-11-08 15:14:10 -08:00
8f04f902df
fix #27771 , create directory if needed
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2483753004 .
2016-11-08 10:21:31 -08:00
3995146b55
fix #27775 , enum declaration where "name" is a property
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2488543002 .
2016-11-08 10:18:55 -08:00
f05e2b0760
recompile for 4179bd7601
...
Review URL: https://codereview.chromium.org/2484853002 .
2016-11-07 11:02:36 -08:00
4179bd7601
Apply codec change from fb968553 to DDC copy
...
Closes https://github.com/dart-lang/sdk/pull/27724
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2481703003 .
2016-11-07 10:59:22 -08:00
8daf4cfb73
Get the basics of deferred libraries working.
...
References to loadLibrary on a library prefix are compiled to a
helper function that returns a Future that always completes
successfully.
The deferred libraries aren't actually deferred, but code that uses
loadLibrary() now doesn't barf.
BUG=#27343
R=vsm@google.com
Review URL: https://codereview.chromium.org/2477673006 .
2016-11-07 10:41:23 -08:00
d062fd7994
Fixes #27752
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2473143003 .
2016-11-03 18:01:05 -07:00
1aff39dd13
replace / with . in sourceUrl to prevent breaking relative source uris in source maps ( #27730 )
2016-11-03 12:22:55 -07:00
4874480d55
Move FF and Canary to green on travis
...
Try run is here:
https://travis-ci.org/dart-lang/sdk/builds/172400947
R=rnystrom@google.com
Review URL: https://codereview.chromium.org/2467063002 .
2016-11-03 07:44:27 -07:00
69279d6b62
Fix summary path for tests
...
Should get travis back to green
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2470053002 .
2016-11-01 21:12:01 -07:00
2e8d011ca3
fix #27607 , add dev_compiler summary to the SDK and move JS files
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2474523003 .
2016-11-01 18:17:43 -07:00
9d34f30c9c
Build collection as a separate test pkg
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2462263002 .
2016-11-01 06:04:57 -07:00
830cf7c3ea
Test packages with ddc on travis
...
Here's a setup to test build of various SDK packages with DDC and strong mode per commit on travis.
It's not an ideal setup:
- If deps / files change, this will need updating.
- It only breaks on error, not warning.
- It doesn't actually run any package tests.
I haven't gone through all packages either. Might be worth automating something like this.
See try-run here:
https://travis-ci.org/dart-lang/sdk/builds/172066040
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2465923003 .
2016-11-01 06:01:45 -07:00
2d15b4ae74
Type-related fixes
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2468493003 .
2016-10-31 15:01:29 -07:00
dddede61fe
Allow trailing options in DDC. ( #27691 )
2016-10-31 14:23:58 -07:00
e8fbfc4f0d
Mark test as runtime failure
...
pkg collection is now clean.
TBR=jmesserly@google.com
Review URL: https://codereview.chromium.org/2466533002 .
2016-10-31 06:00:59 -07:00
89560c68a0
change "the the" to the
2016-10-28 21:47:50 +02:00
bdeb6023af
fix #27672 , call computeConstantValue for metadata
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2458693003 .
2016-10-27 14:05:54 -07:00
644c1dca75
fix #27429 , html wrapper methods pass incorrect number of arguments
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2454173003 .
2016-10-27 13:16:00 -07:00
Vijay Menon