3d03bee32d
Library custom formatters
...
R=alanknight@google.com , jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org/2164763005 .
2016-07-22 14:15:53 -07:00
c1e97b495f
fix #603 , support mock objects
...
if noSuchMethod is used to implement an abstract member, this will be detected and appropriate code will be generated.
R=leafp@google.com
Review URL: https://codereview.chromium.org/2158173003 .
2016-07-19 13:24:02 -07:00
dd1f2acb78
Update patch_sdk.sh
...
make it work from any directory
2016-07-13 13:31:25 -07:00
409fbcf956
Custom formatter popup booleans
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2137063003 .
2016-07-11 16:21:04 -07:00
e7d49ddd7c
Copy browser test output to file
...
BUG=
R=rnystrom@google.com
Review URL: https://codereview.chromium.org/2132593003 .
Committed: https://github.com/dart-lang/dev_compiler/commit/79160a056c0a35adef3542ae4e30fdc451d83612
2016-07-08 12:00:50 -07:00
fc696b039c
Copy browser test output to file
...
BUG=
R=rnystrom@google.com
Review URL: https://codereview.chromium.org/2132593003 .
2016-07-08 11:13:18 -07:00
86d9eb10d0
don't use JS_CONST in dart:html
...
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2113913003 .
2016-07-01 10:53:27 -07:00
f0cde883e9
Change allowInterop to a generic method.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2106613002 .
2016-06-29 14:41:32 -07:00
844cfdb990
maxspanlength setter
...
Merge branch 'master' of https://github.com/dart-lang/dev_compiler
Merge branch 'master' of https://github.com/dart-lang/dev_compiler
comments and 10001 case
naming and logic changes
logic updates and variable renaming
Merge branch 'master' of https://github.com/dart-lang/dev_compiler
Array formatting customized to look like JS
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2101233004 .
2016-06-28 13:48:41 -07:00
d55b213947
Array formatting customized to look like JS
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2100803007 .
2016-06-28 11:13:51 -07:00
5c9e1244bd
Improve message in tool/test.sh
...
New message instructs developers to run tool/browser_test.sh in order to
actually run tests.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2100363002 .
2016-06-27 17:40:14 -07:00
87bcbf9147
Move type tagging logic out of setSignature
...
setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2076713002 .
2016-06-27 15:29:15 -07:00
d27eda4ffc
implement user-defined nSM, Object members on functions
...
fix #591 and fix #59
R=vsm@google.com
Review URL: https://codereview.chromium.org/2061373003 .
2016-06-22 17:18:52 -07:00
430e8f15af
Partial fix for call methods #542
...
This fixes the generated code to support these. Subtype checks are not fixed yet.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2069903002 .
2016-06-16 16:38:43 -07:00
3e5d1d80e6
Fix function subtyping crash
...
Fixes #588
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2069653003 .
2016-06-14 09:55:04 -07:00
5016cbce59
Fixed type error in MapEntry and added keyToStringConfig to display the toString() of a key in a MapEntry preview.
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2033433007 .
2016-06-08 10:12:53 -07:00
68f90ac82b
Refactoring assignment
...
The idea is to have more _emitXXX methods, so that different paths for
the same semantic action (e.g. implicit vs explicit 'this') call the
same _emitXXX method.
This is the first (simplest) step: assignments.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2039173005 .
2016-06-07 17:09:46 -07:00
aea2fa1291
Update Symbol.hashCode
...
New dart2js version avoids inefficient String.hashCode
TBR=vsm@google.com
Review URL: https://codereview.chromium.org/2040963005 .
2016-06-06 12:34:59 -07:00
5fd923523b
Faster type tests
...
Put type tests (is, as, type assertion) on the types as 'is', 'as' and '_check' methods.
The check
dart.check(x, core.String);
becomes
core.String._check(x);
which is more concise and allows the test to be specialized.
In one scrolling action, 224ms in dart.as and dart.check is replaced by 89ms of checks across the specializations.
R=vsm@google.com
Review URL: https://codereview.chromium.org/2012153002 .
2016-06-03 15:35:42 -07:00
fb20c9d6a4
Switch how we track whether trackDdcProfile is set to reduce the performance impact. sra was seeing this call hit 14% usage in the chrome profile.
...
Fill in whitelist call ist and add support for list of whitelists that apply to calls only.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/2032903003 .
2016-06-02 16:59:33 -07:00
61a1d8c9c8
Fix a few cases were obj and name were used instead of $obj and $name. remove ProfileEntry class as sadly defining a class in operations.dart appears to have an ordering issue which causes two tests to fail.
...
Review URL: https://codereview.chromium.org/2035583004 .
2016-06-02 13:07:51 -07:00
314bd180a2
Profile dynamic calls.
...
Debug logic
BUG=
patch from issue 2012423005 at patchset 1 (http://crrev.com/2012423005#ps1 )
R=jacobr@google.com , leafp@google.com
Review URL: https://codereview.chromium.org/2024353002 .
2016-06-02 09:59:23 -07:00
40c7ac9038
Wire up class hierarchy for recursive inheritance
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2033543002 .
2016-06-01 19:21:45 -07:00
73479a600c
Throw TypeError instead of CastError for type coercions.
...
Added 'tag' type StrongModeError, implemented by all errors that are
specific to strong mode semantics.
Failed casts throw CastError(Implementation) or StrongModeCastError.
Failed type assertions and reified coercions throw TypeError or
StrongModeTypeError.
Triaged some tests. Some pass due to now throwing a TypeError, many
pass for unknown reasons.
R=leafp@google.com
Review URL: https://codereview.chromium.org/2026133002 .
2016-06-01 10:18:17 -07:00
f0517c4deb
Enable strong mode in DDC, fix all warnings/errors
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2016483002 .
2016-05-26 11:13:32 -07:00
70698bacf0
Short circuit for 'as dynamic'
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2007423003 .
2016-05-25 21:44:34 -07:00
a7174ce8c2
Tweak _checkPrimitiveType
...
V8 does better with typeof x == 'string'
TBR=vsm@google.com
Review URL: https://codereview.chromium.org/2015513005 .
2016-05-25 20:23:43 -07:00
d094888eec
Use factory constructor for list literals
...
The list literal `<int>[1, 2, 3]` was
dart.list([1, 2, 3], core.int)
now becomes
JSArrayOfInt().of([1, 2, 3])
R=leafp@google.com
Review URL: https://codereview.chromium.org/2006443002 .
2016-05-25 17:40:46 -07:00
451478b208
Add types for valueFromDecomposedDate
...
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org/2010873002 .
2016-05-25 16:09:36 -07:00
3e9ed11db6
Name and hoist types
...
Adds infrastructure for naming and hoisting types in various ways. Makes an initial cut at how to slice the naming, but we will want to adjust.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1988023008 .
2016-05-25 11:07:38 -07:00
d4dd53ede6
Add generic types to Sort and Comparable. Fix crasher bug in codegen.
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org/2011973002 .
2016-05-25 10:42:23 -07:00
fb363715f3
Add a type on lazyAsJsDate
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/2010693002 .
2016-05-24 17:35:10 -07:00
e3836901c3
Make DateTime use in the SDK typed
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/2004463004 .
2016-05-23 09:17:03 -07:00
e6e5635a83
Optimize const construction
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1998113004 .
2016-05-20 17:53:28 -07:00
1e0295d4a5
fix performance of setType
...
it was mutating the class (e.g. JSArray<int>) every time an instance was constructed (!)
R=leafp@google.com
Review URL: https://codereview.chromium.org/1999273002 .
2016-05-20 17:46:13 -07:00
41bac633e1
Fix debugger
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/1997473007 .
2016-05-20 11:11:43 -07:00
f950e422b8
fix #577 - correctly toString ES Symbols
...
R=sra@google.com
Review URL: https://codereview.chromium.org/1993293002 .
2016-05-19 12:33:06 -07:00
ed77841603
Better boolean conversion tests.
...
- Same errors as VM & Dartium
- Failed assertion: boolean expression must not be null
- type 'int' is not a subtype of type 'bool' in boolean expression
- All boolean conversion contexts use the same logic
- No false positives from combining null and as-bool checks in other contexts
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1993023003 .
2016-05-19 12:04:59 -07:00
220553b7e7
Future flattening at runtime.
...
This implements basic one-level future flattening of the runtime
types.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1997473002 .
2016-05-18 15:47:26 -07:00
0235eba4b9
Updates to collection_patch.dart
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org/1987043002 .
2016-05-18 15:10:40 -07:00
1e5b3af2e0
Move generated files to gen/.
...
- The generated SDK goes into gen/patched_sdk.
- Expanded multitests go into gen/codegen_tests.
- Compiled tests go into gen/codegen_output.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1988503002 .
2016-05-18 13:48:10 -07:00
4cf7ee3332
Use _extensionType for detecting prototype inheritance.
...
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1988683004 .
2016-05-18 11:14:26 -07:00
5ed8b5ecab
Misc doc-only updatee, rerun build_sdk.
...
TBR=vsm@google.com
Review URL: https://codereview.chromium.org/1994473002 .
2016-05-17 20:51:53 -07:00
69d11e8df8
Misc updates (mostly doc)
...
TBR=vsm@google.com
Review URL: https://codereview.chromium.org/1987963003 .
2016-05-17 20:27:23 -07:00
d2b6f53630
fix #470 , string interpolation now respects Dart toString
...
R=sra@google.com
Review URL: https://codereview.chromium.org/1989663002 .
2016-05-17 17:23:57 -07:00
9e816ffbef
Wrap and unwrap types in dart:mirrors
...
This is pretty nasty - just the minimum to get us back to where we were before I think.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org/1989593002 .
2016-05-17 15:56:01 -07:00
7a9da0081b
Provide option to suppress mirrors metadata
...
Fixes #268
Probably too small to affect perf, but I'm looking into adding some more for mirrors and don't want it on by default.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/1986693003 .
2016-05-17 15:42:26 -07:00
d95a368e70
Update dart:collection.
...
This doesn't include the copious changes in collection_patch.dart
because I believe (1) those are quite old and (2) are dart2js specific.
The changes here have basically no effect on DDC, but it at least gets
us a little better test coverage and reduces noise in the diffs.
R=sra@google.com
Review URL: https://codereview.chromium.org/1977003002 .
2016-05-17 15:39:52 -07:00
0cedeb49af
simplify constructors, fixes #564
...
we still have an init method, for better or worse, to break out of ES6 restrictions
The idea here is default Dart constructor (really an initialization method) is always called `new` instead of the class name. We already do this for unnamed factory.
R=leafp@google.com
Review URL: https://codereview.chromium.org/1965213003 .
2016-05-17 14:36:56 -07:00
eef9bb5b5a
Speed up global tool
...
Use parsedirectives instead of resolution - this is much faster.
R=leafp@google.com
Review URL: https://codereview.chromium.org/1987723002 .
2016-05-17 09:29:03 -07:00
Brenna Milligan