dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

981 Commits

Author SHA1 Message Date
Jennifer Messerly 5111675810 fix #27631, get/set methods no longer shadow index operator 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2435163002 .
 2016-10-20 15:45:29 -07:00
Alan Knight 47150f50d5 Use dart:html prefixes (e.g. webkitAudioNode) on other browsers 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2431443002 .
 2016-10-19 16:43:41 -07:00
Jacob Richman 4f6ce11bc8 Emulate compiling a source file in the context of an existing library. Add --debugger-compile flag that performs permissive dynamic calls on private members. Polish web_command.dart adding the ability to evaluate code in the context of an existing library. 
BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2423313002 .
 2016-10-18 16:34:48 -07:00
Vijay Menon a032a4c952 Revert "Fix file name handling on windows" 
This appears to break on bazel.

BUG=
R=nshahan@google.com

Review URL: https://codereview.chromium.org/2422403002 .
 2016-10-17 15:27:48 -07:00
Vijay Menon 852ef37f71 Some mirrors fixes 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2415053004 .
 2016-10-14 12:19:24 -07:00
Bob Nystrom ae5a566f98 Move minitest.dart into the expect package. 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2416853003 .
 2016-10-13 14:15:21 -07:00
Bob Nystrom 2305865365 Start cleaning up the HTML tests. 
My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.

Changes:

- Add a "minitest" package. This shims just enough of the unittest/test
  API to make it easy to swap it out for unittest without having to
  rework the entire test.

- Go through the HTML tests from A-J and change them to use minitest
  when possible. The ones that aren't possible use asynchrony.
  Minitest doesn't support async tests (yet, maybe).

- Triage those tests and enable ones that are passing. Mark them failing
  if failing. Filed a couple of tracking bugs for the common issues,
  but for other cases, I just left a comment.

- In the process of this, I went ahead and make some of the affected
  tests strong mode clean if they weren't already and it was easy.

- Synchronize changes between dev_compiler's fork of expect and
  pkg/expect. We'll want to unfork those at some point. D-:

This gets dev_compiler from 1985 tests to 2042.

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2413073002 .
 2016-10-13 08:47:27 -07:00
Vijay Menon 2495f6a060 Handle private members in dart:mirrors 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2410453002 .
 2016-10-10 15:55:20 -07:00
Bob Nystrom 9b6317d571 Stop using unittest in point_test and rectangle_test. 
This also makes rectangle_test strong mode clean. Alas, the test isn't
passing because of another bug, but once that bug is fixed, it should.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2407913002 .
 2016-10-10 11:02:37 -07:00
Vijay Menon 8846988b1d Travis / chrome fixes 
- Use google-chrome-stable by default
- Use google-chrome-unstable as Canary (instead of trying to determine last-known-good-revision - we has issues with that yesterday)
- Test chrome stable and unstable separately on travis

Try bot:
https://travis-ci.org/dart-lang/sdk/builds/165541943

R=kevmoo@google.com

Review URL: https://codereview.chromium.org/2396433007 .
 2016-10-06 08:33:06 -07:00
Vijay Menon 4b2d1e06f3 Workaround from Chromium breakage 
We're installing the latest Chromium Canary on travis.  It appears
broken on Linux.  Pinning pending further investigation.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2398843002 .
 2016-10-05 16:32:11 -07:00
Bob Nystrom 20e402c43d Fix type errors in math.min() and math.max(). 
Really, this works around them, but the workaround is all round better
code.

Remove the Dart implementations of min() and max() and just forward to
the JS ones. In DDC, all numbers are double, so the type checks to
handle them specifically aren't meaningful. Also, we don't need the
other special case checks in there to help dart2js optimize them.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2386493003 .
 2016-09-30 13:18:07 -07:00
Bob Nystrom 2c313a43ac Fix some errors around []= in core types. 
- Get rid of JSMutableIndexable since it isn't useful.
- Make JSIndexable generic. (I think dart2js already did.)
- Add .length to NativeTypedArray since it no longer inherits it from
  JavaScriptIndexingBehavior.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2378423003 .
 2016-09-30 13:03:10 -07:00
Vijay Menon 68d2121fd0 Use .packages instead of pubspec.yaml 
This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204

R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2371113004 .
 2016-09-28 09:49:31 -07:00
John Messerly 361cd4c61c fix #27408, reverts "ignore dynamic in inference" 
this reverts https://github.com/dart-lang/sdk/commit/8c25a41accf52265a89bcc2ffac3bdb7c271f9fb

R=vsm@google.com

Review URL: https://codereview.chromium.org/2360973004 .
 2016-09-23 17:01:33 -07:00
Vijay Menon ead14fbd74 Update global_compile tool 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2363053003 .
 2016-09-23 13:30:18 -07:00
Vijay Menon aae63b7e21 Regenerate DDC SDK 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2358323002 .
 2016-09-21 16:39:24 -07:00
Vijay Menon 8e943b8c59 Fix tests 
This fixed the original 5 static errors from this morning.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2356413002 .
 2016-09-21 13:59:55 -07:00
John Messerly aa85651820 fix #27403, use AST summaries in DDC 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2353133004 .
 2016-09-20 17:55:09 -07:00
Vijay Menon 9732138317 Testing support for FF and Safari 
Also travis support for testing FF.  See:

https://travis-ci.org/dart-lang/sdk/builds/159331789

On FF 48, 1965 out of 1979 tests are passing.  Run locally:
DDC_BROWSERS=Firefox npm test

On Safari 10 (tech preview), it fails immediately due to a static method named "caller".  We disallow it as a field, but not a method right now.  If I hack that out, 1972 out of 1979 tests appear to pass.

Run locally by installing tech preview and running:
DDC_BROWSERS=Safari SAFARI_BIN=/Applications/Safari\ Technology\ Preview.app/Contents/MacOS/Safari\ Technology\ Preview npm test
R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2334763002 .
 2016-09-14 08:41:43 -07:00
Bob Nystrom 33ff9a3d4f Fix type errors in sort(). 
If a comparer isn't provided, it was silently assuming the element type
implements Comparable, even though that isn't required. Fixed to add a
manual cast at each comparison.

A stricter faster approach might be to check that the type argument
itself is a type that implements Comparable, but I don't know if that's
too pessimistic, or even possible to do.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2311513002 .
 2016-09-08 17:14:36 -07:00
Bob Nystrom 8c7dd5cd04 Cast InternalMap to Map. 
It's a tag interface that doesn't declare that it implements Map but all
classes that implement it also implement Map, so just do a cast.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2304323002 .
 2016-09-08 16:23:45 -07:00
John Messerly b797899b35 ignore hints in DDC's build 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2316093003 .
 2016-09-08 08:59:11 -07:00
Vijay Menon d837bc1e67 Simple node runner 
Handy utility to run a test from command line via node.

E.g.:

> node tool/run.js lib/math/math2_test

/Users/vsm/dart/sdk/pkg/dev_compiler/lib/js/amd/dart_sdk.js:1747
    throw obj;
    ^
Expect.equals(expected: <true>, actual: <false>) fails.

> node tool/run.js lib/math/pi_test
pi_test seed: 29735
3.1405

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2318723002 .
 2016-09-06 12:40:10 -07:00
Jacob Richman 38724f0626 Update web_command code so that it continues to use the legacy module loader. Drive by removal of misleading comments. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2303163002 .
 2016-09-06 09:57:05 -07:00
Vijay Menon 0c8cd45dea Regen and fix expectations 
Caught by travis :-)

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2300753006 .
 2016-09-01 15:11:40 -07:00
Vijay Menon 9af2fb0115 More DDC mirrors support 
(Note, this is a straight migration of the old DDC repo CL. :-))

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2301973002 .
 2016-09-01 10:13:31 -07:00
Bob Nystrom 4b321d0ecd Import "NoInline" into core so StackTrace's use of it resolves. 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2277753005 .
 2016-08-25 17:08:52 -07:00
John Messerly c1139934a7 fix #626, add AMD module format and make it default 
R=nweiz@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2249233002 .
 2016-08-25 09:39:36 -07:00
Jacob Richman 87577db2b2 Add dart:js_util library and tests to ddc. This library is already added to dart2js and dartium. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2269963005 .
 2016-08-24 09:13:06 -07:00
John Messerly 9d8ae169de Revert "simplify build sdk" 
This reverts commit 4cf8eebec783fbc3ac8e027bf5a64b5bf2178ad3.

apparently we use it for code coverage. go figure.

Review URL: https://codereview.chromium.org/2261183004 .
 2016-08-22 13:11:36 -07:00
John Messerly 822f65386f simplify build sdk 
the .dart script is left over from when we couldn't build SDK via normal compile path

R=vsm@google.com

Review URL: https://codereview.chromium.org/2265303002 .
 2016-08-22 13:01:09 -07:00
John Messerly a076edad94 roll analyzer 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2254883002 .
 2016-08-17 21:10:21 -07:00
John Messerly 9b421ebb4f fixes #627, update DDC Future.then signature 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2259433002 .
 2016-08-17 10:25:10 -07:00
John Messerly 36273565e3 fixes #610, incorrect help output 
R=nweiz@google.com

Review URL: https://codereview.chromium.org/2244703003 .
 2016-08-12 15:06:41 -07:00
John Messerly 0aa5cbd128 fix #620, infer the input files from sources 
also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing

R=nweiz@google.com

Review URL: https://codereview.chromium.org/2234343003 .
 2016-08-11 13:19:36 -07:00
John Messerly 94085a662e a few cleanups to get IDE message clean 
R=priscillalee@google.com

Review URL: https://codereview.chromium.org/2221253003 .
 2016-08-09 13:40:45 -07:00
Vijay Menon 8fec051a8e Mark recursive_inheritance_test as passing 
This will get the dev and master bots green.

Will need to bump the pubspec on analyzer (once published) to make stable green after this.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2214263005 .
 2016-08-05 09:35:01 -07:00
Vijay Menon 144cca4b62 Roll DDC to latest dart:html 
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2207273002 .
 2016-08-03 17:55:05 -07:00
Vijay Menon b324b14105 Regen with latest analyzer 
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2212663002 .
 2016-08-03 17:32:17 -07:00
Brenna Milligan 3b7e5eed8c Updated sdk 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2206843002 .
 2016-08-02 17:16:07 -07:00
Brenna Milligan 8b0b57844b Get rid of library proto information for debugger libraries 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2208533003 .
 2016-08-02 17:08:27 -07:00
Vijay Menon 0fd3e8821c Fix wrt analyzer tip 
This sidesteps #618 for now.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2209473002 .
 2016-08-02 14:42:06 -07:00
Vijay Menon 803b0e3454 Test against dev version of analyzer on travis 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2203583004 .
 2016-08-02 14:40:46 -07:00
Brenna Milligan a7dc32f424 Deprecation of ClassMetadata wrapper for Class formatters so a stand-alone class is recognizable. 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2205733002 .
 2016-08-02 09:43:02 -07:00
John Messerly e51f9de339 fixes #616, statics on callable functions 
also fixes `this` for them

R=vsm@google.com

Review URL: https://codereview.chromium.org/2200913002 .
 2016-08-01 17:12:37 -07:00
John Messerly 344124e4a1 fix optional params to mock methods, allow all signatures 
switches to use the same technique as `dsend`

R=vsm@google.com

Review URL: https://codereview.chromium.org/2201973002 .
 2016-08-01 16:21:59 -07:00
Brenna Milligan d18ab46592 Addition of StackTrace formatters 
R=alanknight@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org/2189673002 .
 2016-07-27 15:14:55 -07:00
John Messerly 0f29ee9618 Remove DDC custom error list now that strong mode analyzer handles it 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2102053003 .
 2016-07-27 13:10:57 -07:00
Brenna Milligan d7c7c19c54 Library children object fix 
R=alanknight@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org/2176233002 .
 2016-07-25 17:44:59 -07:00