dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

10502 Commits

Author SHA1 Message Date
Konstantin Shcheglov 6b575c72ec Prepare to publish analyzer 1.2.0 and _fe_analyzer_shared 18.0.0. 
Change-Id: If31ece2507cfb012d5742aa147df2ca781b4f712
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191303
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-03-15 22:58:54 +00:00
Konstantin Shcheglov c0b800ceb5 Issue 45318. Check for dynamic bounded and Function bounded. 
Bug: https://github.com/dart-lang/sdk/issues/45318
Change-Id: I5abd2d237cc3a56551471c2a2fc7a9965eb4223c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-15 22:50:14 +00:00
Konstantin Shcheglov 369c36e67c Issue 45299. Fix yield type check for function expressions. 
Bug: https://github.com/dart-lang/sdk/issues/45299
Change-Id: I0f9477a632b635d7e1ac8d4c51f51254e5058cff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191183
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-15 21:26:44 +00:00
Konstantin Shcheglov 60ea845795 Issue 190731. Support for aliasElement/aliasArguments in TypeParameterType. 
Bug: https://github.com/dart-lang/sdk/issues/45291
Change-Id: Ia0378722f0e7c48e7a3042c0ef14d6833c7bf2b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190734
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-12 18:22:47 +00:00
Konstantin Shcheglov 45e3d3c77f Issue 45291. Support aliasElement/aliasArguments for interface types. 
Bug: https://github.com/dart-lang/sdk/issues/45291
Change-Id: I97bab24f4d7cf3232a0260ec3c6abec6a4c310be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190731
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-12 17:06:17 +00:00
Sam Rawlins e1414089cf Analyzer: avoid dynamic calls while examining Yaml 
Change-Id: If569c74bad1d3762deb4cc74ea617d291ec33619
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190727
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-03-12 16:50:37 +00:00
Jens Johansen 31acdc9d92 [parser] Recovery of of new/const/Map/Set/List with said literals 
E.g. recover `Map<int, int>{}` by ignoring the map (i.e. it's
just a literal map), recover `new {}` as just `{}` etc.

Fixes #45251.

Change-Id: I44e67ca6d3b9b068014b8e28822a61063c794d57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190022
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2021-03-12 10:41:06 +00:00
Konstantin Shcheglov dd706e1c0c Issue 45263. Fix resolveToBound() to resolve the promoted bound as well. 
Bug: https://github.com/dart-lang/sdk/issues/45263
Change-Id: I285e675bdec931b1987ac97045e6f97e55ad3fd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190730
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-03-12 07:23:49 +00:00
Sam Rawlins fa0f4680df analyzer: Remove nullable types from _DisoverAvailableFilesTask: 
* remove `isCompleted` field which duplicates `completer.isCompleted`
* make `completer` non-nullable
* make `files` non-nullable
* move `folderIterator` from class as field to `perform()` as local

Change-Id: Ic67dbf8d4e6487152ae1ca6752c45f5c59c70862
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190725
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-03-11 21:48:31 +00:00
Konstantin Shcheglov 54b2948461 Replace TypeAnnotation.type with null check with 'typeOrThrow'. 
Change-Id: I16922aef63d294448436c93004386ee8a3439e31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-11 19:41:10 +00:00
Sam Rawlins d44d590ceb analyzer: Remove unused WorkToWaitAfterComputingResult 
Change-Id: I7f3925c19e6375e93fdc67ed394ec1ad472ffd98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190680
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-03-11 19:30:11 +00:00
Konstantin Shcheglov 14998dfa5a Fix unlinked API signature for const/static out-of-order. 
Saw a crash in logs, was able to reproduce.

Change-Id: I2632c9ec7c3c34e6498f74e17507505128664418
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-11 01:33:21 +00:00
Paul Berry c509ad1e41 Change "could not" to "couldn't" in error messages 
See comments at
https://dart-review.googlesource.com/c/sdk/+/186320/4/pkg/analyzer/lib/src/generated/resolver.dart#3423.
On the recommendation of the documentation team, we use a more
informal tone in messages.

Change-Id: I0c243669ebd91b8f4a745530582e0f829769a754
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189100
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-03-10 15:26:38 +00:00
Paul Berry 73f9d0cd26 Flow analysis: Remove unnecessary argument from tryFinallyStatement_end. 
Flow analysis stopped using this argument (the AST node for the
finally block) some time ago, but I kept it around so I could assert
that clients didn't unnecessarily store assigned variables info for
it.  It's been long enough now that we can eliminate this code
entirely.

Change-Id: I8c64e2b4fc5b154f441ec2d057637f3dc9ced277
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-03-10 13:14:08 +00:00
Sam Rawlins 3a67c5aaa2 analyzer: Remove lateness of LibraryAnalyzer._libraryElement 
This field is late and accessed with regularity, requiring ugly initialization
checks.

Change-Id: I307f3736e374991a37777f24264642fdcb73a57a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190100
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-03-10 05:59:00 +00:00
Konstantin Shcheglov a95b7f6313 Remove an unused field. 
Change-Id: I18a1f057bb01608b4bfb9584d354d71c50ed7294
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-10 05:16:08 +00:00
Konstantin Shcheglov 7f02c8818e Fix FileResolverTest on Windows. 
TBR

Change-Id: I95815a26a46484cd44689b6b47ef62949ad5d1a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190381
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-03-10 02:19:51 +00:00
Sam Rawlins 0471644ac9 Reland: Report unused system libraries with shadowed elements 
Fixes https://github.com/dart-lang/sdk/issues/45028

Change-Id: I77d6ea9f0eaa3589402abf6c23aeae4978694f19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-03-10 00:35:42 +00:00
Konstantin Shcheglov 6550317955 Move updateAnalysisOptions() to CommandLineOptions. 
Change-Id: I96e63478f2e3ea65d58a56a1b12dc2726a3d55ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189860
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-10 00:34:32 +00:00
Konstantin Shcheglov 97655f06b5 Use null aware invocation in removeUnusedFiles(). 
Change-Id: I67175e8cdf6ddd678a57a13d32ec55c06b205dfe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190302
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-09 23:40:02 +00:00
Konstantin Shcheglov 8d25fccb52 Fix for NPE when checking for OVERRIDE_ON_NON_OVERRIDING_METHOD. 
Saw it in crash logs.

Change-Id: I8e4cbfeafa8e3310f89373707e30c8eac6bed544
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-09 23:03:54 +00:00
Konstantin Shcheglov 72e5ac075d Restore linter in analyze tests. 
Change-Id: Id96e8669a5242fac4eee0745fd359e50c37fb706
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-09 22:10:22 +00:00
Keerti Parthasarathy b4adea8f46 Add flutter assist test for Cider 
Change-Id: Icc04283fd2d37638fcb7382c55f8d409a627a97f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189880
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-03-09 21:32:12 +00:00
Daco Harkes ffa5d16ae7 [vm/ffi] Support multi-dimensional inline arrays 
This CL only changes dart:ffi API, CFE, and analyzer. No VM changes
were needed because the dimensions of inline arrays can be flattened
before passing them to the VM. The multi-dimensionality does not
impact the ABI.

Closes: https://github.com/dart-lang/sdk/issues/45023

TEST=pkg/analyzer/test/src/diagnostics/size_annotation_dimensions_test.dart
TEST=pkg/front_end/testcases/nnbd/ffi_struct_inline_array_multi_dimensional.dart
TEST=tests/ffi/function_structs_by_value_generated_test.dart
TEST=tests/ffi/inline_array_multi_dimensional_test.dart

Change-Id: Ica2c01fccbea7e513879365b34086d8968b54c5b
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try,dart-sdk-mac-try,dart-sdk-win-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-win-release-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-msan-linux-release-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-precomp-android-release-arm_x64-try,analyzer-analysis-server-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188286
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2021-03-09 10:50:17 +00:00
Konstantin Shcheglov f0872cb7d2 Issue 45233. Throw StateError with more data when about to StackOverflow in available declarations. 
Bug: https://github.com/dart-lang/sdk/issues/45233
Change-Id: Ie6efdb8336536dee9a484dbd7ffb14d4af358cf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-09 05:57:46 +00:00
Konstantin Shcheglov ff14547a20 Make AnalysisSession.getResolvedUnit() and getUnitElement() non-nullable. 
Change-Id: I779fe40d1c565f9d4d71ba6a809497d26cae8def
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-09 00:42:23 +00:00
Konstantin Shcheglov a0ae791a22 Implement AnalysisSession.getLibraryByUri() for Cider. 
Change-Id: I3b7e17d4dc8c6e011bf1286d73d6f1d3c8e3ccaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189861
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-08 22:40:03 +00:00
Konstantin Shcheglov f7dc2d29de Issue 45195. Report MIXIN_INHERITS_FROM_NOT_OBJECT for class aliases. 
Bug: https://github.com/dart-lang/sdk/issues/45195
Change-Id: I4b1e60a672b49c3c9fda92b3eac59c256eea13da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-08 20:48:43 +00:00
Konstantin Shcheglov ec7d39293d Revert "Replace NodeListImpl<Xyz> with NodeListImpl<XyzImpl> in implementations." 
This reverts commit 14b07bc81c.

Reason for revert: b/182098851 - does not break anyone, but has the same issue with runtime type vs. static type.

Original change's description:
> Replace NodeListImpl<Xyz> with NodeListImpl<XyzImpl> in implementations.
>
> Change-Id: I12a663d6e2ed3288bf3535e019224041ae1a5093
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189600
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Change-Id: I112ecd13e77a9b420c5bc27905e29d728acfab89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-08 19:41:34 +00:00
Konstantin Shcheglov 19e0673582 Revert "Return List<XyzElementImpl> from ElementImpl getters." 
This reverts commit 645035bbb9.

Reason for revert: b/182098851

Original change's description:
> Return List<XyzElementImpl> from ElementImpl getters.
>
> Change-Id: Ice8a0feb6a0bd2599fcfd5ccc35c0b4242ed9530
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189620
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Change-Id: I33eff159d62813c35e7e00eee5b7d9dd4fb4e563
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-08 19:09:44 +00:00
Brian Wilkerson 7d971fad1c Stop suggesting non-factory constructors for abstract classes 
Change-Id: I3ed6936d36b0f35cea7950ac089c89efacdf0ca6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-08 18:53:51 +00:00
Sam Rawlins 7ee3f73a9a Analyzer: Allow generic function types as type arguments and bounds 
Bug: https://github.com/dart-lang/sdk/issues/44929
Change-Id: I9c83a9abd47ec6b3d59c118493c838632fc3182a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185305
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-03-08 18:32:31 +00:00
Konstantin Shcheglov 5794e716ab Make AnalysisSession.getErrors() non-nullable. 
Change-Id: Ib5971e4c7327d96bf7a08b576b487833615d4ae6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189622
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-08 08:38:51 +00:00
Konstantin Shcheglov 1601f6fcd2 Remove ResolutionCopier. 
It is not used.

Change-Id: Ic18e29c0f47e313a55d7b4cc3d8e4bf32182f883
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189621
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-08 08:32:41 +00:00
Konstantin Shcheglov 645035bbb9 Return List<XyzElementImpl> from ElementImpl getters. 
Change-Id: Ice8a0feb6a0bd2599fcfd5ccc35c0b4242ed9530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-08 07:00:40 +00:00
Konstantin Shcheglov 14b07bc81c Replace NodeListImpl<Xyz> with NodeListImpl<XyzImpl> in implementations. 
Change-Id: I12a663d6e2ed3288bf3535e019224041ae1a5093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-08 06:58:10 +00:00
Konstantin Shcheglov 75308fc26b Return Impl nodes from AstFactoryImpl and AstTestFactory. 
Change-Id: I5d3f6eb8d07145079560c6f8820aa15e2f8183a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-07 23:24:10 +00:00
Konstantin Shcheglov 0506b1b2d3 Deprecate setters in API of AST. 
Change-Id: Ib2ec164ef87b3a5a4bf028d592552e37451abd35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189520
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-07 21:48:50 +00:00
Konstantin Shcheglov 637d4f8407 Fix null checks in _BundleWriterReferences. 
Change-Id: I9c99f62846cbc574e1a4694c5b4bb18c578ab6e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-06 20:54:59 +00:00
Konstantin Shcheglov e26bd4471e Return Impl nodes from Impl nodes. 
The goal is to remove operations that modify AST from API.

To do this we need resolution and utilities to use visitors that
provide Impl nodes, and sub-nodes that we access are also Impl nodes.

Change-Id: I4bd9aee8a4c6668e4242df9aa41cd572a1c49bef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-06 20:47:44 +00:00
Konstantin Shcheglov b3de362dc5 Fix null checks for _UnitMemberIndexItem names. 
Change-Id: I4ef5ff13b26d70d96d26496b34b2e8ef1a27a1aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-06 20:46:54 +00:00
Konstantin Shcheglov 2c63f59c9d Fix null check in Cache. 
Change-Id: I0e5924889c82fe47ea8e7e318b9a7694dc6afa61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-06 20:39:39 +00:00
Konstantin Shcheglov 08cb8bebe1 Fix null checks in bazel workspace. 
Change-Id: I5af11caba2cecac95c4d4070bcd6cc831df4666a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-06 20:38:49 +00:00
Konstantin Shcheglov 53c8eda967 Keep more specific types for AnalysisContextCollectionImpl to avoid downcasts. 
It seems to me that implicitly expecting DriverBasedAnalysisContext
is equivalent to explicitly stating this with types.

Change-Id: I16ec14e73030d9b34242a2f4ad582e93fc44afa7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189382
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-06 06:23:25 +00:00
Konstantin Shcheglov f81be2cd8b Use AnalysisDriver.addedFiles for search, remove DriverAnalyzedFiles. 
The client that uses Search - DAS, adds analyzed files.
Visiting the file system again to gather analyzed files is wasteful.
DAS now uses AnalysisContextCollection, so the same set of files.

Change-Id: I2b6ba4181e7ed8cda02db152086d13758ea6f4dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-06 05:15:24 +00:00
Konstantin Shcheglov 3f5694c827 Issue 45141. Check for loadLibrary() using namespace. 
Bug: https://github.com/dart-lang/sdk/issues/45141
Change-Id: Ifb0825d66a560d0136873942f9666d3dc630b6c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-05 22:21:54 +00:00
Konstantin Shcheglov 10a0c238ce Discover default analysis options files in ContextLocatorImpl. 
Change-Id: Idbcb43ab53878b677c3195d3003eb9da6eda5bab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-05 06:30:17 +00:00
Konstantin Shcheglov 73b1cc26d4 Fixes for ContextRootTest and ContextLocatorImplTest on Windows. 
Change-Id: I234ab250dd140df3da23015edd2295d0affbc67a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-04 20:46:49 +00:00
Konstantin Shcheglov 4cb71ce5cb Update analysis options before creating AnalysisDriver. 
Change-Id: If9c337fc69ac11a570da5165edb17a3c4c75f418
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-04 19:18:19 +00:00
Konstantin Shcheglov ca736dbcdb Resolve typeArguments of Annotation. 
We don't have yet full implementation, but this fixes the crash.

Bug: https://github.com/dart-lang/sdk/issues/45119
Change-Id: I0d6aba7c53bf4a9c707c4cbeff8a5c81040f2712
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-04 06:58:35 +00:00