f162db3ba7
[analyzer/ffi] Support Unions
...
This CL does not add unions to `dart:ffi` yet, only to the mock
SDK in the analyzer for testing the analyzer. This means we can review
and land it separately.
Also, this CL fixes some tests to not use nullable fields in Structs.
Bug: https://github.com/dart-lang/sdk/issues/38491
Change-Id: Ia972f31475859aa57e012adf39b636919995b183
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194788
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-12 16:50:16 +00:00
424e670576
Reland "Mark AstTestFactory as internal."
...
This is a reland of 553bfea531https://dart-review.googlesource.com/c/sdk/+/194600
> Reviewed-by: Samuel Rawlins <srawlins@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Change-Id: I097fc5f665880666829eeb982f7fa3b450bb203e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194681
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com >
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com >
2021-04-09 09:46:38 +00:00
9ce236a6cf
Revert "Mark AstTestFactory as internal."
...
This reverts commit 553bfea531https://dart-review.googlesource.com/c/sdk/+/194600
> Reviewed-by: Samuel Rawlins <srawlins@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com ,srawlins@google.com
Change-Id: I6c9e0f5d7863ac7481612d95a7fd414dec743b76
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194680
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com >
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com >
2021-04-09 06:01:27 +00:00
553bfea531
Mark AstTestFactory as internal.
...
I want to continue disallowing users to create AST nodes.
Change-Id: I6597fcf4fbb767cde35320e3b8777873faf5c5bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194600
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-04-09 02:59:11 +00:00
beea8076cd
Migrate more of server
...
Change-Id: I6342016847257ae95314e97b2f31186c43f10e6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-08 19:05:30 +00:00
d6824468f9
Prepare to publish analyzer 1.4.0 and _fe_analyzer_shared 20.0.0.
...
Change-Id: Ifdf4371221776da3ede6c28f2938eb51d19f61da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193898
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-08 03:27:54 +00:00
79c321eed4
Add 'sdkPath' to AnalysisContextCollection constructor..
...
Bug: https://github.com/pq/surveyor/issues/29
Change-Id: Ic6cc28e8e33be50b0cab35ad0f2e236bae04de0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194324
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2021-04-08 02:07:04 +00:00
b13dea3e1e
Reland "Flow analysis: track property get targets."
...
This is a reland of bc6cdf54fdhttps://github.com/dart-lang/sdk/issues/44898
> Change-Id: Ia8ef4a7ce13cc30860e59b7369e6230d233e252d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193832
> Commit-Queue: Paul Berry <paulberry@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: Ib5e6a0eafb381f3a9c8770c6c1c3e55581e44b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194105
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2021-04-07 11:39:12 +00:00
03101c0c2b
Update LICENSE
...
Changes to comply to internal review
Closes https://github.com/dart-lang/sdk/pull/45568
https://github.com/dart-lang/sdk/pull/45568
TEST=CL contains no code changes.
No-Try: true
GitOrigin-RevId: 65796784e5fdfddaa021b5c55ad435b1db419700
Change-Id: I085a948f16dc9a0de128ed0bd456ae69adf6c124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193888
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2021-04-07 10:28:38 +00:00
d8da40ec52
Migrate lib/src/protocol_server.dart and related.
...
Change-Id: Ibb1e5a53aa8ad67fa43b315880c491093b051e20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-04-07 00:26:59 +00:00
1668734697
Add a method to resolve a library
...
Change-Id: I0eba5b60bb46fa7dfbceb2b26e0d1d5ec3ae3ebf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194015
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2021-04-06 21:27:43 +00:00
b5d4d26abe
[cfe] Const factories when const functions enabled.
...
Change-Id: Ifd24678c0ac191c5cc6f1d60443ab96f56cbba7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192400
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Kallen Tu <kallentu@google.com >
2021-04-06 19:46:32 +00:00
cf7587a160
Revert "Flow analysis: track property get targets."
...
This reverts commit bc6cdf54fdhttps://golem.corp.goog/PerformanceChanges?repository=dart&revision=91561
Original change's description:
> Flow analysis: track property get targets.
>
> These targets are needed for "why not promoted" error messages, and
> it's easier to have flow analysis keep track of them than to have the
> analyzer and CFE try to reconstruct them at the time of reporting the
> error.
>
> Bug: https://github.com/dart-lang/sdk/issues/44898
> Change-Id: Ia8ef4a7ce13cc30860e59b7369e6230d233e252d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193832
> Commit-Queue: Paul Berry <paulberry@google.com >
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,johnniwinther@google.com
Change-Id: Ic2b66b1db621c0f4e4c5398acfe2ae61bd7625ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/44898
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194104
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-04-06 11:49:09 +00:00
bc6cdf54fd
Flow analysis: track property get targets.
...
These targets are needed for "why not promoted" error messages, and
it's easier to have flow analysis keep track of them than to have the
analyzer and CFE try to reconstruct them at the time of reporting the
error.
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: Ia8ef4a7ce13cc30860e59b7369e6230d233e252d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193832
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-04-06 06:55:28 +00:00
0190d20bd6
Migrate some tests and test utilities in server
...
Change-Id: I0a37352c903bf7139af25aab255fe6a5331ce98b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-03 19:23:44 +00:00
778c2361c3
Issue 45579. Report WRONG_NUMBER_OF_TYPE_ARGUMENTS and TYPE_ARGUMENT_NOT_MATCHING_BOUNDS.
...
Bug: https://github.com/dart-lang/sdk/issues/45579
Change-Id: I757f4d782895fb1a9c89d8238a7929e12d6a6eed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-04-03 17:46:16 +00:00
72bc3134c5
Unify "why not promoted" representations for for-loops and other writes.
...
This CL changes the responsibility for doing flow analysis of the
implicit variable write in a `for-in` loop as follows: if the `for-in`
loop does not declare a variable, but it assigns to a local variable,
then the flow analysis client is responsible for calling `write` on
entry to the loop.
This in turn allows us to use a single code path to track "why not
promoted" information related to all possible local variable writes;
we no longer need as much special case logic to handle for-in loops.
To make the analyzer integration slightly cleaner, we change the
argument type of FlowAnalysis.write to Node rather than Expression, so
that the analyzer can pass in the ForEachParts object when analyzing a
for-in loop.
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: I24b47be8eac2e276cd291a5b2f2e4444c911138f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193837
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-04-03 15:28:36 +00:00
1cffb93ad7
Improve error message for non-promotion due to assignment.
...
This is clearer because:
- The use of "could not be promoted" is consistent with the other "why
not promoted" messages.
- We avoid speculating about whether the variable might be assigned a
null value; this should help avoid confusion in cases where the user
can see that assigning a null value is impossible, but promotion
still fails.
- We avoid the phrase "intervening write", which is a little too
erudite.
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: I0b8a2132dc99dd06769677f98e6257e9b55ad9d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193820
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2021-04-03 13:43:36 +00:00
39a2e69ea4
Enable non-function type aliases by default in 2.13.
...
TEST=language/nonfunction-type-aliases
Change-Id: Ifff4e838fbfc4f71e2d990e1f1f8a67b987adf91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192948
Commit-Queue: Leaf Petersen <leafp@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2021-04-03 01:31:42 +00:00
9482dd6c6c
Analyzer pkg: output required keyword in ToSourceVisitor
...
This fix `SimpleFormalParameter` in `ToSourceVisitor` to output `required` keyword
Closes https://github.com/dart-lang/sdk/pull/45561
https://github.com/dart-lang/sdk/pull/45561
GitOrigin-RevId: cbdf667aaa983258dd9b5da4323299732c056e72
Change-Id: I2abe0e34b832aed997df6c411b197a12e2f9023a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193839
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-02 16:31:42 +00:00
5e040a20f8
analyzer: Improve span of use_of_nullable_value errors
...
This changes the span reported from the _receiver_ to
the _use_ (method name, property name, operator token).
I think this change is overall an improvement.
Specifically, its a great improvement for cmdline
output, where the receiver and the "use" are on
different lines.
One possibly weird change is that if the operator is `[]`,
then I only highlight the `[` character. I don't know if
there is a better place, and I think this is fine.
Fixes https://github.com/dart-lang/sdk/issues/43708
Change-Id: Ie66ddf04b4904a367575193106385dd63ee39985
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188680
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-02 02:43:48 +00:00
c25e74852c
Add links to "why not promoted" error messages.
...
These links are not live yet, but they will be filled in with
documentation explaining subtleties of type promotion in more detail.
Bug: https://github.com/dart-lang/sdk/issues/44900
Change-Id: I3e1865597fc5c56495a8108c8a4de98cab0c3e4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193749
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-01 16:42:12 +00:00
e673c19820
Resolve annotations via type aliases.
...
Change-Id: I6d22e06775d31856fc85a350892efe15208832f5
Bug: https://github.com/dart-lang/sdk/issues/44838
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-04-01 02:52:43 +00:00
fd63463daf
Don't create additional ContextRoot(s) when nested in an existing root.
...
Change-Id: I52a0b4f32b7d84d3c3287f94a6e4d7c488374a35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193528
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-31 16:14:59 +00:00
3ce196935e
Implement inference via type aliases with aliased InterfaceType.
...
Change-Id: I1d2bba09f19468bc8e095c5ef4a39c09365eb2a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193450
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 23:39:57 +00:00
8c4d10d9cf
Tests for IMPLEMENTS_SUPER_CLASS and MIXINS_SUPER_CLASS via type alias.
...
Also a small tweak for reporting repeated implements/with.
Bug: https://github.com/dart-lang/sdk/issues/45489
Bug: https://github.com/dart-lang/sdk/issues/45526
Change-Id: I6b3e7cb545ce5c63b8facd8b2e55593a45196779
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193522
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 21:42:31 +00:00
6c30a7d582
Flow analysis: implement "why not promoted" logic for index expressions.
...
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: I52a0fa33dbeb4f6382dd8b3154ead25ca2065878
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193088
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-03-30 18:24:11 +00:00
20acfbc876
Move checkIndexExpressionIndex checking to resolver.
...
In order to implement "why not promoted" functionality index
expressions, we need to call checkIndexExpressionIndex from the
resolver, so that we can pass it failed promotion information. So
move it into the ErrorDetectionHelpers mixin.
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: Idc70e3421142da1d3100c288c912b6483a91b28c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193087
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 18:24:11 +00:00
fa243e700a
Issue 45492. Report TYPE_ARGUMENT_NOT_MATCHING_BOUNDS for not regular bounded type as a type alias body.
...
Bug: https://github.com/dart-lang/sdk/issues/45492
Change-Id: I303a7066c356e645d549960f66c1d7b8d50f307a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193452
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 16:50:11 +00:00
fcb9bfb81b
Report IMPLEMENTS_REPEATED and ON_REPEATED also when via type alias.
...
Change-Id: Ied864fe708b6f00976e0629f8f3e514b693b5129
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193451
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 16:50:02 +00:00
4ba4fd3f1d
[analyzer/ffi] Inline array annotation const dimensions
...
Moves the Array forwarding constructors and _ArraySize class out of
the patch files so that the analyzer can reason about them.
(The analyzer does not include patch files, because it does not know
whether it's analyzing for VM or JS backend.)
Closes: https://github.com/dart-lang/sdk/issues/45507
Change-Id: Ia0eb4bbca40b906a1e636714f53c5c73dcfc3cad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2021-03-30 00:28:57 +00:00
93a187e6c8
[analyzer/ffi] Error on sizeOf<Handle>()
...
Test covers both analyzer and CFE throwing an error. (But does not
test what error.)
Closes: https://github.com/dart-lang/sdk/issues/45100
Change-Id: I8b820347945d88304d3f03d7d03f156b7111db42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193405
Auto-Submit: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-30 00:20:52 +00:00
86635c76fa
[analyzer/ffi] Fix NPE in ffi_verifier
...
Closes: https://github.com/dart-lang/sdk/issues/45498
Change-Id: I836c52b03800bc8282e5f26168f1feab93068b8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193304
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-29 15:56:18 +00:00
7374f441f3
Add TypeProvider.isNonSubtypableClass, deprecate TypeProvider.nonSubtypableClasses.
...
Change-Id: I78beaaeb763c33420d84c33b0e87cd5310f99fea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193094
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-29 02:33:52 +00:00
7f54fc96e5
Add documentation for several more codes
...
Change-Id: I012db56773acee6a81fbb6a33958beb686793ec9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-28 21:16:11 +00:00
5621c9f767
Check for TYPE_ARGUMENT_NOT_MATCHING_BOUNDS when generic_metadata is enabled.
...
Change-Id: I32b4963f46c232a0ab41fb1b55ffe1c8723a34e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193160
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-27 23:56:46 +00:00
2c02737d7a
Support for bounds of generic function types for raw-depends / not simply bounded.
...
Change-Id: I568f4ebb922b3ce40debff1f4ce20a9ac580f29d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193141
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-27 21:08:06 +00:00
a7b0f5108d
Flow analysis: implement "why not promoted" logic for compound assignments.
...
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: I57a2c62b8450c313887b516d6fe2ef85fdd0d92b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193084
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-03-26 00:29:24 +00:00
79bf4f33ae
Clean up nomenclature around whyNotPromoted.
...
We used to have some variables called `whyNotPromoted` and others
called `whyNotPromotedInfo`, with no obvious distinction between the
two names. Now we use `whyNotPromoted` for variables holding the map
returned by `FlowAnalysis.whyNotPromoted`, and `whyNotPromotedList`
for variables holding a list of such maps.
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: I3823d16ef908a833e4d4526ae1c3576c73ecf1fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193083
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-03-26 00:29:24 +00:00
92130a010e
Tests for DAS services and generic annotations.
...
Change-Id: I063c78ae778366e60bb0d4aca55c4e7fd70f3d52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193091
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-25 23:38:24 +00:00
4af81e2a5b
Issue 45459. Report EXPERIMENT_NOT_ENABLED instead of INVALID_GENERIC_FUNCTION_TYPE when nonfunction_type_aliases is not enabled.
...
Bug: https://github.com/dart-lang/sdk/issues/45459
Change-Id: I0773f15e4697620427f4449622a592e40b5a5de4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-25 21:43:04 +00:00
182eb2d5c5
Try removing an extra null check in cloneNullableToken.
...
When trying to update to analyzer 1.3.0 dartdoc started crashing
occasionally in CI with the following exception:
https://github.com/dart-lang/dartdoc/pull/2589/checks?check_run_id=2195215917#step:6:3411
Reading the code suggests that returning a null here should be an
OK thing to do, but if this is intended to enforce that an invalid
key should never be passed to this method, some other solution
will need to be found.
Change-Id: Id210a0f8feb6197e7a65569bfaed4d599be4b3c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193062
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Janice Collins <jcollins@google.com >
2021-03-25 20:48:54 +00:00
97daca81be
Report an error when a type alias that expands to a type variable is used where a class is expected in hierarchy.
...
https://dart-review.googlesource.com/c/sdk/+/192743
Bug: https://github.com/dart-lang/sdk/issues/45450
Change-Id: I5d32236ddff7403eb739ca8b7de421f7f5a36ab6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193001
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-25 18:49:34 +00:00
ac9b4aab8d
[parser] More specific error messages when recovering new/const/Map/Set/List with said literals
...
Follow-up to https://dart-review.googlesource.com/c/sdk/+/190022
Change-Id: Id42336216267dcbf481ae6e111177e6296ea6779
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2021-03-25 13:27:03 +00:00
6a2df0de92
Remove unnecessary call to checkForInvalidAssignment
...
Previously, the ErrorVerifier was checking assignability for any `=`
or `??=` assignment whose LHS was not a simple identifier. But this
case is unnecessary; it's already handled by the resolver.
Change-Id: Icc44ab3d13b0a8300fe2ebb7ca134086291a29cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192733
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-03-25 02:01:33 +00:00
f161e228e4
Flow analysis: implement "why not promoted" logic for assignments.
...
This CL handles ordinary assignment expressions, variable declaration
initializers, and constructor field initializers.
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: I06bae2c7d57213bd7769c931a03080d148af3dbe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192724
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-03-25 02:01:33 +00:00
c557efc6bf
analyzer: Allow lint rules to be ignored with cannot-ignore
...
Change-Id: Ib86d4f58595a564c02c804fefd4d5ab05bd35a2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-03-24 20:42:32 +00:00
58dc586929
Remove redundant line number from referencedBeforeDeclaration.
...
Context messages are already displayed in a way that makes it easy for
the user to locate the line of code in question; it's unnecessary to
include the line number in the context message itself.
See discussion at
https://buganizer.corp.google.com/issues/179782591#comment9 .
Change-Id: I2d1383c4cee0ece0d302449302d1f1902fbf136c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-03-24 14:07:51 +00:00
97cd131c9a
analyzer: Introduce cannot-ignore analysis option.
...
Fixes https://github.com/dart-lang/sdk/issues/45404 , which describes the option
in detail.
This removes all unfortunate exceptions for dart2js test code and for flutter
code. This removes the lateness of one final field.
Fixes https://github.com/dart-lang/sdk/issues/44237
Fixes https://github.com/dart-lang/sdk/issues/42977
Fixes https://github.com/dart-lang/sdk/issues/45230
Related to https://github.com/flutter/flutter/issues/52899
Change-Id: I054f487fafe2742ae57da1d2ccd2d52dce4188bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192560
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-24 13:32:49 +00:00
da29d5af66
Share checkForFieldInitializerNotAssignable betwen resolver and ErrorVerifier.
...
In order to implement "why not promoted" functionality for constructor
field initializers, we will need to call
checkForFieldInitializerNotAssignable from the resolver, so that we can pass it
failed promotion information. So move it into the
ErrorDetectionHelpers mixin.
Bug: https://github.com/dart-lang/sdk/issues/44898
Change-Id: I95094e198a97608bf27f84cfb3cac40824a30ba4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192723
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2021-03-24 12:10:09 +00:00
Daco Harkes